pgAdmin 4 commit: Fixed an issue where an operation error message pop u

[Akshay Joshi]

Fixed an issue where an operation error message pop up showing the database 
object's name incorrectly. Fixes #7078

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=191e2b624243651cd1e1cdec7719ef82993095c8
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_6_4.rst  | 1 +
.../browser/server_groups/servers/databases/static/js/database.js | 4 ++--
web/pgadmin/browser/static/js/error.js| 2 +-
web/pgadmin/browser/static/js/node.js | 2 +-
web/pgadmin/static/js/helpers/Notifier.jsx| 1 +
web/pgadmin/tools/sqleditor/static/js/sqleditor.js| 8 
6 files changed, 10 insertions(+), 8 deletions(-)

pgAdmin 4 commit: Port Restore dialog to React. Fixes #7018

[Akshay Joshi]

Port Restore dialog to React. Fixes #7018

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=603d91be0e00f2f98bd7c842b57552f9d85322c1
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/images/backup_general.png   | Bin 64476 -> 35322 bytes
docs/en_US/images/restore_disable.png  | Bin 30776 -> 22537 bytes
docs/en_US/images/restore_do_not_save.png  | Bin 32446 -> 23389 bytes
docs/en_US/images/restore_general.png  | Bin 35596 -> 31963 bytes
docs/en_US/images/restore_messages.png | Bin 60340 -> 55774 bytes
docs/en_US/images/restore_miscellaneous.png| Bin 43928 -> 28820 bytes
docs/en_US/images/restore_objects.png  | Bin 30681 -> 23969 bytes
docs/en_US/images/restore_process_watcher.png  | Bin 97688 -> 62444 bytes
docs/en_US/images/restore_queries.png  | Bin 42774 -> 27893 bytes
docs/en_US/images/restore_sections.png | Bin 48885 -> 23708 bytes
docs/en_US/release_notes_6_4.rst   |   1 +
web/pgadmin/browser/static/js/node.js  |   2 +-
web/pgadmin/static/js/alertify/dialog_factory.js   |  11 -
web/pgadmin/static/scss/_webcabin.pgadmin.scss |   4 +
web/pgadmin/tools/backup/static/js/backup.js   |  49 +-
web/pgadmin/tools/restore/static/js/restore.js | 485 -
web/pgadmin/tools/restore/static/js/restore.ui.js  | 460 
.../tools/restore/static/js/restore_dialog.js  |  86 ---
.../restore/static/js/restore_dialog_wrapper.js| 293 --
.../javascript/restore/restore_dialog_spec.js  | 338 
.../restore/restore_dialog_wrapper_spec.js | 596 -
.../javascript/schema_ui_files/restore.ui.spec.js  |  70 +++
22 files changed, 689 insertions(+), 1706 deletions(-)

Re: [pgAdmin][RM-7078]: Operation error message pop up shown database objects name incorrectly.

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Dec 27, 2021 at 3:27 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-7078:
>   Operation error message pop
> up shows database objects name incorrectly.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [patch][pgAdmin] RM7018 [React] Port Restore dialog to React.

[Akshay Joshi]

Thanks, the patch applied.

On Sun, Dec 26, 2021 at 4:18 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Aditya/Akshay,
>
> Please find the comments below.
>
> On Wed, Dec 22, 2021 at 1:57 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Rahul,
>>
>> Everything looks good except:
>>
>> 1. Remove unnecessary whitespaces
>>
>>
>> adityatoshniwal@LAPTOP381PNIN pgadmin4_copy % git apply
>> ~/Downloads/RM7018.patch
>>
>> /Users/adityatoshniwal/Downloads/RM7018.patch:14070: trailing whitespace.
>>
>>   constructor(getRestoreSectionSchema, getRestoreTypeObjSchema,
>> getRestoreSaveOptSchema,
>>
>> /Users/adityatoshniwal/Downloads/RM7018.patch:15563: trailing whitespace.
>>
>> import RestoreSchema, {getRestoreSaveOptSchema,
>> getRestoreQueryOptionSchema, getRestoreDisableOptionSchema,
>>
>> /Users/adityatoshniwal/Downloads/RM7018.patch:15620: new blank line at
>> EOF.
>>
>> +
>>
>> warning: 3 lines add whitespace errors.
>>
>  Done
>
>>
>> 2. Use lodash, and not underscore.
>>
>> +  'sources/gettext', 'sources/url_for', 'underscore', 'pgadmin.browser',
>> 'sources/utils',
>>
>  It's removed now.
>
>> 3. Use gettext
>> panel.title(`Restore (${pgBrowser.Nodes[data._type].label}:
>> ${data.label})`);
>>
>   It's fixed now.
>
>> 4. Dialog size is huge. Reduce the dialog size.
>>
>  As per discussion on the call, I have reduced the height of the dialog
> (both for restore & backup)
>
>> 5. Mouseover on header should change cursor to "move"
>>
>  It's fixed now.
>
>>
>> [image: image.png]
>>
>> 6. If I remove the bin path from preferences, the "utility not found"
>> error comes after I click on restore. It should come as soon as I hit the
>> menu. Same problem with backup.
>>
>  Fixed for both restore & backup utility.
>
>> 7. In restore.js the below code is repeated. You should get the treeInfo
>> only once the dialog opens.
>> const selectedNode = pgBrowser.tree.selected();
>> var selectedTreeNode = pgBrowser.tree.findNodeByDomElement(selectedNode);
>> const treeInfo = pgBrowser.tree.getTreeNodeHierarchy(selectedTreeNode);
>>
>  Refactored the code, it's removed now.
>
>> 8. Minor spacing fixes between arrow and text.
>> ()=>getRestoreQueryOptionSchema({nodeInfo: treeNodeInfo}),
>> ()=> getRestoreDisableOptionSchema({nodeInfo: treeNodeInfo}),
>> ()=> getRestoreMiscellaneousSchema({nodeInfo: treeNodeInfo}),
>>
>  Have taken care of this.
>
>>
>> On Wed, Dec 22, 2021 at 11:35 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it?
>>>
>>> On Tue, Dec 21, 2021 at 4:52 PM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Please find the attached patch, which ports the restore dialog to react.

 --
 *Rahul Shirsat*
 Senior Software Engineer | EnterpriseDB Corporation.

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*