Re: [patch][pgAdmin] RM7018 [React] Port Restore dialog to React.

2021-12-22 Thread Aditya Toshniwal 
Hi Rahul,

Everything looks good except:

1. Remove unnecessary whitespaces


adityatoshniwal@LAPTOP381PNIN pgadmin4_copy % git apply
~/Downloads/RM7018.patch

/Users/adityatoshniwal/Downloads/RM7018.patch:14070: trailing whitespace.

  constructor(getRestoreSectionSchema, getRestoreTypeObjSchema,
getRestoreSaveOptSchema,

/Users/adityatoshniwal/Downloads/RM7018.patch:15563: trailing whitespace.

import RestoreSchema, {getRestoreSaveOptSchema,
getRestoreQueryOptionSchema, getRestoreDisableOptionSchema,

/Users/adityatoshniwal/Downloads/RM7018.patch:15620: new blank line at EOF.

+

warning: 3 lines add whitespace errors.


2. Use lodash, and not underscore.

+  'sources/gettext', 'sources/url_for', 'underscore', 'pgadmin.browser',
'sources/utils',
3. Use gettext
panel.title(`Restore (${pgBrowser.Nodes[data._type].label}:
${data.label})`);
4. Dialog size is huge. Reduce the dialog size.
5. Mouseover on header should change cursor to "move"

[image: image.png]

6. If I remove the bin path from preferences, the "utility not found" error
comes after I click on restore. It should come as soon as I hit the menu.
Same problem with backup.
7. In restore.js the below code is repeated. You should get the treeInfo
only once the dialog opens.
const selectedNode = pgBrowser.tree.selected();
var selectedTreeNode = pgBrowser.tree.findNodeByDomElement(selectedNode);
const treeInfo = pgBrowser.tree.getTreeNodeHierarchy(selectedTreeNode);
8. Minor spacing fixes between arrow and text.
()=>getRestoreQueryOptionSchema({nodeInfo: treeNodeInfo}),
()=> getRestoreDisableOptionSchema({nodeInfo: treeNodeInfo}),
()=> getRestoreMiscellaneousSchema({nodeInfo: treeNodeInfo}),

On Wed, Dec 22, 2021 at 11:35 AM Akshay Joshi 
wrote:

> Hi Aditya
>
> Can you please review it?
>
> On Tue, Dec 21, 2021 at 4:52 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch, which ports the restore dialog to react.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"

pgAdmin 4 commit: Added beforeNext and beforeBack method in Wizard.

2021-12-22 Thread Akshay Joshi 
Added beforeNext and beforeBack method in Wizard.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae73f138127b3b1147cdbc129fe7432a294b0d3e

Modified Files
--
web/pgadmin/static/js/helpers/wizard/Wizard.jsx| 24 +++
.../static/js/helpers/wizard/WizardStep.jsx| 28 +++---
2 files changed, 23 insertions(+), 29 deletions(-)

pgAdmin 4 commit: Fixed linter errors.

2021-12-22 Thread Akshay Joshi 
Fixed linter errors.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ebee7a5b72bdf1ff0f5d87a8ae6ae4c2c465e164

Modified Files
--
web/pgadmin/static/js/helpers/wizard/Wizard.jsx |  4 +++-
web/pgadmin/static/js/helpers/wizard/WizardStep.jsx | 18 +-
2 files changed, 12 insertions(+), 10 deletions(-)

[pgAdmin][GrantWizard]: Changes in grantWizard and Wizard component.

2021-12-22 Thread Nikhil Mohite 
Hi Hackers,

Please find the attached patch for changes in the grant wizard, wizard, and
wizard step component, updated CSS, and a few other changes in the wizard
component.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


grantWizard.patch
Description: Binary data

pgAdmin 4 commit: Change logic for grant wizard, wizard component, and

2021-12-22 Thread Akshay Joshi 
Change logic for grant wizard, wizard component, and updated CSS.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=45179ccb8c45e64a991f1bbe25434828cddd05c7
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/js/components/PgTable.jsx   |   8 ++
web/pgadmin/static/js/helpers/wizard/Wizard.jsx| 113 +
.../tools/grant_wizard/static/js/GrantWizard.jsx   | 108 +++-
3 files changed, 115 insertions(+), 114 deletions(-)

Re: [pgAdmin][GrantWizard]: Changes in grantWizard and Wizard component.

2021-12-22 Thread Akshay Joshi 
Thanks, the patch applied.

On Wed, Dec 22, 2021 at 3:50 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for changes in the grant wizard, wizard,
> and wizard step component, updated CSS, and a few other changes in the
> wizard component.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin][Patch] - Bug #7077 - Owner is not displayed in the SQL

2021-12-22 Thread Yogesh Mahajan 
Hi,

Please find the attached patch which fixes the issue related to the owner
for procedures.

Thanks,
Yogesh Mahajan
EnterpriseDB


RM_7077_v1.patch
Description: Binary data