[pgAdmin][RM-6745]: Tablespace is created though error is shown on dialogue.

2021-12-21 Thread Nikhil Mohite 
Hi Hackers,

Please find the attached patch for RM-6745
: Tablespace is created though
an error is shown on dialogue.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6745.patch
Description: Binary data

[pgAdmin][RM-7034]: Columns with default value not showing [default] when adding new row

2021-12-21 Thread Nikhil Mohite 
Hi Hackers,

Please find the attached patch for RM-7034
: Columns with default value
not showing [default] when adding a new row.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-7034.patch
Description: Binary data

Re: Feature Test Fix - React porting

2021-12-21 Thread Yogesh Mahajan 
Hi Team,

Please find feature tests fix that are broken due to react porting for
alert dialogues.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Tue, Nov 23, 2021 at 5:38 PM Akshay Joshi 
wrote:

> Thanks, the patch applied.
>
> On Tue, Nov 23, 2021 at 4:32 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix feature test failures due to react
>> porting for backup dialogue.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Mon, Nov 22, 2021 at 6:09 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Mon, Nov 22, 2021 at 12:58 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch which adds flexibility to wait for
 launching pgAdmin.

 Thanks,
 Yogesh Mahajan
 EnterpriseDB


 On Thu, Nov 18, 2021 at 5:15 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, the patch applied.
>
> On Thu, Nov 18, 2021 at 3:23 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch which fixes the problem related to
>> feature tests.
>>
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Fri, Nov 12, 2021 at 11:59 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Thu, Nov 11, 2021 at 10:04 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch which uses selenium 4.0.0a6 which
 works with python 3.6.8.
 Selenium 4.0.0 requires python 3.7+

 Thanks,
 Yogesh Mahajan
 EnterpriseDB


 On Wed, Nov 10, 2021 at 11:59 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, the patch applied. but Jenkins is failing with the below
> error:
> ERROR: No matching distribution found for selenium==4.0.0
> ERROR: Failed to install Python requirements.
>
> On Tue, Nov 9, 2021 at 2:48 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch which fixes feature tests broken
>> due to react porting changes.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


Feature_Test_Fix_React_Porting_v6.patch
Description: Binary data

pgAdmin 4 commit: 1) Added spacing for message and loading spinner.

2021-12-21 Thread Akshay Joshi 
1) Added spacing for message and loading spinner.
2) Rename the GrantWizard Dialog.
3) Return the activeStep from disableNextStep function.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02b83146bee791d3fbc34aa4e419c5090d8f9661

Modified Files
--
web/pgadmin/static/js/components/Loader.jsx  |  5 -
web/pgadmin/static/js/helpers/wizard/Wizard.jsx  |  2 +-
web/pgadmin/static/js/helpers/wizard/WizardStep.jsx  |  2 --
.../tools/grant_wizard/static/js/GrantWizard.jsx |  2 +-
.../tools/grant_wizard/static/js/grant_wizard.js | 20 ++--
5 files changed, 16 insertions(+), 15 deletions(-)

pgAdmin 4 commit: Fixed QueryToolJourneyTest feature test.

2021-12-21 Thread Akshay Joshi 
Fixed QueryToolJourneyTest feature test.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e302a6199a39afcf6ac1b85af66eb7ba3c525927
Author: Yogesh Mahajan 

Modified Files
--
.../feature_tests/query_tool_journey_test.py   | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Fixed an issue where Tablespace is created though an

2021-12-21 Thread Akshay Joshi 
Fixed an issue where Tablespace is created though an error is shown on the 
dialog. Fixes #6745

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=461c0abce1fbe842debc2a112525dc760e3682fa
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_6_4.rst   |  1 +
.../server_groups/servers/tablespaces/__init__.py  | 36 --
web/pgadmin/browser/static/js/node.js  |  6 
3 files changed, 33 insertions(+), 10 deletions(-)

pgAdmin 4 commit: Fixed an issue where Columns with default value not s

2021-12-21 Thread Akshay Joshi 
Fixed an issue where Columns with default value not showing when adding a new 
row. Fixes #7034

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5e9981836bd93cd21c8c95bf0b1a766ad17fce2
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/tools/sqleditor/utils/get_column_types.py | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)

Re: Feature Test Fix - React porting

2021-12-21 Thread Akshay Joshi 
Thanks, the patch applied.

On Tue, Dec 21, 2021 at 4:31 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find feature tests fix that are broken due to react porting for
> alert dialogues.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Tue, Nov 23, 2021 at 5:38 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Tue, Nov 23, 2021 at 4:32 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix feature test failures due to react
>>> porting for backup dialogue.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Mon, Nov 22, 2021 at 6:09 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, the patch applied.

 On Mon, Nov 22, 2021 at 12:58 PM Yogesh Mahajan <
 yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch which adds flexibility to wait for
> launching pgAdmin.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Thu, Nov 18, 2021 at 5:15 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Nov 18, 2021 at 3:23 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which fixes the problem related to
>>> feature tests.
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Fri, Nov 12, 2021 at 11:59 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, the patch applied.

 On Thu, Nov 11, 2021 at 10:04 PM Yogesh Mahajan <
 yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch which uses selenium 4.0.0a6 which
> works with python 3.6.8.
> Selenium 4.0.0 requires python 3.7+
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Nov 10, 2021 at 11:59 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied. but Jenkins is failing with the below
>> error:
>> ERROR: No matching distribution found for selenium==4.0.0
>> ERROR: Failed to install Python requirements.
>>
>> On Tue, Nov 9, 2021 at 2:48 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which fixes feature tests broken
>>> due to react porting changes.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-6745]: Tablespace is created though error is shown on dialogue.

2021-12-21 Thread Akshay Joshi 
Thanks, the patch applied.

On Tue, Dec 21, 2021 at 2:09 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6745
> : Tablespace is created
> though an error is shown on dialogue.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-7034]: Columns with default value not showing [default] when adding new row

2021-12-21 Thread Akshay Joshi 
Thanks, the patch applied.

On Tue, Dec 21, 2021 at 4:07 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-7034
> : Columns with default value
> not showing [default] when adding a new row.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [patch][pgAdmin] RM7018 [React] Port Restore dialog to React.

2021-12-21 Thread Akshay Joshi 
Hi Aditya

Can you please review it?

On Tue, Dec 21, 2021 at 4:52 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch, which ports the restore dialog to react.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*