Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React

[Nikhil Mohite]

Hi Akshay,

Please find the updated patch:
1. Resolved issue if the binary patch is not present/ not correct, then
show error notification to add/ correct the binary path.

Regards,
Nikhil Mohite

On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi 
wrote:

> Thanks, the patch applied.
>
> On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Following are the review comments:
>>>
>>> GUI:
>>>
>>>- Dialog size should be increased.
>>>- Remove the first blank element from the Encoding dropdown.
>>>- When opening the file dialog header should have the title 'Select
>>>file'.
>>>- 'Backup server' title should be changed to 'Backup Server'.
>>>- When taking the backup of any object like database, schema, etc..
>>>the title on the dialog header should be "Backup (Database/Schema ..."
>>>instead of  "Backup (database/schema ..."
>>>
>>>
>>> Code:
>>>
>>>- Jasmine test cases are failing.
>>>- Remove warnBeforeChangesLost function not needed for Utilities.
>>>(Remove Alertify as well)
>>>- The naming convention should be identical, in some cases, you used
>>>camel case and in some cases used with an underscore.
>>>- Remove the commented code from all the files.
>>>- Take all the screenshots again with a width of 681.
>>>
>>> Resolved all review comments.
>>
>>> Note: I haven't tested it thoroughly with all combinations.
>>>
>>> On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Please find the attached patch for RM-6884:
   Port Backup Global,
 Backup Server, and Backup object dialog in React


>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Senior Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM-6984_v3.patch
Description: Binary data

pgAdmin 4 commit: 1) Replace Flask-BabelEx with Flask-Babel. Fixes #608

[Akshay Joshi]

1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088
2) Upgrade Flask to version 2. Fixes #7010

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d644b4f94ec71af78a46434121bce0fcd626a2dc

Modified Files
--
DEPENDENCIES   | 25 
docs/en_US/release_notes_6_3.rst   |  4 ++-
requirements.txt   | 19 ++---
web/migrations/versions/09d53fca90c7_.py   |  7 +++--
web/migrations/versions/fdc58d9bd449_.py   | 14 +++--
web/pgadmin/__init__.py| 33 +-
web/pgadmin/about/__init__.py  |  2 +-
web/pgadmin/authenticate/__init__.py   |  2 +-
web/pgadmin/authenticate/internal.py   |  2 +-
web/pgadmin/authenticate/kerberos.py   |  6 ++--
web/pgadmin/authenticate/ldap.py   |  2 +-
web/pgadmin/authenticate/oauth2.py |  6 ++--
web/pgadmin/authenticate/webserver.py  |  6 ++--
web/pgadmin/browser/__init__.py|  2 +-
web/pgadmin/browser/collection.py  |  2 +-
.../browser/register_browser_preferences.py|  2 +-
web/pgadmin/browser/server_groups/__init__.py  |  2 +-
.../browser/server_groups/servers/__init__.py  | 19 ++---
.../server_groups/servers/databases/__init__.py|  2 +-
.../servers/databases/casts/__init__.py|  2 +-
.../servers/databases/event_triggers/__init__.py   |  2 +-
.../servers/databases/extensions/__init__.py   |  2 +-
.../databases/foreign_data_wrappers/__init__.py|  2 +-
.../foreign_servers/__init__.py|  2 +-
.../foreign_servers/user_mappings/__init__.py  |  2 +-
.../servers/databases/languages/__init__.py|  2 +-
.../servers/databases/publications/__init__.py |  2 +-
.../servers/databases/schemas/__init__.py  |  2 +-
.../databases/schemas/aggregates/__init__.py   |  2 +-
.../databases/schemas/catalog_objects/__init__.py  |  2 +-
.../schemas/catalog_objects/columns/__init__.py|  2 +-
.../databases/schemas/collations/__init__.py   |  2 +-
.../servers/databases/schemas/domains/__init__.py  |  2 +-
.../schemas/domains/domain_constraints/__init__.py |  2 +-
.../databases/schemas/foreign_tables/__init__.py   |  2 +-
.../schemas/fts_configurations/__init__.py |  2 +-
.../databases/schemas/fts_dictionaries/__init__.py |  2 +-
.../databases/schemas/fts_parsers/__init__.py  |  2 +-
.../databases/schemas/fts_templates/__init__.py|  2 +-
.../databases/schemas/functions/__init__.py|  2 +-
.../databases/schemas/operators/__init__.py|  2 +-
.../servers/databases/schemas/packages/__init__.py |  2 +-
.../schemas/packages/edbfuncs/__init__.py  |  2 +-
.../databases/schemas/packages/edbvars/__init__.py |  2 +-
.../databases/schemas/sequences/__init__.py|  2 +-
.../servers/databases/schemas/synonyms/__init__.py |  2 +-
.../servers/databases/schemas/tables/__init__.py   |  2 +-
.../databases/schemas/tables/columns/__init__.py   |  2 +-
.../databases/schemas/tables/columns/utils.py  |  2 +-
.../schemas/tables/compound_triggers/__init__.py   |  2 +-
.../schemas/tables/compound_triggers/utils.py  |  2 +-
.../schemas/tables/constraints/__init__.py |  2 +-
.../constraints/check_constraint/__init__.py   |  2 +-
.../tables/constraints/check_constraint/utils.py   |  2 +-
.../constraints/exclusion_constraint/__init__.py   |  2 +-
.../constraints/exclusion_constraint/utils.py  |  2 +-
.../tables/constraints/foreign_key/__init__.py |  2 +-
.../tables/constraints/foreign_key/utils.py|  2 +-
.../constraints/index_constraint/__init__.py   |  2 +-
.../tables/constraints/index_constraint/utils.py   |  2 +-
.../databases/schemas/tables/indexes/__init__.py   |  2 +-
.../databases/schemas/tables/indexes/utils.py  |  2 +-
.../schemas/tables/partitions/__init__.py  | 32 +
.../tables/row_security_policies/__init__.py   |  2 +-
.../schemas/tables/row_security_policies/utils.py  |  2 +-
.../databases/schemas/tables/rules/__init__.py |  2 +-
.../databases/schemas/tables/triggers/__init__.py  |  2 +-
.../databases/schemas/tables/triggers/utils.py |  2 +-
.../servers/databases/schemas/tables/utils.py  |  2 +-
.../servers/databases/schemas/types/__init__.py|  2 +-
.../servers/databases/schemas/views/__init__.py|  2 +-
.../servers/databases/subscriptions/__init__.py|  2 +-
.../server_groups/servers/pgagent/__init__.py  |  2 +-
.../servers/pgagent/schedules/__init__.py  |  2 +-
.../servers/pgagent/steps/__init__.py  |  2 +-
web/pgadmin/browser/server_groups/servers/ppas.py  |  2 +-
.../servers/resource_groups/__init__.py|  2 +-
.../server_groups/servers/roles/__init__.py|  4 +--
.../server_groups/servers/table

pgAdmin 4 commit: Resolved issue if the binary path is not present/corr

[Akshay Joshi]

Resolved issue if the binary path is not present/correct, then show error 
notification to add/correct the binary path.

refs #6984

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dcee71a92bce1a7c164e777cec7a2795f4149c0
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/tools/backup/static/js/backup.js | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React

[Akshay Joshi]

Thanks, the patch applied.

On Wed, Nov 24, 2021 at 5:09 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch:
> 1. Resolved issue if the binary patch is not present/ not correct, then
> show error notification to add/ correct the binary path.
>
> Regards,
> Nikhil Mohite
>
> On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the updated patch.
>>>
>>> On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Nikhil

 Following are the review comments:

 GUI:

- Dialog size should be increased.
- Remove the first blank element from the Encoding dropdown.
- When opening the file dialog header should have the title 'Select
file'.
- 'Backup server' title should be changed to 'Backup Server'.
- When taking the backup of any object like database, schema, etc..
the title on the dialog header should be "Backup (Database/Schema ..."
instead of  "Backup (database/schema ..."


 Code:

- Jasmine test cases are failing.
- Remove warnBeforeChangesLost function not needed for Utilities.
(Remove Alertify as well)
- The naming convention should be identical, in some cases, you
used camel case and in some cases used with an underscore.
- Remove the commented code from all the files.
- Take all the screenshots again with a width of 681.

 Resolved all review comments.
>>>
 Note: I haven't tested it thoroughly with all combinations.

 On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6884:
>   Port Backup Global,
> Backup Server, and Backup object dialog in React
>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *
 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Senior Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed API test case after upgrading Flask to v2.

[Akshay Joshi]

Fixed API test case after upgrading Flask to v2.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bce7e8346de73d6e5700a0f12b512c56057a7267

Modified Files
--
web/regression/python_test_utils/csrf_test_client.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Use .__ne__ instead of 'is not None' statement to fix

[Akshay Joshi]

Use .__ne__ instead of 'is not None' statement to fix the API test cases.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a0d92469bf57c69ca7ad524d03d2ec1a3b4710d

Modified Files
--
web/pgadmin/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin][RM-7005]: On demand rows throws error if any cell edit saved

[Nikhil Mohite]

Hi Hackers,

Please find the attached patch for RM-7005:
 On-demand rows throw an error
if any cell edit saved

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-7005.patch
Description: Binary data