[pgAdmin4][Patch] - RM #6882 - Object browser tree table columns display order

2021-10-12 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #6882 - Object browser tree
table columns display order.

Thanks,
Khushboo


RM_6882.patch
Description: Binary data


Re: [pgAdmin4][Patch] - RM 6657 - Support for REMOTE_USER as Authentication.

2021-10-12 Thread Dave Page
Very nice (the existence of the patch that is - I haven't reviewed it)! I
think this nicely rounds off and completes the auth mechanisms we're likely
to want.

On Tue, Oct 12, 2021 at 6:13 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for #6657 - Support for REMOTE_USER as
> Authentication.
>
> The initial patch was provided by *Tom Schreiber,* I have made the
> necessary changes to work with pgAdmin and also added test cases and
> documentation.
> Please commit the patch on *Tom Schreiber's *name.
>
> This patch also includes the fix for the RM #6719 - OAuth2 integration
> redirect issue
>
>
> Thanks,
> Khushboo
>


-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


[patch][pgAdmin] RM6754 Color of query highlighting in query tool should be less intensive

2021-10-12 Thread Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves the issue of intensive query
highlighting in the query tool.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6754.patch
Description: Binary data


[pgAdmin4][Patch] - RM #6881 - Browser tree falls apart upon changing resolution

2021-10-12 Thread Khushboo Vashi
Hi,

Please find the attached patch for RM #6881 - Browser tree falls apart upon
changing resolution

Thanks,
Khushboo


RM_6881.patch
Description: Binary data


Re: [pgAdmin][Patch] - Bug #6776 - Label 'Inherits Tables?' is misleading in properties panel.

2021-10-12 Thread Akshay Joshi
Hi Yogesh

Please update the documentation and respective screenshot.

On Tue, Oct 12, 2021 at 12:05 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the attached patch to change the label for table properties
> panel.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Ensure that columns should be displayed in the order

2021-10-12 Thread Akshay Joshi
Ensure that columns should be displayed in the order of creation instead of 
alphabetical order in the browser tree. Fixes #6882

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca40add29bc58a6da0ce64f2bf3386015dfe54bf
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_6_1.rst |  1 +
web/pgadmin/static/js/tree/tree_init.tsx | 14 ++
2 files changed, 15 insertions(+)



pgAdmin 4 commit: Fixed an issue where the browser tree doesn't show al

2021-10-12 Thread Akshay Joshi
Fixed an issue where the browser tree doesn't show all contents on changing 
resolution. Fixes #6881

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac6c6fbf97887f8601423b991699de0293754676
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_6_1.rst | 1 +
web/package.json | 2 +-
web/pgadmin/static/js/tree/tree_init.tsx | 3 +--
3 files changed, 3 insertions(+), 3 deletions(-)



pgAdmin 4 commit: 1) Added support for authentication via the web serve

2021-10-12 Thread Akshay Joshi
1) Added support for authentication via the web server (REMOTE_USER). Fixes 
#6657
2) Fixed OAuth2 integration redirect issue. Fixes #6719

Initial patch for 6657 sent by: Tom Schreiber

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a726635290a91d26226a0b912806c7767a7db56b
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/getting_started.rst |   1 +
docs/en_US/release_notes_6_1.rst   |   2 +
docs/en_US/webserver.rst   |  44 
web/config.py  |   9 +-
web/pgAdmin4.wsgi  |   2 +
web/pgadmin/__init__.py|  17 +--
web/pgadmin/authenticate/webserver.py  | 119 +
.../browser/tests/test_kerberos_with_mocking.py|   1 +
web/pgadmin/browser/tests/test_ldap_login.py   |   1 +
.../browser/tests/test_ldap_with_mocking.py|   1 +
web/pgadmin/browser/tests/test_login.py|   1 +
.../browser/tests/test_oauth2_with_mocking.py  |   1 +
.../browser/tests/test_webserver_with_mocking.py   |  86 +++
web/pgadmin/utils/constants.py |   6 +-
14 files changed, 282 insertions(+), 9 deletions(-)



pgAdmin 4 commit: Ensure that query highlighting color in the query too

2021-10-12 Thread Akshay Joshi
Ensure that query highlighting color in the query tool should be less 
intensive. Fixes #6754

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ced82c7b3fcc1093258833a6c78ae20e981f810
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/release_notes_6_1.rst  | 1 +
web/pgadmin/static/scss/resources/_default.variables.scss | 2 ++
web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss   | 5 +
3 files changed, 8 insertions(+)



pgAdmin 4 commit: Fixed API Test Case for ERD

2021-10-12 Thread Akshay Joshi
Fixed API Test Case for ERD

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d81960a6eb4d912885022a5643936ba6cfbbc59c
Author: Aditya Toshniwal 

Modified Files
--
.../tools/erd/static/js/erd_tool/ERDCore.js| 15 ---
.../tools/erd/tests/test_sql_input_data.json   | 29 +++---
2 files changed, 15 insertions(+), 29 deletions(-)



Re: [pgAdmin][RM6081] Advanced table fields in ERD

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 11:36 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Please review the attached patch to fix failing API test case.
>
> On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch will port Backbone based dialogs in ERD to React based
>>> using the schema view UI framework. This allows us to use the existing
>>> table UI, remove repeated code and enable advanced fields. I have hidden
>>> fields from the existing table UI for ERD.
>>> Please note, this also fixes #6529.
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - RM #6882 - Object browser tree table columns display order

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 12:30 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #6882 - Object browser tree
> table columns display order.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - RM 6657 - Support for REMOTE_USER as Authentication.

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 10:43 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for #6657 - Support for REMOTE_USER as
> Authentication.
>
> The initial patch was provided by *Tom Schreiber,* I have made the
> necessary changes to work with pgAdmin and also added test cases and
> documentation.
> Please commit the patch on *Tom Schreiber's *name.
>
> This patch also includes the fix for the RM #6719 - OAuth2 integration
> redirect issue
>
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [patch][pgAdmin] RM6754 Color of query highlighting in query tool should be less intensive

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 1:59 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of intensive query
> highlighting in the query tool.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - RM #6881 - Browser tree falls apart upon changing resolution

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 2:41 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for RM #6881 - Browser tree falls apart
> upon changing resolution
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - RM #4596 - Directory tree indent guides

2021-10-12 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #4596 - Directory tree indent
guides.

Thanks,
Khushboo


RM_4596.patch
Description: Binary data


Re: [pgAdmin][RM6794]: Provide functionality to disable/enable rules

2021-10-12 Thread Akshay Joshi
 Hi Pradip

You forgot to implement the following:
ENABLE REPLICA RULE rewrite_rule_name
ENABLE ALWAYS RULE rewrite_rule_name

It is just like a trigger, you need to get the drop-down in edit mode.
Please update the documentation and screenshot as well.


On Mon, Oct 11, 2021 at 7:37 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the updated patch for #6794 Provide functionality to
> disable/enable rules.
>
> This patch also includes the fix for #6870 Unable to delete server group
> if first server group has shared server.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Updated yarn.lock file

2021-10-12 Thread Akshay Joshi
Updated yarn.lock file

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72e5d4b42687703582ec6733d868ca871b29dbc9

Modified Files
--
docs/en_US/release_notes_6_1.rst | 4 ++--
web/yarn.lock| 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)



pgAdmin 4 commit: Added support for indent guides in the browser tree.

2021-10-12 Thread Akshay Joshi
Added support for indent guides in the browser tree. Fixes #4596

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9fd9ca2673ecd148af4882b3ab7b2d077afe7a0f
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_6_1.rst|  1 +
.../static/scss/_pgadmin4-tree.overrides.scss   | 21 -
2 files changed, 21 insertions(+), 1 deletion(-)



Re: [pgAdmin4][Patch] - RM #4596 - Directory tree indent guides

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 5:04 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #4596 - Directory tree
> indent guides.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin][RM-6790]: Unable to create index with concurrently keyword.

2021-10-12 Thread Nikhil Mohite
Hi Hackers,

Please find the attached patch for RM-6790:
 Unable to create index with
concurrently keyword.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6790.patch
Description: Binary data


pgAdmin 4 commit: Fixed an issue where the user is unable to create an

2021-10-12 Thread Akshay Joshi
Fixed an issue where the user is unable to create an index with concurrently 
keyword. Fixes #6790

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b9383c880ce0ecb53578973fdeace85ee17fe48
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_6_1.rst   |  1 +
.../databases/schemas/tables/indexes/__init__.py   | 32 +---
.../schemas/tables/indexes/static/js/index.ui.js   | 15 --
.../tables/indexes/tests/index_test_data.json  | 34 --
web/pgadmin/static/js/SchemaView/DataGridView.jsx  |  4 +--
5 files changed, 61 insertions(+), 25 deletions(-)



Re: [pgAdmin][RM-6790]: Unable to create index with concurrently keyword.

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 5:59 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6790:
>  Unable to create index with
> concurrently keyword.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin][RM6900] Unable to create exclusion constraint from table properties

2021-10-12 Thread Aditya Toshniwal
Hi Hackers,

Attached patch fixes the issue where exclusion constraint cannot be created
from table dialog if the access method name is changed once.
The dialog is certainly not crashing, and not stuck. On access method
change, instead of removing ex const columns, it is removing table columns.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6900.patch
Description: Binary data


Re: [pgAdmin][Patch] - Bug #6776 - Label 'Inherits Tables?' is misleading in properties panel.

2021-10-12 Thread Yogesh Mahajan
Hi,

There is no change in documentation for this change.


Thanks,
Yogesh Mahajan
EnterpriseDB


On Tue, Oct 12, 2021 at 2:41 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Please update the documentation and respective screenshot.
>
> On Tue, Oct 12, 2021 at 12:05 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch to change the label for table properties
>> panel.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


pgAdmin 4 commit: Changed the label 'Inherits Tables?' to 'Is inherited

2021-10-12 Thread Akshay Joshi
Changed the label 'Inherits Tables?' to 'Is inherited?' as it misleading in the 
properties panel. Fixes #6776

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c692df118b96e0944916d9e26ae01fba6911a91
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_6_1.rst| 1 +
.../databases/schemas/tables/partitions/static/js/partition.ui.js   | 2 +-
.../servers/databases/schemas/tables/static/js/table.ui.js  | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)



pgAdmin 4 commit: Fixed an issue where exclusion constraint cannot be c

2021-10-12 Thread Akshay Joshi
Fixed an issue where exclusion constraint cannot be created from table dialog
if the access method name is changed once. Fixes #6900

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ace229152f65026837e1d80f284ac7d2dd8172c
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_6_1.rst| 1 +
web/pgadmin/static/js/SchemaView/DepListener.js | 6 --
web/pgadmin/static/js/SchemaView/index.jsx  | 7 +--
3 files changed, 10 insertions(+), 4 deletions(-)



Re: [pgAdmin][Patch] - Bug #6776 - Label 'Inherits Tables?' is misleading in properties panel.

2021-10-12 Thread Akshay Joshi
Thanks, the patch applied.

On Wed, Oct 13, 2021 at 10:47 AM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> There is no change in documentation for this change.
>
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Tue, Oct 12, 2021 at 2:41 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Yogesh
>>
>> Please update the documentation and respective screenshot.
>>
>> On Tue, Oct 12, 2021 at 12:05 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the attached patch to change the label for table properties
>>> panel.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*