[pgAdmin4][Patch] - Fixed Dialog Closing issue

2021-09-28 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the dialog closing issue.

Thanks,
Khushboo


update_issue.patch
Description: Binary data


[pgAdmin][RM6814] Server and DB node related fixes

2021-09-28 Thread Aditya Toshniwal
Hi Hackers,

Attached patch fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction has an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then empty value
error should not come.
5. Values for parameters should be reset on changing parameter.
6. Added a new key - helpMessageMode which can have a value similar to
mode. It will show the help message if mode is supported.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6814.patch
Description: Binary data


pgAdmin 4 commit: Fixed 'Save' button issue where dialog is not getting

2021-09-28 Thread Akshay Joshi
Fixed 'Save' button issue where dialog is not getting closed.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b6101bc6d934ff9ae24b481d7c52a32ff5cbe45
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/js/tree/tree.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)



pgAdmin 4 commit: Fixed keyerror issue in schema diff for 'attnum' and

2021-09-28 Thread Akshay Joshi
Fixed keyerror issue in schema diff for 'attnum' and 'edit_types' parameter. 
Fixes #6755

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1569be7866cd490657f007e96c3e3bdbbd151964

Modified Files
--
docs/en_US/release_notes_6_0.rst   | 1 +
.../servers/databases/schemas/tables/schema_diff_utils.py  | 7 +--
.../server_groups/servers/databases/schemas/tables/utils.py| 2 +-
3 files changed, 3 insertions(+), 7 deletions(-)



pgAdmin 4 commit: Server and Database node fixes:

2021-09-28 Thread Akshay Joshi
Server and Database node fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value 
error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It 
will show the help message if the mode is supported.

Fixes #6814

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be69470d55b0f0fcc7512cb975ec87d978be3789
Author: Aditya Toshniwal 

Modified Files
--
.../servers/databases/static/js/database.ui.js |  3 ++-
.../browser/server_groups/servers/static/js/server.js  |  1 +
.../browser/server_groups/servers/static/js/server.ui.js   | 13 +++--
.../browser/server_groups/servers/static/js/variable.ui.js | 14 ++
web/pgadmin/static/js/SchemaView/MappedControl.jsx |  2 +-
web/pgadmin/static/js/SchemaView/index.jsx |  3 +++
web/pgadmin/static/js/components/FormComponents.jsx|  2 +-
.../javascript/schema_ui_files/server.ui.spec.js   |  2 +-
8 files changed, 26 insertions(+), 14 deletions(-)



[pgAdmin4][Patch]: Fixed Tree Item add error

2021-09-28 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the error on the console while adding
the new node.

Thanks,
Khushboo


tree_add_item_fix.patch
Description: Binary data


Re: [pgAdmin][RM6814] Server and DB node related fixes

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 2:48 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch fixes:
> 1. Unable to change shared server switch.
> 2. DB restriction and schema restriction has an empty option.
> 3. File select input control does not allow manual text input.
> 4. In the Parameters tab if the value is a switch control, then empty
> value error should not come.
> 5. Values for parameters should be reset on changing parameter.
> 6. Added a new key - helpMessageMode which can have a value similar to
> mode. It will show the help message if mode is supported.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - Fixed Dialog Closing issue

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 1:06 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the dialog closing issue.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fixed an error in browser tree when adding any node.

2021-09-28 Thread Akshay Joshi
Fixed an error in browser tree when adding any node.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31c7f3eabab2e9eb9c352d2a6d260420125d56f9
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/js/tree/tree.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Re: [pgAdmin4][Patch]: Fixed Tree Item add error

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 3:06 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the error on the console while
> adding the new node.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-09-28 Thread Akshay Joshi
Please rebase and send the patch.

On Tue, Sep 28, 2021 at 3:05 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch for RM-5741.
>
> On Wed, Sep 22, 2021 at 7:17 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied with some modifications. Changed the variable
>> names.
>>
>> On Wed, Sep 22, 2021 at 4:44 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the updated patch.
>>>
>>> On Mon, Sep 20, 2021 at 8:13 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Nikhil

 As per the discussion, we need to create a flag for whether to add
 the 'IF EXISTS" clause or not. Please send the combined patch after fixing
 that for all the nodes.

 On Mon, Sep 20, 2021 at 3:58 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the patch for RM-5741.
> Updated missing sql checks for following nodes:
> 1. Role
> 2. Resources Group
> 3. Schema
> 4. Language
> 5. Tablespace
>
>
> Regards,
> Nikhil Mohite
>
> On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied to the React_Porting branch as it is a big
>> change.
>> With the testing of each node after porting this patch also gets
>> tested.
>>
>> On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for RM-5741
>>> : [Schema Diff] Revisit
>>> all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' 
>>> and
>>> 'CREATE OR REPLACE'
>>>
>>> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to 13.3.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>> Regards,
>>> Nikhil Mohite
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - Fixes for RM #6817 & RM #6820

2021-09-28 Thread Khushboo Vashi
Hi,

Please find the attached patch for the RM #6817 and RM #6820.

#6817 - Browser panel turns blank on connecting disconnected database &
server has multiple databases

#6820 - Use hand pointer instead of arrow

Thanks,
Khushboo


RM_6817_6820.patch
Description: Binary data


Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-28 Thread Aditya Toshniwal
Hi,

Attached patch fixes:
1. Make Unlogged switch in table as read only.
2. Fix a console warning when saving node data.

On Thu, Sep 23, 2021 at 12:16 PM Akshay Joshi 
wrote:

> Thanks, the patch applied.
>
> On Thu, Sep 23, 2021 at 10:01 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Attached is the updated patch.
>>
>> On Wed, Sep 22, 2021 at 7:15 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Patch not applied, please rebase and send again.
>>>
>>> On Wed, Sep 22, 2021 at 7:00 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Not again. Attached is the patch. :D

 On Wed, Sep 22, 2021 at 6:47 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Can you please attached the patch :)
>
> On Wed, Sep 22, 2021 at 6:40 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch fixes issue where properties panel is not loaded for
>> catalog tables.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


 --
 Thanks,
 Aditya Toshniwal
 pgAdmin Hacker | Software Architect | *edbpostgres.com*
 
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6778.part2.patch
Description: Binary data


pgAdmin 4 commit: Added support for Two-factor authentication for impro

2021-09-28 Thread Akshay Joshi
Added support for Two-factor authentication for improving security. Fixes #6543

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=787a441343988c8e0b24876cc6d3cb81dee317af
Author: Ashesh Vashi 

Modified Files
--
docs/en_US/getting_started.rst |   1 +
docs/en_US/images/mfa_auth_app.png | Bin 0 -> 98072 bytes
docs/en_US/images/mfa_email.png| Bin 0 -> 77094 bytes
docs/en_US/images/mfa_login.png| Bin 0 -> 97855 bytes
docs/en_US/images/mfa_registration.png | Bin 0 -> 68217 bytes
docs/en_US/mfa.rst |  88 +
docs/en_US/release_notes_6_0.rst   |   1 +
requirements.txt   |   3 +
web/.eslintignore  |   1 +
web/config.py  |  23 ++
web/migrations/script.py.mako  |   3 +-
web/migrations/versions/15c88f765bc8_.py   |  44 +++
web/pgadmin/authenticate/__init__.py   |  22 +-
web/pgadmin/authenticate/mfa/__init__.py   | 110 ++
web/pgadmin/authenticate/mfa/authenticator.py  | 222 +++
web/pgadmin/authenticate/mfa/email.py  | 310 
web/pgadmin/authenticate/mfa/registry.py   | 167 +
.../authenticate/mfa/static/images/email_lock.svg  |   5 +
.../authenticate/mfa/static/images/totp_lock.svg   |   5 +
.../authenticate/mfa/templates/mfa/email.js|  66 
.../mfa/templates/mfa/email_code_sent.html |  19 +
.../authenticate/mfa/templates/mfa/email_view.html |   7 +
.../authenticate/mfa/templates/mfa/register.html   |  78 
.../authenticate/mfa/templates/mfa/validate.html   | 121 ++
.../templates/security/email/send_email_otp.html   |   2 +
.../templates/security/email/send_email_otp.txt|   2 +
web/pgadmin/authenticate/mfa/tests/test_config.py  | 154 
web/pgadmin/authenticate/mfa/tests/test_mfa.py |  56 +++
.../authenticate/mfa/tests/test_mfa_view.py|  66 
.../authenticate/mfa/tests/test_user_execution.py  | 125 +++
web/pgadmin/authenticate/mfa/tests/utils.py| 111 ++
web/pgadmin/authenticate/mfa/utils.py  | 408 +
web/pgadmin/authenticate/mfa/views.py  | 346 +
web/pgadmin/browser/__init__.py|  12 +-
web/pgadmin/browser/static/js/browser.js   |   4 +-
web/pgadmin/browser/static/js/dialog.js| 110 ++
web/pgadmin/browser/templates/browser/index.html   |  11 +
web/pgadmin/model/__init__.py  |   8 +
web/pgadmin/static/img/login.svg   |   2 +-
web/pgadmin/static/js/pgadmin.js   |   2 +
web/pgadmin/static/scss/_pgadmin.style.scss|  26 +-
.../static/scss/resources/_default.variables.scss  |   1 +
.../scss/resources/dark/_theme.variables.scss  |   2 +
.../resources/high_contrast/_theme.variables.scss  |   2 +
web/pgadmin/templates/base.html|   6 +-
.../templates/security/change_password.html|   4 +-
web/pgadmin/templates/security/panel.html  |  25 +-
web/pgadmin/tools/datagrid/__init__.py |   2 +
web/pgadmin/tools/debugger/__init__.py |   2 +
web/pgadmin/tools/erd/__init__.py  |   2 +
web/pgadmin/tools/psql/__init__.py |   2 +
web/pgadmin/tools/schema_diff/__init__.py  |   2 +
.../user_management/static/js/user_management.js   |  94 +
web/webpack.shim.js|   1 +
54 files changed, 2774 insertions(+), 112 deletions(-)



pgAdmin 4 commit: 1. Make Unlogged switch in table as read only.

2021-09-28 Thread Akshay Joshi
1. Make Unlogged switch in table as read only.
2. Fix a console warning when saving node data.

Fixes #6778

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08706ba6b278d22b8ca01d72d07152eb9f8c598c
Author: Aditya Toshniwal 

Modified Files
--
.../databases/schemas/tables/static/js/table.ui.js   |  2 +-
web/pgadmin/static/js/SchemaView/index.jsx   | 16 +---
web/pgadmin/static/js/Theme/index.jsx|  3 +++
web/pgadmin/static/js/custom_hooks.js| 11 ++-
4 files changed, 23 insertions(+), 9 deletions(-)



pgAdmin 4 commit: Added appropriate 'IF EXISTS', 'CASCADE', 'IF NOT EXI

2021-09-28 Thread Akshay Joshi
Added appropriate 'IF EXISTS', 'CASCADE', 'IF NOT EXISTS' clause for the 
remaining nodes.

refs #5741

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4db223a64f6461450b161875e884346f0f9a684
Author: Nikhil Mohite 

Modified Files
--
.../server_groups/servers/databases/foreign_data_wrappers/__init__.py | 2 +-
.../databases/foreign_data_wrappers/foreign_servers/__init__.py   | 2 +-
.../foreign_servers/tests/pg/9.3_plus/alter_comment_version.sql   | 2 +-
.../foreign_servers/tests/pg/9.3_plus/alter_options_privileges.sql| 2 +-
.../foreign_servers/tests/pg/9.3_plus/alter_remove_options_priv.sql   | 2 +-
.../foreign_servers/tests/pg/9.3_plus/create_fs_all_options.sql   | 2 +-
.../foreign_servers/tests/ppas/9.3_plus/alter_comment_version.sql | 2 +-
.../foreign_servers/tests/ppas/9.3_plus/alter_options_privileges.sql  | 2 +-
.../foreign_servers/tests/ppas/9.3_plus/alter_remove_options_priv.sql | 2 +-
.../foreign_servers/tests/ppas/9.3_plus/create_fs_all_options.sql | 2 +-
.../foreign_data_wrappers/foreign_servers/user_mappings/__init__.py   | 2 +-
.../user_mappings/templates/user_mappings/sql/default/create.sql  | 2 +-
.../foreign_servers/user_mappings/tests/pg/default/alter_options.sql  | 2 +-
.../user_mappings/tests/pg/default/alter_options_deleted.sql  | 2 +-
.../user_mappings/tests/pg/default/create_user_mapping.sql| 2 +-
.../user_mappings/tests/ppas/default/alter_options.sql| 2 +-
.../user_mappings/tests/ppas/default/alter_options_deleted.sql| 2 +-
.../user_mappings/tests/ppas/default/create_user_mapping.sql  | 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_change_opt2.sql | 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_comment.sql | 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_opt1.sql| 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_opt2.sql| 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_privileges.sql  | 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_rename.sql  | 2 +-
.../foreign_data_wrappers/tests/pg/9.3_plus/alter_fdw_validator.sql   | 2 +-
.../databases/foreign_data_wrappers/tests/pg/9.3_plus/create_fdw.sql  | 2 +-
.../tests/ppas/9.3_plus/alter_fdw_change_opt2.sql | 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/alter_fdw_comment.sql   | 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/alter_fdw_opt1.sql  | 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/alter_fdw_opt2.sql  | 2 +-
.../tests/ppas/9.3_plus/alter_fdw_privileges.sql  | 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/alter_fdw_rename.sql| 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/alter_fdw_validator.sql | 2 +-
.../foreign_data_wrappers/tests/ppas/9.3_plus/create_fdw.sql  | 2 +-
.../browser/server_groups/servers/databases/schemas/__init__.py   | 2 +-
.../server_groups/servers/databases/schemas/domains/__init__.py   | 2 +-
.../schemas/domains/tests/pg/default/alter_domain_comment.sql | 2 +-
.../domains/tests/pg/default/alter_domain_default_expression.sql  | 2 +-
.../databases/schemas/domains/tests/pg/default/alter_domain_name.sql  | 2 +-
.../schemas/domains/tests/pg/default/alter_domain_null_type.sql   | 2 +-
.../databases/schemas/domains/tests/pg/default/create_domain.sql  | 2 +-
.../schemas/domains/tests/pg/default/create_domain_numeric.sql| 2 +-
.../schemas/domains/tests/ppas/default/alter_domain_comment.sql   | 2 +-
.../domains/tests/ppas/default/alter_domain_default_expression.sql| 2 +-
.../schemas/domains/tests/ppas/default/alter_domain_name.sql  | 2 +-
.../schemas/domains/tests/ppas/default/alter_domain_null_type.sql | 2 +-
.../databases/schemas/domains/tests/ppas/default/create_domain.sql| 2 +-
.../schemas/domains/tests/ppas/default/create_domain_numeric.sql  | 2 +-
.../servers/databases/schemas/foreign_tables/__init__.py  | 2 +-
.../schemas/foreign_tables/tests/pg/9.2_plus/alter_add_opts.sql   | 2 +-
.../schemas/foreign_tables/tests/pg/9.2_plus/alter_add_priv.sql   | 2 +-
.../schemas/foreign_tables/tests/pg/9.2_plus/alter_col_opts.sql   | 2 +-
.../foreign_tables/tests/pg/9.2_plus/alter_comment_add_columns.sql| 2 +-
.../foreign_tables/tests/pg/9.2_plus/alter_remove_opts_priv.sql   | 2 +-
.../tests/pg/9.2_plus/create_foreign_table_with_all_options.sql   | 2 +-
.../schemas/foreign_tables/tests/pg/9.6_plus/alter_add_cons_opts.sql  | 2 +-
.../schemas/foreign_tables/tests/pg/9.6_plus/alter_add_priv.sql   | 2 +-
.../schemas/foreign_tables/tests/pg/9.6_plus/alter_col_opts.sql   | 2 +-
.../foreign_tables/tests/pg/9.6_plus/alter_comment_add_columns.sql| 2 +-
.../foreign_tables/tests/pg/9.6_plus/alter_remove_opts_priv_cons.sql  | 2 +-
.../tests/pg/9.6_plus/create_foreign_table_with_all_options.sql   | 2 +-
.

pgAdmin 4 commit: 1) Browser panel turns blank on connecting/disconnect

2021-09-28 Thread Akshay Joshi
1) Browser panel turns blank on connecting/disconnecting the database when the
   server has multiple databases. Fixes #6817
2) Use a hand pointer instead of an arrow. Fixes #6820

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=24399daefe4462f4514fa0990279773a38686fff
Author: Khushboo Vashi 

Modified Files
--
web/package.json  | 2 +-
web/pgadmin/static/scss/_pgadmin4-tree.overrides.scss | 6 --
web/yarn.lock | 4 ++--
3 files changed, 7 insertions(+), 5 deletions(-)



Re: [pgAdmin4][Patch] - Fixes for RM #6817 & RM #6820

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 5:14 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for the RM #6817 and RM #6820.
>
> #6817 - Browser panel turns blank on connecting disconnected database &
> server has multiple databases
>
> #6820 - Use hand pointer instead of arrow
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 5:19 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Attached patch fixes:
> 1. Make Unlogged switch in table as read only.
> 2. Fix a console warning when saving node data.
>
> On Thu, Sep 23, 2021 at 12:16 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Sep 23, 2021 at 10:01 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Attached is the updated patch.
>>>
>>> On Wed, Sep 22, 2021 at 7:15 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Patch not applied, please rebase and send again.

 On Wed, Sep 22, 2021 at 7:00 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Not again. Attached is the patch. :D
>
> On Wed, Sep 22, 2021 at 6:47 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Can you please attached the patch :)
>>
>> On Wed, Sep 22, 2021 at 6:40 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch fixes issue where properties panel is not loaded for
>>> catalog tables.
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-09-28 Thread Akshay Joshi
Thanks, the patch applied.

On Tue, Sep 28, 2021 at 3:32 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
> On Tue, Sep 28, 2021 at 3:30 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Tue, Sep 28, 2021 at 3:10 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Please rebase and send the patch.
>>>
>>> On Tue, Sep 28, 2021 at 3:05 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 Please find the updated patch for RM-5741.

 On Wed, Sep 22, 2021 at 7:17 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, the patch applied with some modifications. Changed the
> variable names.
>
> On Wed, Sep 22, 2021 at 4:44 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Mon, Sep 20, 2021 at 8:13 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> As per the discussion, we need to create a flag for whether to add
>>> the 'IF EXISTS" clause or not. Please send the combined patch after 
>>> fixing
>>> that for all the nodes.
>>>
>>> On Mon, Sep 20, 2021 at 3:58 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 Please find the patch for RM-5741.
 Updated missing sql checks for following nodes:
 1. Role
 2. Resources Group
 3. Schema
 4. Language
 5. Tablespace


 Regards,
 Nikhil Mohite

 On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, the patch applied to the React_Porting branch as it is a
> big change.
> With the testing of each node after porting this patch also gets
> tested.
>
> On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-5741
>> : [Schema Diff]
>> Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS',
>> 'CASCADE' and 'CREATE OR REPLACE'
>>
>> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to
>> 13.3.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>> Regards,
>> Nikhil Mohite
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>> Regards,
> Nikhil Mohite
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[patch][pgAdmin] RM6822 User can not expand the server on Windows

2021-09-28 Thread Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves the tree expanding issue on
windows.

Fix is tested on Windows 2016 & Mac.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6822.patch
Description: Binary data