pgAdmin 4 commit: Fixed html help for foreign server dialog.

[Akshay Joshi]

Fixed html help for foreign server dialog.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c32a325c118edf947ff22678a11aea6a6c981af9

Modified Files
--
.../foreign_servers/static/js/foreign_server.js  | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)

[pgAdmin][RM6783] Partition Node related fixes

[Aditya Toshniwal]

Hi Hackers,

Attached patch fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading
in dropdown.
3. Fix some grid column widths in table node.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6783.patch
Description: Binary data

Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

[Akshay Joshi]

Hi Khushboo

Following are the review comments with the new patch:

   - Select any collection node and make sure that the collection node
   should not have a single child. For example Cast, FDW, etc... Create a new
   Cast/FDW node it will not immediately be visible under the collection node.
   Once you collapse/expand then it is visible.
   - '*Failed to append .*' warning comes whenever you create any new
   node.
   - 'Backup Server', 'Backup' menu not working.
   - The maintenance dialog is showing a blank white screen.
   - PSQL Tool always gives a 'Please select a server/database object.'
   message.
   - *item.getMetadata('data') *is not a function tree.js 740. When select
   Constraints collection node or right-click on it. Make sure the Constraints
   collection node has at least one constraint.
   - Import/Export dialog not opening. *Cannot read properties of undefined
   (reading 'apply') *
   - *Cannot read properties of null (reading 'selected') *dependent.js
   line no 76.  Open pgAdmin in the browser, without selecting any node do the
   reset layout, you will get the same error.


On Fri, Sep 24, 2021 at 11:22 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
> All the review comments are fixed except one as below.
>
> Thanks,
> Khushboo
>
> On Fri, Sep 17, 2021 at 8:35 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Khushboo
>>
>> Following are the GUI review comments:
>>
>>- Arrow ( > ) is not center-aligned with the node labels.
>>- Sorting of tree items is not correct when you have servers like
>>(PostgreSQL 9.5, PostgreSQL 9.6, PostgreSQL 10...)
>>
>> The sorting of the tree is alphabetically,  so, PG 10 will come first
> than PG 9.5.
>
>>
>>- Servers collection node not showing count while expanding it.
>>- The last child should not have a collapse/expand arrow ( >).
>>- Properties panel should not be rendered again and again when the
>>same tree object is collapsed/expanded. I have tried on Schema node.
>>- The labels should be properly quoted. Create a Cast
>>*"money->bigint", *in properties dialog it is showing correctly, but
>>in browser tree, it is showing "*money->bigint*".
>>- Mouse hover any node, we will see the URL as a tooltip.
>>- Open query tool "*tree_data.slice is not a function" *error showing
>>in the developer tools. File: sqleditor.js:2392
>>- *node.getTreeNodeHierarchy is not a function* error visible. File:
>>dependents.js and dependencies.js:167. Please check the same function in
>>the whole source code.
>>- Select "*Postgres*" database or server node and refresh the node
>>using the context menu, after the refresh, it will show the number of
>>children which should not. The same behavior observes for each node.
>>- Lable "Group Roles" should be "Login/Group Roles".
>>- When scrolling at the bottom, the scroll bar automatically moves
>>up. Steps to reproduce Connect to one server and expand till table node,
>>then scroll down and connect to another server, when we try to scroll down
>>completely, the scroll bar automatically moves up.
>>- The following menu options are not working on the respective node:
>>   - *Server: *Reload Configuration, Clear Saved Password, and Add
>>   Named Restore Point
>>   - *Database*: Maintenence (*item.getMetadata is not a function
>>   tree.js line 710*), Grant Wizard, PSQL Tool (Please select a
>>   server or database object)
>>   - *Table*: Count Rows, Reset Statistics, Import/Export,
>>   Maintenence, Truncate
>>   - *Partitions*: Detach Partition,
>>   - *Check Constraint*:  Validate check constraint
>>   - *Constraints*:  Context menu not opening
>>   - *MView*: Context menu not opening:- Cannot read properties of
>>   undefined (reading 'apply') mview.js line no 395
>>
>> *Please check all the other Menu items if I missed them. *
>>
>> Code Review:
>>
>>- Remove commented code. Remove "console.warn" if used for testing
>>purposes.
>>- Remove if (m.name == 'create_table') console.warn(m); } browser.js
>>line no 797
>>
>> Code review still remains.
>>
>> On Wed, Sep 15, 2021 at 12:10 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for the RM #6129 - Port browser tree to
>>> React.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Partition related fixes:

[Akshay Joshi]

Partition related fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in 
dropdown.
3. Fix some grid column widths in table node.

Fixes #6783

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0228d169901d5f262c7f15c549e4074b52c2d79f
Author: Aditya Toshniwal 

Modified Files
--
.../foreign_key/static/js/foreign_key.ui.js|   7 +-
.../tables/partitions/static/js/partition.js   |   2 +-
.../tables/partitions/static/js/partition.ui.js|  46 +-
.../schemas/tables/static/js/partition.utils.js| 595 -
.../schemas/tables/static/js/partition.utils.ui.js |  45 +-
.../databases/schemas/tables/static/js/table.js|  37 +-
.../databases/schemas/tables/static/js/table.ui.js |   8 +-
web/pgadmin/browser/static/js/node_ajax.js |  13 +-
web/pgadmin/static/js/SchemaView/DataGridView.jsx  |   3 +
web/webpack.shim.js|   1 -
10 files changed, 86 insertions(+), 671 deletions(-)

Re: [pgAdmin][RM6783] Partition Node related fixes

[Akshay Joshi]

Thanks, the patch applied.

On Fri, Sep 24, 2021 at 3:34 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch fixes:
> 1. When attaching a partition, tables were not loading in the dropdown.
> 2. When adding a sub partition in a partition, collations were not loading
> in dropdown.
> 3. Fix some grid column widths in table node.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin][RM-6803 & RM-6804]: Trigger Node - [Create]> For constraint trigger only After event should be displayed, [Properties Panel/Edit Properties]> Incorrect values for Constraint trigger, Deferra

[Nikhil Mohite]

Hi Hackers,

Please find the attached combined patch for
RM-6803
 & RM-6804
.


--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6803_RM_6804.patch
Description: Binary data

[pgAdmin][RM-6759]: RLS names are editable in collection node of properties tab

[Nikhil Mohite]

Hi Hackers,

Please find the attached patch for
RM-6759:
RLS names are editable in the
collection node of properties tab.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6759.patch
Description: Binary data

pgAdmin 4 commit: Updated some screenshots and documentation for the no

[Akshay Joshi]

Updated some screenshots and documentation for the nodes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d8754cd3cf9adc553dfbe89ce164463da4de23c

Modified Files
--
docs/en_US/cast_dialog.rst |   9 +++--
docs/en_US/collation_dialog.rst|   2 +-
docs/en_US/domain_constraint_dialog.rst|   4 ++--
docs/en_US/domain_dialog.rst   |   6 +++---
docs/en_US/event_trigger_dialog.rst|  12 ++--
docs/en_US/extension_dialog.rst|   6 +++---
docs/en_US/foreign_data_wrapper_dialog.rst |   4 ++--
docs/en_US/foreign_server_dialog.rst   |   2 +-
docs/en_US/foreign_table_dialog.rst|   2 +-
docs/en_US/fts_configuration_dialog.rst|   6 +++---
docs/en_US/fts_dictionary_dialog.rst   |   2 +-
docs/en_US/fts_parser_dialog.rst   |   2 +-
docs/en_US/fts_template_dialog.rst |   4 ++--
docs/en_US/images/cast_definition.png  | Bin 39424 -> 61308 bytes
docs/en_US/images/cast_general.png | Bin 22379 -> 42823 bytes
docs/en_US/images/cast_sql.png | Bin 28634 -> 48811 bytes
docs/en_US/images/collation_definition.png | Bin 32095 -> 54072 bytes
docs/en_US/images/collation_general.png| Bin 34383 -> 53379 bytes
docs/en_US/images/collation_sql.png| Bin 39896 -> 62210 bytes
docs/en_US/images/domain_constraint_definition.png | Bin 28426 -> 47020 bytes
docs/en_US/images/domain_constraint_general.png| Bin 26122 -> 44294 bytes
docs/en_US/images/domain_constraint_sql.png| Bin 35125 -> 57019 bytes
docs/en_US/images/domain_constraints.png   | Bin 27984 -> 55106 bytes
docs/en_US/images/domain_definition.png| Bin 44058 -> 66208 bytes
docs/en_US/images/domain_general.png   | Bin 34425 -> 57640 bytes
docs/en_US/images/domain_security.png  | Bin 28376 -> 47741 bytes
docs/en_US/images/domain_sql.png   | Bin 56572 -> 58920 bytes
docs/en_US/images/event_trigger_definition.png | Bin 55290 -> 62992 bytes
docs/en_US/images/event_trigger_general.png| Bin 30389 -> 47685 bytes
docs/en_US/images/event_trigger_security.png   | Bin 33883 -> 47921 bytes
docs/en_US/images/event_trigger_sql.png| Bin 64123 -> 70338 bytes
docs/en_US/images/extension_definition.png | Bin 24889 -> 41699 bytes
docs/en_US/images/extension_general.png| Bin 26048 -> 43160 bytes
docs/en_US/images/extension_sql.png| Bin 27134 -> 45118 bytes
.../images/foreign_data_wrapper_definition.png | Bin 39848 -> 54699 bytes
docs/en_US/images/foreign_data_wrapper_general.png | Bin 39906 -> 58564 bytes
docs/en_US/images/foreign_data_wrapper_options.png | Bin 28525 -> 51569 bytes
.../en_US/images/foreign_data_wrapper_security.png | Bin 30901 -> 57120 bytes
docs/en_US/images/foreign_data_wrapper_sql.png | Bin 73533 -> 123002 bytes
docs/en_US/images/foreign_server_definition.png| Bin 26360 -> 44881 bytes
docs/en_US/images/foreign_server_general.png   | Bin 33799 -> 51648 bytes
docs/en_US/images/foreign_server_options.png   | Bin 27703 -> 56028 bytes
docs/en_US/images/foreign_server_security.png  | Bin 30282 -> 59881 bytes
docs/en_US/images/foreign_server_sql.png   | Bin 43464 -> 89739 bytes
docs/en_US/images/foreign_table_columns.png| Bin 38255 -> 68502 bytes
docs/en_US/images/foreign_table_constraints.png| Bin 40969 -> 52991 bytes
docs/en_US/images/foreign_table_definition.png | Bin 36584 -> 45209 bytes
docs/en_US/images/foreign_table_general.png| Bin 40538 -> 50074 bytes
docs/en_US/images/foreign_table_options.png| Bin 31254 -> 41044 bytes
docs/en_US/images/foreign_table_security.png   | Bin 50569 -> 60703 bytes
docs/en_US/images/foreign_table_sql.png| Bin 84395 -> 95810 bytes
docs/en_US/images/fts_configuration_definition.png | Bin 28104 -> 46711 bytes
docs/en_US/images/fts_configuration_general.png| Bin 37464 -> 57994 bytes
docs/en_US/images/fts_configuration_sql.png| Bin 51689 -> 57504 bytes
docs/en_US/images/fts_configuration_tokens.png | Bin 27403 -> 64635 bytes
docs/en_US/images/fts_dictionary_definition.png| Bin 24821 -> 41608 bytes
docs/en_US/images/fts_dictionary_general.png   | Bin 37709 -> 56885 bytes
docs/en_US/images/fts_dictionary_options.png   | Bin 29300 -> 51157 bytes
docs/en_US/images/fts_dictionary_sql.png   | Bin 42144 -> 59576 bytes
docs/en_US/images/fts_parser_definition.png| Bin 55795 -> 71171 bytes
docs/en_US/images/fts_parser_general.png   | Bin 29750 -> 48657 bytes
docs/en_US/images/fts_parser_sql.png   | Bin 51167 -> 66303 bytes
docs/en_US/images/fts_template_definition.png  | Bin 33199 -> 47413 bytes
docs/en_US/images/fts_template_general.png