pgAdmin 4 commit: Fixed the issue where password field is showing as pl

[Akshay Joshi]

Fixed the issue where password field is showing as plain text.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d27b4831d651397e4c7e882b41743679c54ae6c1
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/js/components/FormComponents.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: 1) Port Grant Wizard to react. Fixes #6687

[Akshay Joshi]

1) Port Grant Wizard to react. Fixes #6687
2) Fixed an issue where grant wizard is unresponsive if the database size is 
huge. Fixes #2097

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aa213a5cef9a4442f037e832635953997973835
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/grant_wizard.rst|   10 +-
docs/en_US/images/grant_wizard_step1.png   |  Bin 43337 -> 61164 bytes
docs/en_US/images/grant_wizard_step2.png   |  Bin 49232 -> 67159 bytes
docs/en_US/images/grant_wizard_step3.png   |  Bin 54810 -> 81523 bytes
docs/en_US/release_notes_6_0.rst   |2 +
web/package.json   |2 +
.../servers/static/js/privilege.ui.js  |6 +-
web/pgadmin/browser/static/css/wizard.css  |   15 +
web/pgadmin/browser/static/js/PgTable.jsx  |  285 +
web/pgadmin/browser/static/js/WizardStep.jsx   |   44 +
web/pgadmin/browser/static/js/WizardView.jsx   |  196 
web/pgadmin/browser/static/js/table.jsx|0
.../tools/grant_wizard/static/js/grantWizard.jsx   |  383 +++
.../tools/grant_wizard/static/js/grant_wizard.js   | 1140 +---
.../grant_wizard/static/js/privilege_schema.ui.js  |   34 +
.../grant_wizard/static/scss/_grant_wizard.scss|   14 +
.../javascript/grant_wizard/wizard_spec.js |   58 +
.../schema_ui_files/grant_wizard.ui.spec.js|   64 ++
web/yarn.lock  |   22 +-
19 files changed, 1176 insertions(+), 1099 deletions(-)

Re: [pgAdmin][patch]: Password field issue.

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 20, 2021 at 11:37 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the patch to resolve the issue password field showing plain
> text.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

[Rahul Shirsat]

Hi Akshay,

Please find the updated patch.

On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi 
wrote:

> Hi Rahul
>
> Patch not applied, rebase and send the patch again.
>
> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the below issue:
>>
>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>> dialogue.
>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
index 16d13816b..d989ce6e2 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
@@ -54,6 +54,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
 }).catch((err)=>{
   reject(err);
 });
+  } else {
+resolve(data);
   }
 });
   },
@@ -80,6 +82,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
 }).catch((err)=>{
   reject(err);
 });
+  } else {
+resolve(data);
   }
 });
   },
@@ -107,6 +111,8 @@ function getRangeSchema(nodeObj, treeNodeInfo, itemNodeData) {
 }).catch((err)=>{
   reject(err);
 });
+  } else {
+resolve(data);
   }
 });
   },
@@ -157,11 +163,10 @@ class EnumerationSchema extends BaseUISchema {
 return [
   {
 id: 'label', label: gettext('Label'),
-type: 'text',  cell: 'text',
-cellHeaderClasses: 'width_percent_99',
-readonly: function (state) {
-  return !obj.isNew(state);
-},
+type: 'text', cell: 'text', minWidth: 640,
+editable: (state) => {
+  return _.isUndefined(obj.isNew) ? true : obj.isNew(state);
+}
   }
 ];
   }
@@ -1313,6 +1318,24 @@ export default class TypeSchema extends BaseUISchema {
 this.nodeInfo = this.fieldOptions.node_info;
   }
 
+  isInvalidColumnAdded(state) {
+
+let tempCol = _.map(state.enum, 'label');
+let dontAddColumn = false;
+
+if(tempCol.length == 1 && tempCol[0] == undefined) {
+  dontAddColumn = true;
+} else {
+  tempCol.forEach(function(enumVal) {
+if(enumVal == undefined) {
+  dontAddColumn = true;
+  return;
+}
+  });
+}
+return dontAddColumn;
+  }
+
   schemaCheck(state) {
 if(this.fieldOptions.node_info && 'schema' in this.fieldOptions.node_info)
 {
@@ -1420,14 +1443,17 @@ export default class TypeSchema extends BaseUISchema {
 {
   id: 'enum', label: gettext('Enumeration type'),
   schema: new EnumerationSchema(),
-  editable: true,
   type: 'collection',
   group: gettext('Definition'), mode: ['edit', 'create'],
-  canAdd: true,  canEdit: false,
-  canDelete: function(state) {
+  canAddRow: function(state) {
+return !obj.isInvalidColumnAdded(state);
+  },
+  canEdit: false,
+  canDeleteRow: function(state) {
 // We will disable it if it's in 'edit' mode
-return !obj.isNew(state);
+return obj.isNew(state);
   },
+  canEditRow: false,
   disabled: () => obj.inCatalog(),
   deps: ['typtype'],
   uniqueCol : ['label'],

pgAdmin 4 commit: Fixed following issues for Type dialog:

[Akshay Joshi]

Fixed following issues for Type dialog:
1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue.
2. Range Type - Loading icons are shown in different drop-down tabs.

Fixes #6744

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c142296f3ff69a466eb22a8849c3a6308a38a326
Author: Rahul Shirsat 

Modified Files
--
.../databases/schemas/types/static/js/type.ui.js   | 44 +-
1 file changed, 35 insertions(+), 9 deletions(-)

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Rahul
>>
>> Patch not applied, rebase and send the patch again.
>>
>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which resolves the below issue:
>>>
>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>>> dialogue.
>>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

[Nikhil Mohite]

Hi Akshay,

Please find the patch for RM-5741.
Updated missing sql checks for following nodes:
1. Role
2. Resources Group
3. Schema
4. Language
5. Tablespace


Regards,
Nikhil Mohite

On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi 
wrote:

> Thanks, the patch applied to the React_Porting branch as it is a big
> change.
> With the testing of each node after porting this patch also gets tested.
>
> On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-5741
>> : [Schema Diff] Revisit all
>> the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and
>> 'CREATE OR REPLACE'
>>
>> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to 13.3.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM-5741_updated_sql.patch
Description: Binary data

pgAdmin 4 commit: Added PG/EPAS 14 binary path entry in the preferences

[Akshay Joshi]

Added PG/EPAS 14 binary path entry in the preferences dialog.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=522a92586aefce69e043cfab1fa4004fe25c0516

Modified Files
--
web/config.py  | 4 +++-
web/pgadmin/utils/constants.py | 6 ++
2 files changed, 9 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

[Akshay Joshi]

Hi Nikhil

As per the discussion, we need to create a flag for whether to add the 'IF
EXISTS" clause or not. Please send the combined patch after fixing that for
all the nodes.

On Mon, Sep 20, 2021 at 3:58 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the patch for RM-5741.
> Updated missing sql checks for following nodes:
> 1. Role
> 2. Resources Group
> 3. Schema
> 4. Language
> 5. Tablespace
>
>
> Regards,
> Nikhil Mohite
>
> On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied to the React_Porting branch as it is a big
>> change.
>> With the testing of each node after porting this patch also gets tested.
>>
>> On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for RM-5741
>>> : [Schema Diff] Revisit all
>>> the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and
>>> 'CREATE OR REPLACE'
>>>
>>> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to 13.3.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed RESQL test cases for Partition table using COLL

[Akshay Joshi]

Fixed RESQL test cases for Partition table using COLLATE.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56a17f7c8eacf56a52bdd4c0b8aa4fdb011cd524

Modified Files
--
.../tests/pg/10_plus/create_partition_table_with_collate.sql   | 6 +-
.../tests/pg/10_plus/create_partition_table_with_collate_msql.sql  | 5 -
.../tests/pg/11_plus/create_partition_table_with_collate.sql   | 6 +-
.../tests/pg/11_plus/create_partition_table_with_collate_msql.sql  | 7 +--
.../servers/databases/schemas/tables/tests/pg/12_plus/test.json| 2 +-
.../tests/ppas/10_plus/create_partition_table_with_collate.sql | 6 +-
.../ppas/10_plus/create_partition_table_with_collate_msql.sql  | 5 -
.../tests/ppas/11_plus/create_partition_table_with_collate.sql | 6 +-
.../ppas/11_plus/create_partition_table_with_collate_msql.sql  | 5 -
9 files changed, 38 insertions(+), 10 deletions(-)

[pgAdmin][patch] ERD table dialog failing to open

[Aditya Toshniwal]

Hi Hackers,

As the primary key backbone model is removed after porting, ERD table
dialog is failing to open.
Attached patch will restore the removed model until ERD dialogs are ported
to React based view.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"