Re: [pgAdmin][RM6581] [React] Port Language node to react

2021-07-09 Thread Akshay Joshi
Hi Pradip

Following are the review comments:

   - The language name is not visible for the existing language in the
   properties panel as well as dialog.
   - The "Trusted?" switch is showing the wrong value for the 'plpgsql'
   language in the properties panel as well as dialog.
   - Unable to provide custom language names as we did before this patch.
   - All the controls on the "Definition" tab are always disabled, also
   values are not getting populated for existing language.
   - Improve the code coverage to 80%, currently, it is 72.13%


On Thu, Jul 8, 2021 at 7:22 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for #6581: [React] Port Language node to
> react
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources

2021-07-09 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #6594 - Unable to login with
OAuth2 when LDAP & OAuth2 configured as login sources.

Thanks,
Khushboo


RM_6594.patch
Description: Binary data


[pgAdmin4][Patch] - RM #6595 - Unable to add server in Kerberos Authentication Mode with Master Password enabled

2021-07-09 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM#6595 - Unable to add server in
Kerberos Authentication Mode with Master Password enabled.


Thanks,
Khushboo


RM_6596.patch
Description: Binary data


[pgAdmin][RM6587] [React] Port FTS Template, FTS Parsers nodes to react

2021-07-09 Thread Rahul Shirsat
Hi Hackers,

Please find the below patch which ports fts_template, fts_parsers nodes to
react.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6587.patch
Description: Binary data


pgAdmin 4 commit: Fixed an issue where the user unable to login with OA

2021-07-09 Thread Akshay Joshi
Fixed an issue where the user unable to login with OAuth2 when LDAP & OAuth2 
configured as login sources. Fixes #6594

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3590c9172c679319932aa26ea755ba19c76656fe
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/authenticate/__init__.py | 11 ---
web/pgadmin/authenticate/oauth2.py   |  6 --
2 files changed, 12 insertions(+), 5 deletions(-)



pgAdmin 4 commit: Fixed an issue where the user unable to add server in

2021-07-09 Thread Akshay Joshi
Fixed an issue where the user unable to add server in Kerberos Authentication 
Mode with Master Password. Fixes #6595

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e981868246d04053a8f161e12e1fc75d72b290a3
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/browser/__init__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



pgAdmin 4 commit: Update message catalog.

2021-07-09 Thread Akshay Joshi
Update message catalog.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b154be24eca47da1dea0c1a5940b5511fbb3faa5

Modified Files
--
web/pgadmin/messages.pot   | 1357 
.../translations/cs/LC_MESSAGES/messages.mo|  Bin 223621 -> 207302 bytes
.../translations/cs/LC_MESSAGES/messages.po| 2575 ---
.../translations/de/LC_MESSAGES/messages.mo|  Bin 82560 -> 82464 bytes
.../translations/de/LC_MESSAGES/messages.po| 1412 
.../translations/es/LC_MESSAGES/messages.mo|  Bin 117741 -> 117648 bytes
.../translations/es/LC_MESSAGES/messages.po| 1413 
.../translations/fr/LC_MESSAGES/messages.mo|  Bin 234135 -> 217665 bytes
.../translations/fr/LC_MESSAGES/messages.po| 3484 +++-
.../translations/it/LC_MESSAGES/messages.mo|  Bin 229840 -> 213360 bytes
.../translations/it/LC_MESSAGES/messages.po| 3166 ++
.../translations/ja/LC_MESSAGES/messages.mo|  Bin 231849 -> 229653 bytes
.../translations/ja/LC_MESSAGES/messages.po| 1428 
.../translations/ko/LC_MESSAGES/messages.mo|  Bin 106006 -> 105846 bytes
.../translations/ko/LC_MESSAGES/messages.po| 1415 
.../translations/pl/LC_MESSAGES/messages.mo|  Bin 105450 -> 105303 bytes
.../translations/pl/LC_MESSAGES/messages.po| 1415 
.../translations/ru/LC_MESSAGES/messages.mo|  Bin 136823 -> 136674 bytes
.../translations/ru/LC_MESSAGES/messages.po| 1415 
.../translations/zh/LC_MESSAGES/messages.mo|  Bin 165288 -> 165048 bytes
.../translations/zh/LC_MESSAGES/messages.po| 1419 
21 files changed, 11520 insertions(+), 8979 deletions(-)



Re: [pgAdmin4][Patch] - RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources

2021-07-09 Thread Akshay Joshi
Thanks, the patch applied.

On Fri, Jul 9, 2021 at 5:49 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #6594 - Unable to login with
> OAuth2 when LDAP & OAuth2 configured as login sources.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - RM #6595 - Unable to add server in Kerberos Authentication Mode with Master Password enabled

2021-07-09 Thread Akshay Joshi
Thanks, the patch applied.

On Fri, Jul 9, 2021 at 5:52 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM#6595 - Unable to add server
> in Kerberos Authentication Mode with Master Password enabled.
>
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Translators: Release next week

2021-07-09 Thread Akshay Joshi
Hi Translators,

We will have a release next week, so updates to translations before release
would be helpful. The template and catalogs have been updated in git.

*Note:* We will generally create the candidate build on Monday, so please
send the translation file by Monday 5.00 PM IST would be good.

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*