pgAdmin 4 commit: Clarify when container config envvars may be ignored.

[Dave Page]

Clarify when container config envvars may be ignored.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6429a5b31a42e9228ce864b5736627ce1a6fc243

Modified Files
--
docs/en_US/container_deployment.rst | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

[Aditya Toshniwal]

Hi Hackers,

I made some changes to the core code that will be helpful for other nodes.
Please review.


On Thu, Jun 24, 2021 at 5:39 PM Akshay Joshi 
wrote:

> Thanks, the patch applied in the "React_Porting" branch.
>
> On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Thu, Jun 17, 2021 at 7:26 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached patch marks the beginning of migrating properties dialog/tab
 to React based code, which is easy to maintain, performant and testable
 using automation.
 Patch includes:
 - Framework for creating React based dynamic form view out of a
 pre-defined UI schema. Previously, it was based on Backform/Backbone.
 - The new framework and components will use MaterialUI as base.
 Previously, Bootstrap/Backform/jQuery components were used.
 - The new code uses JSS instead of CSS since material ui and most
 modern React libraries also use JSS. In future, this will allow us to
 change the theme in real-time without refresh.
 - 90% code covered by 80-85 new jasmine test cases.
 - Server group node UI Schema migration to new, with schema test cases.
 - Server node UI Schema migration to new, with schema test cases.
 - Database node UI Schema migration to new, with schema test cases.
 - Few other UI changes.

>>>
>>> Nice!
>>>
>>>

 PS: Until all the nodes are migrated, this will not go in the main
 branch.

>>>
>>> Yeah, how are we going to manage this? I agree with building it out in a
>>> branch until we have full coverage of the dialogues, but I'm concerned that
>>> it'll become a merge nightmare. Though, I guess we aren't touching the
>>> dialogues much for other things right now, so maybe not.
>>>
>> We'll right now work only on the dialogs. So merging should be manageable.
>> BTW, the patch can be merged in the main branch as well. It is backward
>> compatible, and it will work fine. Only the UI components would look
>> slightly different from the non-migrated dialogs.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: https://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6130.part2.patch
Description: Binary data

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

[Aditya Toshniwal]

Hi Hackers,

Please ignore the previous patch. Attached is the revised patch.

On Mon, Jun 28, 2021 at 2:50 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> I made some changes to the core code that will be helpful for other nodes.
> Please review.
>
>
> On Thu, Jun 24, 2021 at 5:39 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied in the "React_Porting" branch.
>>
>> On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Jun 17, 2021 at 7:26 PM Dave Page  wrote:
>>>
 Hi

 On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch marks the beginning of migrating properties dialog/tab
> to React based code, which is easy to maintain, performant and testable
> using automation.
> Patch includes:
> - Framework for creating React based dynamic form view out of a
> pre-defined UI schema. Previously, it was based on Backform/Backbone.
> - The new framework and components will use MaterialUI as base.
> Previously, Bootstrap/Backform/jQuery components were used.
> - The new code uses JSS instead of CSS since material ui and most
> modern React libraries also use JSS. In future, this will allow us to
> change the theme in real-time without refresh.
> - 90% code covered by 80-85 new jasmine test cases.
> - Server group node UI Schema migration to new, with schema test cases.
> - Server node UI Schema migration to new, with schema test cases.
> - Database node UI Schema migration to new, with schema test cases.
> - Few other UI changes.
>

 Nice!


>
> PS: Until all the nodes are migrated, this will not go in the main
> branch.
>

 Yeah, how are we going to manage this? I agree with building it out in
 a branch until we have full coverage of the dialogues, but I'm concerned
 that it'll become a merge nightmare. Though, I guess we aren't touching the
 dialogues much for other things right now, so maybe not.

>>> We'll right now work only on the dialogs. So merging should be
>>> manageable.
>>> BTW, the patch can be merged in the main branch as well. It is backward
>>> compatible, and it will work fine. Only the UI components would look
>>> slightly different from the non-migrated dialogs.
>>>

 --
 Dave Page
 Blog: https://pgsnake.blogspot.com
 Twitter: @pgsnake

 EDB: https://www.enterprisedb.com


>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6130.part2revised.patch
Description: Binary data

[pgAdmin][RM-6536]: Browse button: Directory issues

[Nikhil Mohite]

Hi Hackers,

Please find the attached patch for RM-6536
:  Browse button: Directory
issues.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6536.patch
Description: Binary data

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Jun 28, 2021 at 2:00 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Akshay,
>
> On Thu, Jun 24, 2021 at 2:32 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Rahul
>>
>> Following are the review comments:
>>
>>- The context menu should be renamed to 'Reassign/Drop Owned...'
>>instead of 'Reassign/Drop role'.
>>
>>  Done
>
>>
>>- Remove " role" from the dialog header. It should be "Reassign/Drop
>>Owned - "
>>
>>  Done
>
>>
>>- We have only two operations "Reassign and Drop", so instead of
>>using Radio modern can we use switch control? Though radio modern also
>>looks good.
>>
>> @Dave what do you think?
>>
>>  Keeping the radio modern as discussed.
>
>>
>>- By default, Reassign operation should be selected.
>>
>>  Done
>
>>
>>- After successfully reassign/drop we should show aleritfy notifier
>>"Reassign owned successfully" or "Drop owned successfully".
>>
>>  Done
>
>>
>>-
>>- "Roles dropped successfully!" string should be modified to "Drop
>>owned successfully!".
>>
>>  Done
>
>>
>>- Add validation if the database or reassign object is not selected,
>>show them on GUI.
>>
>>  Done
>
>>
>>- Connection to the database should be released(disconnected) after
>>the execution of the query.
>>
>>  This has been taken care of.
>
>>
>>- From Postgres 9.5 onwards we have "*CURRENT_USER | SESSION_USER*"
>>please check that as well. From Postgres 14 *CURRENT_ROLE* is also
>>there.
>>
>>  All of the above 3 options added. CURRENT_ROLE will be visible on UI
> when connected to postgres >= v14. Also added test cases for the same.
>
>>
>>- DROP OWNED query have *[ CASCADE | RESTRICT ] *which was not there
>>even in pgadmin III, add support this would be good. Create two switch
>>control for cascade and restrict and depending on that create the SQL 
>> query.
>>
>>  These options too are added now as a switch case.
>
>>
>>- Documentation and screenshot update required after the above
>>changes. The "Reassign/Drop Own" string should be replaced with
>>"Reassign/Drop Owned" in the documentation.
>>
>>  Updated the documentations as well.
>
>  *Sorry for previously adding this option* - I have removed the SQL tab
> as REASSIGN/DROP OWNED are single line and not necessarily required to be
> viewed by the user (referring to Delete Object or Drop Cascade options of
> other pg_catalog objects).
>
>>
>> On Mon, Jun 21, 2021 at 4:37 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch which includes the reassign/drop own feature.
>>>
>>> This also includes documentation of the feature.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-6536]: Browse button: Directory issues

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Jun 28, 2021 at 6:30 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6536
> :  Browse button: Directory
> issues.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed directory selection issue with the folder dialo

[Akshay Joshi]

Fixed directory selection issue with the folder dialog. Fixes #6536

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c6d00d54576b9475cf502c402dfda8db5f04b12
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_5_5.rst   |  1 +
web/pgadmin/misc/file_manager/static/js/utility.js | 14 ++
2 files changed, 15 insertions(+)

pgAdmin 4 commit: Added support for Reassign/Drop Owned for login roles

[Akshay Joshi]

Added support for Reassign/Drop Owned for login roles. Fixes #3893

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fe52b9cfec6d283724dfc5877caaf1da729daf9
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/images/role_drop_dialog.png | Bin 0 -> 57831 bytes
docs/en_US/images/role_reassign_dialog.png | Bin 0 -> 60164 bytes
docs/en_US/managing_cluster_objects.rst|   3 +-
docs/en_US/release_notes_5_5.rst   |   1 +
docs/en_US/role_reassign_dialog.rst|  39 ++
.../server_groups/servers/roles/__init__.py| 127 +-
.../server_groups/servers/roles/static/js/role.js  | 432 -
.../templates/roles/sql/9.4_plus/reassign_own.sql  |  13 +
.../servers/roles/tests/role_test_data.json| 127 ++
.../servers/roles/tests/test_role_reassign_own.py  |  99 +
.../server_groups/servers/roles/tests/utils.py |   7 +-
11 files changed, 841 insertions(+), 7 deletions(-)

pgAdmin 4 commit: Fix typo in filename.

[Dave Page]

Fix typo in filename.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9786215978c07298a0d595e5837c4dd2907ae41

Modified Files
--
web/pgadmin/misc/static/explain/js/explain.js  | 2 +-
web/pgadmin/misc/static/explain/js/{image_maper.js => image_mapper.js} | 0
2 files changed, 1 insertion(+), 1 deletion(-)

[patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch for fixation of jenkins failure.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


jenkins_failure_fix.patch
Description: Binary data

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

[Dave Page]

Hi

On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for fixation of jenkins failure.
>

That won't work - you can't include variables (or string building
operations) in the first argument to gettext calls, as there won't be any
way to extract a complete message into the catalogs. The way it's being
done at the moment is correct (I don't know why it's failing, but it's the
correct way to structure the gettext calls).

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

[Rahul Shirsat]

I feel gettext sometimes won't escape the characters as it should be.

I now tried to escape those using some utils.

Please find the updated patch.

On Mon, Jun 28, 2021 at 9:33 PM Dave Page  wrote:

> Hi
>
> On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for fixation of jenkins failure.
>>
>
> That won't work - you can't include variables (or string building
> operations) in the first argument to gettext calls, as there won't be any
> way to extract a complete message into the catalogs. The way it's being
> done at the moment is correct (I don't know why it's failing, but it's the
> correct way to structure the gettext calls).
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


jenkins_failure_fix_v2.patch
Description: Binary data