pgAdmin 4 commit: Disable the PSQL tool for Windows, the 'fcntl' module

2021-06-01 Thread Akshay Joshi
Disable the PSQL tool for Windows, the 'fcntl' module is not working on Windows.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0eac875b619fd41a2ec83f7994a5bac337b521a
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/browser/__init__.py|  3 +-
.../browser/register_browser_preferences.py| 91 ++
web/pgadmin/browser/static/js/collection.js| 14 ++--
web/pgadmin/browser/static/js/node.js  |  2 +-
web/pgadmin/browser/static/js/toolbar.js   |  4 +-
web/pgadmin/browser/templates/browser/js/utils.js  |  2 +
web/pgadmin/tools/psql/__init__.py | 79 +++
web/pgadmin/tools/psql/static/js/psql_module.js|  2 +-
.../tools/psql/templates/editor_template.html  | 58 +++---
web/pgadmin/tools/psql/tests/test_backend_task.py  |  3 +
web/pgadmin/tools/psql/tests/test_panel.py |  3 +
web/pgadmin/tools/psql/tests/test_psql_disabled.py |  3 +
web/pgadmin/tools/psql/tests/test_psql_input.py|  3 +
.../tools/psql/tests/test_resize_terminal.py   |  3 +
.../tools/psql/tests/test_socket_connect.py|  3 +
.../tools/psql/tests/test_socket_disconnect.py |  3 +
web/pgadmin/tools/psql/tests/test_start_process.py |  3 +
.../tools/psql/tests/test_start_process_fail.py|  3 +
18 files changed, 178 insertions(+), 104 deletions(-)



pgAdmin 4 commit: Added OS, Browser, Configuration detailsĀ in the About

2021-06-01 Thread Akshay Joshi
Added OS, Browser, Configuration detailsĀ in the About dialog. Fixes #6231

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c5192563803001b60d3ca89b04e11441bcd1503
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_5_4.rst |  1 +
requirements.txt |  2 +
runtime/package.json |  1 +
web/pgadmin/about/__init__.py| 64 +---
web/pgadmin/about/static/js/about.js | 17 +---
web/pgadmin/about/templates/about/index.html | 40 +++--
6 files changed, 100 insertions(+), 25 deletions(-)



Re: [Patch] RM6478 Duplicates on SQL tab for table with more than one partition

2021-06-01 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, May 31, 2021 at 12:14 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the patch which resolves the mentioned issue of duplicate on
> sql tab for table.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-06-01 Thread Akshay Joshi
Thanks, the patch applied.

On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Akshay,
>
> On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Rahul
>>
>> Following are the review comments:
>>
>>- Why you have changed the order of the toolbar button on the browser
>>tree? It should not.
>>
>>Changes were related to the wcDocker issue showing reverse
> order buttons, so had to change in the pgAdmin app to reflect it correctly.
>
>>
>>- *sqleditor.js (check_db_name_change function)*
>>- var declaration should be comma-separated instead of writing var,
>>   again and again.
>>
>>   Done.
>
>>
>>- Add proper comments.
>>
>>   This too is taken care of.
>
>>
>>- Remove dots from the string "Database moved/renamed.."
>>
>>   Done.
>
>>
>>- "Please note that the database you are working on has been moved or
>>   renamed to ${data.actual_db_name}. Refresh databases in browser panel 
>> or
>>   click OK to continue.." should be changed to "Current database has been
>>   moved or renamed to ${data.actual_db_name}. Click on the OK button to
>>   refresh the database name."
>>
>>   Done.
>Also have done some code refactoring.
>
>>
>>
>> On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which resolves the issue of renaming the
>>> database by another user.
>>>
>>> A minor issue of navigation button alignment is also fixed in this patch.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*