[pgAdmin]:SonarQube Fixes

[Pradip Parkale]

Hi Hackers,

Please find attached the patch for some SonarQube fixes.

-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


SonarQube.patch
Description: Binary data

Re: Feature #6395 - Basic Log Rotation

[Dave Page]

Hi

On Mon, Apr 19, 2021 at 5:17 PM Thomas Greenwood 
wrote:

> Hi,
>
> I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.
>
> Please find the attached basic patch as a starter for 10. It's the same
> patch attached to the feature issue.
>

Nice! My only suggestions would be that the config options be added to
config.py, with default values of zero for log size, and say, 5 for the
number of backups (should that be 'archives'?), and that we test to see if
the log size is > 0 before enabling rotation. The reason for that is that
we keep all config options in config.py to ensure it's self-documenting.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

Re: Feature #6395 - Basic Log Rotation

[COG Internet]

Hi,

I have a version 2 of this with a fixed conditional and initial config 
values which I'll send through later today.


Thanks,

Tom

On 19 April 2021 17:17:30 Thomas Greenwood  wrote:

Hi,
I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.
Please find the attached basic patch as a starter for 10. It's the same 
patch attached to the feature issue.

Thanks a lot,
Tom