[pgAdmin][patch] Linter for JSX files

2021-04-08 Thread Aditya Toshniwal 
Hi Hackers,

Attached patch contains the required changes for including JSX files in
linter checks.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


linter_jsx.patch
Description: Binary data

Re: [pgAdmin][Patch] RM 6082 - Able to change connection when a long query is running

2021-04-08 Thread Yogesh Mahajan 
Hi,

Please discard the previous patch.
Here is the latest patch. This also fixes the issue of disappearing the
connection bar from the query tool on the resize pgAdmin window.


Thanks,
Yogesh Mahajan
EnterpriseDB


On Wed, Apr 7, 2021 at 1:40 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hello,
>
> Sorry for the inconvenience.
> Please update the patch.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Tue, Apr 6, 2021 at 4:07 PM Akshay Joshi 
> wrote:
>
>> Hi Yogesh
>>
>> The issue is not fixed yet. I am able to change the connection while the
>> transaction is in progress. Please check and resend the patch.
>>
>> On Tue, Apr 6, 2021 at 1:43 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hello,
>>>
>>> Please find a patch which diables change of connection from query tool
>>> while query tool transaction is in progress.
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>


RM6082_v3.patch
Description: Binary data

[pgAdmin4][Patch] - RM 6274 - LDAP auth module is not translatable

2021-04-08 Thread Khushboo Vashi 
Hi,

Please find the attached patch to fix RM #6274 - LDAP auth module is not
translatable.

Thanks,
Khushboo


RM_6274.patch
Description: Binary data

pgAdmin 4 commit: Ensure that the strings in the LDAP auth module are t

2021-04-08 Thread Akshay Joshi 
Ensure that the strings in the LDAP auth module are translatable. Fixes #6274

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=437f0df0f39391d43f1ced325c3bb18126ac2762
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_5_2.rst |  1 +
web/pgadmin/authenticate/__init__.py |  5 ++---
web/pgadmin/authenticate/ldap.py | 32 ++--
3 files changed, 21 insertions(+), 17 deletions(-)

pgAdmin 4 commit: Ensure that the user should not be to change the conn

2021-04-08 Thread Akshay Joshi 
Ensure that the user should not be to change the connection when a long query 
is running. Fixes #6082

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14dcb70b95585eaa351bd65bb024e141496e9774
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_5_2.rst|  1 +
web/pgadmin/static/js/sqleditor/execute_query.js|  9 +
web/pgadmin/static/js/sqleditor_utils.js| 11 +++
web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss |  2 --
4 files changed, 21 insertions(+), 2 deletions(-)

Re: [pgAdmin4][Patch] - RM 6274 - LDAP auth module is not translatable

2021-04-08 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Apr 8, 2021 at 5:07 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #6274 - LDAP auth module is not
> translatable.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Included JSX files in the linter check.

2021-04-08 Thread Akshay Joshi 
Included JSX files in the linter check.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c88a63edf8ff937795d85b28914636076e54a468
Author: Aditya Toshniwal 

Modified Files
--
web/.eslintrc.js   |   1 +
web/package.json   |   2 +-
web/pgadmin/dashboard/static/js/Graphs.jsx |  69 
web/pgadmin/static/js/chartjs/index.jsx|   2 +
.../erd/static/js/erd_tool/links/OneToManyLink.jsx |  14 +-
.../erd/static/js/erd_tool/nodes/TableNode.jsx |  13 +-
.../js/erd_tool/ui_components/BodyWidget.jsx   | 185 +++--
.../static/js/erd_tool/ui_components/ToolBar.jsx   |  12 +-
8 files changed, 167 insertions(+), 131 deletions(-)

Re: [pgAdmin][Patch] RM 6082 - Able to change connection when a long query is running

2021-04-08 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Apr 8, 2021 at 4:15 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please discard the previous patch.
> Here is the latest patch. This also fixes the issue of disappearing the
> connection bar from the query tool on the resize pgAdmin window.
>
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Apr 7, 2021 at 1:40 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hello,
>>
>> Sorry for the inconvenience.
>> Please update the patch.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Tue, Apr 6, 2021 at 4:07 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Yogesh
>>>
>>> The issue is not fixed yet. I am able to change the connection while the
>>> transaction is in progress. Please check and resend the patch.
>>>
>>> On Tue, Apr 6, 2021 at 1:43 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
 Hello,

 Please find a patch which diables change of connection from query tool
 while query tool transaction is in progress.


 Thanks,
 Yogesh Mahajan
 EnterpriseDB

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][patch] Linter for JSX files

2021-04-08 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Apr 8, 2021 at 4:06 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch contains the required changes for including JSX files in
> linter checks.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue where a connection warning should be d

2021-04-08 Thread Akshay Joshi 
Fixed an issue where a connection warning should be displayed when the user
clicks on explain or explain analyze and the database server is disconnected
from the browser tree. Fixes #6376

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f4affcb1e74fea21707c28fbd98c3bb19bd781b

Modified Files
--
docs/en_US/release_notes_5_2.rst| 1 +
web/pgadmin/tools/sqleditor/utils/apply_explain_plan_wrapper.py | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)

[pgAdmin][patch] [Macro support] RM5908 Shortcut keys should be working with Manage macro & RM6161 Macro SQL input box cursor issue.

2021-04-08 Thread Rahul Shirsat 
Hi Hackers,

Please find below patch which resolves the issues :

RM5908  Shortcut keys should be
working with Manage macro.
RM6161  Macro SQL input box
cursor issue.

The issue was not only for macro support modal, but also for other models
related to sqleditor (description in RM6161
) which is resolved in this fix.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM5908_RM6161.patch
Description: Binary data