[pgAdmin4][Patch]: RM 6317 - Toggle buttons are inaccessible
Hi, Please find the attached patch to fix the RM #6317: Toggle buttons are inaccessible. Our toggle buttons are not the HTML buttons but the combinations of HTML tags which function as a toggle button. As the toggle button itself doesn't have a label/title as it wrapped around a div, we have provided the extra hidden label above the toggle button div, so on receiving the focus, toggle button will read the label we provided(For example: "Can login?, Yes, Toggle. Button''), which was working as expected with Chrome Screen Reader extension, on which we have tested. Unfortunately, most screen readers like VoiceOver, NVDA etc.. read the label and the button as different tags, so when the label gets the focus, the screen reader reads it as "Can login? Yes, Toggle Button", and when we try to click it, we can't, as it is just a label. To fix this issue, I have put the label inside the toggle div, so the label will belong to the toggle button div itself and with the new version of Bootstrap-toggle, the role="button" is already there, so no need to add it. I have tested this patch on Mac with VoiceOver (on which I could reproduce the issue) and it is working fine. After committing this patch, we need to provide the nightly build link to the author of this RM, so he can test with a Braille display. Thanks, Khushboo RM_6317.patch Description: Binary data
SonarQube Fixes #5 Roles & Functions
Hi Hackers, Please find the patch which resolves below sonar qube issues: For Roles: Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed For Functions: Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_roles_functions.patch Description: Binary data
pgAdmin 4 commit: Fixed an issue where the top menu disappears when ent
Fixed an issue where the top menu disappears when entering into the full screen for minimum screen resolution. Fixes #6322 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4bb71c56adc41887050395a351757fbc4b245adc Modified Files -- docs/en_US/release_notes_5_1.rst | 1 + runtime/src/js/misc.js | 36 +++- runtime/src/js/pgadmin.js| 4 ++-- web/pgadmin/browser/static/js/runtime.js | 8 --- 4 files changed, 38 insertions(+), 11 deletions(-)
pgAdmin 4 commit: Ensure the Python interpreter used by the runtime ign
Ensure the Python interpreter used by the runtime ignores user site-packages. Fixes #6269 Significant debugging by Peter Buckner. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ded65340fefff3cfda7f55e86cc5fe6bd2348e0e Modified Files -- docs/en_US/release_notes_5_1.rst | 1 + runtime/src/js/pgadmin.js| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)
