pgAdmin 4 commit: Ensure that cell content being autoselected when edit

2021-03-04 Thread Akshay Joshi
Ensure that cell content being autoselected when editing the cell data. Fixes 
#5810

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=778e0cd4021f08a1c6fc38e9cb4f24f8d2a9545a
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_5_1.rst   | 1 +
web/pgadmin/static/js/slickgrid/editors.js | 1 +
2 files changed, 2 insertions(+)



pgAdmin 4 commit: Fixed an issue where hanging symlinks in a directory

2021-03-04 Thread Akshay Joshi
Fixed an issue where hanging symlinks in a directory cause select file dialog 
to break. Fixes #5119

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8be3517c6dfed8a748fea83888b871430fd70bdd
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_5_1.rst  |  1 +
web/pgadmin/misc/file_manager/__init__.py | 12 +++-
2 files changed, 8 insertions(+), 5 deletions(-)



pgAdmin 4 commit: Fixed an issue where the user is not able to change t

2021-03-04 Thread Akshay Joshi
Fixed an issue where the user is not able to change the connection in Query 
Tool when any SQL file is opened. Fixes #6272

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9317fe21b222e520db5322d34dffb85828cd9e88
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_5_1.rst | 1 +
web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js | 3 ---
2 files changed, 1 insertion(+), 3 deletions(-)



Re: [pgAdmin][RM-5119]: Hanging symlinks in a directory cause select file dialog to break.

2021-03-04 Thread Akshay Joshi
Thanks, patch applied.

On Wed, Mar 3, 2021 at 2:07 PM Nikhil Mohite 
wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-5119
> : Hanging symlinks in a
> directory cause select file dialog to break.
> The issue was due to a broken symlink exception was occurring while
> reading the file-related data.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-5810]: In-table editing on certain cell values does not result in cell content being autoselected.

2021-03-04 Thread Akshay Joshi
Thanks, patch applied.

On Thu, Mar 4, 2021 at 10:29 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-5810
> : In-table editing on certain
> cell values does not result in cell content being autoselected.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-6272]: Cannot Change Connection in Query Tool

2021-03-04 Thread Akshay Joshi
Thanks, patch applied.

On Wed, Mar 3, 2021 at 5:40 PM Nikhil Mohite 
wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6272:
> Cannot Change Connection in
> Query Tool.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Making Kerberos optional in the Python wheel

2021-03-04 Thread Dave Page
There have been a couple of complaints that the latest Python wheel
distribution doesn't install cleanly. This happens when there is no
pre-built gssapi wheel on PyPi that matches the users combination of Python
version and platform, *and* the MIT Kerberos development headers etc. are
not present on the system, so the source wheel cannot be compiled.

This seems like it's a bit onerous on users, especially if they're on
Windows where they'll also need a suitable compiler to be installed. The
attached patch aims to address that by making the Kerberos support optional
(thankfully, Khushboo made the code handle lack of gssapi libraries).

To install without gssapi, users would simply do:

pip install pgadmin4

or

pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl

To install with gssapi:

pip install pgadmin4['kerberos']

or

pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos']

The patch also cleans up some old cruft that was required for now
unsupported Python versions.

Thoughts?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com


optional_kerberos.diff
Description: Binary data


[pgAdmin][RM-6286]: Template database is not displayed in Databases node.

2021-03-04 Thread Nikhil Mohite
Hi Hackers,

Please find the attached patch for RM-6286
: The template database is not
displayed in the Databases node.
I have also tested issue RM-5875
 (Which is related to this
issue) after new changes and it is working fine.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6286.patch
Description: Binary data


Re: Making Kerberos optional in the Python wheel

2021-03-04 Thread Shaheed Haque
A big thumbs up from me at least :-).

On Thursday, 4 March 2021 10:02:00 GMT Dave Page wrote:
> There have been a couple of complaints that the latest Python wheel
> distribution doesn't install cleanly. This happens when there is no
> pre-built gssapi wheel on PyPi that matches the users combination of Python
> version and platform, *and* the MIT Kerberos development headers etc. are
> not present on the system, so the source wheel cannot be compiled.
> 
> This seems like it's a bit onerous on users, especially if they're on
> Windows where they'll also need a suitable compiler to be installed. The
> attached patch aims to address that by making the Kerberos support optional
> (thankfully, Khushboo made the code handle lack of gssapi libraries).
> 
> To install without gssapi, users would simply do:
> 
> pip install pgadmin4
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl
> 
> To install with gssapi:
> 
> pip install pgadmin4['kerberos']
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos']
> 
> The patch also cleans up some old cruft that was required for now
> unsupported Python versions.
> 
> Thoughts?








pgAdmin 4 commit: Ensure that the template database should be visible w

2021-03-04 Thread Akshay Joshi
Ensure that the template database should be visible while creating the 
database. Fixes #6286

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d70dea507200a39ec5ca0585b3cdb8edf5753955
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_5_1.rst| 1 +
web/pgadmin/browser/server_groups/servers/databases/__init__.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)



Re: [pgAdmin][RM-6286]: Template database is not displayed in Databases node.

2021-03-04 Thread Akshay Joshi
Thanks, patch applied.

On Thu, Mar 4, 2021 at 5:34 PM Nikhil Mohite 
wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6286
> : The template database is
> not displayed in the Databases node.
> I have also tested issue RM-5875
>  (Which is related to this
> issue) after new changes and it is working fine.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Ensure that the venv activation scripts have the corr

2021-03-04 Thread Dave Page
Ensure that the venv activation scripts have the correct path in them on Linux. 
Partially fixes #6278

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9a17952c0932a2c70c19f24d7ecec633fb90bfb

Modified Files
--
docs/en_US/release_notes_5_1.rst | 1 +
pkg/linux/build-functions.sh | 5 +
2 files changed, 6 insertions(+)



pgAdmin 4 commit: Fix changelog for "Ensure that the venv activation sc

2021-03-04 Thread Dave Page
Fix changelog for "Ensure that the venv activation scripts have the correct 
path in them on Linux. Partially fixes #6278" (not #6278 as was mistakenly put 
in the original commit).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67326da9c0435494da3b0839ff574962e18f2df7

Modified Files
--
docs/en_US/release_notes_5_1.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)