[pgAdmin]: Patch for SonarQube fixes.

[Nikhil Mohite]

Hi Team,

I have fixed a few sonarQube issues, PFA patch
Details as follows:

1. Back-form  (backform.pgadmin.js):

   - TypeError can be thrown as "$tabContent" might be null or undefined
   here.

2. User Management (user_management.js):

   - 'self' is already declared in the upper scope.
   - 'res' is already declared in the upper scope.
   - 'self' is already declared in the upper scope.
   - 'ownershipModel' is already declared in the upper scope.


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*

pgAdmin 4 commit: Clarify docs around configuration.

[Dave Page]

Clarify docs around configuration.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6cf3913c8ed998ab4d57cd2e8c3730ac249be7ea

Modified Files
--
docs/en_US/config_py.rst   | 22 +-
docs/en_US/master_password.rst |  7 ---
2 files changed, 21 insertions(+), 8 deletions(-)

Re: [pgAdmin]: Patch for SonarQube fixes.

[Akshay Joshi]

Hi Nikhil

You forgot to attach the patch :)

On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite 
wrote:

> Hi Team,
>
> I have fixed a few sonarQube issues, PFA patch
> Details as follows:
>
> 1. Back-form  (backform.pgadmin.js):
>
>- TypeError can be thrown as "$tabContent" might be null or undefined
>here.
>
> 2. User Management (user_management.js):
>
>- 'self' is already declared in the upper scope.
>- 'res' is already declared in the upper scope.
>- 'self' is already declared in the upper scope.
>- 'ownershipModel' is already declared in the upper scope.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin]: Patch for SonarQube fixes.

[Nikhil Mohite]

Hi Akshay,

Sorry for the inconvenience, Please find the attached patch.

Regards,
Nikhil Mohite.

On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi 
wrote:

> Hi Nikhil
>
> You forgot to attach the patch :)
>
> On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have fixed a few sonarQube issues, PFA patch
>> Details as follows:
>>
>> 1. Back-form  (backform.pgadmin.js):
>>
>>- TypeError can be thrown as "$tabContent" might be null or undefined
>>here.
>>
>> 2. User Management (user_management.js):
>>
>>- 'self' is already declared in the upper scope.
>>- 'res' is already declared in the upper scope.
>>- 'self' is already declared in the upper scope.
>>- 'ownershipModel' is already declared in the upper scope.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


SonarQubeCodeSmellFixes.patch
Description: Binary data

Re: Feature 6270: Allow for --load-servers to replace current server list

[Alessandro De Maria]

Hey Akshay,

Thank you for the suggestions, here are the patches.

Regards
Alessandro

On Fri, 26 Feb 2021 at 09:25, Akshay Joshi 
wrote:

> Hi Alessandro
>
> Patch looks good to me. Please fix the following issues:
>
>- Fix the PEP8 issue.
>- Documentation needs to be updated with this new flag. Please update
>"docs-> en_Us -> import_export_servers.rst" file.
>
>
> On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
> alessandro.dema...@gmail.com> wrote:
>
>> Hello,
>>
>> I have created a patch for the issue I raised earlier:
>>
>> https://redmine.postgresql.org/issues/6270
>>
>> I apologise I have never sent git patches before, and I could not find
>> any specific documentation of how you expect to receive contributions.
>>
>> Regards
>> Alessandro
>>
>> --
>> Alessandro De Maria
>> alessandro.dema...@gmail.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Alessandro De Maria
alessandro.dema...@gmail.com


0002-Address-comments-on-pep8-and-documentation.patch
Description: Binary data


0001-6270-add-replace-flag.patch
Description: Binary data

pgAdmin 4 commit: Added '--replace' option in Import server to replace

[Akshay Joshi]

Added '--replace' option in Import server to replace the list of servers with 
the newly imported one. Fixes #6270

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faa66f1636ef3a8e6e8f82c011126f11a08b7ad0
Author: Alessandro De Maria 

Modified Files
--
docs/en_US/import_export_servers.rst |  7 +
docs/en_US/release_notes_5_1.rst |  1 +
web/setup.py | 58 +---
3 files changed, 62 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Fixed SonarQube issues.

[Akshay Joshi]

Fixed SonarQube issues.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb5d7190c417adae5c784314bfeb4ff42ccf27f8
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js  |  2 +-
.../user_management/static/js/user_management.js   | 36 +++---
2 files changed, 19 insertions(+), 19 deletions(-)

Re: [pgAdmin]: Patch for SonarQube fixes.

[Akshay Joshi]

Thanks, patch applied.

On Mon, Mar 1, 2021 at 4:42 PM Nikhil Mohite 
wrote:

> Hi Akshay,
>
> Sorry for the inconvenience, Please find the attached patch.
>
> Regards,
> Nikhil Mohite.
>
> On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi 
> wrote:
>
>> Hi Nikhil
>>
>> You forgot to attach the patch :)
>>
>> On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> I have fixed a few sonarQube issues, PFA patch
>>> Details as follows:
>>>
>>> 1. Back-form  (backform.pgadmin.js):
>>>
>>>- TypeError can be thrown as "$tabContent" might be null or
>>>undefined here.
>>>
>>> 2. User Management (user_management.js):
>>>
>>>- 'self' is already declared in the upper scope.
>>>- 'res' is already declared in the upper scope.
>>>- 'self' is already declared in the upper scope.
>>>- 'ownershipModel' is already declared in the upper scope.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Feature 6270: Allow for --load-servers to replace current server list

[Akshay Joshi]

Thanks, patch applied.

On Mon, Mar 1, 2021 at 4:42 PM Alessandro De Maria <
alessandro.dema...@gmail.com> wrote:

> Hey Akshay,
>
> Thank you for the suggestions, here are the patches.
>
> Regards
> Alessandro
>
> On Fri, 26 Feb 2021 at 09:25, Akshay Joshi 
> wrote:
>
>> Hi Alessandro
>>
>> Patch looks good to me. Please fix the following issues:
>>
>>- Fix the PEP8 issue.
>>- Documentation needs to be updated with this new flag. Please update
>>"docs-> en_Us -> import_export_servers.rst" file.
>>
>>
>> On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
>> alessandro.dema...@gmail.com> wrote:
>>
>>> Hello,
>>>
>>> I have created a patch for the issue I raised earlier:
>>>
>>> https://redmine.postgresql.org/issues/6270
>>>
>>> I apologise I have never sent git patches before, and I could not find
>>> any specific documentation of how you expect to receive contributions.
>>>
>>> Regards
>>> Alessandro
>>>
>>> --
>>> Alessandro De Maria
>>> alessandro.dema...@gmail.com
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Alessandro De Maria
> alessandro.dema...@gmail.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 - desktop version - RPM

[gmail Vladimir Koković]

After many years of using "pgAdmin III", I tried several times to run 
the "pgAdmin 4" desktop version, but always without success!


So it is on this day in an attempt to run 
pgadmin4-desktop-5.0-1.fc33.x86_64.rpm (snapshots/2021-03-01).
After extracting the files from the RPM to the /tmp/vk/rpm/desktop 
folder based on
the /tmp/vk/rpm/desktop/usr/share/applications/pgadmin4.desktop content 
and running pgadmin4:


/tmp/vk/rpm/desktop/usr/pgadmin4/bin/pgadmin4
folder /root/.local/share/pgadmin contains a log file which mysteriously 
disappears after the end of pgadmin4,

with the following content:

Python Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3"
Runtime Config File: "/root/.config/pgadmin/runtime_config.json"
pgAdmin Config File: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/config.py"
Webapp Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
pgAdmin Command: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3 
/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"

Failed to lauch pgAdmin4 with below error:
Error: spawn ../venv/bin/python3 ENOENT

/tmp/vk/rpm/desktop/usr/pgadmin4 does not contain "venv".


Vladimir Koković, DP senior(70),
Serbia, Belgrade, 1.March 2021

Re: pgAdmin 4 - desktop version - RPM

[Dave Page]

On Mon, Mar 1, 2021 at 3:25 PM gmail Vladimir Koković <
vladimir.koko...@gmail.com> wrote:

> After many years of using "pgAdmin III", I tried several times to run the
> "pgAdmin 4" desktop version, but always without success!
>
> So it is on this day in an attempt to run
> pgadmin4-desktop-5.0-1.fc33.x86_64.rpm (snapshots/2021-03-01).
> After extracting the files from the RPM to the /tmp/vk/rpm/desktop folder
> based on
> the /tmp/vk/rpm/desktop/usr/share/applications/pgadmin4.desktop content
> and running pgadmin4:
>
> /tmp/vk/rpm/desktop/usr/pgadmin4/bin/pgadmin4
> folder /root/.local/share/pgadmin contains a log file which mysteriously
> disappears after the end of pgadmin4,
> with the following content:
>
> Python Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3"
> Runtime Config File: "/root/.config/pgadmin/runtime_config.json"
> pgAdmin Config File: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/config.py"
> Webapp Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
> pgAdmin Command: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3
> /tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
> Failed to lauch pgAdmin4 with below error:
> Error: spawn ../venv/bin/python3 ENOENT
>
> /tmp/vk/rpm/desktop/usr/pgadmin4 does not contain "venv".
>

No, it wouldn't. The RPMs have dependencies, and by doing what you have
done here, those dependencies are not satisfied. At the very least you'll
need to unpack the -server RPM into the same directory (and have
libatomic, python3, postgresql-libs >= 11 and krb5-libs *properly*
installed), and even then I'm not 100% sure it'll work as the packaging was
neither designed or tested for manual unpacking and relocation.

If you follow the installation instructions on the website, it should work
just fine.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Re: pgAdmin 4 - desktop version - RPM

[gmail Vladimir Koković]

Hi Dave,

You are absolutely right, you need to extract the server first and then 
the desktop RPM and the "pgAdmin 4" desktop version works!


By the way, I'm on Linux Manjaro for which you don't have a package and 
that's why it's easiest to use the RPM package.


On 1.3.21. 16:48, Dave Page wrote:



On Mon, Mar 1, 2021 at 3:25 PM gmail Vladimir Koković 
mailto:vladimir.koko...@gmail.com>> wrote:


After many years of using "pgAdmin III", I tried several times to
run the "pgAdmin 4" desktop version, but always without success!

So it is on this day in an attempt to run
pgadmin4-desktop-5.0-1.fc33.x86_64.rpm (snapshots/2021-03-01).
After extracting the files from the RPM to the /tmp/vk/rpm/desktop
folder based on
the /tmp/vk/rpm/desktop/usr/share/applications/pgadmin4.desktop
content and running pgadmin4:

/tmp/vk/rpm/desktop/usr/pgadmin4/bin/pgadmin4
folder /root/.local/share/pgadmin contains a log file which
mysteriously disappears after the end of pgadmin4,
with the following content:

Python Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3"
Runtime Config File: "/root/.config/pgadmin/runtime_config.json"
pgAdmin Config File: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/config.py"
Webapp Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
pgAdmin Command:
"/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3
/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
Failed to lauch pgAdmin4 with below error:
Error: spawn ../venv/bin/python3 ENOENT

/tmp/vk/rpm/desktop/usr/pgadmin4 does not contain "venv".


No, it wouldn't. The RPMs have dependencies, and by doing what you 
have done here, those dependencies are not satisfied. At the very 
least you'll need to unpack the -server RPM into the same directory 
(and have libatomic, python3, postgresql-libs >= 11 and krb5-libs 
*properly* installed), and even then I'm not 100% sure it'll work as 
the packaging was neither designed or tested for manual unpacking and 
relocation.


If you follow the installation instructions on the website, it should 
work just fine.


--
Dave Page
Blog: http://pgsnake.blogspot.com 
Twitter: @pgsnake

EDB: http://www.enterprisedb.com 

Re: pgAdmin 4 - desktop version - RPM

[Dave Page]

On Mon, Mar 1, 2021 at 4:03 PM gmail Vladimir Koković <
vladimir.koko...@gmail.com> wrote:

> Hi Dave,
>
> You are absolutely right, you need to extract the server first and then
> the desktop RPM and the "pgAdmin 4" desktop version works!
>
> By the way, I'm on Linux Manjaro for which you don't have a package and
> that's why it's easiest to use the RPM package.
>

Cool - glad it's working for you!


> On 1.3.21. 16:48, Dave Page wrote:
>
>
>
> On Mon, Mar 1, 2021 at 3:25 PM gmail Vladimir Koković <
> vladimir.koko...@gmail.com> wrote:
>
>> After many years of using "pgAdmin III", I tried several times to run the
>> "pgAdmin 4" desktop version, but always without success!
>>
>> So it is on this day in an attempt to run
>> pgadmin4-desktop-5.0-1.fc33.x86_64.rpm (snapshots/2021-03-01).
>> After extracting the files from the RPM to the /tmp/vk/rpm/desktop folder
>> based on
>> the /tmp/vk/rpm/desktop/usr/share/applications/pgadmin4.desktop content
>> and running pgadmin4:
>>
>> /tmp/vk/rpm/desktop/usr/pgadmin4/bin/pgadmin4
>> folder /root/.local/share/pgadmin contains a log file which mysteriously
>> disappears after the end of pgadmin4,
>> with the following content:
>>
>> Python Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3"
>> Runtime Config File: "/root/.config/pgadmin/runtime_config.json"
>> pgAdmin Config File: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/config.py"
>> Webapp Path: "/tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
>> pgAdmin Command: "/tmp/vk/rpm/desktop/usr/pgadmin4/venv/bin/python3
>> /tmp/vk/rpm/desktop/usr/pgadmin4/web/pgAdmin4.py"
>> Failed to lauch pgAdmin4 with below error:
>> Error: spawn ../venv/bin/python3 ENOENT
>>
>> /tmp/vk/rpm/desktop/usr/pgadmin4 does not contain "venv".
>>
>
> No, it wouldn't. The RPMs have dependencies, and by doing what you have
> done here, those dependencies are not satisfied. At the very least you'll
> need to unpack the -server RPM into the same directory (and have
> libatomic, python3, postgresql-libs >= 11 and krb5-libs *properly*
> installed), and even then I'm not 100% sure it'll work as the packaging was
> neither designed or tested for manual unpacking and relocation.
>
> If you follow the installation instructions on the website, it should work
> just fine.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com