Re: pgAdmin4 v4.28 candidate builds

[Fahar Abbas]

@Akshay Joshi 

One Round of testing has been done, Can you please publish pgadmin4 4.28?


On Mon, Nov 9, 2020 at 2:56 PM Akshay Joshi 
wrote:

>
> On Mon, Nov 9, 2020 at 3:24 PM Akshay Joshi 
> wrote:
>
>> Hi All,
>>
>> pgAdmin4 v4.27 candidate builds and source can be found at
>> https://developer.pgadmin.org/builds/2020-11-09-1/
>>
>
>It's v4.28, sorry for the typo.
>
>>
>> Fahar, can you please verify it for release on Thursday.
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Fahar Abbas
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: *live:fahar.abbas*
Website: www.enterprisedb.com

pgAdmin 4 v4.28 released

[Akshay Joshi]

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.28.
This release of pgAdmin 4 includes 19 bug fixes and new features. For more
details please see the release notes at:

https://www.pgadmin.org/docs/pgadmin4/4.28/release_notes_4_28.html.

pgAdmin is the leading Open Source graphical management tool for
PostgreSQL. For more information, please see:

https://www.pgadmin.org/

Notable changes in this release include:

   - Added support to download utility files at the client-side.
   - Added support to rename query tool and debugger tabs title.
   - Added support for dynamic tab size.
   - Added tab title placeholder for Query Tool, View/Edit Data, and
   Debugger.
   - Added support to compare schemas and databases in schema diff.
   - Ensure that non-superuser should be able to debug the function.
   - Ensure that query history should be listed by date/time in descending
   order.
   - Ensure that Grant Wizard should include foreign tables.
   - Ensure that search object functionality works with case insensitive
   string.


Builds for Windows and macOS are available now, along with a Python Wheel,
Docker Container, RPM, DEB Package, and source code tarball from:

https://www.pgadmin.org/download/

--
Akshay Joshi
pgAdmin Project

pgAdmin 4 commit: Tag REL-4_28 has been created.

[Akshay Joshi]

Tag REL-4_28 has been created.
View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_28

Log Message
---
Tag v4.28

pgAdmin 4 commit: 1) Fixed an issue where the process watcher dialog th

[Akshay Joshi]

1) Fixed an issue where the process watcher dialog throws an error for
   the database server which is already removed. Fixes #5985
2) Fixed cognitive complexity reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be386e77f2ea24d9f470cb7c416c8b8913e3927f
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/release_notes.rst   |  1 +
docs/en_US/release_notes_4_29.rst  | 20 +
web/pgadmin/browser/server_groups/servers/utils.py | 18 
web/pgadmin/misc/bgprocess/processes.py| 50 +-
web/pgadmin/tools/backup/__init__.py   |  5 ---
.../tools/backup/tests/test_batch_process.py   | 15 ++-
.../import_export/tests/test_batch_process.py  |  9 ++--
.../storage_manager/static/js/storage_manager.js   |  2 +-
8 files changed, 99 insertions(+), 21 deletions(-)

pgAdmin 4 commit: Added validation in schema diff which will not allow

[Akshay Joshi]

Added validation in schema diff which will not allow the user to compare the 
same objects.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5839e7cda87b0b40d188e71c199308f501e69a19
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js | 14 ++
1 file changed, 14 insertions(+)

pgAdmin 4 commit: Fixed an issue where the debugger's custom tab title

[Akshay Joshi]

Fixed an issue where the debugger's custom tab title not applied when opened in 
the new browser tab. Fixes #5974

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ebf5e871e084a848774eee09bf072d103bd04b97
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_29.rst  |  1 +
.../datagrid/static/js/datagrid_panel_title.js |  2 +-
web/pgadmin/tools/datagrid/static/js/show_data.js  |  2 +-
web/pgadmin/tools/debugger/__init__.py | 23 ++
.../tools/debugger/static/js/debugger_utils.js |  2 +-
.../tools/debugger/templates/debugger/direct.html  |  2 +-
6 files changed, 28 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Added the appropriate server icon based on the server

[Akshay Joshi]

Added the appropriate server icon based on the server type in the new 
connection dialog. Fixes #5983

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5370bb45151551cf99f40efd908ad666374719c4
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_29.rst  |  1 +
.../js/sqleditor/new_connection_dialog_model.js| 72 +-
.../tools/datagrid/templates/datagrid/index.html   |  3 +
web/pgadmin/tools/sqleditor/__init__.py| 17 +++--
4 files changed, 88 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed cognitive complexity reported by SonarQube.

[Akshay Joshi]

Fixed cognitive complexity reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a026f339c3fb26be746602fbf1a988bedc1232e3
Author: Nikhil Mohite 

Modified Files
--
.../foreign_servers/user_mappings/__init__.py  |  79 ++--
web/pgadmin/tools/debugger/__init__.py | 405 +
.../static/js/schema_diff_dependency.js|   6 +-
3 files changed, 297 insertions(+), 193 deletions(-)

Re: Patch for SonarQube code scan fixes

[Akshay Joshi]

Thanks, patch applied.

On Tue, Nov 10, 2020 at 3:44 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. Schema dif dependency:
>
>- 'isChecked' is already declared in the upper scope.
>
> 2. User management:
>
>- Refactor this function to reduce its Cognitive Complexity from 27 to
>the 15 allowed.
>
> 3. Debugger:
>
>- Refactor this function to reduce its Cognitive Complexity from 30 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 45 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 50 to
>the 15 allowed.
>
>
>
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

[Akshay Joshi]

Thanks, patch applied.

On Thu, Nov 12, 2020 at 2:15 AM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find below attached patch which fixes:
> 1. Bgprocess watcher dialog box disappearing after server is removed
> 2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to
> Storage Manager)
> 3. Previous sonarqube issues carry forward in this patch.
>
> Rest I haven't got any user_old specific issues while removing the orphan
> process, I think, programmatically, it is handled.
>
> Note: Previous sonarqube issue in this mail trace is also considered in
> this patch due to many similar file changes.
>
> On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Minor sonar issues too fixed. Find the updated patch.
>>
>> On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch to fix the SonarQube code smells having
>>> rules:
>>>
>>>- Refactor this function to reduce its Cognitive Complexity from 24
>>>to the 15 allowed.
>>>
>>> Also, corrected one of the backup test cases which were failing in
>>> server mode.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-5974]: Debugger tab title (placeholders) does not apply to debugger opened in the new browser tab.

[Akshay Joshi]

Thanks, patch applied.

On Thu, Nov 12, 2020 at 12:22 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Regarding RM-5974 :  Debugger
> tab title (placeholders) does not apply to debugger opened in the new
> browser tab. Also added a small fix for the rename tab, removed multiple
> escape functions while creating the tab title.
> PFA patch.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin4] Enhance the Schema diff GUI validation

[Akshay Joshi]

Thanks, patch applied.

On Tue, Nov 10, 2020 at 6:53 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to add the validation in schema diff which will not allow
> the user to compare the same objects in source and target dropdowns.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-5983]:Add server type icon on new connection dialog.

[Akshay Joshi]

Thanks, patch applied.

On Wed, Nov 11, 2020 at 5:12 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Regarding RM-5983 : Add
> server type icon on new connection dialog.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*