[pgAdmin][RM-4230]: Resolved issues in Rename tab

[Nikhil Mohite]

Hi Team,

I am sending a common patch RM-4232 and RM-4230
Resolved the issues found in the testing.

*RM-4232:*
1. If the user adds a percentage (other than for placeholders) then it is
stripped off.
2. Backslash is getting removed in the connection string if we provide the
backslash(\) in placeholders or the database name contains it.
3. If the user added only spaces( )in placeholders it is not getting reset
to default values.

*RM-4230:*
1. Rename panel option is not working in the debugger.
2. Added Rename panel for schema diff.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM_4232_and_RM_4230.patch
Description: Binary data

Re: pgAdmin 4 commit: Added support to download utility files at the client

[Murtuza Zabuawala]

Hi,

PFA minor patch to remove dead code which was introduced with this patch.

--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com


On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi 
wrote:

> Added support to download utility files at the client-side. Fixes #3318
>
> Branch
> --
> master
>
> Details
> ---
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2605a
> Author: Rahul Shirsat 
>
> Modified Files
> --
> docs/en_US/release_notes_4_28.rst  |   1 +
> web/pgadmin/misc/bgprocess/processes.py|  58 +++-
> .../misc/bgprocess/static/css/bgprocess.css|   4 +
> .../misc/bgprocess/static/img/storage_manager.svg  |  13 +
> web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  44 ++-
> web/pgadmin/misc/file_manager/__init__.py  |  17 +-
> .../misc/file_manager/static/js/file_manager.js|   6 +-
> .../misc/file_manager/static/js/select_dialogue.js |   3 +-
> .../file_manager/static/js/storage_dialogue.js |  45 +++
> web/pgadmin/misc/file_manager/static/js/utility.js |  76 -
> web/pgadmin/tools/backup/__init__.py   |   5 +
> .../tools/backup/tests/test_backup_message.py  |  34 +-
> web/pgadmin/tools/import_export/__init__.py|  93 --
> .../import_export/tests/test_batch_process.py  | 244 ++
> .../import_export/tests/test_create_export_job.py  | 149 +
> .../import_export/tests/test_create_import_job.py  | 241 ++
> .../test_import_export_create_job_unit_test.py | 353
> +
> .../tests/test_import_export_message.py| 135 
> .../tests/test_import_export_utils.py  | 194 +++
> web/pgadmin/tools/storage_manager/__init__.py  |  75 +
> .../storage_manager/static/js/storage_manager.js   |  93 ++
> .../javascript/file_manager/file_manager_specs.js  |  18 ++
> web/webpack.config.js  |   1 +
> web/webpack.shim.js|   1 +
> 24 files changed, 1842 insertions(+), 61 deletions(-)
>
>


remove_dead_code.diff
Description: Binary data

pgAdmin 4 commit: Remove commented code.

[Akshay Joshi]

Remove commented code.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=892fb83907ce5ecbffd5236848d8d60c397e70f0
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/tools/import_export/__init__.py | 21 -
1 file changed, 21 deletions(-)

pgAdmin 4 commit: Added missing gettext.

[Akshay Joshi]

Added missing gettext.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7648bd964639de3eb773a156b3ccbed10add828b
Author: Libor M 

Modified Files
--
web/pgadmin/browser/__init__.py  | 11 ++-
.../servers/databases/schemas/domains/static/js/domain.js|  2 +-
.../schemas/foreign_tables/static/js/foreign_table.js|  2 +-
.../databases/schemas/tables/columns/static/js/column.js |  6 +++---
.../exclusion_constraint/static/js/exclusion_constraint.js   |  2 +-
.../tables/constraints/foreign_key/static/js/foreign_key.js  |  2 +-
.../row_security_policies/static/js/row_security_policy.js   |  2 +-
.../servers/databases/schemas/types/static/js/type.js| 10 +-
web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js |  2 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js   |  2 +-
web/pgadmin/tools/sqleditor/utils/constant_definition.py | 11 ++-
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py  | 12 ++--
12 files changed, 33 insertions(+), 31 deletions(-)

pgAdmin 4 commit: Fixed the following issues:

[Akshay Joshi]

Fixed the following issues:

RM-4232:
1. If the user adds a percentage (other than for placeholders) then it is 
stripped off.
2. Backslash is getting removed in the connection string if we provide the 
backslash(\) in placeholders or the database name contains it.
3. If the user added only spaces( )in placeholders it is not getting reset to 
default values.

RM-4230:
1. Rename panel option is not working in the debugger.
2. Added Rename panel for schema diff.

Fixes #4232 #4230

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5f9fffaddaf652aef3477bb5a9b7fe25ea66dc0
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/preferences/__init__.py|  6 
.../static/js/sqleditor/new_connection_dialog.js   | 27 +++
web/pgadmin/tools/datagrid/static/js/datagrid.js   |  3 +-
.../datagrid/static/js/datagrid_panel_title.js | 19 +++
web/pgadmin/tools/datagrid/static/js/show_data.js  | 24 --
web/pgadmin/tools/debugger/static/js/debugger.js   | 15 +
.../tools/debugger/static/js/debugger_utils.js | 38 --
.../tools/schema_diff/static/js/schema_diff.js | 19 +--
.../tools/schema_diff/static/js/schema_diff_ui.js  |  1 -
9 files changed, 75 insertions(+), 77 deletions(-)

Re: pgAdmin 4 commit: Added support to download utility files at the client

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 26, 2020 at 6:24 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to remove dead code which was introduced with this patch.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Added support to download utility files at the client-side. Fixes #3318
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2605a
>> Author: Rahul Shirsat 
>>
>> Modified Files
>> --
>> docs/en_US/release_notes_4_28.rst  |   1 +
>> web/pgadmin/misc/bgprocess/processes.py|  58 +++-
>> .../misc/bgprocess/static/css/bgprocess.css|   4 +
>> .../misc/bgprocess/static/img/storage_manager.svg  |  13 +
>> web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  44 ++-
>> web/pgadmin/misc/file_manager/__init__.py  |  17 +-
>> .../misc/file_manager/static/js/file_manager.js|   6 +-
>> .../misc/file_manager/static/js/select_dialogue.js |   3 +-
>> .../file_manager/static/js/storage_dialogue.js |  45 +++
>> web/pgadmin/misc/file_manager/static/js/utility.js |  76 -
>> web/pgadmin/tools/backup/__init__.py   |   5 +
>> .../tools/backup/tests/test_backup_message.py  |  34 +-
>> web/pgadmin/tools/import_export/__init__.py|  93 --
>> .../import_export/tests/test_batch_process.py  | 244 ++
>> .../import_export/tests/test_create_export_job.py  | 149 +
>> .../import_export/tests/test_create_import_job.py  | 241 ++
>> .../test_import_export_create_job_unit_test.py | 353
>> +
>> .../tests/test_import_export_message.py| 135 
>> .../tests/test_import_export_utils.py  | 194 +++
>> web/pgadmin/tools/storage_manager/__init__.py  |  75 +
>> .../storage_manager/static/js/storage_manager.js   |  93 ++
>> .../javascript/file_manager/file_manager_specs.js  |  18 ++
>> web/webpack.config.js  |   1 +
>> web/webpack.shim.js|   1 +
>> 24 files changed, 1842 insertions(+), 61 deletions(-)
>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed API test cases.

[Akshay Joshi]

Fixed API test cases.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5284a1c66b64b6887c759ca9c334e5ff3eb735eb

Modified Files
--
web/pgadmin/tools/backup/tests/test_backup_message.py | 3 ---
1 file changed, 3 deletions(-)

Re: pgAdmin 4 - added missing gettexts

[Akshay Joshi]

Thanks, patch applied.

On Sun, Oct 25, 2020 at 10:18 PM Libor M.  wrote:

> Hi,
> I added missing gettext usage. Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: libor...@gmail.com
> GitHub: https://github.com/liborm85
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-4230]: Resolved issues in Rename tab

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 26, 2020 at 6:18 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I am sending a common patch RM-4232 and RM-4230
> Resolved the issues found in the testing.
>
> *RM-4232:*
> 1. If the user adds a percentage (other than for placeholders) then it is
> stripped off.
> 2. Backslash is getting removed in the connection string if we provide the
> backslash(\) in placeholders or the database name contains it.
> 3. If the user added only spaces( )in placeholders it is not getting reset
> to default values.
>
> *RM-4230:*
> 1. Rename panel option is not working in the debugger.
> 2. Added Rename panel for schema diff.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*