pgAdmin 4 commit: Fixed following issues in the function module:

[Akshay Joshi]

Fixed following issues in the function module:
1) The volatility option is not reflecting. It stays volatile always when 
creating the function.
2) Set "Returns as set" to true and enter estimated rows like 12. Now set 
returns as set to false and save.
   It gives ERROR: ROWS is not applicable when the function does not return a 
set.
   Need to clear estimated rows when returns as set is false.
3) If estimated rows are added and support function is selected then SQL looks 
ugly.

Fixes #5843

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bb510cdd4114163a40682d3f48d758d54079dcb
Author: Pradip Parkale 

Modified Files
--
.../databases/schemas/functions/__init__.py|  7 +++--
.../schemas/functions/static/js/function.js|  5 +++-
.../templates/functions/pg/sql/12_plus/create.sql  |  1 -
.../functions/ppas/sql/9.5_plus/create.sql |  2 +-
.../procedures/ppas/sql/9.6_plus/create.sql|  2 +-
.../procedures/ppas/sql/9.6_plus/update.sql|  2 +-
.../tests/pg/11_plus/test_trigger_functions.json   |  4 +--
.../tests/pg/12_plus/create_event_trigger_full.sql |  2 +-
.../tests/pg/12_plus/create_plain_trigger_full.sql |  2 +-
.../tests/pg/9.5_plus/test_trigger_functions.json  |  4 +--
.../tests/pg/9.6_plus/test_trigger_functions.json  |  4 +--
.../tests/pg/default/test_trigger_functions.json   |  4 +--
.../tests/ppas/11_plus/test_trigger_functions.json |  4 +--
.../tests/ppas/12_plus/test_trigger_functions.json |  4 +--
.../tests/ppas/9.6_plus/alter_proc_opt.sql |  2 +-
.../tests/ppas/9.6_plus/alter_proc_opt_msql.sql|  2 +-
.../ppas/9.6_plus/create_plain_trigger_full.sql|  2 +-
.../tests/ppas/9.6_plus/test_procedures.json   | 31 +-
.../ppas/9.6_plus/test_trigger_functions.json  |  2 +-
.../tests/ppas/default/test_procedures.json|  2 +-
.../tests/ppas/default/test_trigger_functions.json |  4 +--
21 files changed, 55 insertions(+), 37 deletions(-)

pgAdmin 4 commit: Update Italian translation.

[Akshay Joshi]

Update Italian translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33e9b7438849a2ffe71918045ee4a3a016d8f128
Author: Domenico Sgarbossa 

Modified Files
--
.../translations/it/LC_MESSAGES/messages.mo|  Bin 184357 -> 200985 bytes
.../translations/it/LC_MESSAGES/messages.po| 1791 
2 files changed, 336 insertions(+), 1455 deletions(-)

pgAdmin 4 commit: Update Japanese translation.

[Akshay Joshi]

Update Japanese translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92f9ad48a83c53aa5afe2baf3ad89790cd50ec81
Author: Identifier Anonymous 

Modified Files
--
.../translations/ja/LC_MESSAGES/messages.mo| Bin 197640 -> 201723 bytes
.../translations/ja/LC_MESSAGES/messages.po| 122 +++--
2 files changed, 62 insertions(+), 60 deletions(-)

pgAdmin 4 commit: Update French translation.

[Akshay Joshi]

Update French translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc282b358543374575609fe6ecab4088c9088449
Author: Fred Escallier 

Modified Files
--
.../translations/fr/LC_MESSAGES/messages.mo|  Bin 188343 -> 205370 bytes
.../translations/fr/LC_MESSAGES/messages.po| 1846 +---
2 files changed, 838 insertions(+), 1008 deletions(-)

pgAdmin 4 commit: Fixed fg_color and bg_color issue for connection stri

[Akshay Joshi]

Fixed fg_color and bg_color issue for connection string on query tool.

refs #3794

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa267805c964858f0877ab9a1650fcf1c5ee7bf7
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/tools/datagrid/templates/datagrid/index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Added support to view trigger function under the resp

[Akshay Joshi]

Added support to view trigger function under the respective trigger node. Fixes 
#2519

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=556278dbc52913ba266b1febb02232050103eccd

Modified Files
--
docs/en_US/release_notes_4_27.rst  |  1 +
.../databases/schemas/functions/__init__.py|  8 +++
.../functions/static/js/trigger_function.js| 18 +-
.../triggers/sql/pg/9.1_plus/get_function_oid.sql  |  9 +++
.../sql/ppas/9.1_plus/get_function_oid.sql |  9 +++
.../databases/schemas/tables/triggers/__init__.py  | 70 +-
web/pgadmin/browser/static/js/browser.js   |  6 +-
web/pgadmin/browser/static/js/menu.js  | 36 ---
web/pgadmin/browser/static/js/node.js  |  6 +-
9 files changed, 148 insertions(+), 15 deletions(-)

Re: Translators: Release next week

[Akshay Joshi]

Thanks, patch applied.

On Fri, Oct 9, 2020 at 11:29 PM Domenico Sgarbossa  wrote:

> Here Italian files
> Bye
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Translators: Release next week

[Akshay Joshi]

Thanks, patch applied.

On Sun, Oct 11, 2020 at 7:40 PM  wrote:

>
> hi
> here's the french translation update
> frd
>
>
> --
> *De: *"Akshay Joshi" 
> *À: *"pgadmin-hackers" 
> *Envoyé: *Vendredi 9 Octobre 2020 14:51:59
> *Objet: *Translators: Release next week
>
> Hi Translators,
>
> We will have a release next week. We will create the candidate build on
> Monday at 5.00 PM IST so updates to translations before that would be
> helpful. The template and catalogs have been updated in git.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Issue in fg_color and bg_color for connection string on query tool.

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 12, 2020 at 10:54 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed the issue of fg_color and bg_color of the connection string
> for the query tool.
> PFA patch. (This is related to RM-3794
> )
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 12, 2020 at 11:59 AM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the attached patch for below issues:
> 1) The volatility option is not reflecting. It stays volatile always when
> creating the function - Fixed
> 2) Set "Returns as set" to true and enter estimated rows like 12. Now set
> returns as set to false and save. It gives ERROR: ROWS is not applicable
> when function does not return a set. Need to clear estimated rows when
> returns as set is false. - Fixed
> 3) If estimated rows are added and support function is selected then SQL
> looks ugly. - Fixed
>
> On Mon, Oct 5, 2020 at 2:41 PM Akshay Joshi 
> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Oct 1, 2020 at 2:25 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the attached patch to allow the user to modify the option
>>> settings of the procedure. This issue was only for PPAS 11 and PPAS 12.
>>>
>>> On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale <
>>> pradip.park...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 Please find the small patch for the ' Parallel Unsafe' option is
 missing in SQL. It was missing in first patch for PG96 and PG10.


 On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, patch applied. It's a small fix so I have fixed it.
>
> On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Pradip
>>
>> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and
>> resend the patch.
>>
>> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> The 'Unsafe' parallel option was not visible in the SQL for function
>>> and procedure. Attached is the patch to fix this issue.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


 --
 Thanks & Regards,
 Pradip Parkale
 Software Engineer | EnterpriseDB Corporation

>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Translators: Release next week

[Akshay Joshi]

Thanks, patch applied.

On Fri, Oct 9, 2020 at 10:51 PM fn ln  wrote:

> Hello.
> Here's an updated Japanese translation for the upcoming version 4.27
> release.
> (messages.pot revision; 65aba21c14)
>
> 2020年10月9日(金) 21:52 Akshay Joshi :
>
>> Hi Translators,
>>
>> We will have a release next week. We will create the candidate build on
>> Monday at 5.00 PM IST so updates to translations before that would be
>> helpful. The template and catalogs have been updated in git.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

New connection issue.

[Nikhil Mohite]

Hi Team,

I have fixed an issue on a new connection.
When the server is disconnected and we try to connect it through a new
connection model dialog it is falling for every 3rd connection attempt.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


new_connection_issue.patch
Description: Binary data

pgAdmin 4 commit: Fixed an issue on a new connection when the server is

[Akshay Joshi]

Fixed an issue on a new connection when the server is disconnected and we are 
trying to connect it using the new connection model.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b7e3ce64e10d5dff331270937f76501107f3c12
Author: Nikhil Mohite 

Modified Files
--
.../js/sqleditor/new_connection_dialog_model.js| 144 +++--
1 file changed, 75 insertions(+), 69 deletions(-)

pgAdmin 4 commit: Added escape and unescape for the strings used in que

[Akshay Joshi]

Added escape and unescape for the strings used in query tool and new connection 
support. Fixes #5899.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49b139bb75b251b3107cfc6250a510d0ea51dc79
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/js/sqleditor/new_connection_dialog.js | 10 +-
web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js |  2 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js   | 12 ++--
3 files changed, 12 insertions(+), 12 deletions(-)

pgAdmin 4 commit: Fixed documentation review comments for Macro support

[Akshay Joshi]

Fixed documentation review comments for Macro support.

refs #5857

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b11a0d50e63de50666a2a505c5e1f1d6fc245520
Author: Nidhi Bhammar 

Modified Files
--
docs/en_US/images/query_tool_macros_clear_all.png | Bin 0 -> 128381 bytes
docs/en_US/images/query_tool_macros_clear_row.png | Bin 98301 -> 98550 bytes
docs/en_US/images/query_tool_manage_macros.png| Bin 0 -> 53042 bytes
docs/en_US/query_tool.rst |  20 +++-
docs/en_US/query_tool_toolbar.rst |   2 +-
5 files changed, 16 insertions(+), 6 deletions(-)

Re: RM_5857 updated patch - Macros Documentation

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 12, 2020 at 3:39 PM Nidhi Bhammar <
nidhi.bham...@enterprisedb.com> wrote:

> Hi,
>
> I have incorporated the review comments from Khusboo and Susan. PFA update
> patch.
>
> Thanks,
>
> Best Regards,
> Nidhi Bhammar
>
>
> www.enterprisedb.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: New connection issue.

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 12, 2020 at 4:59 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed an issue on a new connection.
> When the server is disconnected and we try to connect it through a new
> connection model dialog it is falling for every 3rd connection attempt.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM4855] Renaming a file removes the file extension

[Aditya Toshniwal]

Hi Hackers,

Attached is a patch to improve this further. It will skip adding the
extension if the file already has the extension selected from the format
dropdown.
Please review.

On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Attached patch will add the .sql when saving a file and and format -> sql
>> selected, no matter what the file name is.
>> Please review.
>>
>> On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch to fix a bug where extension file extension is
 stripped on renaming a file.
 Pleasure review.

 --
 Thanks,
 Aditya Toshniwal
 pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
 
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM4855.part3.patch
Description: Binary data

pgAdmin 4 commit: Update version for release.

[Akshay Joshi]

Update version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9898e114f19329369caf4d2323ff53b96fe8837f

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
web/config.py| 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed an issue where extensions are getting added mul

[Akshay Joshi]

Fixed an issue where extensions are getting added multiple times when the user 
uses the "Save As" option.

refs #4855

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67242862c4ee29bae5ad73516eeb5c2a6610eb5d
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/misc/file_manager/static/js/create_dialogue.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM4855] Renaming a file removes the file extension

[Akshay Joshi]

Thanks, patch applied.

On Mon, Oct 12, 2020 at 5:55 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a patch to improve this further. It will skip adding the
> extension if the file already has the extension selected from the format
> dropdown.
> Please review.
>
> On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Attached patch will add the .sql when saving a file and and format ->
>>> sql selected, no matter what the file name is.
>>> Please review.
>>>
>>> On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix a bug where extension file extension is
> stripped on renaming a file.
> Pleasure review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Sr. Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin4 v4.27 candidate builds

[Akshay Joshi]

Hi All,

pgAdmin4 v4.27 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2020-10-12-1/

Fahar, can you please verify it for release on Thursday.

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin4][Patch] - RM 5911- Query is not executing on Manage macro safari 13 and Chrome 75.0 browsers

[Khushboo Vashi]

Hi,

Please find the attached patch to run macros on the older versions of
browsers.

Thanks,
Khushboo


RM_5911.patch
Description: Binary data