Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

[Nikhil Mohite]

Hi Akshay/Team,

I checked the code and found an issue in the "msql" function, due to which
test cases were failing.
I have fixed the issue, PFA updated patch for the same.
Sorry for the inconvenience.


Regards,
Nikhil Mohite.



On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi 
wrote:

> Hi Nikhil
>
> Test cases are failing for all the database server with the following
> error:
> return True, sql.strip('\n')
> AttributeError: 'tuple' object has no attribute 'strip'
>
> Please check and resend the patch.
>
> On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have added few more test cases for the "Functions" module as per
>> RM-5330 
>> PFA patch.
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM_5330_v2.patch
Description: Binary data

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

[Akshay Joshi]

Hi Aditya

The patch fixes only 1 code smell and introduce 1 new. Please fix those and
resend the patch.

On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached path will reduce the cognitive complexity as 
> below:web/pgadmin/misc/file_manager/__init__.py
> 40 to 15; 43 to 15
>
> Please review.
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Improve code coverage and API test cases for Function

[Akshay Joshi]

Improve code coverage and API test cases for Functions. Fixes #5330

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43d97b0e6f5ea910586092113ec3baf8b74ded9d
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_27.rst  |   1 +
.../databases/schemas/functions/__init__.py|  29 +--
.../schemas/functions/tests/test_function_add.py   |  93 -
.../functions/tests/test_function_delete.py| 103 +-
.../schemas/functions/tests/test_function_get.py   |  73 ++-
.../functions/tests/test_function_get_languages.py |  80 
.../functions/tests/test_function_get_msql.py  | 224 +
.../functions/tests/test_function_get_nodes.py | 121 +++
.../functions/tests/test_function_get_sql.py   |  85 
.../functions/tests/test_function_get_types.py |  82 
.../tests/test_function_get_variable_options.py|  80 
.../schemas/functions/tests/test_function_put.py   | 159 +--
.../functions/tests/test_get_dependencies.py   |  85 
.../schemas/functions/tests/test_get_dependents.py |  85 
.../tests/test_get_function_statistics.py  | 120 +++
.../schemas/functions/tests/test_get_list.py   |  80 
.../schemas/functions/tests/test_get_select_sql.py | 122 +++
.../tests/test_get_supported_functions.py  |  85 
.../databases/schemas/functions/tests/utils.py |  10 +-
19 files changed, 1659 insertions(+), 58 deletions(-)

pgAdmin 4 commit: Fixed an issue where the server is not able to connec

[Akshay Joshi]

Fixed an issue where the server is not able to connect using the service. Fixes 
#5841

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=458036ad6ba3e3dd936330de56b2fbc1708084d7
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_27.rst |  1 +
web/pgadmin/browser/server_groups/servers/__init__.py | 15 +--
.../browser/server_groups/servers/static/js/server.js |  2 +-
.../server_groups/servers/templates/servers/password.html | 10 --
.../servers/templates/servers/tunnel_password.html|  8 +++-
5 files changed, 22 insertions(+), 14 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

[Aditya Toshniwal]

Hi,

Please find the updated patch.

On Tue, Sep 22, 2020 at 2:56 PM Akshay Joshi 
wrote:

> Hi Aditya
>
> The patch fixes only 1 code smell and introduce 1 new. Please fix those
> and resend the patch.
>
> On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached path will reduce the cognitive complexity as 
>> below:web/pgadmin/misc/file_manager/__init__.py
>> 40 to 15; 43 to 15
>>
>> Please review.
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


sonarqube.filemanagerv2.patch
Description: Binary data

Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

[Akshay Joshi]

Thanks, patch applied

On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, 
wrote:

> Hi Akshay/Team,
>
> I checked the code and found an issue in the "msql" function, due to which
> test cases were failing.
> I have fixed the issue, PFA updated patch for the same.
> Sorry for the inconvenience.
>
>
> Regards,
> Nikhil Mohite.
>
>
>
> On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> Test cases are failing for all the database server with the following
>> error:
>> return True, sql.strip('\n')
>> AttributeError: 'tuple' object has no attribute 'strip'
>>
>> Please check and resend the patch.
>>
>> On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> I have added few more test cases for the "Functions" module as per
>>> RM-5330 
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

Re: RM5841: server.username can be empty when using .pg_service.conf

[Akshay Joshi]

Thanks, patch applied

On Tue, 22 Sep, 2020, 12:10 Pradip Parkale, 
wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
> On Mon, Sep 21, 2020 at 4:41 PM Pradip Parkale <
> pradip.park...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>>
>> On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Pradip
>>>
>>> Can you please review the patch as that condition we have added for
>>> Shared Server implementation?
>>>
>> Yes, we have added this for the shared server implementation. Please find
>> the attached for this issue.
>>
>>>
>>> On Sat, Sep 19, 2020 at 6:22 PM Cyril Jouve  wrote:
>>>
 fix for https://redmine.postgresql.org/issues/5841

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

[pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

[Pradip Parkale]

Hi Hackers,

The 'Unsafe' parallel option was not visible in the SQL for function and
procedure. Attached is the patch to fix this issue.

-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM5843.patch
Description: Binary data

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

[Akshay Joshi]

Hi Pradip

RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend the
patch.

On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> The 'Unsafe' parallel option was not visible in the SQL for function and
> procedure. Attached is the patch to fix this issue.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*