pgAdmin 4 commit: 1) Changing the state of the react directly is not re

[Akshay Joshi]

1) Changing the state of the react directly is not recommended, so avoid 
changing it directly.
2) Fixed API test cases.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=796a8a013a5a4bd570d8e35877f62ee2bf4d4076
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/dashboard/static/js/Graphs.jsx  | 17 +++--
web/pgadmin/utils/driver/psycopg2/connection.py |  5 +++--
2 files changed, 14 insertions(+), 8 deletions(-)

pgAdmin 4 commit: Fixed an issue while refreshing Resource Group. Fixes

[Akshay Joshi]

Fixed an issue while refreshing Resource Group. Fixes #5820

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ffb829e80c34a43bc34ac805218041b8c9d73ae1

Modified Files
--
docs/en_US/release_notes_4_26.rst | 3 ++-
web/pgadmin/browser/server_groups/servers/resource_groups/__init__.py | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

[pgAdmin][RM5815] Generate script is not working in new window

[Aditya Toshniwal]

Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked
(with query tool setting "open in new tab" set to true) then it shows a
forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can
allow pop up and generate the script again.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM5815.patch
Description: Binary data

pgAdmin 4 commit: Fixed an issue where vacuum options not consider in S

[Akshay Joshi]

Fixed an issue where vacuum options not consider in Schema Diff. It's a 
regression.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bc1ef7f17b81ac529040368e1d616c7488c2c1d

Modified Files
--
.../browser/server_groups/servers/databases/schemas/tables/__init__.py | 3 +++
1 file changed, 3 insertions(+)

Re: pgAgent build warnings on Fedora 32

[Devrim Gündüz]

Hi Neel,

On Fri, 2020-04-24 at 18:15 +0530, Neel Patel wrote:
> I will look into it.

Any updates?

Cheers,
-- 
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

pgAdmin 4 commit: Fixed an issue where clicking on the 'Generate script

[Akshay Joshi]

Fixed an issue where clicking on the 'Generate script' button shows a forever 
spinner due to pop up blocker. Fixes #5815

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d0310b669e0a01513c9e8996436df57697af7524
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_26.rst  |  1 +
web/pgadmin/tools/datagrid/static/js/datagrid.js   |  9 ++--
.../tools/datagrid/static/js/show_query_tool.js| 27 --
.../tools/schema_diff/static/js/schema_diff_ui.js  |  4 ++--
4 files changed, 25 insertions(+), 16 deletions(-)

pgAdmin 4 commit: 1) Added tooltip & keyboard shortcut for the query to

[Akshay Joshi]

1) Added tooltip & keyboard shortcut for the query tool button.
2) Fixed TypeError issue.

refs #4059

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62e6848dc85af08b4c826ea4e8111a4e6be548f7
Author: Rahul Shirsat 

Modified Files
--
web/pgadmin/static/js/keyboard_shortcuts.js|  4 
web/pgadmin/static/js/sqleditor/query_tool_actions.js  |  8 
.../static/js/sqleditor/query_tool_preferences.js  |  6 ++
.../tools/datagrid/static/js/show_query_tool.js| 10 +-
.../tools/datagrid/templates/datagrid/index.html   |  1 -
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 18 +++---
6 files changed, 42 insertions(+), 5 deletions(-)

Re: [pgAdmin][RM5815] Generate script is not working in new window

[Akshay Joshi]

Thanks, patch applied.

On Wed, Sep 9, 2020 at 3:19 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> If schema diff is opened in a new tab and "Generate script" is clicked
> (with query tool setting "open in new tab" set to true) then it shows a
> forever spinner because of pop up blocks.
>
> Attached patch will show an alert message in that case so that the user
> can allow pop up and generate the script again.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: pgAgent build warnings on Fedora 32

[Neel Patel]

Hi Devrim,

I have tried with gcc 10.1 on Ubuntu and I checked the logs but did not
find any warning. Below is my setup and logs during pgAgent compilation.
Is there any specific gcc 10.X version ? Let me know, I can set up and send
a patch.

#

neel@ubuntu:~/Projects/pgagent/build$ c++ --version
c++ (Ubuntu 10.1.0-2ubuntu1~18.04) 10.1.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


neel@ubuntu:~/Projects/pgagent/build$ g++ --version
g++ (Ubuntu 10.1.0-2ubuntu1~18.04) 10.1.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


neel@ubuntu:~/Projects/pgagent/build$ gcc --version
gcc (Ubuntu 10.1.0-2ubuntu1~18.04) 10.1.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


neel@ubuntu:~/Projects/pgagent/build$
PATH=/opt/PostgreSQL/10/bin:$PATH cmake ../ -DSTATIC_BUILD=NO
-DCMAKE_PREFIX_PATH=/home/neel/pgagent_install
-- The C compiler identification is GNU 10.1.0
-- The CXX compiler identification is GNU 10.1.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   filesystem
--   regex
--   date_time
--   thread
--   system
--   chrono
--   atomic
--
-- 

-- Configuration summary:
--
--   Project : pgagent
--   Description : pgAgent is a job scheduling engine
for PostgreSQL
--   Version : 4.2.0
--
--   PostgreSQL version string   : PostgreSQL 10.11
--   PostgreSQL version parts: 10
--   PostgreSQL path : /opt/PostgreSQL/10
--   PostgreSQL config binary: /opt/PostgreSQL/10/bin/pg_config
--   PostgreSQL include path : /opt/PostgreSQL/10/include
--   PostgreSQL library path : /opt/PostgreSQL/10/lib
--   PostgreSQL share path   : /opt/PostgreSQL/10/share/postgresql
--
--   Boost version   : 1.65.1
--   Boost path  : /usr/include
--   Boost include directory : /usr/include
--   Boost library directory : /usr/lib/x86_64-linux-gnu
--   Boost Static linking: NO
-- 

--
-- Configuring done
-- Generating done
-- Build files have been written to:
/home/neel/Projects/pgagent/buildneel@ubuntu:~/Projects/pgagent/build$
make
Scanning dependencies of target run
[ 11%] Generating pgagent--4.2.sql, pgagent.control
[ 11%] Built target run
Scanning dependencies of target pgagent
[ 22%] Building CXX object CMakeFiles/pgagent.dir/connection.cpp.o
[ 33%] Building CXX object CMakeFiles/pgagent.dir/job.cpp.o
[ 44%] Building CXX object CMakeFiles/pgagent.dir/misc.cpp.o
[ 55%] Building CXX object CMakeFiles/pgagent.dir/pgAgent.cpp.o
[ 66%] Building CXX object CMakeFiles/pgagent.dir/precomp.cpp.o
[ 77%] Building CXX object CMakeFiles/pgagent.dir/unix.cpp.o
[ 88%] Building CXX object CMakeFiles/pgagent.dir/win32.cpp.o
[100%] Linking CXX executable pgagent
[100%] Built target pgagent

###


On Wed, Sep 9, 2020 at 7:39 PM Devrim Gündüz  wrote:

>
> Hi Neel,
>
> On Fri, 2020-04-24 at 18:15 +0530, Neel Patel wrote:
> > I will look into it.
>
> Any updates?
>
> Cheers,
> --
> Devrim Gündüz
> Open Source Solution Architect, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>

pgAdmin 4 commit: Fixed an issue where alert message should get display

[Akshay Joshi]

Fixed an issue where alert message should get displayed on active browser 
window.

refs #4059

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7fac72cac5afbf5f63be9c8da7abf872b1bf761a
Author: Rahul Shirsat 

Modified Files
--
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)