[pgAdmin][RM5794] Excessive CPU usage while browser is idle

2020-09-07 Thread Aditya Toshniwal 
Hi Hackers,

Attached is the patch to stop the indefinite growth of graph dataset. This
has caused excessive CPU usage and the patch will reduce it.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM5794.patch
Description: Binary data

[pgAdmin][RM5764] : RLS SQL Incorrectly generated

2020-09-07 Thread Pradip Parkale 
Hi Hackers,

Please find the attached patch for the RLS SQL error.It was incorrectly
generating.
-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM5764.patch
Description: Binary data

pgAdmin 4 commit: Fixed code smell 'Remove duplicates string literals'.

2020-09-07 Thread Akshay Joshi 
Fixed code smell 'Remove duplicates string literals'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4da4a05611dc18b1a3f45256c799e70738a36ee1
Author: Pradip Parkale 

Modified Files
--
.../server_groups/servers/roles/__init__.py| 44 ++
.../server_groups/servers/static/js/server.js  |  1 -
web/pgadmin/utils/constants.py |  4 ++
web/regression/python_test_utils/test_utils.py |  3 +-
4 files changed, 17 insertions(+), 35 deletions(-)

pgAdmin 4 commit: Fixed an issue in the query tool when columns are hav

2020-09-07 Thread Akshay Joshi 
Fixed an issue in the query tool when columns are having the same name as 
javascript object internal functions. Fixes #5765.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8f00b4ecf8ba852ce121f188cdae4a2b6adbd78
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_26.rst  |  1 +
web/pgadmin/static/js/is_native.js | 42 ++
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 22 +---
3 files changed, 60 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed SQL for Row Level Security which is incorrectly

2020-09-07 Thread Akshay Joshi 
Fixed SQL for Row Level Security which is incorrectly generated. Fixes #5764

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e5487d5ad762b8a5ab9187ca37548dc508781a5
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_26.rst  |  1 +
.../databases/schemas/tables/row_security_policies/__init__.py | 10 ++
.../databases/schemas/tables/row_security_policies/utils.py|  9 +++--
.../templates/row_security_policies/sql/10_plus/properties.sql |  3 ++-
.../row_security_policies/sql/9.5_plus/properties.sql  |  3 ++-
.../templates/row_security_policies/sql/default/properties.sql |  3 ++-
.../server_groups/servers/databases/schemas/tables/utils.py|  3 ++-
7 files changed, 22 insertions(+), 10 deletions(-)

pgAdmin 4 commit: Fixed excessive CPU usage by stopping the indefinite

2020-09-07 Thread Akshay Joshi 
Fixed excessive CPU usage by stopping the indefinite growth of the graph 
dataset. Fixes #5794

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c2e965f6ea5caada496254f4c5193b23a160d8a
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_26.rst  |  3 ++-
web/pgadmin/dashboard/static/js/Graphs.jsx | 23 ---
2 files changed, 10 insertions(+), 16 deletions(-)

Re: [pgAdmin][SonarQube] : Remove duplicates string literals.

2020-09-07 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Sep 3, 2020 at 7:19 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
>
> On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi 
> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments:
>>
>>- ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
>>like gone(_(ROLE_NOT_FOUND)). In fact, can we use
>>
>>self.not_found_error_msg()instead of new constant.
>>
>>- Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,
>>also we can use this constant for string "
>>
>>Error retrieving roles from the database server"
>>
>>
>>
>> On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for removing duplicates string literals.
>>> /server_groups/servers/roles/__init__.py  - 8 places
>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5794] Excessive CPU usage while browser is idle

2020-09-07 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Sep 7, 2020 at 3:59 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to stop the indefinite growth of graph dataset. This
> has caused excessive CPU usage and the patch will reduce it.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5765] Invalid markup for viewing table with field named "constructor"

2020-09-07 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Sep 7, 2020 at 11:14 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to handle issues in the query tool when columns are
> having names same as JS object internal functions like constructor,
> hasOwnProperty, etc.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5764] : RLS SQL Incorrectly generated

2020-09-07 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Sep 7, 2020 at 5:55 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

>
> Hi Hackers,
>
> Please find the attached patch for the RLS SQL error.It was incorrectly
> generating.
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue where the server icon getting change t

2020-09-07 Thread Akshay Joshi 
Fixed an issue where the server icon getting change to the shared server icon 
in desktop mode.

refs #4979

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=98e86a81604dacee337bd231426716c69b3ebefb
Author: Pradip Parkale 

Modified Files
--
web/pgadmin/browser/server_groups/servers/static/js/server.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)

Re: RM_5734 Patch

2020-09-07 Thread Akshay Joshi 
Thanks, patch applied.

On Tue, Sep 8, 2020 at 11:15 AM Nidhi Bhammar <
nidhi.bham...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for RM_5734. It is about correcting the description of GiST and
> GIN Indexes in the pgAdmin4 Online Help.
>
> Thanks,
>
> Best Regards,
> Nidhi Bhammar
>
>
> www.enterprisedb.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Update the description of GIN and GiST indexes in the

2020-09-07 Thread Akshay Joshi 
Update the description of GIN and GiST indexes in the documentation. Fixes #5734

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2784905403e8eb93d62d1958a7bad5eaa1f77a6
Author: Nidhi Bhammar 

Modified Files
--
docs/en_US/index_dialog.rst   | 8 
docs/en_US/release_notes_4_26.rst | 1 +
2 files changed, 5 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Moved logic to check fixed port is in use to ConfigWi

2020-09-07 Thread Akshay Joshi 
Moved logic to check fixed port is in use to ConfigWindow class.

refs #5751

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76b0e3e9f74f652d490abba79fe050516edcecee

Modified Files
--
runtime/ConfigWindow.cpp | 60 
runtime/ConfigWindow.h   |  2 ++
runtime/MenuActions.cpp  |  1 +
runtime/Runtime.cpp  | 24 ---
runtime/Runtime.h|  1 -
5 files changed, 48 insertions(+), 40 deletions(-)