[pgAdmin][Patch] #5746 setup.py --load-server does not allow loading connections that use pg_services

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch below which fixes the issue regarding
--load-servers having service based server connection.

-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


RM5746.patch
Description: Binary data

pgAdmin 4 commit: Change the following to replace Python 2 code with Py

[Akshay Joshi]

Change the following to replace Python 2 code with Python 3:
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a253f9053249ca26e37b5e6df194f08db49a651
Author: Cyril Jouve 

Modified Files
--
docs/en_US/conf.py |   8 +-
tools/sql_keywords.py  |   2 +-
web/config.py  |   4 +-
web/pgAdmin4.py|   2 +-
web/pgadmin/__init__.py|  15 +--
web/pgadmin/about/__init__.py  |   2 +-
web/pgadmin/authenticate/ldap.py   |   2 +-
web/pgadmin/browser/__init__.py|   8 +-
web/pgadmin/browser/server_groups/__init__.py  |  12 +-
.../browser/server_groups/servers/__init__.py  |  24 ++--
.../server_groups/servers/databases/__init__.py|   6 +-
.../servers/databases/casts/__init__.py|   2 +-
.../servers/databases/casts/tests/utils.py |   4 +-
.../servers/databases/event_triggers/__init__.py   |   2 +-
.../event_triggers/tests/test_event_trigger_add.py |   2 +-
.../tests/test_event_trigger_delete.py |   2 +-
.../tests/test_event_trigger_delete_multiple.py|   2 +-
.../test_event_trigger_dependancy_dependent.py |   2 +-
.../tests/test_event_trigger_functions.py  |   2 +-
.../event_triggers/tests/test_event_trigger_get.py |   4 +-
.../event_triggers/tests/test_event_trigger_put.py |   2 +-
.../event_triggers/tests/test_event_trigger_sql.py |   2 +-
.../extensions/tests/test_extension_add.py |   2 +-
.../extensions/tests/test_extension_delete.py  |   2 +-
.../tests/test_extension_delete_multiple.py|   2 +-
.../extensions/tests/test_extension_get.py |   2 +-
.../extensions/tests/test_extension_put.py |   2 +-
.../servers/databases/external_tables/__init__.py  |   6 +-
.../databases/external_tables/mapping_utils.py |   3 +-
.../tests/test_external_tables_module.py   |   4 +-
.../tests/test_external_tables_view.py |   4 +-
.../external_tables/tests/test_properties.py   |   2 +-
.../databases/foreign_data_wrappers/__init__.py|   2 +-
.../foreign_servers/__init__.py|   2 +-
.../tests/test_foreign_servers_add.py  |   2 +-
.../tests/test_foreign_servers_delete.py   |   2 +-
.../tests/test_foreign_servers_delete_multiple.py  |   2 +-
.../test_foreign_servers_dependent_dependency.py   |   2 +-
.../tests/test_foreign_servers_get.py  |   2 +-
.../tests/test_foreign_servers_msql.py |   2 +-
.../tests/test_foreign_servers_node.py |   2 +-
.../tests/test_foreign_servers_put.py  |   2 +-
.../tests/test_foreign_servers_sql.py  |   2 +-
.../foreign_servers/user_mappings/__init__.py  |   2 +-
.../user_mappings/tests/test_user_mapping_add.py   |   2 +-
.../tests/test_user_mapping_delete.py  |   2 +-
.../tests/test_user_mapping_delete_multiple.py |   2 +-
.../test_user_mapping_dependent_dependency.py  |   2 +-
.../user_mappings/tests/test_user_mapping_get.py   |   2 +-
.../user_mappings/tests/test_user_mapping_msql.py  |   2 +-
.../user_mappings/tests/test_user_mapping_node.py  |   2 +-
.../user_mappings/tests/test_user_mapping_put.py   |   2 +-
.../user_mappings/tests/test_user_mapping_sql.py   |   2 +-
.../foreign_data_wrappers/tests/test_fdw_add.py|   4 +-
.../foreign_data_wrappers/tests/test_fdw_delete.py |   4 +-
.../tests/test_fdw_delete_multiple.py  |   4 +-
.../tests/test_fdw_dependency_dependent.py |   2 +-
.../tests/test_fdw_get-handlers.py |   4 +-
.../foreign_data_wrappers/tests/test_fdw_get.py|   2 +-
.../tests/test_fdw_get_nodes.py|   2 +-
.../tests/test_fdw_get_validators.py   |   4 +-
.../foreign_data_wrappers/tests/test_fdw_msql.py   |   2 +-
.../foreign_data_wrappers/tests/test_fdw_put.py|   4 +-
.../foreign_data_wrappers/tests/test_fdw_sql.py|   2 +-
.../databases/languages/tests/test_language_add.py |   2 +-
.../languages/tests/test_language_delete.py|   2 +-
.../tests/test_language_delete_multiple.py |   2 +-
.../languages/tests/test_language_dependency.py|   2 +-
.../languages/tests/test_language_dependent.py |   2 +-
.../databases/languages/tests/test_language_get.py |   4 +-
.../test_language_get_function_and_template.py |   2 +-
.../databases/languages/tests/test_language_put.py |   2 +-
.../databases/languages/tests/test_language_sql.py |   2 +-
.../servers/databases/schemas/__init__.py  |   

Re: More idiomatic python3 + fix some tests

[Akshay Joshi]

Hi Cyril

Thanks, patch applied. Please make sure to run "yarn run pep8" before
sending the patch.

On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve  wrote:

> Hello,
>
> patch 1 to 6 generated mostly using 2to3:
> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts
> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter
> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms
> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass
> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange
> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode
>
> patch 7 fixes change_password tests:
> Less that min length : min is 8 instead of 6
> Valid password : use an user different than admin user / mock mail module
>
> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using simplejson
> like in all other modules).
>
> Regards,
> Cyril
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue where --load-server does not allow loa

[Akshay Joshi]

Fixed an issue where --load-server does not allow loading connections that use 
pg_services. Fixes #5746

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5c299c5ad2547c2813dfb78c6e9fbfb0c382e9a
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/release_notes_4_26.rst |  1 +
web/setup.py  | 39 +++
2 files changed, 24 insertions(+), 16 deletions(-)

Re: [pgAdmin][Patch] #5746 setup.py --load-server does not allow loading connections that use pg_services

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 31, 2020 at 3:09 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch below which fixes the issue regarding
> --load-servers having service based server connection.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin] Accessibility fixes for main panels

[Ganesh Jaybhay]

Hi Hackers,

Please find the attached patch to fix the accessibility errors found with
WAVE tool on

   - Dashboard
   - Dependencies / Dependents panel with no object selected in tree view.

Regards,
Ganesh Jaybhay


accessibility_fix_main_panels.patch
Description: Binary data