[pgAdmin][RM5722]: Not able to drop database.

[Pradip Parkale]

Hi Hackers,

Please find the attached patch. Now, with this patch user can drop a
database even if it is connected.

-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM5622.patch
Description: Binary data

Re: [pgAdmin][SonarQube]: Cognitive complexity

[Pradip Parkale]

Hi Akshay,
Please find the updated patch.

On Fri, Aug 21, 2020 at 11:53 AM Akshay Joshi 
wrote:

> Hi Pradip
>
> Following are the review comments:
>
>- Change the function name to "_get_supported_browser" instead of
>"_get_browser_supported".
>
> Fixed.

>
>- Added docstring to the functions in below format:
>
> """
>
> 
>
> :param trans_id:
> :param session_obj:
> :param diff_model_obj:
> :return:
> """
>
> Fixed.

>
>- Can we make "_check_cascade_operation" to generic or move that
>function to PGChildNodeView class and update it in all the nodes where it
>is used.
>
> Fixed.

>
>-
>
>
> On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale <
> pradip.park...@enterprisedb.com> wrote:
>
>> Please ignore the previous patch, find the updated patch in this mail.
>>
>> On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> The attached patch will reduce cognitive complexity for the following
>>> functions.
>>>
>>>1. web/.../databases/schemas/domains/__init__.py - 16 to 15.
>>>2. web/.../tables/row_security_policies/__init__.py - 17 to 15.
>>>3. web/pgadmin/tools/debugger/__init__.py - 23 to 15
>>>4. user_mapping/__init__.py. 35 to 15.
>>>5. browser/__init__.py.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


SonarQube_cognitive_comp_v2.patch
Description: Binary data

[pgAdmin][SonarQube] Cognitive complexity

[Aditya Toshniwal]

Hi Hackers,

Attached patch reduces the cognitive complexity of functions for below:
web/.../schemas/packages/edbfuncs/__init__.py 21 to 15
web/.../databases/schemas/types/__init__.py 39 to 15; 80 to 15
web/.../server_groups/servers/pgagent/__init__.py 39 to 15
web/pgadmin/misc/bgprocess/process_executor.py 19 to 15
web/pgadmin/tools/backup/__init__.py 54 to 15

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


sonarqube.cognitive.types.patch
Description: Binary data

[pgAdmin][RM-5748][RESQL] Incorrect SQL for Foreign key when creating a table

[Nikhil Mohite]

Hi Team,

I have resolved the issue in SQL statements to add foreign while creating
table  RM-5748 .
PFA patch.


Regards,
Nikhil Mohite.


RM_5748_v1.patch
Description: Binary data

[pgAdmin][RM5751] Enable the runtime menu when the timeout occurs

[Akshay Joshi]

Hi Dave/Hackers

Attached is the patch to fix the following issues:

   - Enable the 'Configure' and 'View log' menu option when the server
   taking longer than usual time to start.
   - When an error occurs from the backend, the configure window opens and
   if the user has changed the setting of the port, it won't take any effect
   as we have retrieved the value of the port at the start of the runtime.
   - Added logic to identify the specified fixed port is already in use.
   Throw the error before starting the pgAdmin server.

Please review and let me know any comments.

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


RM_5751.patch
Description: Binary data

how to completely uninstall?

[Kurt Snyder]

Hi -- I have a pgAdmin 4 install on Mac now that is unusable as the
app will not start and I was hoping to try a fresh reinstall after
wiping everything, but I don't know where to find files it is using.

I'm on MacOS 10.14.6. When I start the app it runs a bit with lots of
CPU then says "The pgAdmin 4 server cannot be contacted". It never
launches so I get no UI to work with. I can't seem to find good docs
on how this is to be configured or how to troubleshoot. I had an old
pgAdmin 3 installed, and a pgAdmin 4 that I don't think I ever used.
Both of those were uninstalled, and I did a fresh install of the
latest .dmg but I'm still getting this error.

Any suggestions on how to get unblocked would be appreciated.  Thanks,

Kurt Snyder

Re: [pgAdmin][SonarQube] Cognitive complexity

[Akshay Joshi]

Hi Aditya

Please fix the following issues:

   - Add docstrings to the newly created functions.
   - Fix PEP8 issue.



On Mon, Aug 24, 2020 at 5:02 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch reduces the cognitive complexity of functions for below:
> web/.../schemas/packages/edbfuncs/__init__.py 21 to 15
> web/.../databases/schemas/types/__init__.py 39 to 15; 80 to 15
> web/.../server_groups/servers/pgagent/__init__.py 39 to 15
> web/pgadmin/misc/bgprocess/process_executor.py 19 to 15
> web/pgadmin/tools/backup/__init__.py 54 to 15
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*