Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

[Dave Page]

Hi

On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Dave/Team,
>
> As per discussion with the UX team, Few updates on style-guide patch.
> 1. I have missed removing the "proposed" keyword from the "High-Contract"
> theme name.
>

Right.


> 2. I have not added the "Writing Style" section in the style guide as we
> don’t have the information for it (UX design is also pending due to this). 
> @Dave
> Page  can you provide some inputs on it.
>

Sure; not sure how to deal with that yet - we'll proceed without it for now.

A couple of other issues I found:

- Random scrollbars:

[image: Screenshot 2020-08-20 at 09.00.38.png]

 - On the Menu section, there is a subsection for "Sub menus" (I realise
you didn't design that, but...). That doesn't seem right; what is described
as a sub menu there is actually a tab set. Can you move it to a separate
section please?

There are a few wording changes I'd like as well, but I can deal with that
when I'm committing.

Nice work - thanks!


>
> Regards,
> Nikhil Mohite.
>
> On Wed, Aug 19, 2020 at 11:40 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have updated the style guide for the pgAdmin 4 website as per RM-5990
>> .
>> Details :
>> 1. The updated style-guide section as per the new UI design.
>> 2. Added new icons as per font-awesome 5.14.0.
>> 3. Added custom icons of pgAdmin4.
>>
>> PFA the patch.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

pgAdmin 4 commit: Improve code coverage and API test cases for Grant Wi

[Akshay Joshi]

Improve code coverage and API test cases for Grant Wizard. Fixes #5344

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64152947828942e934217504da5ec8a70c551a6b
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_26.rst  |   1 +
web/pgadmin/tools/grant_wizard/__init__.py |  76 ---
web/pgadmin/tools/grant_wizard/tests/__init__.py   |  16 ++
.../grant_wizard/tests/grant_wizard_test_data.json | 234 +
.../tests/test_grant_wizard_get_acl.py |  62 ++
.../tests/test_grant_wizard_get_properties.py  |  93 
.../tests/test_grant_wizard_get_sql.py |  97 +
.../tests/test_grant_wizard_save_permissions.py|  94 +
web/pgadmin/tools/grant_wizard/tests/utils.py  |  15 ++
9 files changed, 648 insertions(+), 40 deletions(-)

pgAdmin 4 commit: Added SQL Formatter support in Query Tool. Fixes #204

[Akshay Joshi]

Added SQL Formatter support in Query Tool. Fixes #2042

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6480513b4966ec647f1d96ff2bfe3d8c8e966
Author: Dave Page 

Modified Files
--
docs/en_US/images/preferences_sql_formatting.png   | Bin 0 -> 263141 bytes
docs/en_US/images/preferences_sql_options.png  | Bin 207924 -> 212923 bytes
docs/en_US/preferences.rst |  38 ++-
docs/en_US/query_tool_toolbar.rst  | 362 +++--
docs/en_US/release_notes.rst   |   1 +
docs/en_US/release_notes_4_26.rst  |  20 ++
web/pgadmin/misc/sql/__init__.py   |  61 +++-
web/pgadmin/static/js/keyboard_shortcuts.js|   9 +-
.../static/js/sqleditor/query_tool_actions.js  |   4 +
.../tools/datagrid/templates/datagrid/index.html   |   9 +
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  50 +++
.../sqleditor/utils/query_tool_preferences.py  | 116 +--
12 files changed, 459 insertions(+), 211 deletions(-)

Re: WIP: SQL Formatter

[Akshay Joshi]

Thanks, patch applied.

On Tue, Aug 18, 2020 at 3:53 PM Dave Page  wrote:

> Hi
>
> On Tue, Aug 18, 2020 at 7:33 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> The patch looks good to me except pep8 issues.
>>
>
> Thanks, fixed.
>
>
>> In the below SQL - BEGIN, RETURN, END are not formatted. But when only
>> the BEGIN line is selected and the format button is clicked then it gets
>> formatted. This seems to be a bug in sqlparse.
>> Create or replace Function public.simple_func(i_var integer) Returns
>> integer Language 'plpgsql' cost 100 Volatile As $BODY$
>> BEGIN RETURN OTHER_SIMPLE_FUNC(I_VAR);
>> END;
>> $BODY$;
>>
>
> Yeah, sqlparse isn't perfect. I suspect we'll be sending them patches or
> forking it... (re-indent aligned seems to be somewhat funky).
>
> Anyway, here's a patch that includes doc updates, which I believe is
> complete and ready for review/commit.
>
>
>>
>> On Tue, Aug 18, 2020 at 10:50 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it
>>>
>>> On Mon, Aug 10, 2020 at 11:11 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Aditya

 Can you please review and test.

 On Fri, Aug 7, 2020 at 9:28 PM Dave Page  wrote:

>
>
> On Mon, Aug 3, 2020 at 10:51 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Mon, Aug 3, 2020 at 3:06 PM Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Aug 3, 2020 at 10:31 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi,

 On Fri, Jul 31, 2020 at 6:03 PM Dave Page 
 wrote:

> Hi
>
> Currently, all the CodeMirrors in pgAdmin use the settings from
>> the Query tool -> Editor, even though they're not related.  I
>> think you're right. We should move all CodeMirror settings out of 
>> the Query
>> tool and move it to a new node - "SQL" may be. Editor and 
>> Auto-format would
>> be sub nodes under SQL. With that, the editor settings will apply at 
>> all
>> the places where CodeMirror editing is used(function body, query
>> tool). What do you say ?
>>
>
> Turns out that's more work than I really have time for at the
> moment, because it means making the editors be able to handle 
> automatic
> reloads of multiple preference sections. We can always think about 
> moving
> the formatting preferences into their own section later.
>
> In the meantime, this update to the patch does what was originally
> suggested and puts the options into a Query Tool -> SQL Formatting 
> section.
>
 Cool.

>
> Comments? Obviously docs will need updating too, once we're all
> happy with the basics.
>
 It works nice. A shortcut and auto format only selected text would
 be helpful.

>>>
>>> Yeah, the shortcut crossed my mind. Any thoughts on what it could
>>> be? I was struggling to find something that made sense and wasn't used 
>>> by
>>> Chrome or elsewhere.
>>>
>> I can only find Shift+Cmd+K available.
>>
>>>
>>> Formatting only the selected text might be troublesome; it may
>>> create some very strange results if a partial statement is selected.
>>>
>> Formatter should not be blamed in that case. It did what was asked.
>> :P
>>
>
> *shrug*. OK. How's about this?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Sr. Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5344][Code Coverage] Improve API test cases for Grant Wizard

[Akshay Joshi]

Thanks, patch applied.

On Wed, Aug 19, 2020 at 1:16 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have added test cases for Grant wizard as per RM-5344
> 
>
> PFA patch for the same.
>
>
>
> Regards,
> Nikhil Mohite.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Cleanup a bunch of duplicated gettext calls.

[Dave Page]

Cleanup a bunch of duplicated gettext calls.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99a7ada58a495d4503a91b1b1d6cab3fc2ec69ca

Modified Files
--
.../sqleditor/utils/query_tool_preferences.py  | 182 -
1 file changed, 104 insertions(+), 78 deletions(-)

Re: pgAdmin4 v4.25 candidate builds

[Fahar Abbas]

@Akshay Joshi 

One round of testing has been completed, Can you please release pgadmin4
4.25?
Kind regards,

On Tue, Aug 18, 2020 at 6:25 PM Akshay Joshi 
wrote:

> Hi All
>
> We have found an issue due to the release of a new version of *"bcrypt" 
> *v3.2.0,
> which is having some issue on Windows, and also it is not supported Python
> v3.4 and v3.5.
> Due to the above-mentioned issues, we have to create the candidate build
> again and it can be found at
> https://developer.pgadmin.org/builds/2020-08-18-2/
>
> I have verified the new installer on Windows 2016 server and working fine.
>
> Fahar, can you please verify it for release on Thursday.
>
> On Mon, Aug 17, 2020 at 6:37 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All,
>>
>> pgAdmin4 v4.25 candidate builds and source can be found at
>> https://developer.pgadmin.org/builds/2020-08-17-1/
>>
>> Fahar, can you please verify it for release on Thursday.
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: *live:fahar.abbas*
Website: www.enterprisedb.com

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

[Rahul Shirsat]

Hi Akshay,

Please find the updated patch attached in this email.

On Wed, Aug 19, 2020 at 2:40 PM Akshay Joshi 
wrote:

> Hi Rahul
>
> I have committed Khushboo's patch where she has introduced a new method
> 'not_found_error_msg', so instead of creating a new constant
> 'TABLE_NOT_FOUND_MSG' use self.not_found_error_msg.
>
 Done

>
> Also, instead of
> _NODE_CSS = ‘node.css’
> _COLLECTION_CSS = ‘collection.css’
>
> We can use the following:
> _NODE_CSS = _BROWSER_CSS_PATH + ‘/node.css’
> _COLLECTION_CSS = _BROWSER_CSS_PATH + ‘/collection.css’
>
 Done

>
>

> Make the above changes and resend the patch.
>
> On Fri, Aug 14, 2020 at 8:34 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch to fix the SonarQube Code smells having
>> Rule:
>>
>>
>>1. Define a constant instead of duplicating this literal
>>"browser/css/node.css" 4 times.
>>2. Define a constant instead of duplicating this literal "The
>>specified table could not be found." 10 times.
>>3. Define a constant instead of duplicating this literal
>>'get_columns_for_table.sql' 3 times.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


sonar_qube_table_init_v2.patch
Description: Binary data

pgAdmin 4 v4.25 released

[Akshay Joshi]

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.25.
This release of pgAdmin 4 includes 30 bug fixes and new features. For more
details please see the release notes at:

https://www.pgadmin.org/docs/pgadmin4/4.25/release_notes_4_25.html.

pgAdmin is the leading Open Source graphical management tool for
PostgreSQL. For more information, please see:

https://www.pgadmin.org/

Notable changes in this release include:

   - Modified schema diff tool to compare two databases instead of two
   schemas
   - Resolve schema diff dependencies by selecting the appropriate node
   automatically and maintain the order in the generated script.
   - Replace charting library Flotr2 with ChartJS using React.
   - Upgrade font-awesome from v4 to v5.
   - Fixed an issue where debugger doesn't work if the search path is set
   other than 'public'.
   - Fixed ssh tunnel hang issue when the user tries to disconnect the
   server.
   - Fixed an issue where conversion of bytea to the binary string results
   in an error.
   - Fixed an issue where the entire logs are in red text when the user
   runs backup and restore.
   - Ensure that the user will be able to modify the start value of the
   Identity column.
   - Fixed an issue where 'ALTER VIEW' statement is missing when the user
   sets the default value of a column for View.


Builds for Windows and macOS are available now, along with a Python Wheel,
Docker Container, RPM, DEB Package, and source code tarball from:

https://www.pgadmin.org/download/

--
Akshay Joshi
pgAdmin Project

pgAdmin 4 commit: Tag REL-4_25 has been created.

[Akshay Joshi]

Tag REL-4_25 has been created.
View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_25

Log Message
---
Tag v4.25

pgAdmin 4 commit: Fixed code smell 'Define a constant instead of duplic

[Akshay Joshi]

Fixed code smell 'Define a constant instead of duplicating this literal' 
reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3e8596e3ce811ab5665e615411992ba9632f03
Author: Rahul Shirsat 

Modified Files
--
web/pgadmin/browser/collection.py  |  9 +++--
.../browser/server_groups/servers/__init__.py  | 16 -
.../server_groups/servers/databases/__init__.py| 17 +
.../foreign_servers/__init__.py|  6 ++--
.../foreign_servers/user_mappings/__init__.py  |  6 ++--
.../servers/databases/schemas/tables/__init__.py   | 41 +++---
.../databases/schemas/tables/columns/__init__.py   |  2 +-
.../constraints/check_constraint/__init__.py   |  2 +-
.../tables/constraints/foreign_key/__init__.py |  2 +-
.../databases/schemas/tables/indexes/__init__.py   |  2 +-
.../schemas/tables/partitions/__init__.py  |  2 +-
.../databases/schemas/tables/rules/__init__.py |  2 +-
.../servers/databases/schemas/tables/utils.py  |  7 ++--
.../servers/databases/schemas/views/__init__.py|  2 +-
.../server_groups/servers/pgagent/__init__.py  |  2 +-
.../server_groups/servers/roles/__init__.py|  2 +-
web/pgadmin/browser/utils.py   |  6 ++--
17 files changed, 69 insertions(+), 57 deletions(-)

pgAdmin 4 commit: Fixed code smell 'Define a constant instead of duplic

[Akshay Joshi]

Fixed code smell 'Define a constant instead of duplicating this literal' 
reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbbbc362212c6d8b1ad1f670182d9b2fcc67f3e2

Modified Files
--
web/pgadmin/about/__init__.py  |  3 ++-
.../servers/databases/languages/__init__.py| 14 --
.../databases/schemas/collations/__init__.py   | 19 +
.../servers/databases/schemas/domains/__init__.py  | 15 ---
.../schemas/domains/domain_constraints/__init__.py | 28 +--
.../databases/schemas/foreign_tables/__init__.py   | 30 +++--
.../databases/schemas/fts_templates/__init__.py| 17 
.../servers/databases/schemas/packages/__init__.py | 15 +--
.../databases/schemas/sequences/__init__.py| 14 +-
.../servers/databases/schemas/synonyms/__init__.py | 21 +--
.../databases/schemas/tables/columns/__init__.py   | 22 ++-
.../schemas/tables/compound_triggers/__init__.py   | 23 +---
.../databases/schemas/tables/indexes/__init__.py   | 14 --
.../tables/indexes/tests/index_test_data.json  |  4 +--
.../schemas/tables/partitions/__init__.py  | 11 +++-
.../tables/row_security_policies/__init__.py   | 10 +++
.../databases/schemas/tables/rules/__init__.py | 20 +-
.../databases/schemas/tables/triggers/__init__.py  | 21 +--
.../servers/databases/schemas/views/__init__.py| 31 +++---
web/pgadmin/dashboard/__init__.py  |  4 +--
web/pgadmin/misc/__init__.py   |  3 ++-
web/pgadmin/misc/file_manager/__init__.py  |  8 +++---
web/pgadmin/preferences/__init__.py|  3 ++-
web/pgadmin/settings/__init__.py   |  3 ++-
web/pgadmin/tools/__init__.py  |  3 ++-
web/pgadmin/tools/backup/__init__.py   |  3 ++-
web/pgadmin/tools/datagrid/__init__.py |  3 ++-
web/pgadmin/tools/debugger/__init__.py |  8 +++---
web/pgadmin/tools/grant_wizard/__init__.py |  3 ++-
web/pgadmin/tools/import_export/__init__.py|  3 ++-
web/pgadmin/tools/maintenance/__init__.py  |  3 ++-
web/pgadmin/tools/restore/__init__.py  |  3 ++-
web/pgadmin/tools/schema_diff/__init__.py  |  4 +--
web/pgadmin/tools/sqleditor/__init__.py|  3 ++-
web/pgadmin/tools/user_management/__init__.py  |  6 ++---
35 files changed, 149 insertions(+), 246 deletions(-)

pgAdmin 4 commit: Define constants for preferences label to fix SonarQu

[Akshay Joshi]

Define constants for preferences label to fix SonarQube issues.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=103b08c9c567f29b6fcd897e0725aa1095d38906

Modified Files
--
web/pgadmin/browser/__init__.py|  10 +-
.../browser/register_browser_preferences.py|  61 
.../browser/server_groups/servers/__init__.py  |   4 +-
web/pgadmin/dashboard/__init__.py  |   9 +-
web/pgadmin/misc/file_manager/__init__.py  |  10 +-
web/pgadmin/tools/debugger/__init__.py |  24 ++--
web/pgadmin/tools/schema_diff/__init__.py  |   5 +-
.../sqleditor/utils/query_tool_preferences.py  | 157 +
web/pgadmin/utils/constants.py |  18 ++-
9 files changed, 147 insertions(+), 151 deletions(-)

[pgAdmin][SonarQube]: Cognitive complexity

[Pradip Parkale]

Hi Hackers,

The attached patch will reduce cognitive complexity for the following
functions.

   1. web/.../databases/schemas/domains/__init__.py - 16 to 15.
   2. web/.../tables/row_security_policies/__init__.py - 17 to 15.
   3. web/pgadmin/tools/debugger/__init__.py - 23 to 15
   4. user_mapping/__init__.py. 35 to 15.
   5. browser/__init__.py.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


cognitive_comple_sonarQube.patch
Description: Binary data

Re: [pgAdmin][SonarQube]: Cognitive complexity

[Pradip Parkale]

Please ignore the previous patch, find the updated patch in this mail.

On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> The attached patch will reduce cognitive complexity for the following
> functions.
>
>1. web/.../databases/schemas/domains/__init__.py - 16 to 15.
>2. web/.../tables/row_security_policies/__init__.py - 17 to 15.
>3. web/pgadmin/tools/debugger/__init__.py - 23 to 15
>4. user_mapping/__init__.py. 35 to 15.
>5. browser/__init__.py.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


cognitive_comp_sonarQube
Description: Binary data

Re: [pgAdmin][SonarQube]: Cognitive complexity

[Akshay Joshi]

Hi Pradip

Following are the review comments:

   - Change the function name to "_get_supported_browser" instead of
   "_get_browser_supported".
   - Added docstring to the functions in below format:

"""



:param trans_id:
:param session_obj:
:param diff_model_obj:
:return:
"""


   - Can we make "_check_cascade_operation" to generic or move that
   function to PGChildNodeView class and update it in all the nodes where it
   is used.


On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Please ignore the previous patch, find the updated patch in this mail.
>
> On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <
> pradip.park...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> The attached patch will reduce cognitive complexity for the following
>> functions.
>>
>>1. web/.../databases/schemas/domains/__init__.py - 16 to 15.
>>2. web/.../tables/row_security_policies/__init__.py - 17 to 15.
>>3. web/pgadmin/tools/debugger/__init__.py - 23 to 15
>>4. user_mapping/__init__.py. 35 to 15.
>>5. browser/__init__.py.
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Patch for SonarQube code scan fixes.

[Nikhil Mohite]

Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Foreign servers:

   - Refactor this function to reduce its Cognitive Complexity from 49 to
   the 15 allowed.

2. bgprocess/process:

   - Refactor this function to reduce its Cognitive Complexity from 20 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 19 to
   the 15 allowed.

3. directory compare:

   - Refactor this function to reduce its Cognitive Complexity from 24 to
   the 15 allowed.

4. sql editor:

   - Refactor this function to reduce its Cognitive Complexity from 19 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 18 to
   the 15 allowed.


Regards,
Nikhil Mohite.


sonarQubeCodeSmell.patch
Description: Binary data