[pgAdmin4][Patch] - Fixed Schema Diff UI issue for the identical objects

[Khushboo Vashi]

Hi,

Please find the attached patch to fix the Schema Diff UI issue.
While selecting the identical object, the Javascript console gives an error
which is fixed in this patch.

Thanks,
Khushboo


schema_diff_ui.patch
Description: Binary data

pgAdmin 4 commit: Fixed schema diff issue when selecting any identical

[Akshay Joshi]

Fixed schema diff issue when selecting any identical node.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae18b9a0ac7534d83a6e873a9b0d677ba2b08431
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/tools/schema_diff/static/js/schema_diff_dependency.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Update version for release.

[Akshay Joshi]

Update version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3b1ef0b80138ad7837637fdd3c32ed30e3a3894

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
web/config.py| 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed an issue where the entire logs is in red text w

[Akshay Joshi]

Fixed an issue where the entire logs is in red text when the user runs backup 
and restore. Fixes #5604

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0af385ea0f13d279109e0c1e737878ec06efc89

Modified Files
--
docs/en_US/release_notes_4_25.rst |  1 +
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 16 ++--
2 files changed, 15 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Update Dependencies.

[Akshay Joshi]

Update Dependencies.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=085a4f4abf82bd21b142608b8e16032117f9

Modified Files
--
DEPENDENCIES | 225 +--
1 file changed, 128 insertions(+), 97 deletions(-)

pgAdmin 4 commit: Fixed feature test failure due to updating font-aweso

[Akshay Joshi]

Fixed feature test failure due to updating font-awesome from v4 to v5.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0122cf9aacf94291d962bd88db6b66210db68b16
Author: Yogesh Mahajan 

Modified Files
--
web/regression/feature_utils/locators.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4][Patch] - Feature Test Failures (Locator change fix)

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 17, 2020 at 12:23 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find a patch which fixes change in locator due to 'Updating font
> awesome font version'
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - Fixed Schema Diff UI issue for the identical objects

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 17, 2020 at 2:54 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the Schema Diff UI issue.
> While selecting the identical object, the Javascript console gives an
> error which is fixed in this patch.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Update Czech translation.

[Akshay Joshi]

Update Czech translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f73516f8c9a5cc4c79809db04aba88a7808bd8a
Author: Libor M 

Modified Files
--
.../translations/cs/LC_MESSAGES/messages.mo|  Bin 178709 -> 193620 bytes
.../translations/cs/LC_MESSAGES/messages.po| 7653 ++--
2 files changed, 3820 insertions(+), 3833 deletions(-)

Re: pgAdmin 4 - Czech translation update for 4.25

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 17, 2020 at 5:49 PM Libor M.  wrote:

> Hi,
> updated Czech translation for 4.25 is in attachment.
>
> Best regards,
>
> Libor M.
>
> E-mail: libor...@gmail.com
> GitHub: https://github.com/liborm85
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin4 v4.25 candidate builds

[Akshay Joshi]

Hi All,

pgAdmin4 v4.25 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2020-08-17-1/

Fahar, can you please verify it for release on Thursday.


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: WIP: SQL Formatter

[Akshay Joshi]

Hi Aditya

Can you please review it

On Mon, Aug 10, 2020 at 11:11 AM Akshay Joshi 
wrote:

> Hi Aditya
>
> Can you please review and test.
>
> On Fri, Aug 7, 2020 at 9:28 PM Dave Page  wrote:
>
>>
>>
>> On Mon, Aug 3, 2020 at 10:51 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> On Mon, Aug 3, 2020 at 3:06 PM Dave Page  wrote:
>>>


 On Mon, Aug 3, 2020 at 10:31 AM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> On Fri, Jul 31, 2020 at 6:03 PM Dave Page  wrote:
>
>> Hi
>>
>> Currently, all the CodeMirrors in pgAdmin use the settings from the
>>> Query tool -> Editor, even though they're not related.  I think
>>> you're right. We should move all CodeMirror settings out of the Query 
>>> tool
>>> and move it to a new node - "SQL" may be. Editor and Auto-format would 
>>> be
>>> sub nodes under SQL. With that, the editor settings will apply at all 
>>> the
>>> places where CodeMirror editing is used(function body, query tool). 
>>> What do
>>> you say ?
>>>
>>
>> Turns out that's more work than I really have time for at the moment,
>> because it means making the editors be able to handle automatic reloads 
>> of
>> multiple preference sections. We can always think about moving the
>> formatting preferences into their own section later.
>>
>> In the meantime, this update to the patch does what was originally
>> suggested and puts the options into a Query Tool -> SQL Formatting 
>> section.
>>
> Cool.
>
>>
>> Comments? Obviously docs will need updating too, once we're all happy
>> with the basics.
>>
> It works nice. A shortcut and auto format only selected text would be
> helpful.
>

 Yeah, the shortcut crossed my mind. Any thoughts on what it could be? I
 was struggling to find something that made sense and wasn't used by Chrome
 or elsewhere.

>>> I can only find Shift+Cmd+K available.
>>>

 Formatting only the selected text might be troublesome; it may create
 some very strange results if a partial statement is selected.

>>> Formatter should not be blamed in that case. It did what was asked. :P
>>>
>>
>> *shrug*. OK. How's about this?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: WIP: SQL Formatter

[Aditya Toshniwal]

Hi Dave,

The patch looks good to me except pep8 issues. In the below SQL - BEGIN,
RETURN, END are not formatted. But when only the BEGIN line is selected and
the format button is clicked then it gets formatted. This seems to be a bug
in sqlparse.
Create or replace Function public.simple_func(i_var integer) Returns
integer Language 'plpgsql' cost 100 Volatile As $BODY$
BEGIN RETURN OTHER_SIMPLE_FUNC(I_VAR);
END;
$BODY$;

On Tue, Aug 18, 2020 at 10:50 AM Akshay Joshi 
wrote:

> Hi Aditya
>
> Can you please review it
>
> On Mon, Aug 10, 2020 at 11:11 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> Can you please review and test.
>>
>> On Fri, Aug 7, 2020 at 9:28 PM Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Aug 3, 2020 at 10:51 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi,

 On Mon, Aug 3, 2020 at 3:06 PM Dave Page  wrote:

>
>
> On Mon, Aug 3, 2020 at 10:31 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Fri, Jul 31, 2020 at 6:03 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> Currently, all the CodeMirrors in pgAdmin use the settings from the
 Query tool -> Editor, even though they're not related.  I think
 you're right. We should move all CodeMirror settings out of the Query 
 tool
 and move it to a new node - "SQL" may be. Editor and Auto-format would 
 be
 sub nodes under SQL. With that, the editor settings will apply at all 
 the
 places where CodeMirror editing is used(function body, query tool). 
 What do
 you say ?

>>>
>>> Turns out that's more work than I really have time for at the
>>> moment, because it means making the editors be able to handle automatic
>>> reloads of multiple preference sections. We can always think about 
>>> moving
>>> the formatting preferences into their own section later.
>>>
>>> In the meantime, this update to the patch does what was originally
>>> suggested and puts the options into a Query Tool -> SQL Formatting 
>>> section.
>>>
>> Cool.
>>
>>>
>>> Comments? Obviously docs will need updating too, once we're all
>>> happy with the basics.
>>>
>> It works nice. A shortcut and auto format only selected text would
>> be helpful.
>>
>
> Yeah, the shortcut crossed my mind. Any thoughts on what it could be?
> I was struggling to find something that made sense and wasn't used by
> Chrome or elsewhere.
>
 I can only find Shift+Cmd+K available.

>
> Formatting only the selected text might be troublesome; it may create
> some very strange results if a partial statement is selected.
>
 Formatter should not be blamed in that case. It did what was asked. :P

>>>
>>> *shrug*. OK. How's about this?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"