pgAdmin 4 commit: Fixed an issue where debugger doesn't work if the sea

[Akshay Joshi]

Fixed an issue where debugger doesn't work if the search path is set other than 
'public'. Fixes #4123

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd313f5fc8e7422759f85de84b7955f43715914
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_25.rst  |   1 +
.../servers/databases/extensions/__init__.py   |  32 +++---
.../servers/databases/extensions/utils.py  |  37 +++
web/pgadmin/tools/debugger/__init__.py | 111 +++--
.../debugger/sql/{v2 => v3}/abort_target.sql   |   0
.../debugger/sql/{v2 => v3}/add_breakpoint_edb.sql |   0
.../debugger/sql/{v2 => v3}/add_breakpoint_pg.sql  |   0
.../debugger/sql/{v2 => v3}/attach_to_port.sql |   0
.../debugger/sql/{v2 => v3}/clear_breakpoint.sql   |   0
.../templates/debugger/sql/{v2 => v3}/continue.sql |   0
.../debugger/sql/{v2 => v3}/create_listener.sql|   0
.../{v2 => v3}/debug_plpgsql_execute_target.sql|   0
.../debugger/sql/{v2 => v3}/debug_plpgsql_init.sql |   0
.../sql/{v2 => v3}/debug_spl_execute_target.sql|   0
.../debugger/sql/{v2 => v3}/debug_spl_init.sql |   0
.../debugger/sql/{v2 => v3}/deposit_value.sql  |   0
.../debugger/sql/{v2 => v3}/get_breakpoints.sql|   0
.../debugger/sql/{v2 => v3}/get_function_info.sql  |   0
.../debugger/sql/{v2 => v3}/get_stack_info.sql |   0
.../debugger/sql/{v2 => v3}/get_variables.sql  |   0
.../debugger/sql/{v2 => v3}/select_frame.sql   |   0
.../debugger/sql/{v2 => v3}/set_breakpoint.sql |   0
.../debugger/sql/{v2 => v3}/step_into.sql  |   0
.../debugger/sql/{v2 => v3}/step_over.sql  |   0
.../sql/{v2 => v3}/wait_for_breakpoint.sql |   0
.../debugger/sql/{v2 => v3}/wait_for_target.sql|   0
26 files changed, 133 insertions(+), 48 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to fix certain errors occurring when saving
preferences. This is the regression of patch committed.
Please review.

On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch will reduce cognitive complexity for functions as below:
>> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
>> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
>> web/pgadmin/setup/user_info.py - 22 to 15
>> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


sonarqube.cognitive.pref_fix.patch
Description: Binary data

pgAdmin 4 commit: Resolve schema diff dependencies by selecting the app

[Akshay Joshi]

Resolve schema diff dependencies by selecting the appropriate node 
automatically and maintain the order in the generated script. Fixes #5730

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b688cf949ee96e6552253bd4607e5f37d4d839c
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_4_25.rst  |   3 +-
web/pgadmin/tools/schema_diff/__init__.py  |  11 +
.../schema_diff/static/js/schema_diff.backform.js  |   1 +
.../static/js/schema_diff_dependency.js| 237 +
.../tools/schema_diff/static/js/schema_diff_ui.js  |  54 +++--
5 files changed, 292 insertions(+), 14 deletions(-)

pgAdmin 4 commit: Fixed errors occurring when saving preferences, regre

[Akshay Joshi]

Fixed errors occurring when saving preferences, regression of SonarQube fixes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=caeea7940adf5cc57b7634b3fab1b37ddf1f7b42
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/utils/preferences.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)

pgAdmin 4 commit: Fix PEP8

[Akshay Joshi]

Fix PEP8

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26506a9727add43d2462a4577ee885e9fe6145be

Modified Files
--
web/pgadmin/tools/schema_diff/__init__.py | 8 
1 file changed, 4 insertions(+), 4 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

[Akshay Joshi]

Thanks, patch applied.

On Wed, Aug 12, 2020 at 4:03 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix certain errors occurring when saving
> preferences. This is the regression of patch committed.
> Please review.
>
> On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch will reduce cognitive complexity for functions as below:
>>> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
>>> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
>>> web/pgadmin/setup/user_info.py - 22 to 15
>>> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: str never has attribute decode in py3

[Khushboo Vashi]

The patch looks good to me.

On Tue, Aug 11, 2020 at 9:42 PM Cyril Jouve  wrote:

>
>

pgAdmin 4 commit: The 'str' object never has attribute decode in Python

[Akshay Joshi]

The 'str' object never has attribute decode in Python3, so remove the dead code.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36574b25b697a1ee61fd5342755d5db1efec7306
Author: Cyril Jouve 

Modified Files
--
web/pgadmin/__init__.py|  3 -
web/pgadmin/about/__init__.py  |  3 -
.../browser/server_groups/servers/__init__.py  |  4 -
web/pgadmin/misc/file_manager/__init__.py  | 24 +-
web/pgadmin/tools/sqleditor/__init__.py| 18 +
web/pgadmin/utils/crypto.py| 13 +---
web/pgadmin/utils/driver/psycopg2/connection.py| 89 --
.../utils/driver/psycopg2/server_manager.py|  9 +--
web/pgadmin/utils/session.py   |  7 +-
9 files changed, 21 insertions(+), 149 deletions(-)

Re: str never has attribute decode in py3

[Akshay Joshi]

Thanks, patch applied.

On Wed, Aug 12, 2020 at 6:06 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> The patch looks good to me.
>
> On Tue, Aug 11, 2020 at 9:42 PM Cyril Jouve  wrote:
>
>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin4][Patch] - SonarQube Issues - 14 (String literals should not be duplicated, Cognitive Complexity of functions should not be too high)

[Yogesh Mahajan]

Hello,

Please find patch which fixes issues related to rule from feature test
modules -
1.String literals should not be duplicated - 3 issues
2.Cognitive Complexity of functions should not be too high - 10 issues

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix14_v1.patch
Description: Binary data

pgAdmin 4 commit: Upgrade font awesome from v4 to v5. Fixes #5731

[Akshay Joshi]

Upgrade font awesome from v4 to v5. Fixes #5731

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93adf6884f031ff0e02c60736d9d4588732fdd07
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_25.rst  |  1 +
web/package.json   |  4 ++--
.../servers/databases/schemas/views/static/js/mview.js |  4 ++--
.../servers/databases/static/js/database.js|  2 +-
.../browser/server_groups/servers/static/js/server.js  |  4 ++--
.../servers/tablespaces/static/js/tablespace.js|  2 +-
web/pgadmin/browser/static/js/browser.js   |  2 +-
web/pgadmin/browser/static/js/collection.js|  4 ++--
web/pgadmin/browser/static/js/node.js  | 10 +-
web/pgadmin/browser/static/js/node.ui.js   |  2 +-
web/pgadmin/browser/static/js/wizard.js|  2 +-
.../templates/dashboard/database_dashboard.html|  2 +-
.../templates/dashboard/server_dashboard.html  |  2 +-
web/pgadmin/help/__init__.py   |  4 ++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  4 ++--
web/pgadmin/misc/file_manager/static/js/utility.js | 12 ++--
.../file_manager/templates/file_manager/index.html |  6 +++---
web/pgadmin/misc/static/explain/js/explain.js  |  4 ++--
web/pgadmin/static/css/style.css   |  2 +-
web/pgadmin/static/js/backform.pgadmin.js  |  6 +++---
web/pgadmin/static/js/backgrid.pgadmin.js  |  6 +++---
.../static/js/sqleditor/history/query_sources.js   |  2 +-
web/pgadmin/static/js/sqleditor_utils.js   |  2 +-
web/pgadmin/static/scss/_aci_tree.overrides.scss   |  4 
web/pgadmin/static/scss/_alertify.overrides.scss   |  2 ++
web/pgadmin/static/scss/_backform.overrides.scss   |  1 +
web/pgadmin/static/scss/_bootstrap.overrides.scss  |  2 ++
web/pgadmin/static/scss/_codemirror.overrides.scss |  2 ++
web/pgadmin/static/scss/_pgadmin.style.scss| 18 ++
web/pgadmin/static/scss/_webcabin.pgadmin.scss |  1 +
.../static/scss/resources/_default.variables.scss  |  2 +-
web/pgadmin/tools/backup/static/js/backup.js   | 12 ++--
.../tools/datagrid/static/js/datagrid_panel_title.js   |  2 +-
.../tools/datagrid/templates/datagrid/index.html   | 12 ++--
.../tools/grant_wizard/static/js/grant_wizard.js   |  4 ++--
.../schema_diff/static/js/schema_diff.backform.js  |  2 +-
.../tools/schema_diff/static/scss/_schema_diff.scss|  3 +++
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  2 +-
.../tools/sqleditor/static/scss/_sqleditor.scss|  2 ++
web/regression/feature_utils/locators.py   |  4 ++--
web/yarn.lock  | 16 
41 files changed, 108 insertions(+), 72 deletions(-)