[pgAdmin][Patch] - Bug #5567 - Conversion of bytea to binary string representation works in psql but results in error in pgadmin

[Yogesh Mahajan]

Hello,

Please find a patch which fixes the output for bytea type data.Patch
defaults 'bytea_output' to 'hex' format.


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5567_v1.patch
Description: Binary data

pgAdmin 4 commit: Fixed an issue where conversion of bytea to the binar

[Akshay Joshi]

Fixed an issue where conversion of bytea to the binary string results in an 
error. Fixes #5567

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f70385a4ecb660618d7bdc8f0128592a694c41d
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_4_25.rst   | 1 +
web/pgadmin/utils/driver/psycopg2/connection.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

[Akshay Joshi]

Fixed cognitive complexity issues reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8129df42da8a355a89f2c7213389d469eeac5a90
Author: Aditya Toshniwal 

Modified Files
--
.../servers/pgagent/schedules/__init__.py  |  16 +--
.../servers/pgagent/steps/__init__.py  |  81 ++--
web/pgadmin/dashboard/__init__.py  |  51 +++-
web/pgadmin/setup/user_info.py |  97 +++---
web/pgadmin/utils/preferences.py   | 142 +
5 files changed, 175 insertions(+), 212 deletions(-)

pgAdmin 4 commit: Fixed following schema diff issues:

[Akshay Joshi]

Fixed following schema diff issues:
  1) Wrong SQL generated for the columns having different data type.
  2) Added 'castfunc' in the ignore list.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=082b968bbcec2abde196278e111987147ad2fa72

Modified Files
--
web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py   | 2 +-
.../databases/schemas/tables/templates/columns/sql/10_plus/update.sql   | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

[Akshay Joshi]

Thanks, patch applied.

On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch will reduce cognitive complexity for functions as below:
> web/.../servers/pgagent/schedules/__init__.py - 17 to 15
> web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
> web/pgadmin/setup/user_info.py - 22 to 15
> web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][Patch] - Bug #5567 - Conversion of bytea to binary string representation works in psql but results in error in pgadmin

[Akshay Joshi]

Thanks, patch applied.

On Tue, Aug 11, 2020 at 2:40 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hello,
>
> Please find a patch which fixes the output for bytea type data.Patch
> defaults 'bytea_output' to 'hex' format.
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: pgAdmin debugger failure when search_path set

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch for RM4123, where debugger doesn't work if the search
path is set other than public(where the debugger extension is installed).
Now the schema public is appended to the existing search path and it will
now work no matter what the search path is.
I've also renamed the directory "v2" in templates to "v3". Reason being,
the directory is used for debugger version 3 and above.

Please review.

On Tue, Aug 11, 2020 at 12:17 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Akshay,
>
> On Tue, Aug 11, 2020 at 12:13 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> On Thu, Aug 6, 2020 at 4:48 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave/Team,
>>>
>>> I've been working on an issue to make debugger work no matter what the
>>> search patch is set. I've managed to call the appropriate functions from
>>> pgAdmin using a schema qualified name with no issues. However, the internal
>>> calls in the function don't look schema qualified.
>>> For instance,
>>> I have two schemas "public" where the debugger is installed and "other"
>>> where my user defined function is. I set the search_path to "other" on the
>>> database. Calling plpgsql_oid_debug directly fails because of the search
>>> path set, but I can call the debugger functions with
>>> public.plpgsql_oid_debug, but it fails with:
>>> ERROR: function pldbg_oid_debug(oid) does not exist LINE 1: SELECT
>>> pldbg_oid_debug($1) ^ HINT: No function matches the given name and argument
>>> types. You might need to add explicit type casts. QUERY: SELECT
>>> pldbg_oid_debug($1) CONTEXT: SQL function "plpgsql_oid_debug" during
>>> inlining
>>>
>>> How to approach this ? It is inconvenient for users to remove their
>>> search_path to make debugger work.
>>>
>>
>> To solve the above problem I would suggest, get the existing search
>> path and append *'public' *in that and set it only for the Debugger
>> session and reset back when a debugger is closed.
>>
> Good idea !! I'll give a try.
>
>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM4123.patch
Description: Binary data

str never has attribute decode in py3

[Cyril Jouve]

0001-str-never-has-attribute-decode.patch
Description: Binary data