Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

[Rahul Shirsat]

Hi Akshay,

A syntactical error in a jinja template caught yesterday in Yogesh's local
setup of pgAdmin by running a test suite for the changes done in this RM.
It's strange going through several testings, even on Jenkins, it passed but
failed on Yogesh's machine.

I have made changes for this issue and rechecked with Yogesh, which seems
to be fixed now.

Could you please apply these relevant changes for this RM?

On Wed, Jul 29, 2020 at 6:31 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Ignore the previous patch. Find below the rebased patch.
>>
>> On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch below which fixes the issue of Start value while
>>> updating the identity column.
>>>
>>> *Some additional issues were also found during development, which are
>>> too fixed now :*
>>>
>>>
>>>1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence
>>>options, it only updates identity* - *Fixed*
>>>2. *Cycled option issue - **Fixed*
>>>Steps to reproduce :
>>>- Update cycled to Yes, save it.
>>>- Now change it to No, trying saving, gives error.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


RM5632_v3.patch
Description: Binary data

[pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects

[Satish V]

Hi Hackers,

Please find the patch which improves the code coverage for Schema alone.
Kindly create another RM for the Catalog Objects. Please review the patch.

Thanks,
Sathish V


RM5327v1.patch
Description: Binary data

Re: WIP: SQL Formatter

[Dave Page]

Hi

Currently, all the CodeMirrors in pgAdmin use the settings from the Query
> tool -> Editor, even though they're not related.  I think you're right.
> We should move all CodeMirror settings out of the Query tool and move it to
> a new node - "SQL" may be. Editor and Auto-format would be sub nodes under
> SQL. With that, the editor settings will apply at all the places where
> CodeMirror editing is used(function body, query tool). What do you say ?
>

Turns out that's more work than I really have time for at the moment,
because it means making the editors be able to handle automatic reloads of
multiple preference sections. We can always think about moving the
formatting preferences into their own section later.

In the meantime, this update to the patch does what was originally
suggested and puts the options into a Query Tool -> SQL Formatting section.

Comments? Obviously docs will need updating too, once we're all happy with
the basics.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com


SQL_Formatting_v2.diff
Description: Binary data

Patch for SonarQube code scan fixes.

[Nikhil Mohite]

Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. Utils Route:

   - Refactor this function to reduce its Cognitive Complexity from 16 to
   the 15 allowed.

2. User Management:

   - Refactor this function to reduce its Cognitive Complexity from 16 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 18 to
   the 15 allowed.

3. Query tool preferences:

   - Merge these implicitly concatenated strings; or did you forget a comma?

4. Tool Maintenance:

   - Refactor this function to reduce its Cognitive Complexity from 16 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 20 to
   the 15 allowed.


Regards,
Nikhil Mohite.


SonarQubeCodeSmellFixes.patch
Description: Binary data