pgAdmin 4 commit: Make the runtime configuration dialog non-modal. Fixe

[Akshay Joshi]

Make the runtime configuration dialog non-modal. Fixes #5490
Major refactoring of the runtime code, Specifically:
  - Move the bulk of the core code from main() into a new Runtime class.
  - Break up the mass of code that was main() into a number of relatively 
simple functions.
  - Make the Configuration dialog synchronous so the Log dialog can be properly 
viewed.
  - Enable/disable menu options at the right time.
  - Remove support for Qt < 5.0.
  - Remove the application name constant and hardcode the name to simplify the 
code.
  - Improve log messages.
  - Replace the sdbm hashing with Qt's MD5 hashing.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46ba0310fa9897a1cbd17a8eeb9df097fdb12d12
Author: Dave Page 

Modified Files
--
docs/en_US/release_notes_4_25.rst |   1 +
runtime/ConfigWindow.cpp  |  59 ++--
runtime/ConfigWindow.h|   9 +-
runtime/ConfigWindow.ui   |   2 +-
runtime/FloatingWindow.cpp|  34 ++-
runtime/FloatingWindow.h  |   4 +-
runtime/FloatingWindow.ui |   2 +-
runtime/LogWindow.cpp |  18 +-
runtime/LogWindow.h   |   5 +-
runtime/LogWindow.ui  |   2 +-
runtime/Logger.cpp|   9 +-
runtime/Logger.h  |   1 -
runtime/MenuActions.cpp   |  46 +--
runtime/MenuActions.h |   9 +-
runtime/Runtime.cpp   | 605 ++
runtime/Runtime.h |  65 
runtime/Server.cpp|  17 +-
runtime/Server.h  |  10 +-
runtime/TrayIcon.cpp  |  31 +-
runtime/TrayIcon.h|   7 +-
runtime/pgAdmin4.cpp  | 541 +++---
runtime/pgAdmin4.h|  31 +-
runtime/pgAdmin4.pro  |  18 +-
23 files changed, 878 insertions(+), 648 deletions(-)

pgAdmin 4 commit: Fixed code smell 'variable shadows a builtin' reporte

[Akshay Joshi]

Fixed code smell 'variable shadows a builtin' reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0893fe43bb86dd8ab4a3b0730ec2c342a5a2810
Author: Aditya Toshniwal 

Modified Files
--
pkg/mac/dmg-license.py |   7 +-
.../servers/databases/schemas/types/__init__.py|   8 +-
web/pgadmin/misc/bgprocess/processes.py|   8 +-
web/pgadmin/misc/file_manager/__init__.py  | 122 ++---
web/regression/python_test_utils/test_utils.py |   3 +-
5 files changed, 74 insertions(+), 74 deletions(-)

Re: [pgAdmin][SonarQube] Rule - variable shadows a builtin

[Akshay Joshi]

Thanks, patch applied.

On Tue, Jul 28, 2020 at 10:51 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to rename all the variables which shadows any python
> builtin.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Runtime refactoring

[Akshay Joshi]

Thanks, patch applied with some fixes. I'll work on the SonarQube code
smell and commit them later.

On Mon, Jul 27, 2020 at 5:55 PM Dave Page  wrote:

> Hi Akshay,
>
> Updated patch attached.
>
> Thanks.
>
> On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> The patch is not applied, can you please rebase and send again.
>>
>> On Fri, Jul 17, 2020 at 3:40 PM Dave Page  wrote:
>>
>>> BTW, this will fix https://redmine.postgresql.org/issues/5490
>>>
>>> On Thu, Jul 16, 2020 at 10:41 AM Dave Page  wrote:
>>>
 Here's a pretty large patch that implements a major refactoring of the
 runtime code. Specifically:

 - Move the bulk of the core code from main() into a new Runtime class.
 - Break up the mass of code that was main() into a number of relatively
 simple functions.
 - Make the Configuration dialog synchronous so the Log dialog can be
 properly viewed.
 - Enable/disable menu options at the right time.
 - Remove support for Qt < 5.0.
 - Remove the application name constant and hardcode the name to
 simplify the code.
 - Improve log messages.
 - Replace the sdbm hashing with Qt's MD5 hashing.

 Please review & test, but do not commit before next week's release.

 Thanks!

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EDB: http://www.enterprisedb.com


>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Runtime refactoring

[Akshay Joshi]

Hi Dave/Hackers,

Attached is the patch to fix newly introduce SoanrQube code smells. Please
review it.

On Tue, Jul 28, 2020 at 4:22 PM Akshay Joshi 
wrote:

> Thanks, patch applied with some fixes. I'll work on the SonarQube code
> smell and commit them later.
>
> On Mon, Jul 27, 2020 at 5:55 PM Dave Page  wrote:
>
>> Hi Akshay,
>>
>> Updated patch attached.
>>
>> Thanks.
>>
>> On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Dave
>>>
>>> The patch is not applied, can you please rebase and send again.
>>>
>>> On Fri, Jul 17, 2020 at 3:40 PM Dave Page  wrote:
>>>
 BTW, this will fix https://redmine.postgresql.org/issues/5490

 On Thu, Jul 16, 2020 at 10:41 AM Dave Page  wrote:

> Here's a pretty large patch that implements a major refactoring of the
> runtime code. Specifically:
>
> - Move the bulk of the core code from main() into a new Runtime class.
> - Break up the mass of code that was main() into a number of
> relatively simple functions.
> - Make the Configuration dialog synchronous so the Log dialog can be
> properly viewed.
> - Enable/disable menu options at the right time.
> - Remove support for Qt < 5.0.
> - Remove the application name constant and hardcode the name to
> simplify the code.
> - Improve log messages.
> - Replace the sdbm hashing with Qt's MD5 hashing.
>
> Please review & test, but do not commit before next week's release.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EDB: http://www.enterprisedb.com


>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Runtime_SonarQube_Fixes.patch
Description: Binary data