pgAdmin 4 v4.24 released

[Akshay Joshi]

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.24.
This release of pgAdmin 4 includes 34 bug fixes and new features. For more
details please see the release notes at:

https://www.pgadmin.org/docs/pgadmin4/4.24/release_notes_4_24.html.

pgAdmin is the leading Open Source graphical management tool for
PostgreSQL. For more information, please see:

https://www.pgadmin.org/

Notable changes in this release include:

   - Support configuration files that are external to the application
   installation.
   - Added support for LDAP authentication with different DN by setting the
   dedicated user for the LDAP connection.
   - Added support for schema level restriction.
   - Added RLS Policy support in Schema Diff.
   - Added support for permissive/restricted policy type while creating RLS
   Policy.
   - Added support for LDAP anonymous binding.
   - Added High Contrast theme support.
   - Added missing dependencies/dependent and corrected some wrongly
   identified.
   - Replace the runtime themes with ones that don't have sizing issues.
   - Fixed tab indent issue on a selection of lines is deleting the content
   when 'use spaces == true' in the preferences.
   - Fixed CSRF errors when pgAdmin opened in an iframe on the safari
   browser.


Builds for Windows and macOS are available now, along with a Python Wheel,
Docker Container, RPM, DEB Package, and source code tarball from:

https://www.pgadmin.org/download/

--
Akshay Joshi
pgAdmin Project

pgAdmin 4 commit: Tag REL-4_24 has been created.

[Akshay Joshi]

Tag REL-4_24 has been created.
View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_24

Log Message
---
Tag v4.24

Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

[Dave Page]

Very nice. One quick issue that I immediately saw - if the dashboard is not
the top-most tab when pgAdmin opens, then when you've selected something on
the treeview and then click on the dashboard tab, the graphs don't populate
until you select a different object.

I'll play some more tomorrow when I have more time.

Thanks!


On Thu, Jul 23, 2020 at 11:58 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to:
> 1) Replace the chart library with Chart.js + ReactJS.
> 2) Add support for ReactJS in pgAdmin with webpack, package.json, linter
> and other changes.
> 3) Add support for testing React components with jasmine test cases. Test
> cases added.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

pgAdmin 4 commit: Fixed code smell 'Unused local variables should be re

[Akshay Joshi]

Fixed code smell 'Unused local variables should be removed'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd27e08a98c1564431d5464bc52687935b897474
Author: Yogesh Mahajan 

Modified Files
--
tools/copyright_updater.py | 2 +-
tools/dependency_inventory.py  | 2 +-
tools/get_chromedriver.py  | 4 ++--
web/pgadmin/browser/__init__.py| 2 +-
web/pgadmin/browser/server_groups/servers/databases/__init__.py| 1 -
web/pgadmin/browser/utils.py   | 2 +-
web/pgadmin/feature_tests/pg_utilities_backup_restore_test.py  | 2 +-
web/pgadmin/feature_tests/query_tool_tests.py  | 2 +-
web/pgadmin/feature_tests/xss_checks_panels_and_query_tool_test.py | 2 +-
web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py  | 2 +-
web/pgadmin/utils/csv.py   | 2 +-
web/regression/feature_utils/app_starter.py| 2 +-
web/regression/feature_utils/pgadmin_page.py   | 4 ++--
web/regression/python_test_utils/test_utils.py | 3 ++-
14 files changed, 16 insertions(+), 16 deletions(-)

Re: [pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)

[Akshay Joshi]

Thanks, patch applied.

On Wed, Jul 22, 2020 at 5:42 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hello,
>
> Please find an attached patch fixing 17 sonarqube issues related to below
> rule -
>  - Unused local variables should be removed.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Fixed cognitive complexity issues reported by Sona

[Akshay Joshi]

1) Fixed cognitive complexity issues reported by SonarQube.
2) Fixed code smell 'Add a nested comment explaining why this method is
   empty, or complete the implementation'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=505a3ac960400025e4fea6e725c570c2a62af8a6
Author: Aditya Toshniwal 

Modified Files
--
web/migrations/script.py.mako  |   1 +
web/migrations/versions/02b9dccdcfcb_.py   |   2 +
web/migrations/versions/09d53fca90c7_.py   |   8 +-
web/migrations/versions/35f29b1701bd_.py   |   1 +
web/migrations/versions/3c1e4b6eda55_.py   |   1 +
web/migrations/versions/493cd3e39c0c_.py   |   1 +
web/migrations/versions/50aad68f99c2_.py   |   2 +
web/migrations/versions/7c56ea250085_.py   |   2 +
web/migrations/versions/7fedf8531802_.py   |   1 +
web/migrations/versions/84700139beb0_.py   |   1 +
web/migrations/versions/a68b374fe373_.py   |   2 +
web/migrations/versions/a77a0932a568_.py   |   1 +
web/migrations/versions/aa86fb60b73d_.py   |   1 +
web/migrations/versions/aff1436e3c8c_.py   |   1 +
web/migrations/versions/b5b87fdfcb30_.py   |   1 +
web/migrations/versions/ca00ec32581b_.py   |   1 +
web/migrations/versions/d39482714a2e_.py   |   2 +
web/migrations/versions/d85a62333272_.py   |   1 +
web/migrations/versions/ec1cac3399c9_.py   |   1 +
web/migrations/versions/ece2e76bf60e_.py   |   1 +
web/migrations/versions/ef590e979b0d_.py   |   1 +
web/migrations/versions/f195f9a4923d_.py   |   1 +
.../constraints/exclusion_constraint/__init__.py   |  86 +---
.../servers/databases/schemas/utils.py |  16 +-
web/pgadmin/misc/bgprocess/process_executor.py |   2 +-
web/pgadmin/tools/debugger/__init__.py | 245 +++--
web/pgadmin/tools/grant_wizard/__init__.py |   6 +-
web/pgadmin/utils/__init__.py  |   1 +
web/regression/feature_utils/base_feature_test.py  |   3 +
.../python_test_utils/sql_template_test_base.py|   3 +
web/regression/runtests.py |   1 +
31 files changed, 220 insertions(+), 177 deletions(-)

Re: [pgAdmin][SonarQube] Complete the implementation of empty methods

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 23, 2020 at 11:41 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to close all the 32 SonarQube issues under the rule
> - "Add a nested comment explaining why this method is empty, or complete
> the implementation."
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

[Akshay Joshi]

Fixed cognitive complexity issues reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fbf298d30acef69b98f11b6d711ad5ff38587fa
Author: Nikhil Mohite 

Modified Files
--
.../tables/constraints/foreign_key/utils.py| 163 ++---
.../databases/schemas/tables/rules/__init__.py |  38 ++-
.../databases/schemas/tables/triggers/__init__.py  |   3 +-
.../databases/schemas/tables/triggers/utils.py |  83 +++--
.../servers/databases/schemas/views/__init__.py| 363 +
.../server_groups/servers/databases/utils.py   |  45 ++-
6 files changed, 437 insertions(+), 258 deletions(-)

Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions

[Akshay Joshi]

Thanks, patch applied.

On Mon, Jul 20, 2020 at 12:25 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to reduce cognitive complexity of functions:
> 1) web/.../exclusion_constraint/__init__.py > create > from 25 to 15
> 2) web/.../exclusion_constraint/__init__.py > sql > from 19 to 15
> 3) web/.../databases/schemas/utils.py > parse_vacuum_data > from 18 to 15
> 4) web/.../tools/debugger/__init__.py > initialize_target > from 37 to 15
> 5) web/.../tools/debugger/__init__.py > execute_debugger_query > from 22
> to 15
> 6) web/.../tools/debugger/__init__.py > messages > from 16 to 15
> Please review.
>
> --
> Regards,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: Patch for SonarQube code scan fixes.

[Akshay Joshi]

Thanks, patch applied.

On Tue, Jul 21, 2020 at 10:45 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
> 1. Database utils:
>
>- Refactor this function to reduce its Cognitive Complexity from 27 to
>the 15 allowed.
>
> 2. Schema views:
>
>- Refactor this function to reduce its Cognitive Complexity from 23 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 72 to
>the 15 allowed.
>
> 3. Foreign key utils:
>
>- Refactor this function to reduce its Cognitive Complexity from 39 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 18 to
>the 15 allowed.
>
> 4. Rules init:
>
>- Refactor this function to reduce its Cognitive Complexity from 20 to
>the 15 allowed.
>
> 5. Trigger init and utils:
>
>- Refactor this function to reduce its Cognitive Complexity from 16 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 34 to
>the 15 allowed.
>
>
> Regards,
> Nikhil Mohite.
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*