Re: [pgAdmin][RM5666]: Added missing dependencies/dependent node
Hi, I'll be reviewing the patch. On Tue, Jul 14, 2020 at 12:46 PM Akshay Joshi wrote: > Hi Hackers > > Attached is the patch to add missing dependencies/dependent nodes > > Added following missing nodes: > >- Materialized View >- Event Trigger >- Collation >- FTS Configuration, FTS Dictionary, FTS Parser, FTS Template, >- RLS Policy >- Extension >- Synonyms (EPAS) >- Packages (EPAS) >- Compound Trigger (EPAS) > > Following bugs fixed with this patch: > >- Foreign Table is interpreted as a Foreign Data Wrapper. >- Domain is interpreted as a type. >- Domain constraint is interpreted as a check constraint. >- Partitioned Table is interpreted as a Partition. >- Trigger function is interpreted as a function in the >dependencies tab for Event Triggers. >- Procedure interpreted as a Function. > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Improve code coverage and API test cases for Foreign
Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a91e4d8a7f4c980f8ee63c9801e0f7d672439879 Author: Satish V Modified Files -- docs/en_US/release_notes_4_24.rst | 1 + .../foreign_data_wrappers/tests/fdw_test_data.json | 409 + .../foreign_data_wrappers/tests/test_fdw_add.py| 47 ++- .../foreign_data_wrappers/tests/test_fdw_delete.py | 51 ++- .../tests/test_fdw_delete_multiple.py | 30 +- .../tests/test_fdw_dependency_dependent.py | 77 .../tests/test_fdw_get-handlers.py | 83 + .../foreign_data_wrappers/tests/test_fdw_get.py| 61 ++- .../tests/test_fdw_get_nodes.py| 105 ++ .../tests/test_fdw_get_validators.py | 81 .../foreign_data_wrappers/tests/test_fdw_msql.py | 72 .../foreign_data_wrappers/tests/test_fdw_put.py| 46 ++- .../foreign_data_wrappers/tests/test_fdw_sql.py| 82 + .../databases/foreign_data_wrappers/tests/utils.py | 9 +- 14 files changed, 1088 insertions(+), 66 deletions(-)
pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu
Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0013a3b047f7a4c77c29ad1ee7083b5bc120e17c Author: Nikhil Mohite Modified Files -- .../servers/databases/schemas/tables/__init__.py | 137 ++-- .../databases/schemas/tables/indexes/__init__.py | 7 +- .../servers/databases/schemas/tables/utils.py | 868 - 3 files changed, 567 insertions(+), 445 deletions(-)
pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.
Fixed code smell 'Variables should not be shadowed'. Fixed all the duplicate CSS blocks issues raised by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=161c9b0fc7455c5d9619b7feac94dd3f1755cc09 Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/js/node.js | 127 ++--- web/pgadmin/static/js/pgadmin.js | 58 +- web/pgadmin/static/scss/_alertify.overrides.scss | 5 +- web/pgadmin/static/scss/_backgrid.overrides.scss | 16 +-- web/pgadmin/static/scss/_bootstrap.overrides.scss | 18 +-- web/pgadmin/static/scss/_codemirror.overrides.scss | 7 -- web/pgadmin/static/scss/_pgadmin.style.scss| 37 +++--- web/pgadmin/static/scss/_webcabin.pgadmin.scss | 4 - .../schema_diff/static/scss/_schema_diff.scss | 7 +- .../tools/sqleditor/static/css/sqleditor.css | 4 - .../user_management/static/css/user_management.css | 0 11 files changed, 118 insertions(+), 165 deletions(-)
Re: Patch for SonarQube code scan fixes
Thanks, patch applied. I have changed the function name from "def _get_reverse_engineered_sql_for_" to "def _get_resql_for_", because function name is too long. On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table file(utils): > >- Refactor this function to reduce its Cognitive Complexity from 39 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 122 >to the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 58 to >the 15 allowed. > > 2. Table init file: > >- Refactor this function to reduce its Cognitive Complexity from 24 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 22 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 18 to >the 15 allowed. > > > > Regards, > Nikhil Mohite. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Re-[pgAdmin][RM-5323]
Thanks, patch applied. On Mon, Jul 13, 2020 at 7:26 PM Satish V wrote: > Hi Hackers, > > Please find the patch which improves the API test cases for Foreign Data > Wrappers. > > Before patch - 46% > After Patch - 73% > Kindly review and share the changes if required. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][SonarQube] Shadowing variables
Thanks, patch applied. On Mon, Jul 13, 2020 at 10:15 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the SonarQube reported issues (40+) > which potentially hides a variable declared in an outer scope. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][SonarQube] Duplicate CSS blocks
Thanks, patch applied. On Tue, Jul 14, 2020 at 10:27 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix all the duplicate CSS blocks issues raised by > SonarQube. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - SonarQube Fixes
Hi, Please find the more fixes for the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". Thanks, Khushboo On Fri, Jul 3, 2020 at 2:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the SonarQube Code smells having >> Rule "*Functions, methods and lambdas should not have too many >> parameters*". >> >> In this patch, I have covered sql and delete functions of all the >> reported nodes. >> >> Thanks, >> Khushboo >> >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > Sonar_Qube_Fixes.patch Description: Binary data
pgAdmin 4 commit: Fixed code smell 'Functions, methods, and lambdas sho
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd9dc97b4f1373687be9f2eeb105fb4451447680 Author: Khushboo Vashi Modified Files -- web/pgadmin/utils/csv.py | 18 +++--- web/pgadmin/utils/menu.py| 23 +- web/pgadmin/utils/preferences.py | 52 3 files changed, 52 insertions(+), 41 deletions(-)
pgAdmin 4 commit: Fixed reverse engineered SQL for partitions when stor
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6893f9d8a1a4aed95daf20664e4af3655692a11 Author: Rahul Shirsat Modified Files -- docs/en_US/release_notes_4_24.rst | 1 + .../servers/databases/schemas/tables/__init__.py | 37 +- .../schemas/tables/partitions/__init__.py | 66 +- .../tables/partitions/static/js/partition.js | 10 ++ .../tests/pg/10_plus/alter_table_add_partition.sql | 26 .../pg/10_plus/alter_table_add_partition_msql.sql | 2 + .../pg/10_plus/create_table_with_partition.sql | 18 +++ .../10_plus/create_table_with_partition_msql.sql | 13 ++ .../tests/pg/10_plus/test_partitions.json | 139 + .../tests/pg/12_plus/alter_table_add_partition.sql | 22 .../pg/12_plus/alter_table_add_partition_msql.sql | 2 + .../pg/12_plus/create_table_with_partition.sql | 14 +++ .../12_plus/create_table_with_partition_msql.sql | 10 ++ .../tests/pg/12_plus/test_partitions.json | 139 + .../ppas/10_plus/alter_table_add_partition.sql | 26 .../10_plus/alter_table_add_partition_msql.sql | 2 + .../ppas/10_plus/create_table_with_partition.sql | 18 +++ .../10_plus/create_table_with_partition_msql.sql | 13 ++ .../tests/ppas/10_plus/test_partitions.json| 139 + .../ppas/12_plus/alter_table_add_partition.sql | 22 .../12_plus/alter_table_add_partition_msql.sql | 2 + .../ppas/12_plus/create_table_with_partition.sql | 14 +++ .../12_plus/create_table_with_partition_msql.sql | 10 ++ .../tests/ppas/12_plus/test_partitions.json| 139 + .../partitions/sql/gpdb/5_plus/properties.sql | 6 +- .../templates/partitions/sql/pg/10_plus/create.sql | 32 ++--- .../templates/partitions/sql/pg/10_plus/nodes.sql | 29 - .../partitions/sql/pg/10_plus/properties.sql | 6 +- .../partitions/sql/pg/12_plus/properties.sql | 6 +- .../partitions/sql/ppas/10_plus/create.sql | 29 ++--- .../partitions/sql/ppas/10_plus/nodes.sql | 29 - .../partitions/sql/ppas/10_plus/properties.sql | 6 +- .../partitions/sql/ppas/12_plus/properties.sql | 6 +- .../tables/templates/tables/sql/10_plus/create.sql | 2 +- .../tables/templates/tables/sql/11_plus/create.sql | 2 +- .../tables/templates/tables/sql/12_plus/create.sql | 2 +- .../servers/databases/schemas/tables/utils.py | 101 ++- 37 files changed, 1019 insertions(+), 121 deletions(-)
pgAdmin 4 commit: Added missing dependencies/dependent and corrected so
Added missing dependencies/dependent and corrected some wrongly identified.
Fixes #5666
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f34bc0f0eb4ed33cb010055c0fe02c892b10631
Modified Files
--
docs/en_US/release_notes_4_24.rst | 1 +
.../{sql/9.1_plus => gpdb/5_plus}/dependencies.sql | 48 +--
.../templates/depends/gpdb/5_plus/dependents.sql | 73 +++
.../default => gpdb/5_plus}/role_dependencies.sql | 0
.../templates/depends/pg/11_plus/dependencies.sql | 75 +++
.../templates/depends/pg/11_plus/dependents.sql| 75 +++
.../templates/depends/pg/12_plus/dependencies.sql | 75 +++
.../templates/depends/pg/12_plus/dependents.sql| 75 +++
.../{sql/12_plus => pg/9.1_plus}/dependencies.sql | 50 +--
.../templates/depends/pg/9.1_plus/dependents.sql | 73 +++
.../depends/pg/9.1_plus/role_dependencies.sql | 4 +
.../templates/depends/pg/9.5_plus/dependencies.sql | 75 +++
.../templates/depends/pg/9.5_plus/dependents.sql | 75 +++
.../depends/ppas/11_plus/dependencies.sql | 79
.../templates/depends/ppas/11_plus/dependents.sql | 79
.../depends/ppas/12_plus/dependencies.sql | 79
.../templates/depends/ppas/12_plus/dependents.sql | 79
.../depends/ppas/9.1_plus/dependencies.sql | 77 +++
.../templates/depends/ppas/9.1_plus/dependents.sql | 77 +++
.../depends/ppas/9.1_plus/role_dependencies.sql| 4 +
.../depends/ppas/9.5_plus/dependencies.sql | 79
.../templates/depends/ppas/9.5_plus/dependents.sql | 79
.../templates/depends/sql/12_plus/dependents.sql | 50 ---
.../templates/depends/sql/9.1_plus/dependents.sql | 50 ---
.../templates/depends/sql/default/dependencies.sql | 48 ---
.../templates/depends/sql/default/dependents.sql | 47 ---
.../servers/tests/test_dependencies_sql.py | 2 +-
.../servers/tests/test_dependents_sql.py | 2 +-
.../servers/tests/test_role_dependencies_sql.py| 16 +--
web/pgadmin/browser/utils.py | 143 ++---
.../misc/dependencies/static/js/dependencies.js| 2 +-
.../misc/dependents/static/js/dependents.js| 2 +-
32 files changed, 1386 insertions(+), 307 deletions(-)
Re: [pgAdmin4][Patch] - SonarQube Fixes
Thanks, patch applied. On Tue, Jul 14, 2020 at 6:34 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the more fixes for the SonarQube Code smells having Rule > "*Functions, > methods and lambdas should not have too many parameters*". > > Thanks, > Khushboo > > > On Fri, Jul 3, 2020 at 2:40 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the SonarQube Code smells having >>> Rule "*Functions, methods and lambdas should not have too many >>> parameters*". >>> >>> In this patch, I have covered sql and delete functions of all the >>> reported nodes. >>> >>> Thanks, >>> Khushboo >>> >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin4][Patch] - SonarQube Fixes
Hi Hackers, Please find the patch which fixes sonarQube issues related to variable shadowing. Files altered - backgird.js, backgrid.pgadmin.js Kindly review and share your feedback. Thanks, Sathish V variableShadowing.patch Description: Binary data
