pgAdmin 4 commit: Refactor config loading/saving for the runtime config
Refactor config loading/saving for the runtime config dialog to avoid code duplication. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ac656c63856efb8154d68e6f0c92185fd0903a2 Author: Dave Page Modified Files -- runtime/ConfigWindow.cpp | 86 +--- runtime/ConfigWindow.h | 15 ++--- runtime/MenuActions.cpp | 30 ++--- runtime/pgAdmin4.cpp | 25 ++ 4 files changed, 43 insertions(+), 113 deletions(-)
pgAdmin 4 commit: Use QStandardPaths::AppLocalDataLocation in the runti
Use QStandardPaths::AppLocalDataLocation in the runtime to determine where to store runtime logs. Fixes #5414 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6855ac1d5eb670b36cbf758908b7e1f15cfc84ba Author: Dave Page Modified Files -- docs/en_US/release_notes_4_24.rst | 1 + runtime/LogWindow.cpp | 7 ++- runtime/Logger.cpp| 2 +- runtime/pgAdmin4.cpp | 7 --- 4 files changed, 12 insertions(+), 5 deletions(-)
pgAdmin 4 commit: Use ISO8601 date format in the runtime startup log.
Use ISO8601 date format in the runtime startup log. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd38fed6e08399413dfc087cd129466f1a10b51e Author: Dave Page Modified Files -- runtime/Logger.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Re: RM5414 - Runtime paths
Thanks, patch applied. On Fri, Jul 10, 2020 at 7:37 PM Dave Page wrote: > The attached patch changes the runtime to > use QStandardPaths::AppLocalDataLocation as the directory for the startup > and server logs, instead of $HOME. This should conform to platform > standards (XDG, in the case of Linux). The actual filenames are now > displayed on the log viewer for convenience. > > Please review/commit. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed reverse engineered SQL for partitions when stor
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29175d7ec4259514486056aa1bb89a9513598912 Author: Rahul Shirsat Modified Files -- docs/en_US/release_notes_4_24.rst | 1 + .../servers/databases/schemas/tables/__init__.py | 37 +- .../schemas/tables/partitions/__init__.py | 66 +- .../tables/partitions/static/js/partition.js | 10 ++ .../tests/pg/10_plus/alter_table_add_partition.sql | 23 .../pg/10_plus/alter_table_add_partition_msql.sql | 2 + .../pg/10_plus/create_table_with_partition.sql | 18 +++ .../10_plus/create_table_with_partition_msql.sql | 13 ++ .../tests/pg/10_plus/test_partitions.json | 139 + .../tests/pg/11_plus/alter_table_add_partition.sql | 19 +++ .../pg/11_plus/alter_table_add_partition_msql.sql | 2 + .../pg/11_plus/create_table_with_partition.sql | 14 +++ .../11_plus/create_table_with_partition_msql.sql | 10 ++ .../tests/pg/11_plus/test_partitions.json | 139 + .../partitions/sql/gpdb/5_plus/properties.sql | 6 +- .../templates/partitions/sql/pg/10_plus/create.sql | 32 ++--- .../templates/partitions/sql/pg/10_plus/nodes.sql | 28 - .../partitions/sql/pg/10_plus/properties.sql | 6 +- .../partitions/sql/pg/12_plus/properties.sql | 6 +- .../partitions/sql/ppas/10_plus/create.sql | 27 ++-- .../partitions/sql/ppas/10_plus/properties.sql | 6 +- .../partitions/sql/ppas/12_plus/properties.sql | 6 +- .../tables/templates/tables/sql/10_plus/create.sql | 2 +- .../servers/databases/schemas/tables/utils.py | 94 ++ 24 files changed, 591 insertions(+), 115 deletions(-)
pgAdmin 4 commit: Refactor server request code by removing some duplica
Refactor server request code by removing some duplicated code in the runtime and improves some of the debug logs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6edf400486544951e4f177d0cbe277ed61ff129 Author: Dave Page Modified Files -- runtime/pgAdmin4.cpp | 77 runtime/pgAdmin4.h | 7 +++-- 2 files changed, 27 insertions(+), 57 deletions(-)
Re: Refactor server request code in the runtime
Thanks, patch applied. On Fri, Jul 10, 2020 at 9:17 PM Dave Page wrote: > The attached patch removes some duplicated code in the runtime and > improves some of the debug logging, all around making requests to the > Python APIs. > > Please review/commit. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Use ISO date format in the runtime startup log
Thanks, patch applied. On Fri, Jul 10, 2020 at 8:39 PM Dave Page wrote: > The attached minor patch adjusts the date format used in the runtime > startup log to ISO8601 (albeit without the T separator and timezone) to > avoid confusion for our US friends. > > Please review/commit. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Refactor config loading/saving for the runtime config dialogue
Thanks, patch applied. On Fri, Jul 10, 2020 at 8:23 PM Dave Page wrote: > The attached patch refactors the config loading/saving in the > configuration dialogue to avoid code duplication and keep it confined to > the dialogue itself. > > Please review/commit. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Reverted fix for #5569 due to a couple of issues.
Reverted fix for #5569 due to a couple of issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3eaac8609df7f816421c86a800f95637d7b69ee Modified Files -- docs/en_US/release_notes_4_24.rst | 1 - .../servers/databases/schemas/tables/__init__.py | 37 +- .../schemas/tables/partitions/__init__.py | 66 +- .../tables/partitions/static/js/partition.js | 10 -- .../tests/pg/10_plus/alter_table_add_partition.sql | 23 .../pg/10_plus/alter_table_add_partition_msql.sql | 2 - .../pg/10_plus/create_table_with_partition.sql | 18 --- .../10_plus/create_table_with_partition_msql.sql | 13 -- .../tests/pg/10_plus/test_partitions.json | 139 - .../tests/pg/11_plus/alter_table_add_partition.sql | 19 --- .../pg/11_plus/alter_table_add_partition_msql.sql | 2 - .../pg/11_plus/create_table_with_partition.sql | 14 --- .../11_plus/create_table_with_partition_msql.sql | 10 -- .../tests/pg/11_plus/test_partitions.json | 139 - .../partitions/sql/gpdb/5_plus/properties.sql | 6 +- .../templates/partitions/sql/pg/10_plus/create.sql | 32 +++-- .../templates/partitions/sql/pg/10_plus/nodes.sql | 28 + .../partitions/sql/pg/10_plus/properties.sql | 6 +- .../partitions/sql/pg/12_plus/properties.sql | 6 +- .../partitions/sql/ppas/10_plus/create.sql | 27 ++-- .../partitions/sql/ppas/10_plus/properties.sql | 6 +- .../partitions/sql/ppas/12_plus/properties.sql | 6 +- .../tables/templates/tables/sql/10_plus/create.sql | 2 +- .../servers/databases/schemas/tables/utils.py | 94 -- 24 files changed, 115 insertions(+), 591 deletions(-)
