Re- [pgAdmin][SonarQube] Variables should not be shadowed

[Satish V]

Hi Hackers,

Please find the patch which fixes 10 issues related to the Variables should
not be shadowed.
Kindly review and share the comments.

Thanks,
Sathish V


variable_shadow2.patch
Description: Binary data

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

[Akshay Joshi]

Hi Yogesh

Can you please review it.

On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue where few dialogs are not rendering properly
> when we zoomed in browser window 200% and screen resolution is low.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

[Akshay Joshi]

Hi Aditya

Can you please review it.

On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find a patch which fixes the issue of quoting values of
> numeric data types like 'bigint, numeric, double precision & real'.
>
> The issue was caused because global type caster are registered for
> connection in order to avoid javascript compatibility issue for large size
> data types like real, numeric, double precision, bigint.
> Typcaster used to cast these data type values into String, causing quotes
> to numeric data in downloaded CSV files in case of  "CSV quoting = Strings".
>
> As part of fix, type caster is temporarily unregistered for these numeric
> data types while creating CSV file & registered back after csv file
> creation.
>
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

[Akshay Joshi]

Hi Khushboo

Can you please review it.

On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat 
wrote:

> Hi Hackers,
>
> Following patch includes fix for :
>
> Storage parameters should be displayed in parent tables's SQL.
>
> As the code will be upgraded in feature #5649
> , so only initial test cases
> for pg 10, 11 are included in this patch, so later it can be continued with
> the latest code.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
> On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Rahul,
>>
>> - The storage parameters should be displayed in the parent table's SQL too
>> - Please write test cases, preferably re-sql test cases
>>
>> Thanks,
>> Khushboo
>>
>> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo,
>>>
>>> Can you please review it.
>>>
>>> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Please find the attached patch which fixes the issue related to the
 partition table with storage parameters.

 --
 *Rahul Shirsat*
 Software Engineer | EnterpriseDB Corporation.

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

[Aditya Toshniwal]

Hi Yogesh,

The patch looks good to me except that the newly added import can be
clubbed with the existing one.

+from psycopg2.extensions import DECIMAL as _DECIMAL

 import psycopg2

 from psycopg2.extensions import encodings

On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
wrote:

> Hi Aditya
>
> Can you please review it.
>
> On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find a patch which fixes the issue of quoting values of
>> numeric data types like 'bigint, numeric, double precision & real'.
>>
>> The issue was caused because global type caster are registered for
>> connection in order to avoid javascript compatibility issue for large size
>> data types like real, numeric, double precision, bigint.
>> Typcaster used to cast these data type values into String, causing quotes
>> to numeric data in downloaded CSV files in case of  "CSV quoting = Strings".
>>
>> As part of fix, type caster is temporarily unregistered for these numeric
>> data types while creating CSV file & registered back after csv file
>> creation.
>>
>>
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

[Yogesh Mahajan]

Hello,

Please find an updated patch with the above comment.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jul 9, 2020 at 2:27 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Yogesh,
>
> The patch looks good to me except that the newly added import can be
> clubbed with the existing one.
>
> +from psycopg2.extensions import DECIMAL as _DECIMAL
>
>  import psycopg2
>
>  from psycopg2.extensions import encodings
>
> On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
> wrote:
>
>> Hi Aditya
>>
>> Can you please review it.
>>
>> On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find a patch which fixes the issue of quoting values of
>>> numeric data types like 'bigint, numeric, double precision & real'.
>>>
>>> The issue was caused because global type caster are registered for
>>> connection in order to avoid javascript compatibility issue for large size
>>> data types like real, numeric, double precision, bigint.
>>> Typcaster used to cast these data type values into String, causing
>>> quotes to numeric data in downloaded CSV files in case of  "CSV quoting =
>>> Strings".
>>>
>>> As part of fix, type caster is temporarily unregistered for these
>>> numeric data types while creating CSV file & registered back after csv file
>>> creation.
>>>
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


RM5463_v2.patch
Description: Binary data

Patch for SonarQube code scan fixes

[Nikhil Mohite]

Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Table files(utils):

   - Refactor this function to reduce its Cognitive Complexity from 34 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 25 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 29 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 30 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 38 to
   the 15 allowed.

There are few issues left from this file, I will send it in the next patch.

Regards,
Nikhil Mohite.


SonarQubeCodeSmellFixes.patch
Description: Binary data

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

[Yogesh Mahajan]

Hi,

Patch looks good to me.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
wrote:

> Hi Yogesh
>
> Can you please review it.
>
> On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where few dialogs are not rendering properly
>> when we zoomed in browser window 200% and screen resolution is low.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

[pgAdmin][SonarQube] Critical issue fixes - servers

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch which includes sonarqube fixes :

1. Refactor this function to reduce its Cognitive Complexity from 18 to the
15 allowed
for *check_ssl_fields* in servers/__init__.py
2. Refactor this function to reduce its Cognitive Complexity from 25 to the
15 allowed
for *update *in servers/__init__.py

*Note: Changes were tested in both Server mode & Desktop mode respectively.*

-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


server-cognitive-comp-part-01.patch
Description: Binary data

[pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)

[Yogesh Mahajan]

Hi,

Please find a patch which fixes issues related to rule -
   a.Variables should not be shadowed.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix10_v1.patch
Description: Binary data

pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.

[Akshay Joshi]

Fixed code smell 'Variables should not be shadowed'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2cefa9afca4d0a5c0e389e9512fad7f5e88327d1
Author: Yogesh Mahajan 

Modified Files
--
.../tools/debugger/static/js/debugger_ui.js|  90 ++--
web/pgadmin/tools/debugger/static/js/direct.js |  14 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 160 ++---
3 files changed, 132 insertions(+), 132 deletions(-)

pgAdmin 4 commit: Fixed an issue where CSV download quotes numeric colu

[Akshay Joshi]

Fixed an issue where CSV download quotes numeric columns. Fixes #5463

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c08e618bd31587f98e6653286b0914661b65cc4
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_4_24.rst   |  1 +
web/pgadmin/utils/driver/psycopg2/connection.py |  7 ++-
web/pgadmin/utils/driver/psycopg2/typecast.py   | 23 ---
3 files changed, 23 insertions(+), 8 deletions(-)

pgAdmin 4 commit: Fixed convention related issues reported by SonarQube

[Akshay Joshi]

Fixed convention related issues reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=357a9179b145d1bc15902781cecc9603ed48be71
Author: Aditya Toshniwal 

Modified Files
--
web/pgAdmin4.py|  4 +--
web/pgadmin/dashboard/__init__.py  |  8 ++---
web/pgadmin/misc/bgprocess/processes.py| 14 
web/pgadmin/misc/file_manager/__init__.py  |  2 +-
web/pgadmin/setup/db_upgrade.py|  4 +--
web/pgadmin/tools/schema_diff/__init__.py  |  4 +--
web/pgadmin/tools/sqleditor/__init__.py|  4 +--
web/pgadmin/tools/sqleditor/command.py |  2 +-
.../sqleditor/utils/query_tool_preferences.py  |  2 +-
web/pgadmin/utils/__init__.py  |  2 +-
web/pgadmin/utils/driver/abstract.py   |  2 +-
web/pgadmin/utils/driver/psycopg2/__init__.py  | 40 +++---
web/pgadmin/utils/driver/psycopg2/connection.py|  6 ++--
web/pgadmin/utils/driver/psycopg2/cursor.py|  4 +--
web/pgadmin/utils/driver/psycopg2/encoding.py  |  4 +--
web/pgadmin/utils/driver/psycopg2/keywords.py  |  6 ++--
web/pgadmin/utils/driver/psycopg2/typecast.py  |  6 ++--
web/pgadmin/utils/javascript/javascript_bundler.py | 12 +++
web/pgadmin/utils/menu.py  | 16 -
web/pgadmin/utils/tests/test_encoding.py   |  4 +--
20 files changed, 73 insertions(+), 73 deletions(-)

pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.

[Akshay Joshi]

Fixed code smell 'Variables should not be shadowed'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=290cf8271be46701d3f8aff5f2577189290bdf37
Author: Satish V 

Modified Files
--
web/pgadmin/misc/file_manager/static/js/utility.js | 76 +++---
1 file changed, 38 insertions(+), 38 deletions(-)

pgAdmin 4 commit: Fixed accessibility issue where few dialogs are not r

[Akshay Joshi]

Fixed accessibility issue where few dialogs are not rendering properly
when we zoomed in browser window 200% and screen resolution is low.

Fixes #5662

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2db9242f5c256ba2f1187bede5b127c1c077e994
Author: Murtuza Zabuawala 

Modified Files
--
docs/en_US/release_notes_4_24.rst  |  3 ++-
web/pgadmin/browser/static/js/browser.js   | 29 ++
.../misc/file_manager/static/js/file_manager.js|  6 +++--
.../misc/file_manager/static/js/select_dialogue.js |  1 -
web/pgadmin/preferences/static/js/preferences.js   |  2 +-
web/pgadmin/tools/backup/static/js/backup.js   |  6 ++---
web/pgadmin/tools/restore/static/js/restore.js |  2 +-
.../search_objects/static/js/search_objects.js |  2 +-
.../javascript/file_manager/file_manager_specs.js  | 20 +++
9 files changed, 61 insertions(+), 10 deletions(-)

pgAdmin 4 commit: Ensure that create RLS Policy menu should not be visi

[Akshay Joshi]

Ensure that create RLS Policy menu should not be visible for catalog objects. 
Fixes #5633

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c58fda0a70134bde31c712ccd85f9825f088053a
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_24.rst| 3 ++-
.../tables/row_security_policies/static/js/row_security_policy.js| 5 +
2 files changed, 7 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Fixed code smell to reduce cognitive complexity.

[Akshay Joshi]

Fixed code smell to reduce cognitive complexity.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e1168f8de0f30faebf95fd1359dec2a62be85b27
Author: Nikhil Mohite 

Modified Files
--
.../servers/databases/schemas/tables/utils.py  | 325 -
1 file changed, 182 insertions(+), 143 deletions(-)

pgAdmin 4 commit: Fixed code smell for variable naming convention.

[Akshay Joshi]

Fixed code smell for variable naming convention.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=916182f80f3521169a59179ae030c5d400efe28f
Author: Pradip Parkale 

Modified Files
--
web/pgAdmin4.py|  6 +++---
.../servers/databases/schemas/tables/columns/utils.py  | 14 +++---
2 files changed, 10 insertions(+), 10 deletions(-)

Re: [SonarQube]: Rename function and variable name to match the regular expression

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 11:56 AM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find another patch variable naming convention.
>
> On Wed, Jul 1, 2020 at 1:54 PM Akshay Joshi 
> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Jul 1, 2020 at 1:10 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for :
>>>
>>>1. Rename function and variable name to match the regular expression.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5633]:Create RLS Policy option enabled for catalog objects

[Akshay Joshi]

Thanks, patch applied.

On Wed, Jul 8, 2020 at 7:28 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch. I have disabled creating an RLS policy
> option for catalog objects.
>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Patch for SonarQube code scan fixes

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 4:11 PM Nikhil Mohite 
wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
> 1. Table files(utils):
>
>- Refactor this function to reduce its Cognitive Complexity from 34 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 25 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 29 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 30 to
>the 15 allowed.
>- Refactor this function to reduce its Cognitive Complexity from 38 to
>the 15 allowed.
>
> There are few issues left from this file, I will send it in the next patch.
>
> Regards,
> Nikhil Mohite.
>
>
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][patch] SonarQube "convention" tagged fixes

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 11:40 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch for a few more "convention" tagged fixes. The patch
> also fixes a regression caused by the previous patch in file dialog.
>
> On Mon, Jul 6, 2020 at 11:49 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, Jul 6, 2020 at 11:11 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix "convention" related fixes reported by
>>> SonarQube.
>>> Please review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Re- [pgAdmin][SonarQube] Variables should not be shadowed

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 12:59 PM Satish V  wrote:

> Hi Hackers,
>
> Please find the patch which fixes 10 issues related to the Variables
> should not be shadowed.
> Kindly review and share the comments.
>
> Thanks,
> Sathish V
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 3:25 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hello,
>
> Please find an updated patch with the above comment.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Thu, Jul 9, 2020 at 2:27 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Yogesh,
>>
>> The patch looks good to me except that the newly added import can be
>> clubbed with the existing one.
>>
>> +from psycopg2.extensions import DECIMAL as _DECIMAL
>>
>>  import psycopg2
>>
>>  from psycopg2.extensions import encodings
>>
>> On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it.
>>>
>>> On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <
>>> yogesh.maha...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find a patch which fixes the issue of quoting values of
 numeric data types like 'bigint, numeric, double precision & real'.

 The issue was caused because global type caster are registered for
 connection in order to avoid javascript compatibility issue for large size
 data types like real, numeric, double precision, bigint.
 Typcaster used to cast these data type values into String, causing
 quotes to numeric data in downloaded CSV files in case of  "CSV quoting =
 Strings".

 As part of fix, type caster is temporarily unregistered for these
 numeric data types while creating CSV file & registered back after csv file
 creation.



 Thanks,
 Yogesh Mahajan
 QA - Team
 EnterpriseDB Corporation

 Phone: +91-9741705709

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 6:07 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find a patch which fixes issues related to rule -
>a.Variables should not be shadowed.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 4:37 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Patch looks good to me.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi 
> wrote:
>
>> Hi Yogesh
>>
>> Can you please review it.
>>
>> On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where few dialogs are not rendering properly
>>> when we zoomed in browser window 200% and screen resolution is low.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> *EDB*
>>> *POWER TO POSTGRES*
>>> https://www.edbpostgres.com
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

[Rahul Shirsat]

Hi Hackers,

Please find the updated patch below which fixes the issue in sslcompression
changes.

On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat 
wrote:

> Hi Hackers,
>
> Please find the attached patch which includes sonarqube fixes :
>
> 1. Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed
> for *check_ssl_fields* in servers/__init__.py
> 2. Refactor this function to reduce its Cognitive Complexity from 25 to
> the 15 allowed
> for *update *in servers/__init__.py
>
> *Note: Changes were tested in both Server mode & Desktop mode
> respectively.*
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


server-cognitive-comp-part-01_v2.patch
Description: Binary data

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

[Khushboo Vashi]

Hi Rahul,

I am getting errors while applying the patch, please rebase the patch and
send it again.

Thanks,
Khushboo

On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi 
wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Following patch includes fix for :
>>
>> Storage parameters should be displayed in parent tables's SQL.
>>
>> As the code will be upgraded in feature #5649
>> , so only initial test cases
>> for pg 10, 11 are included in this patch, so later it can be continued with
>> the latest code.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>> On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Rahul,
>>>
>>> - The storage parameters should be displayed in the parent table's SQL
>>> too
>>> - Please write test cases, preferably re-sql test cases
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Khushboo,

 Can you please review it.

 On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat <
 rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which fixes the issue related to the
> partition table with storage parameters.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


 --
 *Thanks & Regards*
 *Akshay Joshi*

 *Sr. Software Architect*
 *EnterpriseDB Software India Private Limited*
 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

[pgAdmin] Regarding Alert-box on login page

[Yogesh Jain]

Hi Hackers,

In case, if we have more than one flash messages/alert box on the pgAdmin
login page and if we click on any alert box close button then it will close
all alerts as each div has the same ID.

PFA to fix the potential issue.
--
Thanks,
Yogesh Jain
Ph:+91-8982696654


alertBoxLogin.patch
Description: Binary data

pgAdmin 4 commit: Ensure that closing the alert box on the login page w

[Akshay Joshi]

Ensure that closing the alert box on the login page will close multiple alert 
boxes if opened.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92858e40bf009f8d05a57eeb75317cbff0ecbf3f
Author: Yogesh Jain 

Modified Files
--
web/pgadmin/templates/security/messages.html | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Improve code coverage and API test cases for FTS Conf

[Akshay Joshi]

Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS 
Dictionaries, and FTS Template. Fixes #5329.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7420673a0f23fa14291f8574a47131929b233da5
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_24.rst  |   1 +
.../tests/fts_configurations_test_data.json| 291 +
.../tests/test_fts_configuration_copyConfig.py | 121 +
.../tests/test_fts_configuration_delete.py |   9 +
.../test_fts_configuration_dependency_dependent.py | 118 +
.../test_fts_configuration_get_dictionaries.py | 122 +
.../tests/test_fts_configuration_get_nodes.py  | 142 ++
.../tests/test_fts_configuration_get_sql.py| 124 +
.../tests/test_fts_configuration_parsers.py| 121 +
.../tests/test_fts_configuration_put.py|  10 +
.../tests/test_fts_configuration_tokens.py | 123 +
.../schemas/fts_configurations/tests/utils.py  |   4 +
.../tests/fts_dictionaries_test_data.json  | 143 ++
.../tests/test_fts_dictionaries_delete.py  |  10 +
.../test_fts_dictionaries_dependency_dependent.py  | 118 +
.../tests/test_fts_dictionaries_fetch_templates.py | 122 +
.../tests/test_fts_dictionaries_get_nodes.py   | 142 ++
.../tests/test_fts_dictionaries_put.py |  11 +
.../schemas/fts_dictionaries/tests/utils.py|   4 +
.../fts_parsers/tests/fts_parsers_test_data.json   | 248 ++
.../fts_parsers/tests/test_fts_parser_delete.py|  10 +
.../tests/test_fts_parser_dependency_dependent.py  | 118 +
.../tests/test_fts_parser_end_functions.py | 123 +
.../fts_parsers/tests/test_fts_parser_get_nodes.py | 142 ++
.../tests/test_fts_parser_head_line_functions.py   | 123 +
.../tests/test_fts_parser_lextype_functions.py | 123 +
.../tests/test_fts_parser_start_functions.py   | 123 +
.../tests/test_fts_parser_token_functions.py   | 123 +
.../databases/schemas/fts_parsers/tests/utils.py   |   4 +
.../tests/fts_templates_test_data.json | 170 
.../test_fts_template_dependency_dependent.py  | 118 +
.../tests/test_fts_template_get_init.py| 125 +
.../tests/test_fts_template_get_lexize.py  | 125 +
.../tests/test_fts_template_get_nodes.py   | 143 ++
.../tests/test_fts_templates_delete.py |  10 +
.../fts_templates/tests/test_fts_templates_put.py  |  11 +
.../databases/schemas/fts_templates/tests/utils.py |   4 +
37 files changed, 3579 insertions(+)

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

[Akshay Joshi]

Fixed cognitive complexity issues reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8b81db9778e89203734fe3b80578c47ff8f379e
Author: Rahul Shirsat 

Modified Files
--
.../browser/server_groups/servers/__init__.py  | 82 +-
.../servers/databases/event_triggers/__init__.py   | 59 +---
2 files changed, 80 insertions(+), 61 deletions(-)

Re: [pgAdmin] Regarding Alert-box on login page

[Akshay Joshi]

Thanks, patch applied.

On Fri, Jul 10, 2020 at 10:59 AM Yogesh Jain 
wrote:

> Hi Hackers,
>
> In case, if we have more than one flash messages/alert box on the pgAdmin
> login page and if we click on any alert box close button then it will close
> all alerts as each div has the same ID.
>
> PFA to fix the potential issue.
> --
> Thanks,
> Yogesh Jain
> Ph:+91-8982696654
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 9, 2020 at 7:15 PM Rahul Shirsat 
wrote:

> Hi Hackers,
>
> Please find the updated patch below which fixes the issue in
> sslcompression changes.
>
> On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which includes sonarqube fixes :
>>
>> 1. Refactor this function to reduce its Cognitive Complexity from 18 to
>> the 15 allowed
>> for *check_ssl_fields* in servers/__init__.py
>> 2. Refactor this function to reduce its Cognitive Complexity from 25 to
>> the 15 allowed
>> for *update *in servers/__init__.py
>>
>> *Note: Changes were tested in both Server mode & Desktop mode
>> respectively.*
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - SonarQube Fixes

[Akshay Joshi]

Thanks, patch applied.

On Wed, Jul 8, 2020 at 3:00 PM Rahul Shirsat 
wrote:

> Hi Hackers,
>
> Please find the attached patch to fix the SonarQube Code smells having
> Rule "Refactor this function to reduce its Cognitive Complexity from 18
> to the 15 allowed".
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*