Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Hi Rahul, - The storage parameters should be displayed in the parent table's SQL too - Please write test cases, preferably re-sql test cases Thanks, Khushboo On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi wrote: > Hi Khushboo, > > Can you please review it. > > On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which fixes the issue related to the >> partition table with storage parameters. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Hi Aditya, Please find the attached updated patch. On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > I suggest, > 1) Remove the commented code > > +# if 'mail' in entry: > > +# user_email = entry['mail'].value > Removed. > 2) Change the below condition to check "is not None" instead which makes > more sense. > > +if not self.bind_user or not self.bind_pass: > > "is not None" will not check empty strings. Though the default value is None but the user might set an empty string into config_local.py file. Thanks, Khushboo > Other changes looks fine. > > On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> Can you please review it. >> >> On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for the RM 5484 - Support LDAP based >>> auth also when users do not have the same DN structure. >>> >>> Currently, pgAdmin only supports LDAP authentication with the same DN >>> structure. With this patch, the LDAP authentication will also support the >>> different DN by setting the dedicated user for the LDAP connection in the >>> config file. >>> >>> Thanks, >>> Khushboo >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > RM_5484_v1.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > Please find the attached updated patch. > > On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> I suggest, >> 1) Remove the commented code >> >> +# if 'mail' in entry: >> >> +# user_email = entry['mail'].value >> > Removed. > >> 2) Change the below condition to check "is not None" instead which makes >> more sense. >> >> +if not self.bind_user or not self.bind_pass: >> >> "is not None" will not check empty strings. Though the default value is > None but the user might set an empty string into config_local.py file. > A password can be empty. And setting this config var indicates the user wants to set it as its an optional config. > > Thanks, > Khushboo > >> Other changes looks fine. >> >> On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya, >>> >>> Can you please review it. >>> >>> On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, Please find the attached patch for the RM 5484 - Support LDAP based auth also when users do not have the same DN structure. Currently, pgAdmin only supports LDAP authentication with the same DN structure. With this patch, the LDAP authentication will also support the different DN by setting the dedicated user for the LDAP connection in the config file. Thanks, Khushboo >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> Please find the attached updated patch. >> >> On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Khushboo, >>> >>> I suggest, >>> 1) Remove the commented code >>> >>> +# if 'mail' in entry: >>> >>> +# user_email = entry['mail'].value >>> >> Removed. >> >>> 2) Change the below condition to check "is not None" instead which >>> makes more sense. >>> >>> +if not self.bind_user or not self.bind_pass: >>> >>> "is not None" will not check empty strings. Though the default value is >> None but the user might set an empty string into config_local.py file. >> > A password can be empty. And setting this config var indicates the user > wants to set it as its an optional config. > Yes, it's an optional config but if the user has set BIND_USER param then password is mandatory. > >> Thanks, >> Khushboo >> >>> Other changes looks fine. >>> >>> On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Aditya, Can you please review it. On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RM 5484 - Support LDAP based > auth also when users do not have the same DN structure. > > Currently, pgAdmin only supports LDAP authentication with the same DN > structure. With this patch, the LDAP authentication will also support the > different DN by setting the dedicated user for the LDAP connection in the > config file. > > Thanks, > Khushboo > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" >
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Aditya, >>> >>> Please find the attached updated patch. >>> >>> On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> Hi Khushboo, I suggest, 1) Remove the commented code +# if 'mail' in entry: +# user_email = entry['mail'].value >>> Removed. >>> 2) Change the below condition to check "is not None" instead which makes more sense. +if not self.bind_user or not self.bind_pass: "is not None" will not check empty strings. Though the default value is >>> None but the user might set an empty string into config_local.py file. >>> >> A password can be empty. And setting this config var indicates the user >> wants to set it as its an optional config. >> > Yes, it's an optional config but if the user has set BIND_USER param then > password is mandatory. > I agree that password is mandatory. But, one can have a blank password. Which also suggests maybe there should be some meaningful error thrown to the user if the user sets the username but not the password. > >>> Thanks, >>> Khushboo >>> Other changes looks fine. On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Aditya, > > Can you please review it. > > On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for the RM 5484 - Support LDAP based >> auth also when users do not have the same DN structure. >> >> Currently, pgAdmin only supports LDAP authentication with the same DN >> structure. With this patch, the LDAP authentication will also support the >> different DN by setting the dedicated user for the LDAP connection in the >> config file. >> >> Thanks, >> Khushboo >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
On Mon, Jul 6, 2020 at 3:20 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Aditya, Please find the attached updated patch. On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > I suggest, > 1) Remove the commented code > > +# if 'mail' in entry: > > +# user_email = entry['mail'].value > Removed. > 2) Change the below condition to check "is not None" instead which > makes more sense. > > +if not self.bind_user or not self.bind_pass: > > "is not None" will not check empty strings. Though the default value is None but the user might set an empty string into config_local.py file. >>> A password can be empty. And setting this config var indicates the user >>> wants to set it as its an optional config. >>> >> Yes, it's an optional config but if the user has set BIND_USER param then >> password is mandatory. >> > I agree that password is mandatory. But, one can have a blank password. > Which also suggests maybe there should be some meaningful error thrown to > the user if the user sets the username but not the password. > I have given the error message if the admin has only set the username and not the password though this message is not useful for normal users as this has been set by the admin. Thanks, Khushboo > Thanks, Khushboo > Other changes looks fine. > > On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> Can you please review it. >> >> On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for the RM 5484 - Support LDAP based >>> auth also when users do not have the same DN structure. >>> >>> Currently, pgAdmin only supports LDAP authentication with the same >>> DN structure. With this patch, the LDAP authentication will also support >>> the different DN by setting the dedicated user for the LDAP connection >>> in >>> the config file. >>> >>> Thanks, >>> Khushboo >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > RM_5484_v2.patch Description: Binary data
Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty
Hi Akshay, Patch looks good. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi wrote: > Hi Yogesh, > > Can you please review it. > > On Fri, Jul 3, 2020 at 4:30 PM Satish V wrote: > >> Hi Hackers, >> >> Please find the patch in the attachment which resolves the issue of error >> messages not getting displayed in the dialog boxes of *backup, restore *and >> *import/export.* >> >> Kindly review the patch. >> >> Thanks, >> Sathish V >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
pgAdmin 4 commit: Fixed issue of error message not getting displayed wh
Fixed issue of error message not getting displayed when filename is empty for backup, restore, and import/export. Fixes #3814. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebf20341296ed51bc87675a33392a9b0efab155 Author: Satish V Modified Files -- docs/en_US/release_notes_4_24.rst | 1 + web/pgadmin/static/scss/_alert.scss| 6 .../backup/static/js/backup_dialog_wrapper.js | 28 -- .../tools/import_export/static/js/import_export.js | 34 +++--- .../restore/static/js/restore_dialog_wrapper.js| 28 -- .../backup/backup_dialog_wrapper_spec.js | 2 ++ .../restore/restore_dialog_wrapper_spec.js | 2 ++ 7 files changed, 91 insertions(+), 10 deletions(-)
pgAdmin 4 commit: Fixed SonarQube issues in css/scss files.
Fixed SonarQube issues in css/scss files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6ce78a8c01166cb91219e61a0160f5ba5f45cd2 Author: Pramod Ahire Modified Files -- web/pgadmin/dashboard/static/scss/_dashboard.scss| 6 ++ web/pgadmin/misc/file_manager/static/css/file_manager.css| 7 ++- web/pgadmin/misc/file_manager/static/scss/_file_manager.scss | 6 ++ web/pgadmin/misc/static/explain/scss/_explain.scss | 6 +- 4 files changed, 7 insertions(+), 18 deletions(-)
pgAdmin 4 commit: Added support for LDAP authentication with different
Added support for LDAP authentication with different DN by setting the dedicated user for the LDAP connection. Fixes #5484 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=58b4c45d0c08040c49ed24c72e12245b833265e1 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_24.rst| 1 + web/config.py| 10 ++ web/pgadmin/authenticate/ldap.py | 53 +--- web/pgadmin/browser/tests/test_ldap_login.py | 7 web/regression/test_config.json.in | 20 +++ 5 files changed, 79 insertions(+), 12 deletions(-)
Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty
Thanks, patch applied. On Mon, Jul 6, 2020 at 5:08 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Akshay, > > Patch looks good. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Yogesh, >> >> Can you please review it. >> >> On Fri, Jul 3, 2020 at 4:30 PM Satish V >> wrote: >> >>> Hi Hackers, >>> >>> Please find the patch in the attachment which resolves the issue of >>> error messages not getting displayed in the dialog boxes of *backup, >>> restore *and *import/export.* >>> >>> Kindly review the patch. >>> >>> Thanks, >>> Sathish V >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Thanks, patch applied. On Mon, Jul 6, 2020 at 4:05 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 6, 2020 at 3:20 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 6, 2020 at 3:16 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Jul 6, 2020 at 3:02 PM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> On Mon, Jul 6, 2020 at 2:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > Please find the attached updated patch. > > On Mon, Jul 6, 2020 at 11:44 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> I suggest, >> 1) Remove the commented code >> >> +# if 'mail' in entry: >> >> +# user_email = entry['mail'].value >> > Removed. > >> 2) Change the below condition to check "is not None" instead which >> makes more sense. >> >> +if not self.bind_user or not self.bind_pass: >> >> "is not None" will not check empty strings. Though the default value > is None but the user might set an empty string into config_local.py file. > A password can be empty. And setting this config var indicates the user wants to set it as its an optional config. >>> Yes, it's an optional config but if the user has set BIND_USER param >>> then password is mandatory. >>> >> I agree that password is mandatory. But, one can have a blank password. >> Which also suggests maybe there should be some meaningful error thrown to >> the user if the user sets the username but not the password. >> > I have given the error message if the admin has only set the username and > not the password though this message is not useful for normal users as this > has been set by the admin. > > Thanks, > Khushboo > >> Thanks, > Khushboo > >> Other changes looks fine. >> >> On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Aditya, >>> >>> Can you please review it. >>> >>> On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, Please find the attached patch for the RM 5484 - Support LDAP based auth also when users do not have the same DN structure. Currently, pgAdmin only supports LDAP authentication with the same DN structure. With this patch, the LDAP authentication will also support the different DN by setting the dedicated user for the LDAP connection in the config file. Thanks, Khushboo >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above
Hi Hackers, Please find the attached patch for a permissive and restrictive RLS policy support. I have also updated the document with new screenshots. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5622.patch Description: Binary data
Patch for SonarQube code scan fixes
Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Table Index files(utils and init): - Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed. Regards, Nikhil Mohite. sonarQube_code_smell.patch Description: Binary data
Re: Patch for SonarQube code scan fixes
Hi Nikhil Fix the PEP8 issues. On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table Index files(utils and init): > >- Refactor this function to reduce its Cognitive Complexity from 27 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 20 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 18 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 16 to >the 15 allowed. >- Refactor this function to reduce its Cognitive Complexity from 22 to >the 15 allowed. > > > Regards, > Nikhil Mohite. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re- Patch for SonarQube issues
Hi Hackers, I have fixed some issues related to variable shadowing. Please find the patch in the attachments. Files changed import_export.js and maintenance.js Thanks, Sathish V variable_shadow.patch Description: Binary data
Re: [pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above
Patch not applied. Please check and resend it. On Mon, Jul 6, 2020 at 8:37 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for a permissive and restrictive RLS policy > support. I have also updated the document with new screenshots. > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Patch for SonarQube code scan fixes
Hi Akshay, I have resolved the PEP8 issues, PFA updated patch. Regards, Nikhil Mohite. On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi wrote: > Hi Nikhil > > Fix the PEP8 issues. > > On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have fixed some code smell issues in the SonarQube scan, PFA patch. >> Details as follows: >> 1. Table Index files(utils and init): >> >>- Refactor this function to reduce its Cognitive Complexity from 27 >>to the 15 allowed. >>- Refactor this function to reduce its Cognitive Complexity from 20 >>to the 15 allowed. >>- Refactor this function to reduce its Cognitive Complexity from 18 >>to the 15 allowed. >>- Refactor this function to reduce its Cognitive Complexity from 16 >>to the 15 allowed. >>- Refactor this function to reduce its Cognitive Complexity from 22 >>to the 15 allowed. >> >> >> Regards, >> Nikhil Mohite. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > sonarQubeCodeSmell_v2.patch Description: Binary data
[pgAdmin4][Patch] - SonarQube Issues - 9 (Variables and functions should not be redeclared, Variables should not be shadowed)
Hi, Please find a patch which fixes issues related to rule- a.Variables should not be shadowed. b.Variables and functions should not be redeclared. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix9_v1.patch Description: Binary data
