[pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Hi, Please find the attached patch for the RM 5484 - Support LDAP based auth also when users do not have the same DN structure. Currently, pgAdmin only supports LDAP authentication with the same DN structure. With this patch, the LDAP authentication will also support the different DN by setting the dedicated user for the LDAP connection in the config file. Thanks, Khushboo RM_5484.patch Description: Binary data
Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)
Hi Khushboo, Can you please review it. On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which fixes the issue related to the > partition table with storage parameters. > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Reg - [RM-3814] Backup dialog does not show details of error if file name box kept empty
Hi Yogesh, Can you please review it. On Fri, Jul 3, 2020 at 4:30 PM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which resolves the issue of error > messages not getting displayed in the dialog boxes of *backup, restore *and > *import/export.* > > Kindly review the patch. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Hi Aditya, Can you please review it. On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RM 5484 - Support LDAP based auth > also when users do not have the same DN structure. > > Currently, pgAdmin only supports LDAP authentication with the same DN > structure. With this patch, the LDAP authentication will also support the > different DN by setting the dedicated user for the LDAP connection in the > config file. > > Thanks, > Khushboo > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 5484 Support LDAP based auth also when users do not have the same DN structure
Hi Khushboo, I suggest, 1) Remove the commented code +# if 'mail' in entry: +# user_email = entry['mail'].value 2) Change the below condition to check "is not None" instead which makes more sense. +if not self.bind_user or not self.bind_pass: Other changes looks fine. On Mon, Jul 6, 2020 at 11:29 AM Akshay Joshi wrote: > Hi Aditya, > > Can you please review it. > > On Mon, Jul 6, 2020 at 11:17 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for the RM 5484 - Support LDAP based auth >> also when users do not have the same DN structure. >> >> Currently, pgAdmin only supports LDAP authentication with the same DN >> structure. With this patch, the LDAP authentication will also support the >> different DN by setting the dedicated user for the LDAP connection in the >> config file. >> >> Thanks, >> Khushboo >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Fixed 'convention' related code smell reported by Son
Fixed 'convention' related code smell reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=45a03dd6639e70b197d5e11605702bf2ec823cf3 Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py| 4 +- .../tests/test_external_tables_module.py | 10 ++-- .../servers/databases/schemas/__init__.py | 2 +- .../schemas/tables/compound_triggers/__init__.py | 4 +- .../databases/schemas/tables/indexes/__init__.py | 4 +- .../schemas/tables/partitions/__init__.py | 8 +-- .../partitions/tests/test_backend_supported.py | 4 +- .../databases/schemas/tables/rules/__init__.py | 4 +- .../databases/schemas/tables/triggers/__init__.py | 4 +- .../servers/databases/schemas/utils.py | 4 +- .../server_groups/servers/pgagent/__init__.py | 2 +- .../servers/resource_groups/__init__.py| 2 +- .../tablespaces/tests/test_backend_supported.py| 2 +- web/pgadmin/browser/utils.py | 6 +-- web/pgadmin/misc/bgprocess/process_executor.py | 17 +++--- web/pgadmin/misc/file_manager/__init__.py | 62 +++--- web/pgadmin/misc/themes/__init__.py| 2 +- web/pgadmin/tools/datagrid/__init__.py | 6 +-- web/pgadmin/tools/debugger/__init__.py | 28 +- web/pgadmin/tools/grant_wizard/__init__.py | 20 +++ .../tests/test_search_objects_helper.py| 2 +- web/pgadmin/tools/search_objects/utils.py | 4 +- 22 files changed, 98 insertions(+), 103 deletions(-)
pgAdmin 4 commit: Fixed code smell 'Variable should not be shadowed'
Fixed code smell 'Variable should not be shadowed' Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcf720a5d89a82a1d2e853a97024434b0b580bea Author: Satish V Modified Files -- .../tools/grant_wizard/static/js/grant_wizard.js | 30 +++--- .../tools/import_export/static/js/import_export.js | 28 ++-- 2 files changed, 29 insertions(+), 29 deletions(-)
Re: [pgAdmin][patch] SonarQube "convention" tagged fixes
Thanks, patch applied. On Mon, Jul 6, 2020 at 11:11 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix "convention" related fixes reported by > SonarQube. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Re- SonarQube[Variables should not be shadowed]
Thanks, patch applied. On Fri, Jul 3, 2020 at 7:32 PM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes some of the sonar qube issues related to > variable shadowing. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
