[pgAdmin][Patch] RM 5530 - Referenced Table is not displayed on foriegn key constraints property

[Yogesh Mahajan]

Hi,

Please find a patch fixing RM 5530.
Refer Table Name is shown in Foreign Key creation dialogue & properties tab.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM5530_v1.patch
Description: Binary data

pgAdmin 4 commit: Fix typo. Fixes #5517

[Dave Page]

Fix typo. Fixes #5517

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0fa4a6cb2f50c1ecf2aa6c8411ac7e1faf4f196

Modified Files
--
runtime/ConfigWindow.ui | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)

[pgAdmin][RM5629] Properties tab of collection nodes should not allow editing

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to fix the issue where the user is able to edit
properties when some of the collection nodes are selected (eg- tables,
functions). The code is changed to make the columns non editable always.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM5629.patch
Description: Binary data

Re: [pgAdmin][RM5629] Properties tab of collection nodes should not allow editing

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 2, 2020 at 3:39 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the issue where the user is able to edit
> properties when some of the collection nodes are selected (eg- tables,
> functions). The code is changed to make the columns non editable always.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue where the user is able to edit propert

[Akshay Joshi]

Fixed an issue where the user is able to edit properties when some of the 
collection nodes are selected. Fixes #5629

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ced296939f1231e5c1ef7bb48a2be45693609928
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_24.rst   | 1 +
web/pgadmin/browser/static/js/collection.js | 4 
2 files changed, 5 insertions(+)

pgAdmin 4 commit: Added hints for 'Using' and 'With check' options of R

[Akshay Joshi]

Added hints for 'Using' and 'With check' options of RLS Policy node.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b10315e2a83f388dea118b7ca99a342ad98f6c9
Author: Pradip Parkale 

Modified Files
--
.../row_security_policies/static/js/row_security_policy.js  | 13 +
.../servers/databases/schemas/tables/static/js/table.js |  2 +-
2 files changed, 14 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Comment out the 'yarn audit' command to fix the vulne

[Akshay Joshi]

Comment out the 'yarn audit' command to fix the vulnerability found in the 
'lodash' package. No fix is currently available.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec30e6ace78a813eb5215efc5c1f0e94582ffc12

Modified Files
--
Dockerfile | 8 +++-
Makefile   | 8 +++-
2 files changed, 6 insertions(+), 10 deletions(-)

pgAdmin 4 commit: Ensure that the referenced table should be displayed

[Akshay Joshi]

Ensure that the referenced table should be displayed on foreign key 
constraints. Fixes #5530

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1802f8a3f8f9d9369ed79ec88f36280fc9640af7
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_4_24.rst  |  1 +
.../foreign_key/static/js/foreign_key.js   | 52 +++---
.../tables/constraints/foreign_key/utils.py|  4 +-
.../databases/schemas/tables/static/js/table.js|  2 +-
4 files changed, 52 insertions(+), 7 deletions(-)

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 2, 2020 at 10:51 AM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the attached patch. I have added hints for 'Using' and 'With
> check'.
>
> On Mon, Jun 22, 2020 at 5:45 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, Jun 22, 2020 at 3:23 PM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the updated patch. I have added a new RLS policy event
>>> 'ALL'.
>>>
>>>
>>> On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied with the following modifications:


- js file name should be "row_security_policy.js" instead of
"row_security_policies.js".
- Node name should be "row_security_policy" instead of
"row_level_policies". Node name should not be pluralized and it matches 
 the
folder name.
- Icon name should be "coll-row_security_policy.svg" and
"row_security_policy.svg", it should matches with the Node name.
- The 'Owner' should be renamed to 'Role' and there must be
a role 'public' in the drop-down list. If the user does not provide any
role then by default it is public.
- Keywords like select, where, As should be in upper case in Jinja
template.
- The policy node is disappeared when updating any value. Fixed
that issue.
- There is no icon showing after creating the RLS node.



 On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale <
 pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for the 'Row Level Security' feature.
> I have added RE-SQL and API test cases also.
>
> To run the RE-SQL cases -
>
>- python runtests.py --pkg resql --modules row_security_policies.
>
> To run the API cases -
>
>-  python runtests.py --pkg
>
> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


 --
 *Thanks & Regards*
 *Akshay Joshi*

 *Sr. Software Architect*
 *EnterpriseDB Software India Private Limited*
 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][Patch] RM 5530 - Referenced Table is not displayed on foriegn key constraints property

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 2, 2020 at 1:19 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find a patch fixing RM 5530.
> Refer Table Name is shown in Foreign Key creation dialogue & properties
> tab.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

[pgAdmin][patch] Dialog width issue

[Aditya Toshniwal]

Hi Hackers,

Attached is a tiny patch to fix the dialog sizes snapping to default widths.
Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


widthissue.patch
Description: Binary data

Regression in of browser.js code

[Murtuza Zabuawala]

Hi,

There was a regression where we have changed the panel variables in menu.py
but we did not change their respective reference in JS which is causing
issues while loading wcDocker Panel/Frames which are defined in python side.

Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3



--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com


browser_regression.diff
Description: Binary data

Re: Regression in of browser.js code

[Khushboo Vashi]

On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> There was a regression where we have changed the panel variables in
> menu.py but we did not change their respective reference in JS which is
> causing issues while loading wcDocker Panel/Frames which are defined in
> python side.
>
> This has been fixed, please get the latest pgAdmin code.

> Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3
> 
>
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>

Re: Regression in of browser.js code

[Murtuza Zabuawala]

Hi Khushboo,

I am already on the latest code :)

*commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master,
origin/master, origin/HEAD)


--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com


On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> There was a regression where we have changed the panel variables in
>> menu.py but we did not change their respective reference in JS which is
>> causing issues while loading wcDocker Panel/Frames which are defined in
>> python side.
>>
>> This has been fixed, please get the latest pgAdmin code.
>
>> Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3
>> 
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>

Re: Regression in of browser.js code

[Khushboo Vashi]

On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Khushboo,
>
> I am already on the latest code :)
>
Then your patch will not work. :)

>
> *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master,
> origin/master, origin/HEAD)
>
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> There was a regression where we have changed the panel variables in
>>> menu.py but we did not change their respective reference in JS which is
>>> causing issues while loading wcDocker Panel/Frames which are defined in
>>> python side.
>>>
>>> This has been fixed, please get the latest pgAdmin code.
>>
>>> Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3
>>> 
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> *EDB*
>>> *POWER TO POSTGRES*
>>> https://www.edbpostgres.com
>>>
>>

Re: Regression in of browser.js code

[Murtuza Zabuawala]

On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Khushboo,
>>
>> I am already on the latest code :)
>>
> Then your patch will not work. :)
>

It is applying and I'm able to see the diff,

--

(venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ git apply
browser_regression.diff
(venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ gs
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add ..." to update what will be committed)
  (use "git checkout -- ..." to discard changes in working directory)

modified:   web/pgadmin/browser/static/js/browser.js


-

(venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ git diff
diff --git a/web/pgadmin/browser/static/js/browser.js
b/web/pgadmin/browser/static/js/browser.js
index 9db31de59..dc6c26920 100644
--- a/web/pgadmin/browser/static/js/browser.js
+++ b/web/pgadmin/browser/static/js/browser.js
@@ -278,16 +278,16 @@ define('pgadmin.browser', [
   /* Add hooked-in panels by extensions */
   var panels = JSON.parse(pgBrowser.panels_items);
   _.each(panels, function(panel) {
-if (panel.isIframe) {
+if (panel.is_iframe) {
   pgBrowser.frames[panel.name] = new pgBrowser.Frame({
 name: panel.name,
 title: panel.title,
 icon: panel.icon,
 width: panel.width,
 height: panel.height,
-showTitle: panel.showTitle,
-isCloseable: panel.isCloseable,
-isPrivate: panel.isPrivate,
+showTitle: panel.show_title,
+isCloseable: panel.is_closeable,
+isPrivate: panel.is_private,
 url: panel.content,
   });
 } else {
@@ -297,12 +297,12 @@ define('pgadmin.browser', [
 icon: panel.icon,
 width: panel.width,
 height: panel.height,
-showTitle: panel.showTitle,
-isCloseable: panel.isCloseable,
-isPrivate: panel.isPrivate,
+showTitle: panel.show_title,
+isCloseable: panel.is_closeable,
+isPrivate: panel.is_private,
 content: (panel.content) ? panel.content : '',
 events: (panel.events) ? panel.events : '',
-canHide: (panel.canHide) ? panel.canHide : '',
+canHide: (panel.can_hide) ? panel.can_hide : '',
   });
 }
   });




>
>> *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master,
>> origin/master, origin/HEAD)
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 There was a regression where we have changed the panel variables in
 menu.py but we did not change their respective reference in JS which
 is causing issues while loading wcDocker Panel/Frames which are defined in
 python side.

 This has been fixed, please get the latest pgAdmin code.
>>>
 Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3
 


 --
 Regards,
 Murtuza Zabuawala
 *EDB*
 *POWER TO POSTGRES*
 https://www.edbpostgres.com

>>>

Re: Regression in of browser.js code

[Murtuza Zabuawala]

Ok the commit is reverted :(


On Thu, Jul 2, 2020 at 5:45 PM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
>
>
> On Thu, Jul 2, 2020 at 5:41 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jul 2, 2020 at 5:33 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo,
>>>
>>> I am already on the latest code :)
>>>
>> Then your patch will not work. :)
>>
>
> It is applying and I'm able to see the diff,
>
> --
>
> (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ git apply
> browser_regression.diff
> (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ gs
> On branch master
> Your branch is up to date with 'origin/master'.
>
> Changes not staged for commit:
>   (use "git add ..." to update what will be committed)
>   (use "git checkout -- ..." to discard changes in working directory)
>
> modified:   web/pgadmin/browser/static/js/browser.js
>
>
> -
>
> (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4 (master)$ git diff
> diff --git a/web/pgadmin/browser/static/js/browser.js
> b/web/pgadmin/browser/static/js/browser.js
> index 9db31de59..dc6c26920 100644
> --- a/web/pgadmin/browser/static/js/browser.js
> +++ b/web/pgadmin/browser/static/js/browser.js
> @@ -278,16 +278,16 @@ define('pgadmin.browser', [
>/* Add hooked-in panels by extensions */
>var panels = JSON.parse(pgBrowser.panels_items);
>_.each(panels, function(panel) {
> -if (panel.isIframe) {
> +if (panel.is_iframe) {
>pgBrowser.frames[panel.name] = new pgBrowser.Frame({
>  name: panel.name,
>  title: panel.title,
>  icon: panel.icon,
>  width: panel.width,
>  height: panel.height,
> -showTitle: panel.showTitle,
> -isCloseable: panel.isCloseable,
> -isPrivate: panel.isPrivate,
> +showTitle: panel.show_title,
> +isCloseable: panel.is_closeable,
> +isPrivate: panel.is_private,
>  url: panel.content,
>});
>  } else {
> @@ -297,12 +297,12 @@ define('pgadmin.browser', [
>  icon: panel.icon,
>  width: panel.width,
>  height: panel.height,
> -showTitle: panel.showTitle,
> -isCloseable: panel.isCloseable,
> -isPrivate: panel.isPrivate,
> +showTitle: panel.show_title,
> +isCloseable: panel.is_closeable,
> +isPrivate: panel.is_private,
>  content: (panel.content) ? panel.content : '',
>  events: (panel.events) ? panel.events : '',
> -canHide: (panel.canHide) ? panel.canHide : '',
> +canHide: (panel.can_hide) ? panel.can_hide : '',
>});
>  }
>});
>
>
>
>
>>
>>> *commit* ec30e6ace78a813eb5215efc5c1f0e94582ffc12 (HEAD -> master,
>>> origin/master, origin/HEAD)
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> *EDB*
>>> *POWER TO POSTGRES*
>>> https://www.edbpostgres.com
>>>
>>>
>>> On Thu, Jul 2, 2020 at 5:25 PM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Jul 2, 2020 at 5:16 PM Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> There was a regression where we have changed the panel variables in
> menu.py but we did not change their respective reference in JS which
> is causing issues while loading wcDocker Panel/Frames which are defined in
> python side.
>
> This has been fixed, please get the latest pgAdmin code.

> Ref: 830ac1cc9177c8b9ebed2304924cec1db22e45c3
> 
>
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>

[pgAdmin][RM5287] Dark theme and other CSS related fixes

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to:
1) Change the way editable field is displayed in backgrid.
2) Change colors for alerts in dark theme.
3) Change the dashboard graph grid lines colors based on theme.
4) Fix the backgrid hover background issue. Fixes #5470.
5) Few other CSS improvements.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM5287_5470.patch
Description: Binary data

Re: [pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

[Nikhil Mohite]

Hi Team,

I have removed duplicate code for codemirror settings.
This will also resolve the issue with autocomplete is not working in the
query tool due to earlier fixes.

PFA patch

Regards,
Nikhil Mohite.

On Wed, Jul 1, 2020 at 1:55 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Wed, Jul 1, 2020 at 11:39 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have done fixes for RM-4235.
>> Details as follows:
>> 1. Resolved issue with tab indent when a user set "use spaces == true" in
>> preferences > Querytool > Editor > Use spaces.
>> 2. Making sure the behavior is the same when "user spaces" setting to
>> "true" or "false".
>>
>> PFA patch.
>>
>>
>> Regards,
>> Nikhil Mohite
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


RM4235_v2.patch
Description: Binary data

Re: [pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

[Akshay Joshi]

Thanks, patch applied.

On Fri, Jul 3, 2020 at 10:03 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have removed duplicate code for codemirror settings.
> This will also resolve the issue with autocomplete is not working in the
> query tool due to earlier fixes.
>
> PFA patch
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Jul 1, 2020 at 1:55 PM Akshay Joshi 
> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Jul 1, 2020 at 11:39 AM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> I have done fixes for RM-4235.
>>> Details as follows:
>>> 1. Resolved issue with tab indent when a user set "use spaces == true"
>>> in preferences > Querytool > Editor > Use spaces.
>>> 2. Making sure the behavior is the same when "user spaces" setting to
>>> "true" or "false".
>>>
>>> PFA patch.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed issue where dialog sizes snapping to the defaul

[Akshay Joshi]

Fixed issue where dialog sizes snapping to the default widths.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd4dc19add28d2533525fd102cfed62c73fe2f5e
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/browser/static/js/node.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Fixed dark theme-related CSS and modify the color cod

[Akshay Joshi]

Fixed dark theme-related CSS and modify the color codes. Fixes #5287
Fixed backgrid row hover issue where on hover background color is set for edit 
and delete cell only. Fixes #5470

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=341c3aded6edc771dc9f43ba31fc67874146118f
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_24.rst  |  2 ++
.../schemas/tables/columns/static/js/column.js | 12 ++--
.../servers/databases/schemas/types/static/js/type.js  | 13 +++--
web/pgadmin/dashboard/static/js/dashboard.js   |  5 +
web/pgadmin/static/js/alertify.pgadmin.defaults.js |  6 +++---
web/pgadmin/static/scss/_alert.scss| 16 ++--
web/pgadmin/static/scss/_alertify.overrides.scss   | 15 +--
web/pgadmin/static/scss/_backgrid.overrides.scss   | 18 +-
web/pgadmin/static/scss/_bootstrap.overrides.scss  |  7 ---
web/pgadmin/static/scss/pgadmin.scss   |  5 +
web/pgadmin/static/scss/resources/_default.style.scss  |  8 
.../static/scss/resources/_default.variables.scss  |  9 -
.../static/scss/resources/_theme.variables.scss.sample |  8 +++-
.../static/scss/resources/dark/_theme.variables.scss   | 11 ++-
web/pgadmin/static/vendor/backgrid/backgrid.js |  9 -
.../static/js/search_objects_dialog_wrapper.js |  4 ++--
.../tools/user_management/static/js/user_management.js |  1 +
17 files changed, 88 insertions(+), 61 deletions(-)

Re: [pgAdmin][RM5287] Dark theme and other CSS related fixes

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 2, 2020 at 5:54 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to:
> 1) Change the way editable field is displayed in backgrid.
> 2) Change colors for alerts in dark theme.
> 3) Change the dashboard graph grid lines colors based on theme.
> 4) Fix the backgrid hover background issue. Fixes #5470.
> 5) Few other CSS improvements.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Remove the duplicate code for tab indent and add the

[Akshay Joshi]

Remove the duplicate code for tab indent and add the logic into codemirror.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ec8051303cb34f32c12a1762bef2d15c59cf22f
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/bundle/codemirror.js   | 19 ++-
web/pgadmin/static/js/backform.pgadmin.js | 16 
.../static/js/sqleditor/query_tool_preferences.js | 16 
web/pgadmin/tools/datagrid/static/js/show_data.js | 16 
4 files changed, 18 insertions(+), 49 deletions(-)

pgAdmin 4 commit: Fixed Cognitive Complexity code smell reproted by Son

[Akshay Joshi]

Fixed Cognitive Complexity code smell reproted by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ab257d512afd5d7a5eca1d58ec5904c3aa531e7
Author: Nikhil Mohite 

Modified Files
--
.../schemas/fts_configurations/__init__.py | 50 --
.../databases/schemas/fts_dictionaries/__init__.py | 65 ++
.../databases/schemas/fts_parsers/__init__.py  | 56 ---
.../databases/schemas/fts_templates/__init__.py| 80 +-
.../databases/schemas/functions/__init__.py|  8 ++-
web/pgadmin/browser/static/js/node.js  |  4 +-
6 files changed, 151 insertions(+), 112 deletions(-)

Re: [pgAdmin][patch] Dialog width issue

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jul 2, 2020 at 4:57 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a tiny patch to fix the dialog sizes snapping to default
> widths.
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Patch for SonarQube code scan fixes

[Akshay Joshi]

Thanks, patch applied.

On Wed, Jul 1, 2020 at 5:30 PM Ashesh Vashi 
wrote:

>
>
> On Wed, Jul 1, 2020 at 5:28 PM Dave Page  wrote:
>
>>
>>
>> On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>>
>>> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 I have fixed some code smell issues in the SonarQube scan, PFA patch.
 Details as follows:
 1. Functions files:

- Remove the unused local variable "args"

 2. node.js file in browser/static:

- "j" hides or potentially hides a variable declared in an outer
scope at line 1080.

 This is a common file between pgAdmin & PEM.
>>> Please send a patch to the pgadmin team.
>>>
>>
>> That's what he did! Time for a coffee perhaps my friend? :-)
>>
> Yes. :/
>
> -- Ashesh
>
>>
>>
>>> 3. FTS Templates files:

- Refactor this function to reduce its Cognitive Complexity from 22
to the 15 allowed.

 This is a common file between pgAdmin & PEM.
>>> Please send a patch to the pgadmin team.
>>>
 4. FTS Parsers files:

- Refactor this function to reduce its Cognitive Complexity from 22
to the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16
to the 15 allowed.

 This is a common file between pgAdmin & PEM.
>>> Please send a patch to the pgadmin team.
>>>
 5. FTS Dictionaries files:

- Refactor this function to reduce its Cognitive Complexity from 25
to the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16
to the 15 allowed.

 This is a common file between pgAdmin & PEM.
>>> Please send a patch to the pgadmin team.
>>>
 6. FTS Configurations files:

- Refactor this function to reduce its Cognitive Complexity from 22
to the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16
to the 15 allowed.

 This is a common file between pgAdmin & PEM.
>>> Please send a patch to the pgadmin team.
>>>
>>> -- Thanks, Ashesh
>>>

 Regards,
 Nikhil Mohite.

>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*