Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Akshay, Ignore the above patch, reconsider this latest patch with some optimizations. On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Akshay, > > I have made the relevant changes for existing and the new procedure, > functions & triggers. > > Please find the patch. > > On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> I have tested your patch and the issue is not fixed. Create one >> Procedure, Function, and Trigger Function using below code *without* >> applying your patch: >> BEGIN >> SELECT 1; >> END; >> >> Then apply your patch and check the SQL tab. >> >> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which fixes pg/ppas issues listed below: >>> >>>1. Stored procedure code indentation. >>>2. Functions code indentation. >>>3. Trigger Functions code indentation. >>> >>> Please review. >>> >>> -- >>> *Rahul Shirsat* >>> Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v3.patch Description: Binary data
Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure
Corrected some indentations. Find the patch below. On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Akshay, > > Ignore the above patch, reconsider this latest patch with some > optimizations. > > On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I have made the relevant changes for existing and the new procedure, >> functions & triggers. >> >> Please find the patch. >> >> On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Rahul >>> >>> I have tested your patch and the issue is not fixed. Create one >>> Procedure, Function, and Trigger Function using below code *without* >>> applying your patch: >>> BEGIN >>> SELECT 1; >>> END; >>> >>> Then apply your patch and check the SQL tab. >>> >>> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> Hi Hackers, Please find the attached patch which fixes pg/ppas issues listed below: 1. Stored procedure code indentation. 2. Functions code indentation. 3. Trigger Functions code indentation. Please review. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3851_v4.patch Description: Binary data
pgAdmin 4 commit: Fixed an issue where installation of pgadmin4 not wor
Fixed an issue where installation of pgadmin4 not working on 32-bit Windows. Fixes #5630 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2db518c9c6f32c1d1eb670faec1020b6790fbfe0 Author: Paresh More Modified Files -- docs/en_US/release_notes_4_24.rst | 3 ++- pkg/win32/installer.iss.in| 21 + 2 files changed, 15 insertions(+), 9 deletions(-)
Re: Patch for Redmine Bug 5630
Thanks, patch applied. On Fri, Jun 26, 2020 at 6:15 PM Paresh More wrote: > Hello Dave, > > This is regarding issue #5630 (Installation on 32-bit Windows not working) > https://redmine.postgresql.org/issues/5630 > > > There was one condition missing > - For system running a 32-bit version of Windows there should not be any > checkfor HKLM64 in RegQueryStringValue (This get reproduce purely on 32bit > machine) > > I don't have a 32-bit windows machine, so I am unable to test it. > > I am able to build this on 64-bit arch machine with this patch. > > Attached is the patch for the same. > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
