[SonarQube]: Rename class name

[Pradip Parkale]

Hi Hackers,

Please find the attached patch for :

   1. Rename class name to match the regular expression.

-- 
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


rename_class.patch
Description: Binary data

Support schema level restrictions and edit connection properties when already connected.

[Nikhil Mohite]

Hi Team,

PFA patch for  5583  support
schema level restrictions and edit connection properties when already
connected.

Details as follows:
1. Schema restrictions :

1. Added a new tab "Advanced" in the database properties, with the "Schema
restrictions" option it is similar to the "DB restrictions" in server
properties.

2. Added new table  "databases" in the SQLite database, to store schema
restrictions per database.

2. Edit connection properties when already connected:

1. Now allowing a user to edit server connection properties when the server
is already connected, here the user will get a warning for disconnect and
reconnect the server to apply the changes in configuration.

Regards,
Nikhil Mohite.


schema_restriction_and_database_connection_change.patch
Description: Binary data

pgAdmin 4 commit: Fixed code smells having rule 'Nested blocks of code

[Akshay Joshi]

Fixed code smells having rule 'Nested blocks of code should not be left empty'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7a16a4bd58d2dfb0257e5433031a2138c588e39
Author: Khushboo Vashi 

Modified Files
--
tools/update_selenoid_browsers.py  |  3 +--
.../servers/databases/schemas/tables/utils.py  |  3 ---
web/pgadmin/misc/themes/__init__.py|  4 +---
web/pgadmin/tools/backup/__init__.py   | 27 +++---
web/pgadmin/tools/import_export/__init__.py|  2 +-
web/pgadmin/tools/schema_diff/directory_compare.py |  2 +-
web/pgadmin/utils/csv.py   | 16 +
web/pgadmin/utils/session.py   |  2 +-
web/regression/feature_utils/base_feature_test.py  |  4 +---
9 files changed, 25 insertions(+), 38 deletions(-)

pgAdmin 4 commit: Fixed following SonarQube issues:

[Akshay Joshi]

Fixed following SonarQube issues:
 1. Method/Field names should comply with a naming convention.
 2. Conditionals should start on new lines

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=830ac1cc9177c8b9ebed2304924cec1db22e45c3
Author: Satish V 

Modified Files
--
web/pgadmin/misc/dependencies/static/js/dependencies.js |  3 ++-
web/pgadmin/misc/dependents/static/js/dependents.js |  3 ++-
web/pgadmin/utils/driver/abstract.py|  2 +-
web/pgadmin/utils/driver/psycopg2/__init__.py   |  2 +-
web/pgadmin/utils/driver/psycopg2/server_manager.py |  8 
web/pgadmin/utils/javascript/javascript_bundler.py  | 10 +-
web/pgadmin/utils/menu.py   | 10 +-
7 files changed, 20 insertions(+), 18 deletions(-)

pgAdmin 4 commit: Fixed code smells having rule 'Rename class name to m

[Akshay Joshi]

Fixed code smells having rule 'Rename class name to match the regular 
expression'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5206dafb3554d836b4cc477fe3a345174554d354
Author: Pradip Parkale 

Modified Files
--
web/pgadmin/utils/csv.py | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)

pgAdmin 4 commit: Ensure that the OWNER should be quoted for foreign ta

[Akshay Joshi]

Ensure that the OWNER should be quoted for foreign tables, procedures, and 
trigger functions.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a632793962d03a61f409cd5998e2560f54c3697
Author: Diego Augusto Molina 

Modified Files
--
.../event_triggers/templates/event_triggers/sql/9.3_plus/grant.sql| 4 ++--
.../foreign_tables/templates/foreign_tables/sql/9.2_plus/create.sql   | 2 +-
.../foreign_tables/templates/foreign_tables/sql/9.2_plus/update.sql   | 2 +-
.../foreign_tables/templates/foreign_tables/sql/9.5_plus/create.sql   | 2 +-
.../foreign_tables/sql/9.5_plus/foreign_table_schema_diff.sql | 2 +-
.../foreign_tables/templates/foreign_tables/sql/9.5_plus/update.sql   | 2 +-
.../foreign_tables/templates/foreign_tables/sql/default/create.sql| 2 +-
.../foreign_tables/templates/foreign_tables/sql/default/update.sql| 2 +-
.../schemas/functions/templates/procedures/pg/sql/11_plus/update.sql  | 2 +-
.../functions/templates/procedures/ppas/sql/11_plus/update.sql| 2 +-
.../functions/templates/procedures/ppas/sql/9.2_plus/update.sql   | 2 +-
.../functions/templates/procedures/ppas/sql/9.5_plus/update.sql   | 2 +-
.../functions/templates/procedures/ppas/sql/9.6_plus/update.sql   | 2 +-
.../functions/templates/procedures/ppas/sql/default/update.sql| 2 +-
.../templates/trigger_functions/ppas/sql/9.5_plus/create.sql  | 2 +-
.../templates/trigger_functions/ppas/sql/9.5_plus/update.sql  | 2 +-
16 files changed, 17 insertions(+), 17 deletions(-)

pgAdmin 4 commit: Fixed following SonarQube issues:

[Akshay Joshi]

Fixed following SonarQube issues:
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=707ff450b5ddaf69b8d4052c579aaa2807e99c64
Author: Yogesh Mahajan 

Modified Files
--
.../server_groups/servers/databases/schemas/types/static/js/type.js | 4 ++--
web/pgadmin/static/js/codemirror/addon/fold/pgadmin-sqlfoldcode.js  | 5 +++--
web/pgadmin/static/js/pgadmin.js| 2 +-
web/pgadmin/static/js/sqleditor_utils.js| 3 ++-
web/pgadmin/tools/backup/static/js/backup.js| 2 +-
web/pgadmin/tools/debugger/static/js/direct.js  | 3 ++-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js  | 6 --
web/pgadmin/tools/user_management/static/js/user_management.js  | 4 ++--
8 files changed, 17 insertions(+), 12 deletions(-)

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jun 25, 2020 at 3:53 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find an updated patch.
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Yogesh
>>
>> Jasmin tests are failing, please fix and resend the patch.
>>
>> On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find an updated patch.
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>>
>>> On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Yogesh

 After applying your patch a new sonarqube issue has been found "Change
 this argument to the documented type: Number." in sqleditor_utils.js
 Please fix that and resend the patch.

 On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <
 yogesh.maha...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find patch fixing sonarqube issues related to below rules -
>
> 1.Boolean checks should not be inverted,
> 2.Comma operator should not be used,
> 3.Arguments to built-in functions should match documented types,
> 4.Redundant pairs of parentheses should be removed,
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


 --
 *Thanks & Regards*
 *Akshay Joshi*

 *Sr. Software Architect*
 *EnterpriseDB Software India Private Limited*
 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jun 25, 2020 at 5:05 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find patch fixing the issues related to below rules -
> 1.A conditionally executed single line should be denoted by indentation,
> 2.A "while" loop should be used instead of a "for" loop.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Thu, Jun 25, 2020 at 12:28 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Yogesh
>>
>> Please fix the linter error and send the patch again.
>>
>> On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find patch fixing the issues related to below rules -
>>> 1.A conditionally executed single line should be denoted by indentation,
>>> 2.A "while" loop should be used instead of a "for" loop, \
>>> 3.Variables should be declared explicitly)
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] SonarQube Fixes

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jun 25, 2020 at 5:55 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the code smells having rule (PYTHON)
> NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Re- [SonarQube][patch]- tagged suspicious, convention

[Akshay Joshi]

Thanks, patch applied.

On Fri, Jun 26, 2020 at 11:37 AM Satish V  wrote:

> Hi Hackers,
>
> Please find the patch which resolves the SonarQube scan issue stated below.
> 1.Method/Field names should comply with a naming convention.
> 2.Conditionals should start on new lines
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [SonarQube]: Rename class name

[Akshay Joshi]

Thanks, patch applied.

On Fri, Jun 26, 2020 at 12:32 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for :
>
>1. Rename class name to match the regular expression.
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Patch for SonarQube code scan.

[Khushboo Vashi]

Hi,

Please fix PEP8 issues. Other than PEP8, everything looks good to me.

Thanks,
Khushboo

On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Khushboo,
>>
>> Details as follows:
>> 1. Package files:
>>
>> 1. Refactor this function to reduce its Cognitive Complexity from 40 to
>> the 15 allowed.
>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>> the 15 allowed.
>>
>> 2. Functions files:
>>
>> 1. Rename this local variable "argString" to match the regular expression
>> ^[_a-z][a-z0-9_]*$.
>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>> the 15 allowed.
>>
>> Thanks,
>> Nikhil Mohite.
>>
>> Thanks.
>
>>
>> On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil,
>>>
>>> Can you please provide the details of the issue provided by SonarQube
>>> (so review would be easy) ?
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 I have fixed some code smell issues in SonarQube scan.
 1. Code smells in packages init file.
 2. Code smells in function init file (not fixed all code smell will
 send new path for it).

 Regards,
 Nikhil Mohite.

Re: Patch for SonarQube code scan.

[Nikhil Mohite]

Hi Team,

resolved PEP8 warnings PFA latest patch.

On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please fix PEP8 issues. Other than PEP8, everything looks good to me.
>
> Thanks,
> Khushboo
>
> On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo,
>>>
>>> Details as follows:
>>> 1. Package files:
>>>
>>> 1. Refactor this function to reduce its Cognitive Complexity from 40 to
>>> the 15 allowed.
>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>> the 15 allowed.
>>>
>>> 2. Functions files:
>>>
>>> 1. Rename this local variable "argString" to match the regular
>>> expression ^[_a-z][a-z0-9_]*$.
>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>> the 15 allowed.
>>>
>>> Thanks,
>>> Nikhil Mohite.
>>>
>>> Thanks.
>>
>>>
>>> On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Nikhil,

 Can you please provide the details of the issue provided by SonarQube
 (so review would be easy) ?

 Thanks,
 Khushboo

 On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in SonarQube scan.
> 1. Code smells in packages init file.
> 2. Code smells in function init file (not fixed all code smell will
> send new path for it).
>
> Regards,
> Nikhil Mohite.
>
>


sonar_qube_code_smell_fixes.patch
Description: Binary data

pgAdmin 4 commit: Fixed following SonarQube issues:

[Akshay Joshi]

Fixed following SonarQube issues:
 1) Refactor function to reduce its Cognitive Complexity.
 2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=115657a465405be94c8c25dab3f88c9abd36ffb9
Author: Nikhil Mohite 

Modified Files
--
.../databases/schemas/functions/__init__.py| 119 +++-
.../servers/databases/schemas/packages/__init__.py | 210 +++--
2 files changed, 181 insertions(+), 148 deletions(-)

pgAdmin 4 commit: Improve code coverage and API test cases for Domain a

[Akshay Joshi]

Improve code coverage and API test cases for Domain and Domain Constraints. 
Fixes #5326

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e28e0a32b4c3a8bb7f3e149977afb34a0aebb24
Author: Satish V 

Modified Files
--
docs/en_US/release_notes.rst   |   1 +
docs/en_US/release_notes_4_24.rst  |  19 +
.../schemas/domains/domain_constraints/__init__.py |   1 +
.../domains/domain_constraints/tests/__init__.py   |  15 +
.../tests/domain_constraints_test_data.json| 550 
.../tests/test_domain_constraints_add.py   | 104 
.../tests/test_domain_constraints_delete.py| 113 
.../test_domain_constraints_delete_multiple.py | 115 +
.../tests/test_domain_constraints_dependents.py| 107 
.../tests/test_domain_constraints_get.py   | 135 +
.../tests/test_domain_constraints_msql.py  | 114 +
.../tests/test_domain_constraints_node.py  | 139 +
.../tests/test_domain_constraints_put.py   | 116 +
.../tests/test_domain_constraints_sql.py   | 118 +
.../domains/domain_constraints/tests/utils.py  | 221 
.../schemas/domains/tests/domain_test_data.json| 567 +
.../schemas/domains/tests/test_domain_add.py   |  85 +--
.../schemas/domains/tests/test_domain_delete.py|  64 ++-
.../domains/tests/test_domain_delete_multiple.py   |  44 +-
.../tests/test_domain_dependent_dependency.py  |  77 +++
.../schemas/domains/tests/test_domain_get.py   |  73 ++-
.../domains/tests/test_domain_get_collations.py|  83 +++
.../schemas/domains/tests/test_domain_get_node.py  |  93 
.../domains/tests/test_domain_get_types_func.py|  89 
.../schemas/domains/tests/test_domain_msql.py  |  81 +++
.../schemas/domains/tests/test_domain_put.py   |  67 ++-
.../schemas/domains/tests/test_domain_sql.py   | 160 +++---
.../databases/schemas/domains/tests/utils.py   |   7 +-
28 files changed, 3169 insertions(+), 189 deletions(-)

Re: Patch for SonarQube code scan.

[Akshay Joshi]

Thanks, patch applied.

On Fri, Jun 26, 2020 at 2:35 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> resolved PEP8 warnings PFA latest patch.
>
> On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please fix PEP8 issues. Other than PEP8, everything looks good to me.
>>
>> Thanks,
>> Khushboo
>>
>> On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Khushboo,

 Details as follows:
 1. Package files:

 1. Refactor this function to reduce its Cognitive Complexity from 40 to
 the 15 allowed.
 2. Refactor this function to reduce its Cognitive Complexity from 16 to
 the 15 allowed.

 2. Functions files:

 1. Rename this local variable "argString" to match the regular
 expression ^[_a-z][a-z0-9_]*$.
 2. Refactor this function to reduce its Cognitive Complexity from 16 to
 the 15 allowed.

 Thanks,
 Nikhil Mohite.

 Thanks.
>>>

 On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Nikhil,
>
> Can you please provide the details of the issue provided by SonarQube
> (so review would be easy) ?
>
> Thanks,
> Khushboo
>
> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have fixed some code smell issues in SonarQube scan.
>> 1. Code smells in packages init file.
>> 2. Code smells in function init file (not fixed all code smell will
>> send new path for it).
>>
>> Regards,
>> Nikhil Mohite.
>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: Reg-RM 5326[Code Coverage] Improve API test cases for Domain and Domain Constraints

[Akshay Joshi]

Thanks, patch applied.

On Thu, Jun 25, 2020 at 7:58 PM Satish V  wrote:

> Hi Hackers,
>
> Please find the attached patch which improves the code coverage for
> domains and domain constraints.
> coverage percentage for *domains *- 75 percentage from 56
> coverage percentage for *domains constraints *- 73 percentage
>
> kindly review.
>
> Thanks
> Sathish V
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

[Akshay Joshi]

Hi Pradip

Following are the review comments:

   - For function arguments please make sure the right sequence is *gid,
   sid, did, scid,  ... *All the parameters are not compulsory
   but the parameters should be in the mentioned order for consistency. Change
   it to all the functions of RLS Policy wherever not followed, revisit the
   already committed code as well.
   - In case of more than one policy, all the headers are showing as a
   comment on top of policy DDL in schema diff.
   - If the policy event is different for source and target policy then it
   is showing different but no diff SQL has been generated.
   - Created new RM #5631, fixed that to test schema diff further.


On Thu, Jun 25, 2020 at 7:38 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RLS policy support in schema diff.
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Patch for Redmine Bug 5630

[Paresh More]

Hello Dave,

This is regarding issue #5630 (Installation on 32-bit Windows not working)
https://redmine.postgresql.org/issues/5630


There was one condition missing
- For system running a 32-bit version of Windows there should not be any
checkfor  HKLM64 in RegQueryStringValue (This get reproduce purely on 32bit
machine)

I don't have a 32-bit windows machine, so I am unable to test it.

I am able to build this on 64-bit arch machine with this patch.

Attached is the patch for the same.


-- 

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell :  +919922000564 |  www.enterprisedb.com


5630_v1.patch
Description: Binary data

pgAdmin 4 commit: Fixed an issue where the semicolon is misplaced in RL

[Akshay Joshi]

Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
Fixed one regression issue introduced by renaming the method 'gc' to 
'gc_timeout'.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b91f6f0f5c3c7b45223dedaca020f2fec76dafa6

Modified Files
--
.../tests/default/alter_policy.sql |  3 +--
.../tests/default/create_insert_policy.sql |  3 +--
.../tests/default/create_public_policy.sql |  3 +--
.../tests/default/create_select_policy.sql |  3 +--
.../row_security_policies/sql/9.5_plus/create.sql  | 18 +-
web/pgadmin/utils/driver/__init__.py   |  2 +-
6 files changed, 18 insertions(+), 14 deletions(-)

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

[Rahul Shirsat]

Hi Akshay,

I have made the relevant changes for existing and the new procedure,
functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi 
wrote:

> Hi Rahul
>
> I have tested your patch and the issue is not fixed. Create one Procedure,
> Function, and Trigger Function using below code *without* applying your
> patch:
> BEGIN
>   SELECT 1;
> END;
>
> Then apply your patch and check the SQL tab.
>
> On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which fixes pg/ppas issues listed below:
>>
>>1. Stored procedure code indentation.
>>2. Functions code indentation.
>>3. Trigger Functions code indentation.
>>
>> Please review.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


RM3851_v2.patch
Description: Binary data