Re: [pgAdmin][patch] SonarQube reported issues tagged - unused
Thanks, patch applied. On Thu, Jun 25, 2020 at 10:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix SonarQube issues with the tag "unused". All > the unused variables, assignments, code comments are fixed. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 v4.23 released
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.23. This release of pgAdmin 4 includes 19 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_23.html. We are pleased to announce a number of new packaging options for pgAdmin with this release. Note that as these packages are all new, they have only been tested by the pgAdmin development team and its possible issues may be found in general use. We will aim to resolve any issues reported as quickly as possible. Please report any issues at the URL below, making sure you include any error messages and details of the platform you're running on: https://redmine.postgresql.org/projects/pgadmin4/issues/new Windows 64 bit == Windows users can now choose to use a new 64-bit build of pgAdmin. This is being published alongside the 32-bit build which will be discontinued in a future release. If you already have the 32-bit build of pgAdmin installed on Windows, you must uninstall it before installing the 64-bit build. Linux Packages == We now have pre-built native packages for popular RPM and DEB based platforms. These are all built in a consistent way and are designed to avoid the dependency issues are seen with other Linux packages in the past. RHEL/CentOS/Fedora -- Yum, repositories can be found at: https://www.postgresql.org/ftp/pgadmin/pgadmin4/yum/ Follow the instructions on that page to setup the required repository and install pgAdmin 4 in desktop or server mode. Supported platforms: - RHEL/CentOS 7 & 8 (x86_64) - Fedora 30, 31 & 32 (x86_64) Debian/Ubuntu - Yum, repositories can be found at: https://www.postgresql.org/ftp/pgadmin/pgadmin4/apt/ Follow the instructions on that page to setup the required repository and install pgAdmin 4 in desktop or server mode. Supported platforms: - Debian 9 (Stretch), 10 (Buster) - Ubuntu 16.04 (Xenial), 18.04 (Bionic), 19.04 (Disco), 19.10 (Eoan), 20.04 (Focal) PyPi Following the last release of pgAdmin, v4.22 was published to the Python package index (PyPi). This will continue with future releases, enabling users of Python 3.4 and later to install quickly and easily. Please see the Python download page for more information: https://www.pgadmin.org/download/pgadmin-4-python/ pgAdmin is the leading Open Source graphical management tool for PostgreSQL. For more information, please see: https://www.pgadmin.org/ Notable changes in this release include: - Added option to ignore the whitespaces while comparing objects in schema diff. - Added server group name while selecting servers in schema diff. - Added support of Row Security Policies. - Improve error messaging if the storage and log directories cannot be created. - Cleanup Windows build scripts and ensure Windows x64 builds will work. - Fixed an issue where the Edge browser version is showing wrong and warning message gets displayed. - Fixed an issue where select all checkbox only selects the first 50 tables. - Fixed an issue where two identical tables showing different by schema diff tool. - Fixed an issue when dumping servers from a desktop pgAdmin app by providing an option '--sqlite-path'. - Ensure that the query tool panel gets closed when clicking on the 'Don't Save' button. Builds for Windows and macOS are available now, along with a Python Wheel, Docker Container, RPM, DEB Package, and source code tarball from: https://www.pgadmin.org/download/ -- Akshay Joshi pgAdmin Project
pgAdmin 4 commit: Tag REL-4_23 has been created.
Tag REL-4_23 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_23 Log Message --- Tag v4.23
Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)
Hi, Please find an updated patch. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi wrote: > Hi Yogesh > > Jasmin tests are failing, please fix and resend the patch. > > On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hi, >> >> Please find an updated patch. >> >> >> Thanks, >> Yogesh Mahajan >> QA - Team >> EnterpriseDB Corporation >> >> Phone: +91-9741705709 >> >> >> On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Yogesh >>> >>> After applying your patch a new sonarqube issue has been found "Change >>> this argument to the documented type: Number." in sqleditor_utils.js >>> Please fix that and resend the patch. >>> >>> On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan < >>> yogesh.maha...@enterprisedb.com> wrote: >>> Hi Hackers, Please find patch fixing sonarqube issues related to below rules - 1.Boolean checks should not be inverted, 2.Comma operator should not be used, 3.Arguments to built-in functions should match documented types, 4.Redundant pairs of parentheses should be removed, Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > SonarQubeFix5_v3.patch Description: Binary data
Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)
Hi, Please find patch fixing the issues related to below rules - 1.A conditionally executed single line should be denoted by indentation, 2.A "while" loop should be used instead of a "for" loop. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jun 25, 2020 at 12:28 PM Akshay Joshi wrote: > Hi Yogesh > > Please fix the linter error and send the patch again. > > On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hi, >> >> Please find patch fixing the issues related to below rules - >> 1.A conditionally executed single line should be denoted by indentation, >> 2.A "while" loop should be used instead of a "for" loop, \ >> 3.Variables should be declared explicitly) >> >> Thanks, >> Yogesh Mahajan >> QA - Team >> EnterpriseDB Corporation >> >> Phone: +91-9741705709 >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > SonarQubeFix6_v2.patch Description: Binary data
[pgAdmin4][Patch] SonarQube Fixes
Hi, Please find the attached patch to fix the code smells having rule (PYTHON) NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. Thanks, Khushboo sonarqube_fixes_nested_code_blocks.patch Description: Binary data
[pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff
Hi Hackers, Please find the attached patch for RLS policy support in schema diff. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM-5601.patch Description: Binary data
Patch for SonarQube code scan.
Hi Team, I have fixed some code smell issues in SonarQube scan. 1. Code smells in packages init file. 2. Code smells in function init file (not fixed all code smell will send new path for it). Regards, Nikhil Mohite. sonar_qube_code_smell_fixes.patch Description: Binary data
Re: Patch for SonarQube code scan.
Hi Nikhil, Can you please provide the details of the issue provided by SonarQube (so review would be easy) ? Thanks, Khushboo On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in SonarQube scan. > 1. Code smells in packages init file. > 2. Code smells in function init file (not fixed all code smell will send > new path for it). > > Regards, > Nikhil Mohite. > >
Re: Patch for SonarQube code scan.
Hi Khushboo, Details as follows: 1. Package files: 1. Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed. 2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 2. Functions files: 1. Rename this local variable "argString" to match the regular expression ^[_a-z][a-z0-9_]*$. 2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. Thanks, Nikhil Mohite. On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Nikhil, > > Can you please provide the details of the issue provided by SonarQube (so > review would be easy) ? > > Thanks, > Khushboo > > On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have fixed some code smell issues in SonarQube scan. >> 1. Code smells in packages init file. >> 2. Code smells in function init file (not fixed all code smell will send >> new path for it). >> >> Regards, >> Nikhil Mohite. >> >>
Re: Patch for SonarQube code scan.
On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Khushboo, > > Details as follows: > 1. Package files: > > 1. Refactor this function to reduce its Cognitive Complexity from 40 to > the 15 allowed. > 2. Refactor this function to reduce its Cognitive Complexity from 16 to > the 15 allowed. > > 2. Functions files: > > 1. Rename this local variable "argString" to match the regular expression > ^[_a-z][a-z0-9_]*$. > 2. Refactor this function to reduce its Cognitive Complexity from 16 to > the 15 allowed. > > Thanks, > Nikhil Mohite. > > Thanks. > > On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Nikhil, >> >> Can you please provide the details of the issue provided by SonarQube (so >> review would be easy) ? >> >> Thanks, >> Khushboo >> >> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have fixed some code smell issues in SonarQube scan. >>> 1. Code smells in packages init file. >>> 2. Code smells in function init file (not fixed all code smell will send >>> new path for it). >>> >>> Regards, >>> Nikhil Mohite. >>> >>>
Re- [SonarQube][patch]- tagged suspicious, convention
Hi Hackers, Please find the patch which resolves the SonarQube scan issue stated below. 1.Method/Field names should comply with a naming convention. 2.Conditionals should start on new lines conditionals_and_rename.patch Description: Binary data
