Patch for Redmine Bug 5587
Hello Dave, This is regarding issue #5587 (Handle Windows x32/x64 installation using Innotool) https://redmine.postgresql.org/issues/5587 This patch will make sure the following thing - pgAdmin4 windows installer should restrict the user not to install 32bit and 64bit parallelly. - It should not allow pgAdmin4 install x64 if x32 is installed Or vice versa, only upgrade of the same type should be allowed. - If user has already installed 32bit installer and try to install 64bit it should throw an error as "You already have a 32bit installation of pgAdmin 4. Please uninstall this before installing the 64bit version." - If user has already installed 64bit installer and try to install 32bit it should throw an error as "You already have a 64 bit installation of pgAdmin 4. Please uninstall this before installing the 32 bit version." It's working fine at my end. Attached is the patch for the same. -- Thanks & Regards *Paresh More* [image: NEW-EDB-logo-4c] Pune, India. Cell : +919922000564 | www.enterprisedb.com 5587_v1.patch Description: Binary data
pgAdmin 4 commit: Fixed issues reported by SonarQube with tag 'bad-prac
Fixed issues reported by SonarQube with tag 'bad-practice'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6620f9263d4061ab01a19e71f9e22940db9bb826 Author: Aditya Toshniwal Modified Files -- .../databases/schemas/tables/indexes/__init__.py | 20 +- web/pgadmin/browser/static/js/error.js | 46 +++--- web/pgadmin/static/js/alertify.pgadmin.defaults.js | 39 -- .../tools/import_export/static/js/import_export.js | 5 +-- 4 files changed, 50 insertions(+), 60 deletions(-)
pgAdmin 4 commit: Update Italian translation.
Update Italian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecdd95d15afb281afe3bba0a6f137e34cc7f8009 Author: Domenico Sgarbossa Modified Files -- .../translations/it/LC_MESSAGES/messages.mo| Bin 180395 -> 195761 bytes .../translations/it/LC_MESSAGES/messages.po| 1316 +--- 2 files changed, 591 insertions(+), 725 deletions(-)
pgAdmin 4 commit: Fixed an issue where the search object is unable to l
Fixed an issue where the search object is unable to locate inherited tables and constraint filters are not working. Fixes #5492 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6b22f1f4c631d969910d0ee09755fae0943785e Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_23.rst | 1 + .../static/js/search_objects_dialog_wrapper.js | 15 +++-- .../search_objects/sql/pg/10_plus/search.sql | 37 -- .../search_objects/sql/pg/11_plus/search.sql | 37 -- .../search_objects/sql/ppas/10_plus/search.sql | 37 -- .../search_objects/sql/ppas/12_plus/search.sql | 37 -- 6 files changed, 98 insertions(+), 66 deletions(-)
pgAdmin 4 commit: Update Japanese translation.
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e40995ab0ed88c518e7b8980ffa5235d5bcf69b Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 193944 -> 196920 bytes .../translations/ja/LC_MESSAGES/messages.po| 140 +++-- 2 files changed, 72 insertions(+), 68 deletions(-)
pgAdmin 4 commit: 1) Fixes parallel test execution failures.
1) Fixes parallel test execution failures. 2) Added capability to pass browser-name via command line for parallel execution. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34fbe756e854bc202c53abfa12e7257851415e7c Author: Yogesh Mahajan Modified Files -- web/pgadmin/feature_tests/file_manager_test.py | 11 +- .../feature_tests/query_tool_journey_test.py | 20 ++- web/pgadmin/feature_tests/query_tool_tests.py | 1 + .../xss_checks_panels_and_query_tool_test.py | 5 +- web/regression/python_test_utils/test_utils.py | 19 ++- web/regression/runtests.py | 178 +++-- 6 files changed, 134 insertions(+), 100 deletions(-)
pgAdmin 4 commit: Fixed issue related to reducing the if-else statement
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=daad16ea93c778cd28d5df6c2ce48c0374448304 Author: Satish V Modified Files -- .../static/js/unique_constraint.js | 6 +--- .../schemas/tables/indexes/static/js/index.js | 6 +--- .../tables/partitions/static/js/partition.js | 22 +- .../schemas/tables/rules/static/js/rule.js | 24 +++ .../databases/schemas/tables/static/js/table.js| 22 +- .../schemas/tables/triggers/static/js/trigger.js | 35 +++--- .../servers/databases/static/js/database.js| 3 +- .../user_management/static/js/user_management.js | 30 --- 8 files changed, 36 insertions(+), 112 deletions(-)
Re: [pgAdmin] : Patch fixing Feature Test failures.
Thanks, patch applied. On Mon, Jun 22, 2020 at 12:01 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch which fixes parallel test execution failures. > Also, added capability to pass browser-name via command line for parallel > execution. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Translators: Release next week
Thanks, patch applied. On Sun, Jun 21, 2020 at 9:15 PM Domenico Sgarbossa wrote: > Hi, here italians files > Bye! > > Il venerdì 19 giugno 2020, 14:33:00 CEST, Akshay Joshi < > akshay.jo...@enterprisedb.com> ha scritto: > > > Hi Translators, > > We will have a release next week, so updates to translations before > release would be helpful. The template and catalogs have been updated in > git. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][patch]SonarQube tagged clumsy
Thanks, patch applied. On Mon, Jun 22, 2020 at 10:38 AM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which solves the problem related > to reducing if else statement to single return expression. > Kindly review and share the changes required.. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][patch] SonarQube tagged bad-practice
Thanks, patch applied. On Mon, Jun 22, 2020 at 10:18 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix issues reported by SonarQube with tag > "bad-practice". > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Translators: Release next week
Thanks, patch applied. On Sat, Jun 20, 2020 at 12:59 PM fn ln wrote: > Hello. > Here's an updated Japanese translation for upcoming version 4.23 release. > (messages.pot revision; 7ce7808093) > > 2020年6月19日(金) 21:32 Akshay Joshi : > >> Hi Translators, >> >> We will have a release next week, so updates to translations before >> release would be helpful. The template and catalogs have been updated in >> git. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM5492] Search Object - Unable to locate inherited tables and Constraints filter not working
Thanks, patch applied. On Thu, Jun 11, 2020 at 4:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the following search objects dialog issues: > 1) Unable to locate inherited tables. Fixed. > 2) "Constraints" type filter not working. Fixed. > > Please review. > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error
Hi Hackers, Please find the patch fixing error shown in the query tool while in progress query execution on session termination from dashboard. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM3591_v1.patch Description: Binary data
Re: [pgAdmin][RM5516]: Added support of Row Security Policies
Hi Akshay, Please find the updated patch. I have added a new RLS policy event 'ALL'. On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi wrote: > Thanks, patch applied with the following modifications: > > >- js file name should be "row_security_policy.js" instead of >"row_security_policies.js". >- Node name should be "row_security_policy" instead of >"row_level_policies". Node name should not be pluralized and it matches the >folder name. >- Icon name should be "coll-row_security_policy.svg" and >"row_security_policy.svg", it should matches with the Node name. >- The 'Owner' should be renamed to 'Role' and there must be >a role 'public' in the drop-down list. If the user does not provide any >role then by default it is public. >- Keywords like select, where, As should be in upper case in Jinja >template. >- The policy node is disappeared when updating any value. Fixed that >issue. >- There is no icon showing after creating the RLS node. > > > > On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for the 'Row Level Security' feature. >> I have added RE-SQL and API test cases also. >> >> To run the RE-SQL cases - >> >>- python runtests.py --pkg resql --modules row_security_policies. >> >> To run the API cases - >> >>- python runtests.py --pkg >> >> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation cld-5516_v2.patch Description: Binary data
[pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)
Hi Hackers, Please find patch fixing sonarqube issues related to below rules - 1.Boolean checks should not be inverted, 2.Comma operator should not be used, 3.Arguments to built-in functions should match documented types, 4.Redundant pairs of parentheses should be removed, Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix5_v1.patch Description: Binary data
pgAdmin 4 commit: Disallow installation of the 32 and 64 bit builds at
Disallow installation of the 32 and 64 bit builds at the same time on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d25973a779890787c35e91e9e664ade8ac95220 Author: Paresh More Modified Files -- pkg/win32/installer.iss.in | 70 -- 1 file changed, 56 insertions(+), 14 deletions(-)
Re: Patch for Redmine Bug 5587
Thanks, applied with some spelling fixes :-p Akshay, please have one of the team test this thoroughly. On Mon, Jun 22, 2020 at 8:31 AM Paresh More wrote: > Hello Dave, > > This is regarding issue #5587 (Handle Windows x32/x64 installation using > Innotool) > https://redmine.postgresql.org/issues/5587 > > This patch will make sure the following thing > > >- pgAdmin4 windows installer should restrict the user not to install >32bit and 64bit parallelly. >- It should not allow pgAdmin4 install x64 if x32 is installed Or vice >versa, only upgrade of the same type should be allowed. > > >- If user has already installed 32bit installer and try to install >64bit it should throw an error as "You already have a 32bit installation of >pgAdmin 4. Please uninstall this before installing the 64bit version." > > >- If user has already installed 64bit installer and try to install >32bit it should throw an error as "You already have a 64 bit installation >of pgAdmin 4. Please uninstall this before installing the 32 bit version." > > > It's working fine at my end. > > Attached is the patch for the same. > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Update version for release.
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2268c82ee99221008c8b8eb075cd6b59ed6a550 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
pgAdmin 4 commit: Ensure that the query tool should display the proper
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=caebdcfa912e6e40f5823406745fdefcfe8d3389 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_23.rst | 1 + web/pgadmin/utils/driver/psycopg2/connection.py | 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-)
pgAdmin 4 commit: Documentation of Row Level Security Policies. Fixes #
Documentation of Row Level Security Policies. Fixes #5581 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2f4a62bf36ea129a69aeea0fb27ae15f5bddc69 Author: Yogesh Mahajan Modified Files -- docs/en_US/images/rls_policy_commands_tab.png | Bin 0 -> 73862 bytes docs/en_US/images/rls_policy_general_tab.png | Bin 0 -> 70609 bytes docs/en_US/images/rls_policy_sql_tab.png | Bin 0 -> 120105 bytes docs/en_US/images/table_advanced.png | Bin 88949 -> 112697 bytes docs/en_US/modifying_tables.rst | 1 + docs/en_US/release_notes_4_23.rst | 1 + docs/en_US/rls_policy_dialog.rst | 57 ++ docs/en_US/table_dialog.rst | 4 +- 8 files changed, 62 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Added policy event 'ALL' in events drop-down list.
Added policy event 'ALL' in events drop-down list. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6012f49919f9d9084fb697de2a28182ed50d3444 Author: Pradip Parkale Modified Files -- .../tables/row_security_policies/static/js/row_security_policy.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Re: [pgAdmin][RM5516]: Added support of Row Security Policies
Thanks, patch applied. On Mon, Jun 22, 2020 at 3:23 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. I have added a new RLS policy event 'ALL'. > > > On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied with the following modifications: >> >> >>- js file name should be "row_security_policy.js" instead of >>"row_security_policies.js". >>- Node name should be "row_security_policy" instead of >>"row_level_policies". Node name should not be pluralized and it matches >> the >>folder name. >>- Icon name should be "coll-row_security_policy.svg" and >>"row_security_policy.svg", it should matches with the Node name. >>- The 'Owner' should be renamed to 'Role' and there must be >>a role 'public' in the drop-down list. If the user does not provide any >>role then by default it is public. >>- Keywords like select, where, As should be in upper case in Jinja >>template. >>- The policy node is disappeared when updating any value. Fixed that >>issue. >>- There is no icon showing after creating the RLS node. >> >> >> >> On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale < >> pradip.park...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for the 'Row Level Security' feature. >>> I have added RE-SQL and API test cases also. >>> >>> To run the RE-SQL cases - >>> >>>- python runtests.py --pkg resql --modules row_security_policies. >>> >>> To run the API cases - >>> >>>- python runtests.py --pkg >>> >>> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error
Thanks, patch applied. On Mon, Jun 22, 2020 at 2:58 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch fixing error shown in the query tool while in > progress query execution on session termination from dashboard. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin] : Patch fixing Feature Test failures.
Hi Hackers, Please find the patch which fixes parallel test execution failures. Handled slowness when multiple sessions are logged in concurrently. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 fix_selenium_grid_failures_v3.0.patch Description: Binary data
pgAdmin4 v4.23 candidate builds
Hi All, pgAdmin4 v4.23 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-06-22-1/ Team, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin4] Fix RLS node dialog help link
Hi, PFA minor patch to fix the issue where RLS node dialog help is not opening. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_RLS_dialog_help.diff Description: Binary data
