pgAdmin 4 commit: Cleanup some duplicated styles.
Cleanup some duplicated styles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ca99129873d01081e6ca0055dceaccb0cc66fe2 Modified Files -- docs/en_US/theme/pgadmin4/static/style.css | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-)
pgAdmin 4 commit: Cleanup some variable naming.
Cleanup some variable naming. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa15d2a7e2b32e3cd1c1e61634caa99b78a99a0c Modified Files -- pkg/mac/dmg-license.py | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)
pgAdmin 4 commit: Correct URL and versions.
Correct URL and versions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6525f25a227d603b2b1137eacb00ed2df2db0f78 Modified Files -- tools/dependency_inventory.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgAdmin 4 commit: Correct function naming.
Correct function naming. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f5e8962b5fa66f00e2d790a5a2d3cc65787e4e8 Modified Files -- tools/copyright_updater.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgAdmin 4 commit: 1) Added option to ignore the whitespaces while compa
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468 2) Added server group name while selecting servers in schema diff. Fixes #5500 3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb268075c2e8f61c6297ead49970c6f81e04c292 Modified Files -- docs/en_US/images/preferences_schema_diff.png | Bin 93009 -> 119849 bytes docs/en_US/preferences.rst | 3 ++ docs/en_US/release_notes_4_23.rst | 3 ++ .../databases/schemas/tables/columns/utils.py | 4 +-- .../databases/schemas/tables/indexes/__init__.py | 12 +++ .../databases/schemas/tables/schema_diff_utils.py | 15 +--- web/pgadmin/static/css/style.css | 1 + web/pgadmin/tools/schema_diff/__init__.py | 31 web/pgadmin/tools/schema_diff/compare.py | 2 ++ web/pgadmin/tools/schema_diff/directory_compare.py | 39 .../schema_diff/static/js/schema_diff.backform.js | 40 +++-- .../tools/schema_diff/static/js/schema_diff_ui.js | 18 ++ 12 files changed, 132 insertions(+), 36 deletions(-)
[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2
Hi, Please find patching and fixing issues related to shadowing variables of some more js files. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix3_v1.patch Description: Binary data
pgAdmin 4 commit: Fixed issue related to shadowing variables reported b
Fixed issue related to shadowing variables reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c12ade161ebe852b8e05cca7eb9120a9c4819de Author: Yogesh Mahajan Modified Files -- .../servers/tablespaces/static/js/tablespace.js| 30 +- web/pgadmin/browser/static/js/browser.js | 366 ++--- web/pgadmin/browser/static/js/collection.js| 34 +- 3 files changed, 215 insertions(+), 215 deletions(-)
Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions
Thanks, patch applied. On Wed, Jun 17, 2020 at 10:55 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the patch for few more similar issues. Please review. > > On Tue, Jun 16, 2020 at 11:16 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Jun 16, 2020 at 10:01 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached patch will fix few vulnerabilities and few design suspicions >>> where >>> two conditional structures are having same implementation. >>> Please review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed vulnerabilities and few design suspicions where
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df05efd7d9c5981d254f3fea3d025e14755af2db Author: Aditya Toshniwal Modified Files -- .../databases/schemas/tables/indexes/__init__.py | 6 +++-- .../servers/databases/schemas/tables/utils.py | 6 ++--- .../server_groups/servers/static/js/privilege.js | 18 ++--- .../tools/debugger/static/js/debugger_ui.js| 30 -- web/pgadmin/tools/debugger/static/js/direct.js | 13 +- .../tools/schema_diff/static/js/schema_diff_ui.js | 10 ++-- .../user_management/static/js/user_management.js | 13 +++--- web/pgadmin/utils/session.py | 9 +++ web/pgadmin/utils/sqlautocomplete/autocomplete.py | 9 +++ 9 files changed, 28 insertions(+), 86 deletions(-)
Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube -2
Thanks, patch applied. On Tue, Jun 16, 2020 at 5:52 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patching fixing issues related to shadowing variables of some > more js file. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube -2
Thanks, patch applied. On Wed, Jun 17, 2020 at 4:34 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patching and fixing issues related to shadowing variables of > some more js files. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed some sonarqube issues.
Fixed some sonarqube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ed1e1e5b6d07751aca1db3e29d28d146930f14f Modified Files -- .../servers/databases/schemas/functions/static/js/procedure.js| 2 +- .../constraints/check_constraint/static/js/check_constraint.js| 2 +- .../exclusion_constraint/static/js/exclusion_constraint.js| 2 +- .../servers/databases/schemas/views/static/js/mview.js| 2 +- web/pgadmin/browser/static/js/collection.js | 8 web/pgadmin/dashboard/static/js/dashboard.js | 4 +--- web/pgadmin/misc/file_manager/static/scss/_file_manager.scss | 5 - web/pgadmin/static/scss/_pgadmin.style.scss | 2 +- web/pgadmin/static/scss/resources/_default.style.scss | 2 +- 9 files changed, 11 insertions(+), 18 deletions(-)
[pgAdmin][patch] Sonarqube issues tagged as redundant
Hi Hackers, Attached is the patch to fix sonarqube issues tagged as redundant. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" sonarqube.redundant.patch Description: Binary data
pgAdmin 4 commit: Fixed redundant tagged issue reported by SonarQube.
Fixed redundant tagged issue reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0490a54b7db6b07c5a4df1b83a18e1ff833401e Author: Aditya Toshniwal Modified Files -- .../databases/extensions/static/js/extension.js| 2 +- .../check_constraint/static/js/check_constraint.js | 2 +- .../databases/schemas/tables/indexes/__init__.py | 6 ++ .../databases/schemas/tables/rules/static/js/rule.js | 2 +- .../schemas/tables/triggers/static/js/trigger.js | 5 ++--- .../servers/databases/schemas/views/static/js/mview.js | 4 ++-- .../servers/databases/schemas/views/static/js/view.js | 4 ++-- .../servers/pgagent/steps/static/js/pga_jobstep.js | 2 +- .../server_groups/servers/roles/static/js/role.js | 4 ++-- web/pgadmin/browser/static/js/browser.js | 2 +- web/pgadmin/browser/static/js/node.js | 3 +-- web/pgadmin/misc/statistics/static/js/statistics.js| 18 -- web/pgadmin/static/js/backform.pgadmin.js | 2 +- web/pgadmin/static/js/keyboard_shortcuts.js| 4 +--- web/pgadmin/static/js/pgadmin.js | 2 +- web/pgadmin/static/js/slickgrid/editors.js | 2 +- .../static/js/sqleditor/query_tool_notifications.js| 2 +- web/pgadmin/static/js/utils.js | 2 +- web/pgadmin/tools/debugger/static/js/direct.js | 2 +- .../tools/grant_wizard/static/js/grant_wizard.js | 2 +- web/pgadmin/tools/maintenance/static/js/maintenance.js | 2 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 2 +- 22 files changed, 34 insertions(+), 42 deletions(-)
Re: [pgAdmin][patch] Sonarqube issues tagged as redundant
Thanks, patch applied. On Thu, Jun 18, 2020 at 10:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix sonarqube issues tagged as redundant. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re-[Sonarqube]- Clumsy code
Hi Hackers, Please find the patch in the attachment which resolves below issue. 1.Replace this if-then-else statement by a single return statement. Kindy review and share the changes, if required Thanks, Sathish V if_else_reduction.patch Description: Binary data
[pgAdmin4][Patch] - Issue fixes reported by SonarQube - 4 (Rule Comma operator should not be used)
Hi, Please find patching and fixing issues related to "Rule *Comma operator should not be used*" across the project. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix4_v1.patch Description: Binary data
