Reg-[Sonarqube]CodeSmell issues
Hi Hackers, Please find the patch in the attachment which resolves below issues 1.Replace this if-then-else statement by a single return statement.(clumsy) 2."switch" statements should have at least 3 "case" clauses. (bad practise) Kindly review and share the changes, if required. Thanks Sathish V switch_case_and_if_else_reduction.patch Description: Binary data
pgAdmin 4 commit: Fixed runtime issues reported by SonarQube.
Fixed runtime issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf64e2c97c764763186569280afeaedafa342590 Modified Files -- runtime/ConfigWindow.cpp | 6 +- runtime/ConfigWindow.h | 1 + runtime/FloatingWindow.cpp | 14 -- runtime/FloatingWindow.h | 10 +- runtime/LogWindow.cpp | 6 +- runtime/LogWindow.h| 1 + runtime/MenuActions.cpp| 6 +- runtime/MenuActions.h | 6 +++--- runtime/Server.cpp | 6 ++ runtime/Server.h | 4 ++-- runtime/TrayIcon.cpp | 9 + runtime/TrayIcon.h | 10 +- runtime/pgAdmin4.cpp | 4 ++-- 13 files changed, 37 insertions(+), 46 deletions(-)
pgAdmin 4 commit: Fixed following issues reported by SonarQube:
Fixed following issues reported by SonarQube: 1) Replace this if-then-else statement by a single return statement. (clumsy) 2) 'switch' statements should have at least 3 'case' clauses. (bad practice) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d43518cb3c1a393af544f2a81633c20b06e1e00c Author: Satish V Modified Files -- .../schemas/functions/static/js/function.js| 5 ++-- .../schemas/functions/static/js/procedure.js | 7 + .../functions/static/js/trigger_function.js| 5 ++-- .../schemas/tables/columns/static/js/column.js | 32 ++ .../static/js/compound_trigger.js | 6 +--- .../check_constraint/static/js/check_constraint.js | 6 +--- .../static/js/exclusion_constraint.js | 3 +- .../index_constraint/static/js/primary_key.js | 6 +--- 8 files changed, 17 insertions(+), 53 deletions(-)
Re: Reg-[Sonarqube]CodeSmell issues
Thanks, patch applied. On Tue, Jun 16, 2020 at 12:49 PM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which resolves below issues > 1.Replace this if-then-else statement by a single return > statement.(clumsy) > 2."switch" statements should have at least 3 "case" clauses. (bad > practise) > Kindly review and share the changes, if required. > > > Thanks > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin4][Patch] - Issue fixes reported by SonarQube -2
Hi, Please find patching fixing issues related to shadowing variables of some more js file. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix2_v1.patch Description: Binary data
Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions
Hi, Attached is the patch for few more similar issues. Please review. On Tue, Jun 16, 2020 at 11:16 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Jun 16, 2020 at 10:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch will fix few vulnerabilities and few design suspicions >> where >> two conditional structures are having same implementation. >> Please review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" sonarqube.design.part2.patch Description: Binary data
