Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true
Hi Hackers, Please find the patch in the attachment which clears the sonarqube error, related to expressions evaluated to true/false always. Kindly review the patch and share the changes required Thanks, Sathish V refactor_always_evaluate_to_true.patch Description: Binary data
Re: [pgAdmin][patch] Clumsy coding related fixes
Hi, Few more clumsy coding related fixes. Please review. On Fri, Jun 12, 2020 at 3:25 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jun 12, 2020 at 11:40 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for some clumsy coding related fixes as reported by >> SonarQube. This is the first batch, and will be sending another later. >> Please review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" sonarqube.clumsy.part2.patch Description: Binary data
Re: [pgAdmin][patch] Clumsy coding related fixes
Hi, Please ignore the previous patch, attached is the updated patch. On Mon, Jun 15, 2020 at 11:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Few more clumsy coding related fixes. > Please review. > > On Fri, Jun 12, 2020 at 3:25 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Fri, Jun 12, 2020 at 11:40 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for some clumsy coding related fixes as reported >>> by SonarQube. This is the first batch, and will be sending another later. >>> Please review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" sonarqube.clumsy.part2.patch Description: Binary data
