[pgAdmin4][Patch] - RM 5481 update is truncating data for type character with length
Hi Hackers, Attached is the patch to fix the data truncation issue when updating the data of the type character with length. To fix this issue I have created a ignore type cast list, where while inserting/updating we ignore the typecasting for the mentioned data type. Added test cases for character and bit Data Type. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_5481.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM 5481 update is truncating data for type character with length
Hi Akshay, The patch looks good to me. The test cases work fine. I've also tested with custom domain types and is working fine. On Mon, May 25, 2020 at 3:45 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the data truncation issue when updating the > data of the type character with length. To fix this issue I have created a > ignore type cast list, where while inserting/updating we ignore the > typecasting for the mentioned data type. > > Added test cases for character and bit Data Type. > > Please review it. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Update version for release.
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1347c89d619503196a6859801f6cb13eb8bda266 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
pgAdmin 4 commit: Fixed data truncation issue when updating the data of
Fixed data truncation issue when updating the data of type character with length. Fixes #5481 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1cbcc7ef603205d5fa98a5bfb8d072681659330 Modified Files -- docs/en_US/release_notes_4_22.rst | 1 + .../templates/sqleditor/sql/default/insert.sql | 2 +- .../templates/sqleditor/sql/default/update.sql | 2 +- .../sqleditor/tests/test_view_data_templates.py| 12 +- .../tools/sqleditor/utils/save_changed_data.py | 13 +- .../utils/tests/test_save_changed_data.py | 721 + 6 files changed, 633 insertions(+), 118 deletions(-)
pgAdmin4 v4.22 candidate builds
Hi All, pgAdmin4 v4.21 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-05-25-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: pgAdmin4 v4.22 candidate builds
On Mon, May 25, 2020 at 6:54 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.21 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2020-05-25-1/ > pgAdmin4 v4.22 candidate builds. Sorry for the typo > > > Fahar, can you please verify it for release on Thursday. > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
