Re: [pgAdmin][RM5455] Cleanup pgAdmin.py
Hi Dave Can you please review it and check whether it fulfills your requirement or not. On Thu, Apr 30, 2020 at 7:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to restructure pgAdmin4.py so that the startup code > can be imported by setup_pip.py. > Code is also changed to tidy and restructure the code a bit. Changes won't > affect other runners like runtime, WSGI, etc. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM5455] Cleanup pgAdmin.py
Hi On Thu, Apr 30, 2020 at 2:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to restructure pgAdmin4.py so that the startup code > can be imported by setup_pip.py. > Code is also changed to tidy and restructure the code a bit. Changes won't > affect other runners like runtime, WSGI, etc. > > Please review. > Looks good structure-wise. Here's an updated patch with a couple of very minor tweaks. It seems to work fine from the wheel entry point, and as a top-level script. However, in testing under Debian 10, having built and installed the .deb packages: - Desktop mode just times out during startup with the following error in the application log: 2020-05-01 09:54:56,839: ERROR flask.app: Error starting the app server: (, PermissionError(13, 'Permission denied'), ) - In server mode on the same system (setup using the setup-web.sh), upon login I'm redirected to / which displays the default Apache index.html. Manually navigating to /pgadmin4 again does the right thing. Unlike the desktop error, this one is not resolved if I revert your patch, so I think we must have broken this elsewhere (which is worrying, as we've just done a release). Can you look into these issues ASAP please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM5455_v2.patch Description: Binary data
Re: Patch to remove Python 2.7 support in the macOS Appbundle
Akshay, are you happy with this patch? On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote: > > > On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The code looks good to me. The package building was tested by Neel and we >> found that the venv was built with Python 3+ but the runtime was built >> against Python 2.7. >> As per Dave, Neel may have not used a venv of the correct version as it >> is working fine on Dav'e system. So, we can commit the patch. >> > > Yeah, that's not ideal, but the same problem exists today. I need to spend > some time figuring out how to make that more robust. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Rename the README and fix it up to match modern reali
Rename the README and fix it up to match modern reality. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=70e24ba0591a057028ffdedd9d4c30f573eb0244 Modified Files -- pkg/mac/README | 42 ++ 1 file changed, 42 insertions(+)
pgAdmin 4 commit: Minor cleanup and modernisation.
Minor cleanup and modernisation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ec60a6f85c1b0a5ca1686d1225d2bb3b970b512 Modified Files -- pkg/mac/codesign.conf.in | 2 +- pkg/mac/framework.conf.in | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)
pgAdmin 4 commit: Rename README
Rename README Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bdf900b257596d2d600ba827a375db17508152c Modified Files -- pkg/mac/README.txt | 32 1 file changed, 32 deletions(-)
Cleanup runtime qmake code
The attached patch tidies up the qmake code for configuring the runtime build so that it's consistent on all platforms, and simply requires that the PGADMIN_PYTHON_DIR environment variable points to the Python installation to be used. Please review, but don't commit, as this change will probably break some of the Jenkins jobs. I'll commit and fix them when the patch has passed review. (Sidenote: this is part of a larger tidy up/standardisation of the build scripts). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Cleanup_runtime_Python_detection.patch Description: Binary data
