Re: Translators: Release next week
hello in attachment french translation for upcoming relase bye Fred - Mail original - De: "Akshay Joshi" À: "pgadmin-hackers" Envoyé: Vendredi 24 Avril 2020 15:03:07 Objet: Translators: Release next week Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. -- Thanks & Regards Akshay Joshi Sr. Software Architect EnterpriseDB Software India Private Limited Mobile: +91 976-788-8246 messages-fr.tar.xz Description: application/xz-compressed-tar
Re: [pgAdmin][RM4279] : Issue with File Browser Home button
Hi Yogesh,
Just did an eyeball review. You've included homedir path in the response
rendered JS file. You're exposing underlying directory structure to users
even in server mode. This is not appropriate. This info should remain at
the server and not at the client side.
+homedir=os.path.expanduser('~'),
On Fri, Apr 24, 2020 at 7:26 PM Yogesh Jain
wrote:
> Hi Hackers,
>
> Attached is the patch to fix the issue with the file browser Home button.
>
> FYI : While clicking on the home button it was pointing to the user's root
> directory rather than home directory, which is fixed in this patch.
>
> Please review.
> PFA.
>
> --
> Regards,
> Yogesh Jain
> 8982696654
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
[pgAdmin4][Patch] - Improve LDAP Error messages
Hi, Please find the attached patch to improve the ldap error messages. Thanks, Khushboo ldap_error_messages.patch Description: Binary data
Re: Addition of support for base path in pgAdmin Web
Hi Aditya Can you please review it. On Sat, Apr 25, 2020 at 3:28 PM Eldhose M Joy wrote: > Hi, > > I have added a commit on 2 files to include a base path that would avoid > all the hassle while doing a reverse proxy on to the pgAdmin. Please find > the commits below. > > https://github.com/postgres/pgadmin4/compare/master...eldhosemjoy:patch-2 > https://github.com/postgres/pgadmin4/compare/master...eldhosemjoy:patch-3 > > Thanks and Regards, > Eldhose > > Sent from my iPhone > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4279] : Issue with File Browser Home button
Hi Aditya,
Thanks for the feedback. Here is an updated patch, regarding the same.
Please Review.
PFA.
On Mon, Apr 27, 2020 at 9:05 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Yogesh,
>
> Just did an eyeball review. You've included homedir path in the response
> rendered JS file. You're exposing underlying directory structure to users
> even in server mode. This is not appropriate. This info should remain at
> the server and not at the client side.
> +homedir=os.path.expanduser('~'),
>
> On Fri, Apr 24, 2020 at 7:26 PM Yogesh Jain
> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the issue with the file browser Home button.
>>
>> FYI : While clicking on the home button it was pointing to the user's
>> root directory rather than home directory, which is fixed in this patch.
>>
>> Please review.
>> PFA.
>>
>> --
>> Regards,
>> Yogesh Jain
>> 8982696654
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Regards,
Yogesh Jain
8982696654
diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py
index 39aa39315..6ec75716e 100644
--- a/web/pgadmin/misc/file_manager/__init__.py
+++ b/web/pgadmin/misc/file_manager/__init__.py
@@ -249,13 +249,14 @@ def file_manager_config(trans_id):
pref = Preferences.module('file_manager')
file_dialog_view = pref.preference('file_dialog_view').get()
show_hidden_files = pref.preference('show_hidden_files').get()
-
+homedir ='/' if(config.SERVER_MODE) else os.path.expanduser('~')
return Response(response=render_template(
"file_manager/js/file_manager_config.json",
_=gettext,
data=data,
file_dialog_view=file_dialog_view,
-show_hidden_files=show_hidden_files
+show_hidden_files=show_hidden_files,
+homedir=homedir
),
status=200,
mimetype="application/json"
diff --git a/web/pgadmin/misc/file_manager/static/js/utility.js b/web/pgadmin/misc/file_manager/static/js/utility.js
index 353baf560..181f75abb 100644
--- a/web/pgadmin/misc/file_manager/static/js/utility.js
+++ b/web/pgadmin/misc/file_manager/static/js/utility.js
@@ -1141,14 +1141,11 @@ define([
setTimeout(function() {
var b = $('.currentpath').val(),
-$level_up = $('.file_manager').find('button.level-up'),
-$home_btn = $('.file_manager').find('button.home');
+$level_up = $('.file_manager').find('button.level-up');
if (b === '/') {
$level_up.attr('disabled', 'disabled');
-$home_btn.attr('disabled', 'disabled');
} else {
-$home_btn.removeAttr('disabled');
$level_up.removeAttr('disabled');
}
}, 100);
@@ -1343,8 +1340,7 @@ define([
$('.delete_item, .fileinfo .fm_dimmer').hide();
});
- // Disable home button on load
- $('.file_manager').find('button.home').attr('disabled', 'disabled');
+ // Disable button on load
$('.file_manager').find('button.rename').attr('disabled', 'disabled');
// stop click event on dimmer click
@@ -1382,7 +1378,7 @@ define([
$('.file_manager .home').on('click', function() {
var currentViewMode = $('.fileinfo').data('view');
$('.fileinfo').data('view', currentViewMode);
-getFolderInfo('/');
+getFolderInfo(config.options.homedir);
enab_dis_level_up();
});
diff --git a/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json b/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
index b29fcfb5f..3a7ed8d5c 100644
--- a/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
+++ b/web/pgadmin/misc/file_manager/templates/file_manager/js/file_manager_config.json
@@ -11,7 +11,8 @@
"capabilities": [{% for i in data.capabilities %}{% if loop.index != 1 %}, {% endif %}"{{i}}"{% endfor %}],
"allowed_file_types": [{% for i in data.supported_types %}{% if loop.index != 1 %}, {% endif %}"{{i}}"{% endfor %}],
"platform_type": "{{ data.platform_type }}",
- "show_volumes": {% if data.show_volumes %}true{% else %}false{% endif %}
+ "show_volumes": {% if data.show_volumes %}true{% else %}false{% endif %},
+ "homedir":"{{homedir}}"
},
"security": {
"uploadPolicy": "{{ data.security.uploadPolicy }}",
Re: [pgAdmin][RM4279] : Issue with File Browser Home button
Hi Hackers,
I have tested this patch in linux (Ubuntu 18.04) env only , which is
working fine. It will be great if someone can review/test in the Windows
environment as well as I don't have the setup ready for that.
On Mon, Apr 27, 2020 at 10:47 AM Yogesh Jain
wrote:
> Hi Aditya,
>
> Thanks for the feedback. Here is an updated patch, regarding the same.
>
> Please Review.
> PFA.
>
> On Mon, Apr 27, 2020 at 9:05 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Yogesh,
>>
>> Just did an eyeball review. You've included homedir path in the response
>> rendered JS file. You're exposing underlying directory structure to users
>> even in server mode. This is not appropriate. This info should remain at
>> the server and not at the client side.
>> +homedir=os.path.expanduser('~'),
>>
>> On Fri, Apr 24, 2020 at 7:26 PM Yogesh Jain
>> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the issue with the file browser Home button.
>>>
>>> FYI : While clicking on the home button it was pointing to the user's
>>> root directory rather than home directory, which is fixed in this patch.
>>>
>>> Please review.
>>> PFA.
>>>
>>> --
>>> Regards,
>>> Yogesh Jain
>>> 8982696654
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Regards,
> Yogesh Jain
> 8982696654
>
--
Regards,
Yogesh Jain
8982696654
Re: Addition of support for base path in pgAdmin Web
Hi Eldhose, The changes you've suggested are already implemented in pgAdmin ( https://github.com/postgres/pgadmin4/blob/master/web/pgAdmin4.py#L87). Almost all the servers provide the way to set the header - "X-Script-Name". pgAdmin uses X-Script-Name to set the prefix. You don't need to add any new config in pgAdmin. For instance, in nginx it can be done as: proxy_set_header X-Script-Name /pgadmin4; Please refer: https://www.pgadmin.org/docs/pgadmin4/4.20/server_deployment.html#hosting In case, the above setting is not working then please log a bug at - https://redmine.postgresql.org/projects/pgadmin4/issues/new On Mon, Apr 27, 2020 at 10:29 AM Akshay Joshi wrote: > Hi Aditya > > Can you please review it. > > On Sat, Apr 25, 2020 at 3:28 PM Eldhose M Joy > wrote: > >> Hi, >> >> I have added a commit on 2 files to include a base path that would avoid >> all the hassle while doing a reverse proxy on to the pgAdmin. Please find >> the commits below. >> >> https://github.com/postgres/pgadmin4/compare/master...eldhosemjoy:patch-2 >> https://github.com/postgres/pgadmin4/compare/master...eldhosemjoy:patch-3 >> >> Thanks and Regards, >> Eldhose >> >> Sent from my iPhone >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it
Hi Murtuza API test cases are not running, there is no error but all the tests are skipped. I have run it for EPAS/PG 9.5 to 12 where the binary path for EPAS is not set. I also found one issue where the proper error message is not shown if the binary path is not set in the Preferences dialog. I have fixed those issues and attached is the patch. Please continue working on the attached patch. On Fri, Apr 24, 2020 at 6:27 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue for materialized view when the user performs > refresh on it, large size materialized view can take longer time to refresh > the view hence we will run it same as we run maintenance commands and it > will also allow the user to view the status of the refresh command. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_5213_v2.patch Description: Binary data
Re: [pgAdmin][RM3787] Issue with Stop Process button
Hi Nagesh Your patch looks good to me, but it will not solve the issue that "Richard" has mentioned in the RM. What if terminating the process takes a long time? Please consider that and provide the proper solution. On Fri, Apr 24, 2020 at 7:12 PM Nagesh Dhope wrote: > Hi Hackers, > After the process is terminated, it's taking some time to return exit_code > and our frontend code is waiting for exit_code to notify the user that the > process is terminated by the user. Also *Stop Process *button is not > getting disabled and which is misleading the user that nothing is > happening, which may result in user clicking on the button multiple > times(Backend is throwing process not found exception due to this). > > To fix this, I have disabled *Stop Process *button after the user clicks > on it and added a message *"Terminating the process..." *till exit_code > is received. > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it
Thanks Akshay, flag not to run tests set to true when the check utility fails in-case if the binary path is not set, I will fix that issue as I did not consider more than one server scenario. On Mon, Apr 27, 2020 at 12:05 PM Akshay Joshi wrote: > Hi Murtuza > > API test cases are not running, there is no error but all the tests are > skipped. I have run it for EPAS/PG 9.5 to 12 where the binary path for EPAS > is not set. > > I also found one issue where the proper error message is not shown if the > binary path is not set in the Preferences dialog. I have fixed those issues > and attached is the patch. > Please continue working on the attached patch. > > On Fri, Apr 24, 2020 at 6:27 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue for materialized view when the user performs >> refresh on it, large size materialized view can take longer time to refresh >> the view hence we will run it same as we run maintenance commands and it >> will also allow the user to view the status of the refresh command. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
