[pgAdmin][RM5410] Package Body is not being removed

[Akshay Joshi]

Hi Hackers

RM #5410 has been reopened. *Problem Statement*: When we change the
definition of the package header it will delete the existing package body.
I confirmed that this is the expected behavior in the EDB Postgres Advanced
Server.

Attached is the patch to just popped up the warning message for the user
before saving it.
*Note*: Warning message will be displayed only when the package header is
changed if we change the package body then no need to popped up the warning
message.

Please review it.



-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


RM_5410.patch
Description: Binary data

Re: [pgAdmin][RM5410] Package Body is not being removed

[Shubham Agarwal]

I will be reviewing this patch.

On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi 
wrote:

> Hi Hackers
>
> RM #5410 has been reopened. *Problem Statement*: When we change the
> definition of the package header it will delete the existing package body.
> I confirmed that this is the expected behavior in the EDB Postgres Advanced
> Server.
>
> Attached is the patch to just popped up the warning message for the user
> before saving it.
> *Note*: Warning message will be displayed only when the package header is
> changed if we change the package body then no need to popped up the warning
> message.
>
> Please review it.
>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

[pgagent]: Modified 'next_schedule' function and updated pgagent 4.2 version

[Neel Patel]

Hi,

Please find an updated patch that fixes a bug in 'next_schedule' function
where minute should be extracted instead of year for calculation.

Issue found by: Vik Fearing

Please find the attached patch that fixed the issue in respective pgagent
files and updated pgagent for 4.2 version.

Do review it and let me know for comments.

Thanks,
Neel Patel


pgagent_4_2.patch
Description: Binary data

[pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

[Aditya Toshniwal]

Hi Hackers,

Attached is the patch to add the "System XXX?" property to the object types
where it was missing.
I've also attached a allobjects.sql file to create all types of objects
under a database for PGv12 which might help to test.
Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM1257.patch
Description: Binary data


allobjects.sql
Description: Binary data

Re: [pgAdmin][RM5410] Package Body is not being removed

[Shubham Agarwal]

Patch looks good to me.
Please go ahead and commit the code.

On Thu, Apr 23, 2020 at 4:25 PM Shubham Agarwal <
shubham.agar...@enterprisedb.com> wrote:

> I will be reviewing this patch.
>
> On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers
>>
>> RM #5410 has been reopened. *Problem Statement*: When we change the
>> definition of the package header it will delete the existing package body.
>> I confirmed that this is the expected behavior in the EDB Postgres Advanced
>> Server.
>>
>> Attached is the patch to just popped up the warning message for the user
>> before saving it.
>> *Note*: Warning message will be displayed only when the package header
>> is changed if we change the package body then no need to popped up the
>> warning message.
>>
>> Please review it.
>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>


-- 
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

pgAdmin 4 commit: Fixed an issue where columns names should be visible

[Akshay Joshi]

Fixed an issue where columns names should be visible in the order of their 
creation in the browser tree. Fixes #5043

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e29f3fd6d26542df7ea3d684960c69de1039db8
Author: Satish V 

Modified Files
--
docs/en_US/release_notes_4_21.rst|  1 +
web/pgadmin/browser/static/js/browser.js | 46 +++-
web/pgadmin/static/js/pgadmin.js |  9 +++
3 files changed, 37 insertions(+), 19 deletions(-)

pgAdmin 4 commit: A warning message will be displayed only when the pac

[Akshay Joshi]

A warning message will be displayed only when the package header is changed for 
EPAS packages. Fixes #5410

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b5c90e379d4a94bac5e9359cbe2f5e9ca8d9c45

Modified Files
--
.../schemas/packages/static/js/package.js  | 39 --
1 file changed, 37 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Ensure all object types have a System XXX? property.

[Akshay Joshi]

Ensure all object types have a System XXX? property. Fixes #1257

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfb74904ed54db96f57ddae304dbc286428e943e
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_21.rst |  1 +
.../browser/server_groups/servers/databases/__init__.py   |  4 
.../servers/databases/event_triggers/__init__.py  |  7 +++
.../databases/event_triggers/static/js/event_trigger.js   |  5 +
.../server_groups/servers/databases/extensions/__init__.py|  7 +++
.../servers/databases/extensions/static/js/extension.js   |  6 --
.../servers/databases/foreign_data_wrappers/__init__.py   |  7 +++
.../foreign_data_wrappers/foreign_servers/__init__.py |  8 
.../foreign_servers/static/js/foreign_server.js   |  4 
.../foreign_servers/user_mappings/__init__.py |  7 +++
.../foreign_servers/user_mappings/static/js/user_mapping.js   |  4 
.../foreign_data_wrappers/static/js/foreign_data_wrapper.js   |  4 
.../server_groups/servers/databases/languages/__init__.py |  8 
.../servers/databases/languages/static/js/language.js |  3 +++
.../server_groups/servers/databases/schemas/__init__.py   |  6 ++
.../servers/databases/schemas/catalog_objects/__init__.py |  7 +++
.../databases/schemas/catalog_objects/columns/__init__.py |  7 +++
.../columns/static/js/catalog_object_column.js|  4 
.../schemas/catalog_objects/static/js/catalog_object.js   |  4 
.../servers/databases/schemas/collations/__init__.py  | 11 ++-
.../databases/schemas/collations/static/js/collation.js   |  3 +++
.../servers/databases/schemas/domains/__init__.py |  4 
.../databases/schemas/domains/domain_constraints/__init__.py  |  6 ++
.../domain_constraints/static/js/domain_constraints.js|  3 +++
.../servers/databases/schemas/foreign_tables/__init__.py  |  6 ++
.../schemas/foreign_tables/static/js/foreign_table.js |  4 
.../servers/databases/schemas/fts_configurations/__init__.py  |  7 +++
.../schemas/fts_configurations/static/js/fts_configuration.js |  4 
.../servers/databases/schemas/fts_dictionaries/__init__.py|  8 
.../schemas/fts_dictionaries/static/js/fts_dictionary.js  |  4 
.../servers/databases/schemas/fts_parsers/__init__.py |  6 ++
.../databases/schemas/fts_parsers/static/js/fts_parser.js |  4 
.../servers/databases/schemas/fts_templates/__init__.py   |  7 ++-
.../databases/schemas/fts_templates/static/js/fts_template.js |  4 
.../databases/schemas/functions/static/js/trigger_function.js |  2 +-
.../servers/databases/schemas/sequences/__init__.py   |  7 +++
.../servers/databases/schemas/sequences/static/js/sequence.js |  4 
.../servers/databases/schemas/static/js/catalog.js|  4 
.../servers/databases/schemas/static/js/schema.js |  2 +-
.../schemas/tables/constraints/check_constraint/__init__.py   |  6 ++
.../check_constraint/static/js/check_constraint.js|  3 +++
.../tables/constraints/exclusion_constraint/__init__.py   |  6 ++
.../exclusion_constraint/static/js/exclusion_constraint.js|  4 
.../schemas/tables/constraints/foreign_key/__init__.py|  6 ++
.../tables/constraints/foreign_key/static/js/foreign_key.js   |  4 
.../schemas/tables/constraints/index_constraint/__init__.py   |  6 ++
.../constraints/index_constraint/static/js/primary_key.js |  4 
.../index_constraint/static/js/unique_constraint.js   |  4 
.../servers/databases/schemas/tables/static/js/table.js   |  8 
.../schemas/templates/catalog/pg/9.1_plus/sql/properties.sql  |  3 ---
.../schemas/templates/catalog/pg/9.2_plus/sql/properties.sql  |  3 ---
.../templates/catalog/ppas/9.1_plus/sql/properties.sql|  3 ---
.../templates/catalog/ppas/9.2_plus/sql/properties.sql|  3 ---
.../schemas/templates/schemas/pg/9.2_plus/sql/properties.sql  |  3 ---
.../schemas/templates/schemas/pg/default/sql/properties.sql   |  3 ---
.../templates/schemas/ppas/9.1_plus/sql/properties.sql|  3 ---
.../templates/schemas/ppas/9.2_plus/sql/properties.sql|  3 ---
.../server_groups/servers/databases/static/js/database.js |  4 
.../browser/server_groups/servers/resource_groups/__init__.py |  9 -
.../servers/resource_groups/static/js/resource_group.js   |  4 
web/pgadmin/browser/server_groups/servers/roles/__init__.py   |  8 
.../browser/server_groups/servers/roles/static/js/role.js |  3 +++
.../browser/server_groups/servers/tablespaces/__init__.py |  6 ++
.../server_groups/servers/tablespaces/static/js/tablespace.js |  4 
64 files changed, 281 insertions(+), 35 deletions(-)

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

[Akshay Joshi]

Thanks, patch applied.

On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to add the "System XXX?" property to the object
> types where it was missing.
> I've also attached a allobjects.sql file to create all types of objects
> under a database for PGv12 which might help to test.
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

[Akshay Joshi]

Thanks, patch applied.

On Thu, Apr 23, 2020 at 12:02 PM navnath gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hello,
>
>  Patch looks good to me. Newly created columns sorted according to their
> creation order without context refresh.
>
> Thanks!
>
> On Thu, Apr 23, 2020 at 10:13 AM navnath gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hi,
>>
>>  I'm reviewing this patch.
>>
>> On Wed, Apr 22, 2020 at 6:54 PM Satish V 
>> wrote:
>>
>>>
>>> Hi Hackers,
>>>
>>> In the attached patch, newly created columns in a table are sorted
>>> according to their creation order rather than the alphanumerical order.
>>> Previously this was not happening without context refresh.
>>>
>>>
>>>
>>> Please review.
>>>
>>> Thanks
>>> Sathish V
>>>
>>
>>
>> --
>> Regards,
>> Navnath Gadakh
>>
>
>
> --
> Regards,
> Navnath Gadakh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

[pgAdmin][RM4180] Mouse click does not select object in Browser unless pointer is over object

[Aditya Toshniwal]

Hi Hackers,

Attached patch will allow the tree objects to be selected on the full row.
Currently, it works only on the expand/collapse icon and the object text.

I went through the acitree code and found an option - "fullRow" to enable
it. However, changes were required to CSS to fit our current view.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM4180.patch
Description: Binary data

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

[Nagesh Dhope]

Hi Hackers,
After fixing the issue reported by Shubham, I observed that sometimes
browser is getting hanged and sometimes ViewData grid is getting disappear,
I suspect its due to the number of rows to update on slick grid after
fetching next of rows. FYI, I was running a query which was
returning 1000100 rows and 3 columns. I tried fixing it but I didn't find
any feasible solution.
As there is workaround provided for RM3269
 by Dave. I would suggest, we
shall revert the already applied patches. Please find the attached patch
for the same.


On Wed, Apr 22, 2020 at 6:49 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope <
> nagesh.dh...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>> The attached patch makes an API call to fetch the next batch of rows only
>> after a user stops scrolling down(to detect added timeout of 250ms) using
>> the slider.
>>
>> On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <
>>> nagesh.dh...@enterprisedb.com> wrote:
>>>
 Hi Hackers,
 The attached patch fixes an issue where slider jumps up when new rows
 get loaded while scrolling down in the DataView panel in the query tool.
 Fix uses *rows_affected *field to create dummy rows (Apart from the
 first *batch of rows). *Dummy rows will be updated as and when they
 are required*. *As total required rows are created initially,
 SlickGrid will not readjust its height when the next batch of rows are
 loaded. Hence the jump up in the slider will not happen.

 --
 Thanks,
 Nagesh

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Nagesh
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Nagesh


RM3269_revert.patch
Description: Binary data

pgAdmin 4 commit: Fixed mouse click issue where it does not select an o

[Akshay Joshi]

Fixed mouse click issue where it does not select an object in Browser unless 
the pointer is over the object. Fixes #4180

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90849fe29b99914308c7f46ac99223ff1b417d76
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_21.rst|   1 +
web/pgadmin/browser/static/js/browser.js |   1 +
web/pgadmin/preferences/static/js/preferences.js |   1 +
web/pgadmin/static/scss/_aci_tree.overrides.scss | 216 ---
4 files changed, 119 insertions(+), 100 deletions(-)

pgAdmin 4 commit: Reverting patch for RM #3269.

[Akshay Joshi]

Reverting patch for RM #3269.

We observed that sometimes the browser is getting hanged and sometimes
the ViewData grid is getting disappear. We suspect its due to the number
of rows to update on the slick grid after fetching next of rows.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17129b259b4936e8a484c8278ceabc3c8c3c5e5e
Author: Nagesh Dhope 

Modified Files
--
docs/en_US/release_notes_4_21.rst  |  3 +-
web/pgadmin/tools/sqleditor/__init__.py| 16 ++-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 55 +++---
3 files changed, 22 insertions(+), 52 deletions(-)

Re: [pgAdmin][RM4180] Mouse click does not select object in Browser unless pointer is over object

[Akshay Joshi]

Thanks, patch applied.

On Thu, Apr 23, 2020 at 6:59 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch will allow the tree objects to be selected on the full row.
> Currently, it works only on the expand/collapse icon and the object text.
>
> I went through the acitree code and found an option - "fullRow" to enable
> it. However, changes were required to CSS to fit our current view.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

[Akshay Joshi]

Thanks, patch applied.

On Fri, Apr 24, 2020 at 10:49 AM Nagesh Dhope 
wrote:

> Hi Hackers,
> After fixing the issue reported by Shubham, I observed that sometimes
> browser is getting hanged and sometimes ViewData grid is getting disappear,
> I suspect its due to the number of rows to update on slick grid after
> fetching next of rows. FYI, I was running a query which was
> returning 1000100 rows and 3 columns. I tried fixing it but I didn't find
> any feasible solution.
> As there is workaround provided for RM3269
>  by Dave. I would suggest, we
> shall revert the already applied patches. Please find the attached patch
> for the same.
>
>
> On Wed, Apr 22, 2020 at 6:49 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope <
>> nagesh.dh...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>> The attached patch makes an API call to fetch the next batch of rows
>>> only after a user stops scrolling down(to detect added timeout of 250ms)
>>> using the slider.
>>>
>>> On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <
 nagesh.dh...@enterprisedb.com> wrote:

> Hi Hackers,
> The attached patch fixes an issue where slider jumps up when new rows
> get loaded while scrolling down in the DataView panel in the query tool.
> Fix uses *rows_affected *field to create dummy rows (Apart from the
> first *batch of rows). *Dummy rows will be updated as and when they
> are required*. *As total required rows are created initially,
> SlickGrid will not readjust its height when the next batch of rows are
> loaded. Hence the jump up in the slider will not happen.
>
> --
> Thanks,
> Nagesh
>


 --
 *Thanks & Regards*
 *Akshay Joshi*

 *Sr. Software Architect*
 *EnterpriseDB Software India Private Limited*
 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> Thanks,
>>> Nagesh
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Nagesh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*