Re: [Patch][pgAdmin4]: Fix pgagent issues

2020-04-21 Thread Akshay Joshi
Hi Neel

RESQL test cases are failing on my machine due to different timezone

- '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15
01:11:34-07'::timestamp with time zone,
? -  ^^ ^ -  ^
   ^ ^
+ '2020-04-14 13:41:31+05:30'::timestamp with time zone, '2020-04-15
13:41:34+05:30'::timestamp with time zone,
?  + ^^   +
^^ 

Please fix the above issue and resend the patch.

On Mon, Apr 20, 2020 at 3:07 PM Neel Patel 
wrote:

> Hi,
>
> Please find the attached patch to stabilize the pgagent and fix below
> issues.
>
>- Reverse engineering SQL and MSQL was incorrect when the user added a
>job schedule with exception Fixes #5356
>- Job schedule exception time was not showing correctly in SQL tab.
>- Identify the job step and schedule if disabled from browser tree,
>same as pgagent job - Fixes #4636
>- Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623
>
> Do review it and let me know for comments.
>
> Thanks,
> Neel Patel
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-21 Thread Akshay Joshi
Hi Navnath

On Tue, Apr 21, 2020 at 12:21 PM navnath gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hello Hackers,
>  It's related to applying data sorting on table data by primary
> key.
> With the existing implementation, we can view the table's data using 4
> options with the different orders by default
> 1 - All Rows (No order)
> 2 - First 100 rows (ASC order)
> 3 - Last 100 rows (DESC order)
> 4 - Filtered rows (No order)
>
> In the https://redmine.postgresql.org/issues/5157  it's not clearly
> mentioned on which option to apply sorting by PK?  I'm assuming that should
> be on ALL Rows option.
>
> Please suggest.
>

   Yes, for all those options. Sorting by Primary Key is all depends on the
value set by the user in the Preferences dialog.

>
> Thanks!
>
>
> On Tue, Apr 21, 2020 at 10:12 AM navnath gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hi Khushboo,
>> Please hold this patch for review I'm still optimizing the code in
>> the patch.
>>
>>
>> On Mon, Apr 20, 2020 at 9:16 PM navnath gadakh <
>> navnath.gad...@enterprisedb.com> wrote:
>>
>>> Hi Khushboo,
>>>I have modified the code as per review comments. Please review the
>>> attached patch file.
>>>
>>> Thanks!
>>>
>>> On Mon, Apr 20, 2020 at 10:56 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Navnath,

 Review comments:

 1. If we have multiple Primary keys, then we should include all the
 keys into the Order by clause.
 2. In the Preferences dialog, please put this option  in the Query Tool
 > Options instead of Result Grid and also change the Label.
 3. Please optimize the code, as I can see objectname.sql file is being
 used in else condition also, which is not required. Based on the parameter
 setting, Just one call of that sql is enough.

 Thanks,
 Khushboo


 On Fri, Apr 17, 2020 at 6:43 PM navnath gadakh <
 navnath.gad...@enterprisedb.com> wrote:

> Hello Hackers,
>
>  Please find the modified patch with an option in Preferences for data
> sorting by the primary key. Also, the previous  patch was not working with
> table has no primary key.
>
> Thanks!
>
>
>
>
> On Thu, Apr 16, 2020 at 5:01 PM Dave Page 
> wrote:
>
>>
>>
>> On Thu, Apr 16, 2020 at 12:08 PM navnath gadakh <
>> navnath.gad...@enterprisedb.com> wrote:
>>
>>> Hi Dave/Team,
>>>   This patch is related to the default sort order for the
>>> view table data. In pgAdminIII default ordering is by primary key and 
>>> this
>>> is not working in pgAdminIV.
>>> I have attached the patch with the back end code.
>>>
>>> Please review it.
>>>
>>> *Question*: There is one suggestion on
>>> https://redmine.postgresql.org/issues/5157 about to put a checkbox
>>> in the configuration for this behavior.
>>>   Do I need to implement that really? I yes, Is
>>> preferences a good place for that? / Suggestions?
>>>
>>
>> I think we should make this optional, and yes, Preferences is a good
>> place. The reason is that sorting data is not without cost - at the very
>> least it will require use of an index to access what may be the whole 
>> table.
>>
>> --
>> Dave Page
>> VP & Chief Architect, Database Infrastructure
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
> --
> Regards,
> Navnath Gadakh
>

>>>
>>> --
>>> Regards,
>>> Navnath Gadakh
>>>
>>
>>
>> --
>> Regards,
>> Navnath Gadakh
>>
>
>
> --
> Regards,
> Navnath Gadakh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-04-21 Thread Shubham Agarwal
Hi Yogesh,
Below are the review comments-

1. runtests.py
a. The exception traceback logic at line number 653 in runtests.py is
not correct since it is particular to the thread
but there is much more code in that block which can throw some exception.
b. line number 447 -> The drop_database function will only try to drop the
database with the name which is newly created
at 431 line number, its probability is 1% instead of this you can write a
logic so that it will drop all the database which starts with name
‘acceptance_test_db'.
  c. line 584 - Why we are including resql test case execution in GUI
execution logic.
d. Change the function name run_test as script name is also runtests.py

2. test_utils.py
a. Remove the headless chrome code from get_remote_webdriver() in
test_utils.py since we are using solenoid and it is not required anymore.
b. Create separate functions to instantiate the firefox driver and
chrome driver logic since the same code is used in multiple files.
c. launch_url_in_browser() -> you can simplify the definition of the
function like:
retry = 60
*while *retry > 0:
try:
driver.get(url)
except WebDriverException:
 retry -= 1
3. Execution logs are not printing as per the logic some time, I ran the
suite for two servers and attached are the execution logs.
4. Readme -
Please provide the Valid selenoid URL to be provided in the
test_config.json, with all the steps mentioned in the readme it is not
clear.
Revisit the readme and write the missing steps.
5. copy_selected_query_results_feature_tests.py-
Create the function to avoid duplicate code. The code for pasting the
values is repeating 8 times in the test code.
6. Provide the valid docstring in newly introduced functions and also valid
comments while calling it. for ex.- _update_preference() function is
introduced in pg_utilities_backup_restrore_test.py but from the function
name, it is not clear what preferences are going to update in it.
7. test_index_constraint_add test case is failing due to the latest change,
please merge and update this test case

On Thu, Apr 16, 2020 at 2:41 PM navnath gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi,
> I think I am not the right person to review this patch now as I already
> reviewed this code offline in the last week. I know the approached Yogesh
> has followed, also given some review comments on it.
> Someone else please review it.
>
> Thanks!
>
> On Mon, Apr 13, 2020 at 2:49 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Navnath
>>
>> Can you please review it?
>>
>> On Mon, Apr 13, 2020 at 2:40 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch for running *features tests* using
>>> solenoid(selenium grid + docker).
>>> KIndly review.
>>> To sun feature tests in parallel, required prerequisites can be checked
>>> in '~/web/regression/README' file.
>>> Also detailed instructions are added in the same file.
>>> After applying the patch, any existing process for execution of
>>> API/Features tests remains the same.
>>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Regards,
> Navnath Gadakh
>


-- 
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


regression.log
Description: Binary data


pgAdmin 4 commit: Fixed an issue wherein grant wizard the last object i

2020-04-21 Thread Akshay Joshi
Fixed an issue wherein grant wizard the last object is not selectable. Fixes 
#4545

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d516101a446e04d09ad34f2fd00b76216ad2fb2
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_21.rst | 1 +
web/pgadmin/static/js/backgrid.pgadmin.js | 1 +
web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js  | 2 +-
web/pgadmin/tools/grant_wizard/static/scss/_grant_wizard.scss | 4 ++--
4 files changed, 5 insertions(+), 3 deletions(-)



pgAdmin 4 commit: Fixed an issue where slider jumps up when new rows ge

2020-04-21 Thread Akshay Joshi
Fixed an issue where slider jumps up when new rows get loaded while scrolling 
down in the DataView panel in the query tool. Fixes #3269

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d4f3c07c777d57cf0e89af8ed06b0e7886f37ab
Author: Nagesh Dhope 

Modified Files
--
docs/en_US/release_notes_4_21.rst  |  1 +
web/pgadmin/tools/sqleditor/__init__.py| 11 -
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 48 ++
3 files changed, 42 insertions(+), 18 deletions(-)



pgAdmin 4 commit: Fixed the rightmost and bottom tooltip crop issues in

2020-04-21 Thread Akshay Joshi
Fixed the rightmost and bottom tooltip crop issues in the explain query plan. 
Fixes #5352

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e30a99937737e1e86f9ee93ea1bccf97f1a0198
Author: Yogesh Jain 

Modified Files
--
docs/en_US/release_notes_4_21.rst | 1 +
web/pgadmin/misc/static/explain/js/explain.js | 3 +++
2 files changed, 4 insertions(+)



Re: [pgAdmin][RM4545]: In grant wizard, last object is not selectable

2020-04-21 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Apr 20, 2020 at 7:44 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a patch to fix the issue in the grand wizard.
>
> This patch will fix:
>
>1. If we try to select the last object type in grant wizard, it's not
>getting selected.
>2. If we filter any object and select it, all the listed object types
>are getting selected.
>3. When you remove the text added in the filter search box by directly
>clicking the cross button, it doesn't show original data.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-21 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope 
wrote:

> Hi Hackers,
> The attached patch fixes an issue where slider jumps up when new rows get
> loaded while scrolling down in the DataView panel in the query tool.
> Fix uses *rows_affected *field to create dummy rows (Apart from the first 
> *batch
> of rows). *Dummy rows will be updated as and when they are required*. *As
> total required rows are created initially, SlickGrid will not readjust its
> height when the next batch of rows are loaded. Hence the jump up in the
> slider will not happen.
>
> --
> Thanks,
> Nagesh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

2020-04-21 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Apr 20, 2020 at 8:05 PM Yogesh Jain 
wrote:

> Hi Hackers,
>
> Attached is the patch to fix the rightmost & bottom tooltip crop issues in
> the explain query plan.
>
> FYI : While explaining a large query if we hover the rightmost or bottom
> icon the tooltip is cropped & partially visible, which is fixed in this
> patch.
>
> Please review.
> PFA.
>
> --
> Regards,
> Yogesh Jain
> 8982696654
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [Patch][pgAdmin4]: Fix pgagent issues

2020-04-21 Thread Neel Patel
Hi Akshay,

Please find the attached update patch with the fix.
Also fixed the Roles resql test cases as it was failing due to timezone
change.

Thanks,
Neel Patel

On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi 
wrote:

> Hi Neel
>
> RESQL test cases are failing on my machine due to different timezone
>
> - '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15
> 01:11:34-07'::timestamp with time zone,
> ? -  ^^ ^ -  ^
>^ ^
> + '2020-04-14 13:41:31+05:30'::timestamp with time zone, '2020-04-15
> 13:41:34+05:30'::timestamp with time zone,
> ?  + ^^ 
>  + ^^ 
>
> Please fix the above issue and resend the patch.
>
> On Mon, Apr 20, 2020 at 3:07 PM Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find the attached patch to stabilize the pgagent and fix below
>> issues.
>>
>>- Reverse engineering SQL and MSQL was incorrect when the user added
>>a job schedule with exception Fixes #5356
>>- Job schedule exception time was not showing correctly in SQL tab.
>>- Identify the job step and schedule if disabled from browser tree,
>>same as pgagent job - Fixes #4636
>>- Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623
>>
>> Do review it and let me know for comments.
>>
>> Thanks,
>> Neel Patel
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py b/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py
index 797a6cb..ee87a1a 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/__init__.py
@@ -10,6 +10,7 @@
 """Implements the pgAgent Jobs Node"""
 from functools import wraps
 import json
+from datetime import datetime, time
 
 from flask import render_template, request, jsonify
 from flask_babelex import gettext as _
@@ -323,7 +324,8 @@ SELECT EXISTS(
 row['jobid'],
 sid,
 row['jobname'],
-icon="icon-pga_job"
+icon="icon-pga_job" if row['jobenabled']
+else "icon-pga_job-disabled"
 )
 )
 
@@ -500,6 +502,10 @@ SELECT EXISTS(
 if schedule['jexid']:
 idx = 0
 for exc in schedule['jexid']:
+# Convert datetime.time object to string
+if isinstance(schedule['jextime'][idx], time):
+schedule['jextime'][idx] = \
+schedule['jextime'][idx].strftime("%H:%M:%S")
 schedule['jscexceptions'].append({
 'jexid': exc,
 'jexdate': schedule['jexdate'][idx],
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
index ad3e7e9..13bd25a 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
@@ -74,6 +74,23 @@ class JobScheduleModule(CollectionNodeModule):
 return 'pga_job'
 
 @property
+def csssnippets(self):
+"""
+Returns a snippet of css to include in the page
+"""
+snippets = [
+render_template(
+"pga_schedule/css/pga_schedule.css",
+node_type=self.node_type
+)
+]
+
+for submodule in self.submodules:
+snippets.extend(submodule.csssnippets)
+
+return snippets
+
+@property
 def module_use_template_javascript(self):
 """
 Returns whether Jinja2 template is used for generating the javascript
@@ -245,7 +262,8 @@ class JobScheduleView(PGChildNodeView):
 row['jscid'],
 row['jscjobid'],
 row['jscname'],
-icon="icon-pga_schedule",
+icon="icon-pga_schedule" if row['jscenabled'] else
+"icon-pga_schedule-disabled",
 enabled=row['jscenabled']
 )
 )
@@ -256,7 +274,8 @@ class JobScheduleView(PGChildNodeView):
 row['jscid'],
 row['jscjobid'],
 row['jscname'],
-icon="icon-pga_schedule",
+icon="icon-pga_schedule" if row['jscenabled'] else
+"icon-pga_schedule-disabled",
 enabled=row['jscenabled']
 )
 )
@@ -359,7 +378,8 @@ class JobScheduleView(PGChildNodeView):
 row['jscid'],
 row['jscjobid'],
 row['jscname'],
-icon="icon-pga_schedule",
+icon="icon-pga_schedule" if row['jsc

pgAdmin 4 commit: Added job step and job schedule disable icons to iden

2020-04-21 Thread Akshay Joshi
Added job step and job schedule disable icons to identify it quickly within the 
browser tree. Fixes #4636
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. 
Fixes #5356

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07f72252d7a1d59517f2072697856630ed344db4
Author: Neel Patel 

Modified Files
--
docs/en_US/release_notes_4_21.rst  |   3 +
.../server_groups/servers/pgagent/__init__.py  |   8 +-
.../servers/pgagent/schedules/__init__.py  |  29 +-
.../schedules/static/img/pga_schedule-disabled.svg |  16 +
.../pgagent/schedules/static/js/pga_schedule.js|  10 +-
.../templates/pga_schedule/css/pga_schedule.css|  18 +
.../servers/pgagent/steps/__init__.py  |  12 +-
.../pgagent/steps/static/img/coll-pga_jobstep.svg  |  46 +-
.../steps/static/img/pga_jobstep-disabled.svg  |  32 ++
.../steps/templates/pga_jobstep/css/pga_step.css   |   9 +
.../alter_batch_job_schedule_all_options.sql   |  54 +++
.../alter_batch_job_schedule_all_options_msql.sql  |  25 +
.../default/alter_batch_job_step_all_options.sql   |  33 ++
.../alter_batch_job_step_all_options_msql.sql  |  11 +
.../default/alter_job_schedule_all_options.sql |  66 +++
.../alter_job_schedule_all_options_msql.sql|  37 ++
.../alter_job_schedule_remote_db_all_options.sql   |  54 +++
...ter_job_schedule_remote_db_all_options_msql.sql |  25 +
.../tests/default/alter_job_step_all_options.sql   |  33 ++
.../default/alter_job_step_all_options_msql.sql|  11 +
.../alter_job_step_remote_db_all_options.sql   |  33 ++
.../alter_job_step_remote_db_all_options_msql.sql  |  11 +
.../tests/default/alter_sql_job_all_options.sql|  24 +
.../default/alter_sql_job_all_options_msql.sql |   3 +
.../default/create_batch_job_with_all_options.sql  |  45 ++
.../create_batch_job_with_all_options_msql.sql |  45 ++
.../tests/default/create_batch_job_with_step.sql   |  24 +
.../default/create_batch_job_with_step_msql.sql|  24 +
.../create_sql_job_local_db_with_all_options.sql   |  57 +++
...eate_sql_job_local_db_with_all_options_msql.sql |  57 +++
.../create_sql_job_remote_db_with_all_options.sql  |  45 ++
...ate_sql_job_remote_db_with_all_options_msql.sql |  45 ++
.../default/create_sql_job_step_remote_db.sql  |  24 +
.../default/create_sql_job_step_remote_db_msql.sql |  24 +
.../default/create_sql_job_with_step_local_db.sql  |  24 +
.../create_sql_job_with_step_local_db_msql.sql |  24 +
.../pgagent/tests/default/test_pgagent.json| 503 +
.../tests/9.4_plus/alter_login_role_options.sql|   2 +-
.../roles/tests/9.4_plus/alter_role_options.sql|   2 +-
web/pgadmin/static/js/backgrid.pgadmin.js  |  10 +-
web/regression/re_sql/tests/test_resql.py  |  97 +++-
41 files changed, 1616 insertions(+), 39 deletions(-)



pgAdmin 4 commit: Fixed following issues for packages:

2020-04-21 Thread Akshay Joshi
Fixed following issues for packages:
  1) Removing the package header removes the body as well.
  2) Schema is not visible on the properties dialog.
  3) Reverse engineering SQL and Create script not showing schema-qualified 
packages.

Fixes #5410

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f289dfb762cff2f1ec3621aa0cb3b3576c057911

Modified Files
--
.../servers/databases/schemas/packages/__init__.py   | 11 +++
.../packages/templates/packages/ppas/9.1_plus/update.sql | 10 +++---
.../packages/templates/packages/ppas/9.2_plus/update.sql |  2 +-
.../tests/ppas/10_plus/alter_package_headers_and_comment.sql | 10 +-
.../tests/ppas/10_plus/create_package_with_all_options.sql   | 12 ++--
.../ppas/9.2_plus/alter_package_headers_and_comment.sql  | 10 +-
.../tests/ppas/9.2_plus/create_package_with_all_options.sql  | 12 ++--
7 files changed, 37 insertions(+), 30 deletions(-)



Re: [Patch][pgAdmin4]: Fix pgagent issues

2020-04-21 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Apr 21, 2020 at 4:40 PM Neel Patel 
wrote:

> Hi Akshay,
>
> Please find the attached update patch with the fix.
> Also fixed the Roles resql test cases as it was failing due to timezone
> change.
>
> Thanks,
> Neel Patel
>
> On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Neel
>>
>> RESQL test cases are failing on my machine due to different timezone
>>
>> - '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15
>> 01:11:34-07'::timestamp with time zone,
>> ? -  ^^ ^ -
>>  ^^ ^
>> + '2020-04-14 13:41:31+05:30'::timestamp with time zone, '2020-04-15
>> 13:41:34+05:30'::timestamp with time zone,
>> ?  + ^^ 
>>  + ^^ 
>>
>> Please fix the above issue and resend the patch.
>>
>> On Mon, Apr 20, 2020 at 3:07 PM Neel Patel 
>> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to stabilize the pgagent and fix below
>>> issues.
>>>
>>>- Reverse engineering SQL and MSQL was incorrect when the user added
>>>a job schedule with exception Fixes #5356
>>>- Job schedule exception time was not showing correctly in SQL tab.
>>>- Identify the job step and schedule if disabled from browser tree,
>>>same as pgagent job - Fixes #4636
>>>- Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623
>>>
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[SSPI] Windows group support

2020-04-21 Thread The Dude
Hi,

I have some code that I've been using in production that supports adding
and authenticating Windows groups via the pg_ident file.  It has a new
indicator (+), that signifies the identifier is a Windows group, as in the
following example:

# MAPNAME   SYSTEM-USERNAME   PG-USERNAME
"Users" "+User group"   postgres

A new function was added to test if a user token is in the windows group:

/*
 * Check if the user (sspiToken) is a member of the specified group
 */
static BOOL
sspi_user_is_in_group(HANDLE sspiToken, LPCTSTR groupName)

I wanted to share this as a patch for the latest, as soon as I port it to
v12.  Does this sound reasonable?

thanks,
Russell


Minor request :)

2020-04-21 Thread x
Hello

It would be great to have something in the  tags on the
login page, so Keepass is able to use it as reference for the auto-type
login.

https://github.com/postgres/pgadmin4/blob/8180403f976ee0d759631e7539205548dbdd2d6c/web/pgadmin/templates/base.html#L14

... seems not to set anything on the login page.

thx 'n' regards,
Didier



signature.asc
Description: OpenPGP digital signature


Re: Minor request :)

2020-04-21 Thread Khushboo Vashi
Hi,

On Tue, Apr 21, 2020 at 7:03 PM  wrote:

> Hello
>
> It would be great to have something in the  tags on the
> login page, so Keepass is able to use it as reference for the auto-type
> login.
>
Please log your request @ https://redmine.postgresql.org/projects/pgadmin4 .

Thanks,
Khushboo

>
>
> https://github.com/postgres/pgadmin4/blob/8180403f976ee0d759631e7539205548dbdd2d6c/web/pgadmin/templates/base.html#L14
>
> ... seems not to set anything on the login page.
>
> thx 'n' regards,
> Didier
>
>


Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

2020-04-21 Thread Nagesh Dhope
Hi,
Please find a patch, which will allow copying *[null]* and *[default] cell
values.*


RM3947_v3.patch
Description: Binary data


[pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

2020-04-21 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #3900 - Delete/Drop option is
disabled for the constraints.

- Implemented multiple drop/delete functionality for the Table constraints.

Thanks,
Khushboo


RM_3900.patch
Description: Binary data


Exclude RESQL test cases

2020-04-21 Thread navnath gadakh
Hello Hackers,

  Please review the small patch to exclude RESQL test cases.  resql
param is added to --exclude.

Thanks!

-- 
Regards,
Navnath Gadakh


exclude_resql_tests_v1.patch
Description: Binary data