pgAdmin 4 commit: Make the configuration window in runtime to auto-resi
Make the configuration window in runtime to auto-resize. Fixes #4864 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c93e93cb47120e652de2bfa539ee24ab32c3337 Author: Neel Patel Modified Files -- docs/en_US/release_notes_4_21.rst | 1 + runtime/ConfigWindow.ui | 323 -- 2 files changed, 244 insertions(+), 80 deletions(-)
pgAdmin 4 commit: Added dark mode support for the configuration dialog
Added dark mode support for the configuration dialog on Windows/macOS runtime. Fixes #4292 Detects dark mode at server start and styles the runtime accordingly. Patch modified by: Neel Patel Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41be5479afd3b1e0849c20cece2657b96db70c47 Author: Dave Page Modified Files -- docs/en_US/release_notes_4_21.rst |1 + runtime/ConfigWindow.ui | 22 +- runtime/breeze.qrc| 89 ++ runtime/dark.qss | 1648 runtime/dark/branch_closed-on.svg |3 + runtime/dark/branch_closed.svg|3 + runtime/dark/branch_open-on.svg |3 + runtime/dark/branch_open.svg |3 + runtime/dark/checkbox_checked.svg |5 + runtime/dark/checkbox_checked_disabled.svg|5 + runtime/dark/checkbox_indeterminate.svg |7 + runtime/dark/checkbox_indeterminate_disabled.svg |7 + runtime/dark/checkbox_unchecked.svg |4 + runtime/dark/checkbox_unchecked_disabled.svg |4 + runtime/dark/close-hover.svg |3 + runtime/dark/close-pressed.svg|3 + runtime/dark/close.svg|3 + runtime/dark/down_arrow-hover.svg |3 + runtime/dark/down_arrow.svg |3 + runtime/dark/down_arrow_disabled.svg |3 + runtime/dark/hmovetoolbar.svg |4 + runtime/dark/hsepartoolbar.svg|3 + runtime/dark/left_arrow.svg |3 + runtime/dark/left_arrow_disabled.svg |3 + runtime/dark/radio_checked.svg|5 + runtime/dark/radio_checked_disabled.svg |5 + runtime/dark/radio_unchecked.svg |4 + runtime/dark/radio_unchecked_disabled.svg |4 + runtime/dark/right_arrow.svg |3 + runtime/dark/right_arrow_disabled.svg |3 + runtime/dark/sizegrip.svg |3 + runtime/dark/spinup_disabled.svg |3 + runtime/dark/stylesheet-branch-end-closed.svg |4 + runtime/dark/stylesheet-branch-end-open.svg |4 + runtime/dark/stylesheet-branch-end.svg|4 + runtime/dark/stylesheet-branch-more.svg |4 + runtime/dark/stylesheet-vline.svg |3 + runtime/dark/transparent.svg |1 + runtime/dark/undock-hover.svg |5 + runtime/dark/undock.svg |3 + runtime/dark/up_arrow-hover.svg |3 + runtime/dark/up_arrow.svg |3 + runtime/dark/up_arrow_disabled.svg|3 + runtime/dark/vmovetoolbar.svg |8 + runtime/dark/vsepartoolbars.svg |7 + runtime/light.qss | 1654 + runtime/light/branch_closed-on.svg|3 + runtime/light/branch_closed.svg |3 + runtime/light/branch_open-on.svg |3 + runtime/light/branch_open.svg |3 + runtime/light/checkbox_checked-hover.svg |5 + runtime/light/checkbox_checked.svg|5 + runtime/light/checkbox_checked_disabled.svg |5 + runtime/light/checkbox_indeterminate-hover.svg|7 + runtime/light/checkbox_indeterminate.svg |7 + runtime/light/checkbox_indeterminate_disabled.svg |7 + runtime/light/checkbox_unchecked-hover.svg|4 + runtime/light/checkbox_unchecked_disabled.svg |4 + runtime/light/close-hover.svg |3 + runtime/light/close-pressed.svg |3 + runtime/light/close.svg |3 + runtime/light/down_arrow-hover.svg|3 + runtime/light/down_arrow.svg |3 + runtime/light/down_arrow_disabled.svg |3 + runtime/light/hmovetoolbar.svg|5 + runtime/light/hsepartoolbar.svg |3 + runtime/light/left_arrow.svg |3 + runtime/light/left_arrow_disabled.svg |3 + runtime/light/radio_checked-hover.svg |5 + runtime/light/radio_checked.svg |5 + runtime/light/radio_checked_disabled.svg |5 + runtime/light/radio_unchecked-hover.svg |4 + runtime/light/radio_unchecked_disabled.svg|4 + runtime/light/right_arrow.svg |3 + runtime/light/right_arrow_disabled.svg|3 + runtime/light/sizegrip.svg|3 + runtime/light/spinup_disabled.svg |3 + runtime/light/stylesheet-br
pgAdmin 4 commit: Fixed an issue where changing the values of columns w
Fixed an issue where changing the values of columns with JSONB or JSON types to NULL. Fixes #4969 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b427a8772441eecf24a6932246c5551e7de40614 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_21.rst | 3 ++- web/pgadmin/static/js/slickgrid/editors.js | 8 +--- 2 files changed, 7 insertions(+), 4 deletions(-)
Re: [pgAdmin4][Runtime][Patch]: RM-4864 - Window too small for text in configuration
Thanks, patch applied. On Mon, Apr 13, 2020 at 10:48 AM Neel Patel wrote: > Hi, > > Please find an attached patch to fix the issue in the configuration window > in runtime where control where not auto resize and visible when the user > resizes the dialog. > > Do review it and let me know for comments. > > Thanks, > Neel Patel > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM4969] JSONB and JSON field editing
Thanks, patch applied. On Fri, Apr 10, 2020 at 11:49 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch fix issue for jsonb and json field editing. Making > the field blank throws a validation error. The patch will set json, jsonb > to null when set to blank. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop
Hi Murtuza The issue has been fixed with your patch, but there is an existing issue discover with the fix. After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. Following error observed in the browser: sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' of undefined at Object. (sqleditor.js?ver=42000:1) at Object.callback (vendor.others.js?ver=42000:2) at Tt (vendor.others.js?ver=42000:2) at Object.Ct (vendor.others.js?ver=42000:2) at HTMLDivElement. (vendor.others.js?ver=42000:2) If possible can you please fix the above and resend the combined patch. On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Upon downloading the csv file, we used the prompt for re-connecting to the > database server when there is a database server connection issue. Currently > the user tries to download CSV and there is a connection issue then it is > showing a python exception error. > > Steps: > 1) Open query tool > 2) Execute -> SELECT 1,2,3 > 3) Disconnect from server from browser tree > 4) Click on Download CSV button > > Current: Python exception error > Expected: It should display dialog to reconnect the server. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
Hi, Please find the attached patch to fix the test cases due to this patch. Also, this functionality will not be applicable on EPAS server as we can change the view definition without dropping it. Thanks, Khushboo On Wed, Apr 8, 2020 at 11:42 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Apr 8, 2020 at 10:58 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the attached updated patch. >> >> Thanks, >> Khushboo >> >> On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Khushboo >>> >>> The warning message is not showing up. Please fix and resend the patch. >>> >>> On Tue, Apr 7, 2020 at 10:00 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Akshay, Please find the attached updated patch. On Tue, Mar 24, 2020 at 2:47 PM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Khushboo > > On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Khushboo >>> >>> Following are the review comments: >>> >>>- Fix the PEP8 issue. >>>- Drop query should be part of the jinja template for >>>consistency. Currently, it is added through the python file. >>> >>> The Delete query is already in the template file, I have just reused >> the delete call and merged the SQL queries in the python file. >> >>> >>>- Any changes in the view code should not warn the user >>>"Changing the columns in a view requires dropping" and we should >>> not >>>drop the view. For example, I have only change the WHERE clause or >>> added >>>'ORDER BY'. >>> >>> I have tested but couldn't reproduce this issue. Can you please >> let me know the proper use case? >> > >Create a view with 'SELECT 1;' as code. Then change the code to > 'SELECT 1234;' and click on the Save button. >Warning popup is displayed "Changing the columns in a view". > Click on the 'Yes' button and check the OID of the view. You will get the > same OID, it means view is not recreated. > > I can reproduce this issue with the given SQL but the problem is as per the PostgreSQL documentation, (Ref: https://www.postgresql.org/docs/12/sql-createview.html) "CREATE OR REPLACE VIEW is similar, but if a view of the same name already exists, it is replaced. The new query must generate the same columns that were generated by the existing view query (that is, the same column names in the same order and with the same data types), but it may add additional columns to the end of the list. The calculations giving rise to the output columns may be completely different." So, I put a check on the columns and if the column is changed, the message will popup. In case of the example given by you, the column name is not changed as if you don't give the column name it will be default and I think view would have the column names properly. > I have observed below error in the browser while changing the > code: > view.js:241 Uncaught TypeError: Cannot read property > 'replace' of undefined > at child.onChange (view.js:241) > at HTMLDivElement.dispatch (jquery.js:5237) > at HTMLDivElement.elemData.handle (jquery.js:5044) > > Fixed. Thanks, Khushboo > >> Thanks, >> Khushboo >> >>> >>> >> >>> On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, Please find the attached patch for RM #5053 - Getting an error while changing the columns in the existing view. PostgreSQL doesn't allow to change the view columns. So, while performing this task the existing view should be dropped first and then recreate it and also user will get a warning first. Thanks, Khushboo >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software A
Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework
Hi Navnath Can you please review it? On Mon, Apr 13, 2020 at 2:40 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for running *features tests* using > solenoid(selenium grid + docker). > KIndly review. > To sun feature tests in parallel, required prerequisites can be checked in > '~/web/regression/README' file. > Also detailed instructions are added in the same file. > After applying the patch, any existing process for execution of > API/Features tests remains the same. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
[pgAdmin4][Patch]: RM 4445 - Ensure all object names in the title line of the reverse-engineered SQL are *not* quoted.
Hi Team, Please find the patch attached for RM-4445. The patch contains following things- 1. Fixes for each node. 2. Fixes for Resql test cases -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company rm_4445_v1.patch Description: Binary data
[pgAdmin RM#1257] Show system XX properties for sequences node
Hi Hackers, PFA the patch for showing the System sequence properties for sequences node. Please review. Regards, Vishal diff_1257.patch Description: Binary data
[pgAdmin][RM5371] : Tab key navigation is not working in some of the dialogs
Hi Hackers, Please find the attached path. I have fixed tab key navigation in some of the dialogs. This patch includes the fixes for: 1 Login/Group roles >> Group parameter 2 Table space >> Security >> Privileges 3 Foreign data wrapper >> Security 4 Languages >> Security 5 Foreign table >> columns. 2 >> security 6 Function >> Security. 7 MV >> Security. 8 Table >> Security 9 Trigger Function >> Security 10 View >> Security 11 Types >> Security 12 Procedure >> Security Please review. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5371.patch Description: Binary data
[pgAdmin][RM5007] Index should be visible using unique constraints
Hi Hackers,
Please find the attached patch with below fixes:
- Index dropdown should have existing indexes while creating unique
constraint
- On selecting index from index dropdown, other fields( should be empty and
disabled (Applicable for Primary and unique key constraint)
- Added test cases
Please review.
Regards,
Ganesh Jaybhay
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
index 8126184..5ff6b30 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
@@ -368,6 +368,14 @@ define('pgadmin.node.primary_key', [
Backform.MultiSelectAjaxControl.prototype.remove.apply(this, arguments);
}
},
+render: function() {
+ var index = this.model.get('index');
+ if(!_.isUndefined(index) && index != '') {
+var col = this.model.get('columns');
+col.reset([], {silent: true});
+ }
+ return Backform.Select2Control.prototype.render.apply(this, arguments);
+},
}),
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
@@ -408,8 +416,6 @@ define('pgadmin.node.primary_key', [
if(_.isUndefined(index) || index == '') {
return false;
} else {
- var col = m.get('columns');
- col.reset();
return true;
}
},
@@ -507,8 +513,9 @@ define('pgadmin.node.primary_key', [
if(_.isUndefined(index) || index == '') {
return false;
} else {
- var col = m.get('columns');
- col.reset();
+ setTimeout(function(){
+m.set('include', []);
+ },10);
return true;
}
},
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
index cc7472e..c23fc05 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
@@ -354,6 +354,14 @@ define('pgadmin.node.unique_constraint', [
Backform.MultiSelectAjaxControl.prototype.remove.apply(this, arguments);
}
},
+render: function() {
+ var index = this.model.get('index');
+ if(!_.isUndefined(index) && index != '') {
+var col = this.model.get('columns');
+col.reset([], {silent: true});
+ }
+ return Backform.Select2Control.prototype.render.apply(this, arguments);
+},
}),
deps: ['index'], node: 'column',
model: pgBrowser.Node.Model.extend({
@@ -394,8 +402,6 @@ define('pgadmin.node.unique_constraint', [
if(_.isUndefined(index) || index == '') {
return false;
} else {
- var col = m.get('columns');
- col.reset();
return true;
}
},
@@ -493,8 +499,9 @@ define('pgadmin.node.unique_constraint', [
if(_.isUndefined(index) || index == '') {
return false;
} else {
- var col = m.get('columns');
- col.reset();
+ setTimeout(function(){
+m.set('include', []);
+ },10);
return true;
}
},
@@ -527,11 +534,7 @@ define('pgadmin.node.unique_constraint', [
type: 'text', group: gettext('Definition'),
control: Backform.NodeListByNameControl.extend({
initialize:function() {
- if (_.isUndefined(this.model.top)) {
-Backform.NodeListByNameControl.prototype.initialize.apply(this,arguments);
- } else {
-Backform.Control.prototype.initialize.apply(this,arguments);
- }
+ Backform.NodeListByNameControl.prototype.initialize.apply(this,arguments);
},
}),
select2:{allowClear:true}, node: 'index',
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/tests/test_index_constraint_add.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/co
pgAdmin 4 commit: Fixed an issue where the identical packages and seque
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df11f28593e874f6c0b01c63dc272a96528adca9 Modified Files -- docs/en_US/release_notes_4_21.rst | 3 ++- .../server_groups/servers/databases/schemas/packages/__init__.py | 2 +- .../server_groups/servers/databases/schemas/sequences/__init__.py | 1 + .../schemas/sequences/templates/sequences/sql/default/update.sql | 3 +++ .../schemas/sequences/tests/pg/default/alter_seq_privs_add.sql| 2 +- .../schemas/sequences/tests/pg/default/alter_seq_privs_remove.sql | 2 +- .../schemas/sequences/tests/pg/default/alter_seq_privs_update.sql | 2 +- .../schemas/sequences/tests/pg/default/alter_seq_props.sql| 2 +- .../schemas/sequences/tests/ppas/default/alter_seq_privs_add.sql | 2 +- .../sequences/tests/ppas/default/alter_seq_privs_remove.sql | 2 +- .../sequences/tests/ppas/default/alter_seq_privs_update.sql | 2 +- .../schemas/sequences/tests/ppas/default/alter_seq_props.sql | 2 +- web/pgadmin/tools/schema_diff/tests/pg/10_plus/source.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/10_plus/target.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/11_plus/source.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/11_plus/target.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/12_plus/source.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/12_plus/target.sql | 8 web/pgadmin/tools/schema_diff/tests/pg/9.2_plus/source.sql| 8 web/pgadmin/tools/schema_diff/tests/pg/9.2_plus/target.sql| 8 web/pgadmin/tools/schema_diff/tests/ppas/10_plus/source.sql | 8 web/pgadmin/tools/schema_diff/tests/ppas/10_plus/target.sql | 8 web/pgadmin/tools/schema_diff/tests/ppas/9.2_plus/source.sql | 8 web/pgadmin/tools/schema_diff/tests/ppas/9.2_plus/target.sql | 8 24 files changed, 111 insertions(+), 10 deletions(-)
pgAdmin 4 commit: Fixed an issue where difference SQL is not seen in th
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=781b766ac42282a98738fcc658f32fc4e8db74c1 Modified Files -- docs/en_US/release_notes_4_21.rst | 1 + .../servers/databases/schemas/types/__init__.py| 2 +- web/pgadmin/tools/schema_diff/directory_compare.py | 10 ++ .../tools/schema_diff/tests/pg/10_plus/source.sql | 6 .../tools/schema_diff/tests/pg/10_plus/target.sql | 8 + .../tools/schema_diff/tests/pg/11_plus/source.sql | 42 ++ .../tools/schema_diff/tests/pg/11_plus/target.sql | 8 + .../tools/schema_diff/tests/pg/12_plus/source.sql | 42 ++ .../tools/schema_diff/tests/pg/12_plus/target.sql | 8 + .../tools/schema_diff/tests/pg/9.2_plus/source.sql | 40 + .../tools/schema_diff/tests/pg/9.2_plus/target.sql | 8 + .../schema_diff/tests/ppas/10_plus/source.sql | 42 ++ .../schema_diff/tests/ppas/10_plus/target.sql | 8 + .../schema_diff/tests/ppas/9.2_plus/source.sql | 40 + .../schema_diff/tests/ppas/9.2_plus/target.sql | 8 + 15 files changed, 272 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Modified some logic for the EPAS server as the user c
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=030741bba55ce2420567d46e269099a8a1c53cfb Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/views/__init__.py| 71 ++ .../databases/schemas/views/static/js/view.js | 2 +- .../templates/views/pg/9.4_plus/sql/delete.sql | 2 +- .../templates/views/pg/9.4_plus/sql/update.sql | 17 -- .../pg/9.4_plus/alter_view_add_some_priv_msql.sql | 4 ++ .../pg/9.4_plus/alter_view_definition_msql.sql | 4 ++ .../schemas/views/tests/pg/9.4_plus/tests.json | 18 ++ 7 files changed, 88 insertions(+), 30 deletions(-)
Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view
Thanks, patch applied. On Mon, Apr 13, 2020 at 2:29 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the test cases due to this patch. > Also, this functionality will not be applicable on EPAS server as we can > change the view definition without dropping it. > > Thanks, > Khushboo > > On Wed, Apr 8, 2020 at 11:42 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Apr 8, 2020 at 10:58 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the attached updated patch. >>> >>> Thanks, >>> Khushboo >>> >>> On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Khushboo The warning message is not showing up. Please fix and resend the patch. On Tue, Apr 7, 2020 at 10:00 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Mar 24, 2020 at 2:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Khushboo Following are the review comments: - Fix the PEP8 issue. - Drop query should be part of the jinja template for consistency. Currently, it is added through the python file. The Delete query is already in the template file, I have just >>> reused the delete call and merged the SQL queries in the python file. >>> - Any changes in the view code should not warn the user "Changing the columns in a view requires dropping" and we should not drop the view. For example, I have only change the WHERE clause or added 'ORDER BY'. I have tested but couldn't reproduce this issue. Can you please >>> let me know the proper use case? >>> >> >>Create a view with 'SELECT 1;' as code. Then change the code to >> 'SELECT 1234;' and click on the Save button. >>Warning popup is displayed "Changing the columns in a view". >> Click on the 'Yes' button and check the OID of the view. You will get the >> same OID, it means view is not recreated. >> >> > I can reproduce this issue with the given SQL but the problem is as > per the PostgreSQL documentation, (Ref: > https://www.postgresql.org/docs/12/sql-createview.html) > > "CREATE OR REPLACE VIEW is similar, but if a view of the same name > already exists, it is replaced. The new query must generate the same > columns that were generated by the existing view query (that is, the same > column names in the same order and with the same data types), but it may > add additional columns to the end of the list. The calculations giving > rise > to the output columns may be completely different." > > So, I put a check on the columns and if the column is changed, the > message will popup. > > In case of the example given by you, the column name is not changed as > if you don't give the column name it will be default and I think view > would > have the column names properly. > > >> I have observed below error in the browser while changing the >> code: >> view.js:241 Uncaught TypeError: Cannot read property >> 'replace' of undefined >> at child.onChange (view.js:241) >> at HTMLDivElement.dispatch (jquery.js:5237) >> at HTMLDivElement.elemData.handle (jquery.js:5044) >> >> Fixed. > > Thanks, > Khushboo > >> >>> Thanks, >>> Khushboo >>> >>> On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #5053 - Getting an error > while changing the columns in the existing view. > > PostgreSQL doesn't allow to change the view columns. So, while > performing this task the existing view should be dropped first and > then > recreate it and also user will get a warning first. > > Thanks, > Khushboo > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >>>
[Patch]: Typo in 'test_config.json.in' file
Hi, Fix the typo in the test configuration json file while running the test cases. Currently if someone uses the latest file to run the test cases, it will fail to run. Please find the attached patch. Thanks, Neel Patel test_config.patch Description: Binary data
[pgAdmin4][Patch] - RM 5383 - Error related to OID displayed if Click on properties of synonym and Click on refresh button
Hi, Please find the attached small patch to fix the RM #5383 - Error related to OID displayed if Click on properties of synonym and Click on refresh button. Thanks, Khushboo RM_5383.patch Description: Binary data
